From: David Miller <da...@davemloft.net> Date: Thu, 14 May 2020 13:01:59 -0700 (PDT)
> From: Igor Russkikh <irussk...@marvell.com> > Date: Thu, 14 May 2020 12:57:16 +0300 > >> FastLinQ devices as a complex systems may observe various hardware >> level error conditions, both severe and recoverable. >> >> Driver is able to detect and report this, but so far it only did >> trace/dmesg based reporting. >> >> Here we implement an extended hw error detection, service task >> handler captures a dump for the later analysis. >> >> I also resubmit a patch from Denis Bolotin on tx timeout handler, >> addressing David's comment regarding recovery procedure as an extra >> reaction on this event. >> >> v2: >> >> Removing the patch with ethtool dump and udev magic. Its quite isolated, >> I'm working on devlink based logic for this separately. >> >> v1: >> >> https://patchwork.ozlabs.org/project/netdev/cover/cover.1588758463.git.irussk...@marvell.com/ > > I'm only applying this series because I trust that you will actually do the > devlink work, and you will have it done and submitted in a reasonable amount > of ti me. > > Also, patch #4 had trailing empty lines added to a file, which is > warned about by 'git' when I apply your patches. I fixed it up, but > this is the kind of thing you should have sorted out before you submit > changes to the list. Actually, I had to revert, please fix these warnings (with gcc-10.1.1 on Fedora)_: drivers/net/ethernet/qlogic/qed/qed_dev.c: In function ‘qed_llh_add_mac_filter’: ./include/linux/printk.h:303:2: warning: ‘abs_ppfid’ may be used uninitialized in this function [-Wmaybe-uninitialized] 303 | printk(KERN_NOTICE pr_fmt(fmt), ##__VA_ARGS__) | ^~~~~~ drivers/net/ethernet/qlogic/qed/qed_dev.c:983:17: note: ‘abs_ppfid’ was declared here 983 | u8 filter_idx, abs_ppfid; | ^~~~~~~~~
