Hi Heiner,
Quoting Heiner Kallweit (2020-05-14 15:07:42)
> On 14.05.2020 23:31, Jeff Kirsher wrote:
> > @@ -4877,8 +4870,7 @@ static int igc_probe(struct pci_dev *pdev,
> >
> > if (igc_get_flash_presence_i225(hw)) {
> > if (hw->nvm.ops.validate(hw) < 0) {
> > - dev_err(&pdev->dev,
> > - "The NVM Checksum Is Not Valid\n");
> > + netdev_err(netdev, "The NVM Checksum Is Not Valid\n");
>
> Using the netdev_xxx message functions before register_netdev() doesn't
> provide a benefit. You get "(unnamed net_device) (uninitialized)" in
> the message instead of a netdev name. Therefore I went the opposite way
> for messages in probe() in 22148df0d0bd ("r8169: don't use netif_info
> et al before net_device has been registered")
Agreed. I'm fixing it. Since this log happens in an error condition, I missed
it in my tests. Thank you for pointing that out.
- Andre
