Re: New skb extension for use by LSMs (skb "security blob")?

2019-08-22 Thread Florian Westphal
Paul Moore wrote: > Hello netdev, > > I was just made aware of the skb extension work, and it looks very > appealing from a LSM perspective. As some of you probably remember, > we (the LSM folks) have wanted a proper security blob in the skb for > quite some time, but netdev has been resistant t

Re: [RFC bpf-next 0/5] Convert iproute2 to use libbpf (WIP)

2019-08-22 Thread Andrii Nakryiko
On Wed, Aug 21, 2019 at 2:07 PM Toke Høiland-Jørgensen wrote: > > Andrii Nakryiko writes: > > > On Tue, Aug 20, 2019 at 4:47 AM Toke Høiland-Jørgensen > > wrote: > >> > >> iproute2 uses its own bpf loader to load eBPF programs, which has > >> evolved separately from libbpf. Since we are now sta

Re: [RFC bpf-next 0/5] Convert iproute2 to use libbpf (WIP)

2019-08-22 Thread Andrii Nakryiko
On Wed, Aug 21, 2019 at 4:29 PM Toke Høiland-Jørgensen wrote: > > Alexei Starovoitov writes: > > > On Tue, Aug 20, 2019 at 01:47:01PM +0200, Toke Høiland-Jørgensen wrote: > >> iproute2 uses its own bpf loader to load eBPF programs, which has > >> evolved separately from libbpf. Since we are now s

Re: [PATCH net-next v3 4/8] MIPS: dts: mscc: describe the PTP ready interrupt

2019-08-22 Thread Antoine Tenart
Hello, On Wed, Jul 24, 2019 at 10:17:11AM +0200, Antoine Tenart wrote: > This patch adds a description of the PTP ready interrupt, which can be > triggered when a PTP timestamp is available on an hardware FIFO. > > Signed-off-by: Antoine Tenart > Acked-by: Paul Burton The net patches of this s

Re: [PATCHv2 net] ipv6/addrconf: allow adding multicast addr if IFA_F_MCAUTOJOIN is set

2019-08-22 Thread Hangbin Liu
On Mon, Aug 19, 2019 at 10:33:58PM -0400, David Ahern wrote: > On 8/19/19 10:19 PM, Hangbin Liu wrote: > > But in ipv6_add_addr() it will check the address type and reject multicast > > address directly. So this feature is never worked for IPv6. > > If true, that is really disappointing. > > We n

Re: [RFC bpf-next 0/5] Convert iproute2 to use libbpf (WIP)

2019-08-22 Thread Daniel Borkmann
On 8/22/19 9:49 AM, Andrii Nakryiko wrote: On Wed, Aug 21, 2019 at 2:07 PM Toke Høiland-Jørgensen wrote: Andrii Nakryiko writes: On Tue, Aug 20, 2019 at 4:47 AM Toke Høiland-Jørgensen wrote: iproute2 uses its own bpf loader to load eBPF programs, which has evolved separately from libbpf. S

Re: [RFC v2] vsock: proposal to support multiple transports at runtime

2019-08-22 Thread Stefano Garzarella
On Mon, Aug 19, 2019 at 02:09:11PM +0100, Stefan Hajnoczi wrote: > On Thu, Jun 06, 2019 at 12:09:12PM +0200, Stefano Garzarella wrote: > > > > Hi all, > > this is a v2 of a proposal addressing the comments made by Dexuan, Stefan, > > and Jorgen. > > > > v1: https://www.spinics.net/lists/netdev/ms

Re: [RFC bpf-next 4/5] iproute2: Allow compiling against libbpf

2019-08-22 Thread Daniel Borkmann
On 8/20/19 1:47 PM, Toke Høiland-Jørgensen wrote: This adds a configure check for libbpf and renames functions to allow lib/bpf.c to be compiled with it present. This makes it possible to port functionality piecemeal to use libbpf. Signed-off-by: Toke Høiland-Jørgensen --- configure

Re: [PATCH v1] ocfs2/dlm: Move BITS_TO_BYTES() to bitops.h for wider use

2019-08-22 Thread Andy Shevchenko
On Thu, Aug 22, 2019 at 05:46:07AM +, Sudarsana Reddy Kalluru wrote: > > > -Original Message- > > From: netdev-ow...@vger.kernel.org On > > Behalf Of Andy Shevchenko > > Sent: Wednesday, August 21, 2019 2:56 PM > > To: Joseph Qi > > Cc: Mark Fasheh ; Joel Becker ; > > ocfs2-de...@oss

[PATCH bpf-next 2/4] xsk: add proper barriers and {READ, WRITE}_ONCE-correctness for state

2019-08-22 Thread Björn Töpel
From: Björn Töpel The state variable was read, and written outside the control mutex (struct xdp_sock, mutex), without proper barriers and {READ, WRITE}_ONCE correctness. In this commit this issue is addressed, and the state member is now used a point of synchronization whether the socket is set

[PATCH bpf-next 1/4] xsk: avoid store-tearing when assigning queues

2019-08-22 Thread Björn Töpel
From: Björn Töpel Use WRITE_ONCE when doing the store of tx, rx, fq, and cq, to avoid potential store-tearing. These members are read outside of the control mutex in the mmap implementation. Fixes: 37b076933a8e ("xsk: add missing write- and data-dependency barrier") Signed-off-by: Björn Töpel -

[PATCH bpf-next 0/4] xsk: various CPU barrier and {READ, WRITE}_ONCE fixes

2019-08-22 Thread Björn Töpel
This is a four patch series of various barrier, {READ, WRITE}_ONCE cleanups in the AF_XDP socket code. More details can be found in the corresponding commit message. For an AF_XDP socket, most control plane operations are done under the control mutex (struct xdp_sock, mutex), but there are some pl

[PATCH bpf-next 3/4] xsk: avoid store-tearing when assigning umem

2019-08-22 Thread Björn Töpel
From: Björn Töpel The umem member of struct xdp_sock is read outside of the control mutex, in the mmap implementation, and needs a WRITE_ONCE to avoid potentional store-tearing. Fixes: 423f38329d26 ("xsk: add umem fill queue support and mmap") Signed-off-by: Björn Töpel --- net/xdp/xsk.c | 2 +

[PATCH bpf-next 4/4] xsk: lock the control mutex in sock_diag interface

2019-08-22 Thread Björn Töpel
From: Björn Töpel When accessing the members of an XDP socket, the control mutex should be held. This commit fixes that. Fixes: a36b38aa2af6 ("xsk: add sock_diag interface for AF_XDP") Signed-off-by: Björn Töpel --- net/xdp/xsk_diag.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/

RE: [PATCH v1] ocfs2/dlm: Move BITS_TO_BYTES() to bitops.h for wider use

2019-08-22 Thread Sudarsana Reddy Kalluru
> -Original Message- > From: Andy Shevchenko > Sent: Thursday, August 22, 2019 2:39 PM > To: Sudarsana Reddy Kalluru > Cc: Joseph Qi ; Mark Fasheh > ; Joel Becker ; ocfs2- > de...@oss.oracle.com; Ariel Elior ; GR-everest-linux-l2 > ; David S. Miller > ; netdev@vger.kernel.org; Colin Ian

[PATCH bpf-next v5] libbpf: add xsk_ring_prod__nb_free() function

2019-08-22 Thread Eelco Chaudron
When an AF_XDP application received X packets, it does not mean X frames can be stuffed into the producer ring. To make it easier for AF_XDP applications this API allows them to check how many frames can be added into the ring. The patch below looks like a name change only, but the xsk_prod__ pref

[PATCH bpf-next v5 02/11] ixgbe: simplify Rx buffer recycle

2019-08-22 Thread Kevin Laatz
Currently, the dma, addr and handle are modified when we reuse Rx buffers in zero-copy mode. However, this is not required as the inputs to the function are copies, not the original values themselves. As we use the copies within the function, we can use the original 'obi' values directly without ha

[PATCH bpf-next v5 03/11] xsk: add support to allow unaligned chunk placement

2019-08-22 Thread Kevin Laatz
Currently, addresses are chunk size aligned. This means, we are very restricted in terms of where we can place chunk within the umem. For example, if we have a chunk size of 2k, then our chunks can only be placed at 0,2k,4k,6k,8k... and so on (ie. every 2k starting from 0). This patch introduces t

[PATCH bpf-next v5 01/11] i40e: simplify Rx buffer recycle

2019-08-22 Thread Kevin Laatz
Currently, the dma, addr and handle are modified when we reuse Rx buffers in zero-copy mode. However, this is not required as the inputs to the function are copies, not the original values themselves. As we use the copies within the function, we can use the original 'old_bi' values directly without

[PATCH bpf-next v5 00/11] XDP unaligned chunk placement support

2019-08-22 Thread Kevin Laatz
This patch set adds the ability to use unaligned chunks in the XDP umem. Currently, all chunk addresses passed to the umem are masked to be chunk size aligned (max is PAGE_SIZE). This limits where we can place chunks within the umem as well as limiting the packet sizes that are supported. The cha

[PATCH bpf-next v5 04/11] i40e: modify driver for handling offsets

2019-08-22 Thread Kevin Laatz
With the addition of the unaligned chunks option, we need to make sure we handle the offsets accordingly based on the mode we are currently running in. This patch modifies the driver to appropriately mask the address for each case. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz ---

[PATCH bpf-next v5 09/11] samples/bpf: add buffer recycling for unaligned chunks to xdpsock

2019-08-22 Thread Kevin Laatz
This patch adds buffer recycling support for unaligned buffers. Since we don't mask the addr to 2k at umem_reg in unaligned mode, we need to make sure we give back the correct (original) addr to the fill queue. We achieve this using the new descriptor format and associated masks. The new format use

[PATCH bpf-next v5 11/11] doc/af_xdp: include unaligned chunk case

2019-08-22 Thread Kevin Laatz
The addition of unaligned chunks mode, the documentation needs to be updated to indicate that the incoming addr to the fill ring will only be masked if the user application is run in the aligned chunk mode. This patch also adds a line to explicitly indicate that the incoming addr will not be masked

[PATCH bpf-next v5 05/11] ixgbe: modify driver for handling offsets

2019-08-22 Thread Kevin Laatz
With the addition of the unaligned chunks option, we need to make sure we handle the offsets accordingly based on the mode we are currently running in. This patch modifies the driver to appropriately mask the address for each case. Signed-off-by: Kevin Laatz --- v3: - Use new helper function t

[PATCH bpf-next v5 10/11] samples/bpf: use hugepages in xdpsock app

2019-08-22 Thread Kevin Laatz
This patch modifies xdpsock to use mmap instead of posix_memalign. With this change, we can use hugepages when running the application in unaligned chunks mode. Using hugepages makes it more likely that we have physically contiguous memory, which supports the unaligned chunk mode better. Signed-of

[PATCH bpf-next v5 08/11] samples/bpf: add unaligned chunks mode support to xdpsock

2019-08-22 Thread Kevin Laatz
This patch adds support for the unaligned chunks mode. The addition of the unaligned chunks option will allow users to run the application with more relaxed chunk placement in the XDP umem. Unaligned chunks mode can be used with the '-u' or '--unaligned' command line options. Signed-off-by: Kevin

[PATCH bpf-next v5 06/11] mlx5e: modify driver for handling offsets

2019-08-22 Thread Kevin Laatz
With the addition of the unaligned chunks option, we need to make sure we handle the offsets accordingly based on the mode we are currently running in. This patch modifies the driver to appropriately mask the address for each case. Note: This patch only adds support for the new offset handling. An

[PATCH bpf-next v5 07/11] libbpf: add flags to umem config

2019-08-22 Thread Kevin Laatz
This patch adds a 'flags' field to the umem_config and umem_reg structs. This will allow for more options to be added for configuring umems. The first use for the flags field is to add a flag for unaligned chunks mode. These flags can either be user-provided or filled with a default. Since we cha

Re: [PATCH bpf-next v4] libbpf: add xsk_ring_prod__nb_free() function

2019-08-22 Thread Eelco Chaudron
On 21 Aug 2019, at 16:53, Magnus Karlsson wrote: On Wed, Aug 21, 2019 at 4:14 PM Magnus Karlsson wrote: On Wed, Aug 21, 2019 at 3:46 PM Eelco Chaudron wrote: On 21 Aug 2019, at 15:11, Magnus Karlsson wrote: On Wed, Aug 14, 2019 at 3:51 PM Eelco Chaudron wrote: When an AF_XDP ap

RE: Help needed - Kernel lockup while running ipsec

2019-08-22 Thread Vakul Garg
> -Original Message- > From: Florian Westphal > Sent: Wednesday, August 21, 2019 9:42 PM > To: Vakul Garg > Cc: Florian Westphal ; netdev@vger.kernel.org > Subject: Re: Help needed - Kernel lockup while running ipsec > > Vakul Garg wrote: > > > Policy refcount is decreasing properly

Re: [RFC bpf-next 0/5] Convert iproute2 to use libbpf (WIP)

2019-08-22 Thread Toke Høiland-Jørgensen
Andrii Nakryiko writes: > On Wed, Aug 21, 2019 at 4:29 PM Toke Høiland-Jørgensen > wrote: >> >> Alexei Starovoitov writes: >> >> > On Tue, Aug 20, 2019 at 01:47:01PM +0200, Toke Høiland-Jørgensen wrote: >> >> iproute2 uses its own bpf loader to load eBPF programs, which has >> >> evolved separ

Re: [RFC bpf-next 4/5] iproute2: Allow compiling against libbpf

2019-08-22 Thread Toke Høiland-Jørgensen
Daniel Borkmann writes: > On 8/20/19 1:47 PM, Toke Høiland-Jørgensen wrote: >> This adds a configure check for libbpf and renames functions to allow >> lib/bpf.c to be compiled with it present. This makes it possible to >> port functionality piecemeal to use libbpf. >> >> Signed-off-by: Toke Høi

Re: [PATCH bpf-next v5] libbpf: add xsk_ring_prod__nb_free() function

2019-08-22 Thread Magnus Karlsson
On Thu, Aug 22, 2019 at 11:54 AM Eelco Chaudron wrote: > > When an AF_XDP application received X packets, it does not mean X > frames can be stuffed into the producer ring. To make it easier for > AF_XDP applications this API allows them to check how many frames can > be added into the ring. > > T

[iproute2, master 2/2] devlink: Add a new time-stamp format for health reporter's dump

2019-08-22 Thread Aya Levin
Introduce a new attribute representing a new time-stamp format: current time instead of jiffies. If the new attribute was received, translate the time-stamp accordingly. Fixes: 2f1242efe9d0 ("devlink: Add devlink health show command") Signed-off-by: Aya Levin Acked-by: Jiri Pirko --- devlink/de

[iproute2, master 0/2] Fix reporter's dump's time-stamp

2019-08-22 Thread Aya Levin
This patch set handles the reporter's dump time-stamp display. First patch refactors the current implementation of helper function which displays the reporter's dump time-stamp and add the actual print to the function's body. The second patch introduces a new attribute which is the time-stamp in t

[iproute2, master 1/2] devlink: Print health reporter's dump time-stamp in a helper function

2019-08-22 Thread Aya Levin
Add pr_out_dump_reporter prefix to the helper function's name and encapsulate the print in it. Fixes: 2f1242efe9d0 ("devlink: Add devlink health show command") Signed-off-by: Aya Levin Acked-by: Jiri Pirko --- devlink/devlink.c | 26 ++ 1 file changed, 10 insertions(+),

[PATCH 4.14.y stable] xfrm: policy: remove pcpu policy cache

2019-08-22 Thread Florian Westphal
commit e4db5b61c572475bbbcf63e3c8a2606bfccf2c9d upstream. Kristian Evensen says: In a project I am involved in, we are running ipsec (Strongswan) on different mt7621-based routers. Each router is configured as an initiator and has around ~30 tunnels to different responders (running on misc

Re: [RFC bpf-next 4/5] iproute2: Allow compiling against libbpf

2019-08-22 Thread Daniel Borkmann
On 8/22/19 12:43 PM, Toke Høiland-Jørgensen wrote: Daniel Borkmann writes: On 8/20/19 1:47 PM, Toke Høiland-Jørgensen wrote: This adds a configure check for libbpf and renames functions to allow lib/bpf.c to be compiled with it present. This makes it possible to port functionality piecemeal to

Re: [RFC bpf-next 0/5] Convert iproute2 to use libbpf (WIP)

2019-08-22 Thread Toke Høiland-Jørgensen
Daniel Borkmann writes: > On 8/22/19 9:49 AM, Andrii Nakryiko wrote: >> On Wed, Aug 21, 2019 at 2:07 PM Toke Høiland-Jørgensen >> wrote: >>> Andrii Nakryiko writes: On Tue, Aug 20, 2019 at 4:47 AM Toke Høiland-Jørgensen wrote: > > iproute2 uses its own bpf loader to load eB

Re: [RFC bpf-next 0/5] Convert iproute2 to use libbpf (WIP)

2019-08-22 Thread Toke Høiland-Jørgensen
Toke Høiland-Jørgensen writes: > Daniel Borkmann writes: > >> On 8/22/19 9:49 AM, Andrii Nakryiko wrote: >>> On Wed, Aug 21, 2019 at 2:07 PM Toke Høiland-Jørgensen >>> wrote: Andrii Nakryiko writes: > On Tue, Aug 20, 2019 at 4:47 AM Toke Høiland-Jørgensen > wrote: >> >>

Re: [PATCH][net-next] net: drop_monitor: change the stats variable to u64 in net_dm_stats_put

2019-08-22 Thread Ido Schimmel
On Thu, Aug 22, 2019 at 02:22:33PM +0800, Li RongQing wrote: > only the element drop of struct net_dm_stats is used, so simplify it to u64 Thanks for the patch, but I don't really see the value here. The struct allows for easy extensions in the future. What do you gain from this change? We merely

Re: [RFC bpf-next 4/5] iproute2: Allow compiling against libbpf

2019-08-22 Thread Toke Høiland-Jørgensen
Daniel Borkmann writes: > On 8/22/19 12:43 PM, Toke Høiland-Jørgensen wrote: >> Daniel Borkmann writes: >>> On 8/20/19 1:47 PM, Toke Høiland-Jørgensen wrote: This adds a configure check for libbpf and renames functions to allow lib/bpf.c to be compiled with it present. This makes it po

Re: BUG: MAX_STACK_TRACE_ENTRIES too low in tipc_topsrv_exit_net

2019-08-22 Thread Andrey Konovalov
On Thu, Aug 22, 2019 at 5:05 AM Eric Biggers wrote: > > On Mon, Aug 19, 2019 at 05:22:07AM -0700, syzbot wrote: > > Hello, > > > > syzbot found the following crash on: > > > > HEAD commit:5181b473 net: phy: realtek: add NBase-T PHY auto-detection > > git tree: net-next > > console output

答复: [PATCH][net-next] net: drop_monitor: change the stats variable to u64 in net_dm_stats_put

2019-08-22 Thread Li,Rongqing
> -邮件原件- > 发件人: Ido Schimmel [mailto:ido...@idosch.org] > 发送时间: 2019年8月22日 20:00 > 收件人: Li,Rongqing > 抄送: netdev@vger.kernel.org; ido...@mellanox.com > 主题: Re: [PATCH][net-next] net: drop_monitor: change the stats variable to > u64 in net_dm_stats_put > > On Thu, Aug 22, 2019 at 02:22:3

Re: [RFC bpf-next 4/5] iproute2: Allow compiling against libbpf

2019-08-22 Thread Daniel Borkmann
On 8/22/19 2:04 PM, Toke Høiland-Jørgensen wrote: Daniel Borkmann writes: On 8/22/19 12:43 PM, Toke Høiland-Jørgensen wrote: Daniel Borkmann writes: On 8/20/19 1:47 PM, Toke Høiland-Jørgensen wrote: This adds a configure check for libbpf and renames functions to allow lib/bpf.c to be compil

MY $25,000,000.00 INVESTMENT PROPOSAL WITH YOU AND IN YOUR COUNTRY.

2019-08-22 Thread Law firm(Eku and Associates)
-- Dear, With due respect this is not spam or Scam mail, because I have contacted you before and there was no response from you,I apologise if the contents of this mail are contrary to your moral ethics, which I feel may be of great disturbance to your person, but please treat this with absolute c

[PATCH net-next 00/10] Refactor cls hardware offload API to support rtnl-independent drivers

2019-08-22 Thread Vlad Buslov
Currently, all cls API hardware offloads driver callbacks require caller to hold rtnl lock when calling them. This patch set introduces new API that allows drivers to register callbacks that are not dependent on rtnl lock and unlocked classifiers to offload filters without obtaining rtnl lock first

[PATCH net-next 03/10] net: sched: refactor block offloads counter usage

2019-08-22 Thread Vlad Buslov
Without rtnl lock protection filters can no longer safely manage block offloads counter themselves. Refactor cls API to protect block offloadcnt with tcf_block->cb_lock that is already used to protect driver callback list and nooffloaddevcnt counter. The counter can be modified by concurrent tasks

[PATCH net-next 08/10] net: sched: take reference to action dev before calling offloads

2019-08-22 Thread Vlad Buslov
In order to remove dependency on rtnl lock when calling hardware offload API, take reference to action mirred dev when initializing flow_action structure in tc_setup_flow_action(). Implement function tc_cleanup_flow_action(), use it to release the device after hardware offload API is done using it.

[PATCH net-next 02/10] net: sched: change tcf block offload counter type to atomic_t

2019-08-22 Thread Vlad Buslov
As a preparation for running proto ops functions without rtnl lock, change offload counter type to atomic. This is necessary to allow updating the counter by multiple concurrent users when offloading filters to hardware from unlocked classifiers. Signed-off-by: Vlad Buslov Acked-by: Jiri Pirko -

[PATCH net-next 06/10] net: sched: conditionally obtain rtnl lock in cls hw offloads API

2019-08-22 Thread Vlad Buslov
In order to remove dependency on rtnl lock from offloads code of classifiers, take rtnl lock conditionally before executing driver callbacks. Only obtain rtnl lock if block is bound to devices that require it. Block bind/unbind code is rtnl-locked and obtains block->cb_lock while holding rtnl lock

[PATCH net-next 10/10] net: sched: flower: don't take rtnl lock for cls hw offloads API

2019-08-22 Thread Vlad Buslov
Don't manually take rtnl lock in flower classifier before calling cls hardware offloads API. Instead, pass rtnl lock status via 'rtnl_held' parameter. Signed-off-by: Vlad Buslov Acked-by: Jiri Pirko --- net/sched/cls_flower.c | 55 -- 1 file changed, 16 i

[PATCH net-next 05/10] net: sched: add API for registering unlocked offload block callbacks

2019-08-22 Thread Vlad Buslov
Extend struct flow_block_offload with "unlocked_driver_cb" flag to allow registering and unregistering block hardware offload callbacks that do not require caller to hold rtnl lock. Extend tcf_block with additional lockeddevcnt counter that is incremented for each non-unlocked driver callback attac

[PATCH net-next 07/10] net: sched: take rtnl lock in tc_setup_flow_action()

2019-08-22 Thread Vlad Buslov
In order to allow using new flow_action infrastructure from unlocked classifiers, modify tc_setup_flow_action() to accept new 'rtnl_held' argument. Take rtnl lock before accessing tc_action data. This is necessary to protect from concurrent action replace. Signed-off-by: Vlad Buslov Acked-by: Jir

[PATCH net-next 01/10] net: sched: protect block offload-related fields with rw_semaphore

2019-08-22 Thread Vlad Buslov
In order to remove dependency on rtnl lock, extend tcf_block with 'cb_lock' rwsem and use it to protect flow_block->cb_list and related counters from concurrent modification. The lock is taken in read mode for read-only traversal of cb_list in tc_setup_cb_call() and write mode in all other cases. T

[PATCH net-next 04/10] net: sched: notify classifier on successful offload add/delete

2019-08-22 Thread Vlad Buslov
To remove dependency on rtnl lock, extend classifier ops with new ops->hw_add() and ops->hw_del() callbacks. Call them from cls API while holding cb_lock every time filter if successfully added to or deleted from hardware. Implement the new API in flower classifier. Use it to manage hw_filters lis

[PATCH net-next 09/10] net: sched: copy tunnel info when setting flow_action entry->tunnel

2019-08-22 Thread Vlad Buslov
In order to remove dependency on rtnl lock, modify tc_setup_flow_action() to copy tunnel info, instead of just saving pointer to tunnel_key action tunnel info. This is necessary to prevent concurrent action overwrite from releasing tunnel info while it is being used by rtnl-unlocked driver. Implem

Re: [PATCH v3] tun: fix use-after-free when register netdev failed

2019-08-22 Thread Yang Yingliang
On 2019/8/22 14:07, Yang Yingliang wrote: On 2019/8/22 10:13, Jason Wang wrote: On 2019/8/20 上午10:28, Jason Wang wrote: On 2019/8/20 上午9:25, David Miller wrote: From: Yang Yingliang Date: Mon, 19 Aug 2019 21:31:19 +0800 Call tun_attach() after register_netdevice() to make sure tfile-

Re: [PATCH net-next 02/10] net: dsa: mv88e6xxx: remove extra newline

2019-08-22 Thread Andrew Lunn
On Thu, Aug 22, 2019 at 01:27:16AM +0200, Marek Behún wrote: > There are two newlines separating mv88e6390_hidden_wait and > mv88e6390_hidden_read. Remove one. > > Signed-off-by: Marek Behún Reviewed-by: Andrew Lunn Andrew

Re: [PATCH net-next 03/10] net: dsa: mv88e6xxx: move hidden registers operations in own file

2019-08-22 Thread Andrew Lunn
On Thu, Aug 22, 2019 at 01:27:17AM +0200, Marek Behún wrote: > This patch moves the functions operating on the hidden debug registers > into it's own file, hidden.c. > > Signed-off-by: Marek Behún Reviewed-by: Andrew Lunn Andrew

Re: [PATCH 4.14.y stable] xfrm: policy: remove pcpu policy cache

2019-08-22 Thread Greg KH
On Thu, Aug 22, 2019 at 01:21:09PM +0200, Florian Westphal wrote: > commit e4db5b61c572475bbbcf63e3c8a2606bfccf2c9d upstream. > > Kristian Evensen says: > In a project I am involved in, we are running ipsec (Strongswan) on > different mt7621-based routers. Each router is configured as an > i

Re: [PATCH net-next 03/10] net: dsa: mv88e6xxx: move hidden registers operations in own file

2019-08-22 Thread Andrew Lunn
On Thu, Aug 22, 2019 at 01:27:17AM +0200, Marek Behún wrote: > This patch moves the functions operating on the hidden debug registers > into it's own file, hidden.c. Humm, actually... These are in the port register space. Maybe it would be better to move them into port.c/port.h? What you really

Re: [PATCH net-next 04/10] net: dsa: mv88e6xxx: prefix hidden register macro names with MV88E6XXX_

2019-08-22 Thread Andrew Lunn
On Thu, Aug 22, 2019 at 01:27:18AM +0200, Marek Behún wrote: > In order to be uniform with the rest of the driver, prepend hidden > register macro names with the MV88E6XXX_ prefix. > > Signed-off-by: Marek Behún For the idea of the patch: Reviewed-by: Andrew Lunn But it could be the actual pa

Re: [PATCH 4.14.y stable] xfrm: policy: remove pcpu policy cache

2019-08-22 Thread Florian Westphal
Greg KH wrote: > On Thu, Aug 22, 2019 at 01:21:09PM +0200, Florian Westphal wrote: > > commit e4db5b61c572475bbbcf63e3c8a2606bfccf2c9d upstream. > > > > Kristian Evensen says: > > In a project I am involved in, we are running ipsec (Strongswan) on > > different mt7621-based routers. Each rout

Re: [RFC bpf-next 4/5] iproute2: Allow compiling against libbpf

2019-08-22 Thread Toke Høiland-Jørgensen
Daniel Borkmann writes: > On 8/22/19 2:04 PM, Toke Høiland-Jørgensen wrote: >> Daniel Borkmann writes: >>> On 8/22/19 12:43 PM, Toke Høiland-Jørgensen wrote: Daniel Borkmann writes: > On 8/20/19 1:47 PM, Toke Høiland-Jørgensen wrote: >> This adds a configure check for libbpf and re

Re: [RFC bpf-next 4/5] iproute2: Allow compiling against libbpf

2019-08-22 Thread Daniel Borkmann
On 8/22/19 3:38 PM, Toke Høiland-Jørgensen wrote: Daniel Borkmann writes: On 8/22/19 2:04 PM, Toke Høiland-Jørgensen wrote: Daniel Borkmann writes: On 8/22/19 12:43 PM, Toke Høiland-Jørgensen wrote: Daniel Borkmann writes: On 8/20/19 1:47 PM, Toke Høiland-Jørgensen wrote: This adds a con

Re: [PATCH bpf-next 1/4] xsk: avoid store-tearing when assigning queues

2019-08-22 Thread Björn Töpel
On Thu, 22 Aug 2019 at 15:26, Hillf Danton wrote: > > > > > >/* Make sure queue is ready before it can be seen by others */ > > >smp_wmb(); > > > > Hehe, who put mb here and for what? > That was from an earlier commit, and it's a barrier paired with the lock-less reading of queues in xsk_

Re: [PATCH spi for-5.4 0/5] Deterministic SPI latency with NXP DSPI driver

2019-08-22 Thread Richard Cochran
On Wed, Aug 21, 2019 at 11:17:23PM +0300, Vladimir Oltean wrote: > Of course PPS with a dedicated hardware receiver that can take input > compare timestamps is always preferable. However non-Ethernet > synchronization in the field looks to me like "make do with whatever > you can". I'm not sure a p

Re: [PATCH v2 bpf-next 1/4] bpf: unprivileged BPF access via /dev/bpf

2019-08-22 Thread Daniel Borkmann
On 8/7/19 7:24 AM, Andy Lutomirski wrote: On Mon, Aug 5, 2019 at 6:11 PM Alexei Starovoitov wrote: On Mon, Aug 05, 2019 at 02:25:35PM -0700, Andy Lutomirski wrote: It tries to make the kernel respect the access modes for fds. Without this patch, there seem to be some holes: nothing looked at

[PATCHv4 0/2] fix dev null pointer dereference when send packets larger than mtu in collect_md mode

2019-08-22 Thread Hangbin Liu
When we send a packet larger than PMTU, we need to reply with icmp_send(ICMP_FRAG_NEEDED) or icmpv6_send(ICMPV6_PKT_TOOBIG). But with collect_md mode, kernel will crash while accessing the dst dev as __metadata_dst_init() init dst->dev to NULL by default. Here is what the code path looks like, for

[PATCHv4 net 2/2] xfrm/xfrm_policy: fix dst dev null pointer dereference in collect_md mode

2019-08-22 Thread Hangbin Liu
In decode_session{4,6} there is a possibility that the skb dst dev is NULL, e,g, with tunnel collect_md mode, which will cause kernel crash. Here is what the code path looks like, for GRE: - ip6gre_tunnel_xmit - ip6gre_xmit_ipv6 - __gre6_xmit - ip6_tnl_xmit - if skb->len - t->t

[PATCHv4 net 1/2] ipv4/icmp: fix rt dst dev null pointer dereference

2019-08-22 Thread Hangbin Liu
In __icmp_send() there is a possibility that the rt->dst.dev is NULL, e,g, with tunnel collect_md mode, which will cause kernel crash. Here is what the code path looks like, for GRE: - ip6gre_tunnel_xmit - ip6gre_xmit_ipv4 - __gre6_xmit - ip6_tnl_xmit - if skb->len - t->tun_hle

Re: [PATCH net-next v2 1/3] net: ethernet: mediatek: Add basic PHYLINK support

2019-08-22 Thread Russell King - ARM Linux admin
On Wed, Aug 21, 2019 at 04:43:34PM +0200, René van Dorst wrote: > +static void mtk_mac_link_down(struct phylink_config *config, unsigned int > mode, > + phy_interface_t interface) > +{ > + struct mtk_mac *mac = container_of(config, struct mtk_mac, > +

Re: [PATCH net-next v2 2/3] net: ethernet: mediatek: Re-add support SGMII

2019-08-22 Thread Russell King - ARM Linux admin
On Wed, Aug 21, 2019 at 04:43:35PM +0200, René van Dorst wrote: > + if (MTK_HAS_CAPS(mac->hw->soc->caps, MTK_SGMII)) { > + if (state->interface != PHY_INTERFACE_MODE_2500BASEX) { > phylink_set(mask, 1000baseT_Full); > phylink_set(mask, 100

Re: [PATCH spi for-5.4 0/5] Deterministic SPI latency with NXP DSPI driver

2019-08-22 Thread Andrew Lunn
> Thinking back... > > One problem is this. PTP requires a delay measurement. You can send > a delay request from the host, but there will never be a reply. > > Another problem is this. A Sync message arriving on an external port > is time stamped there, but then it is encapsulated as a tagged

Re: [PATCH spi for-5.4 0/5] Deterministic SPI latency with NXP DSPI driver

2019-08-22 Thread Vladimir Oltean
On Thu, 22 Aug 2019 at 17:16, Richard Cochran wrote: > > On Wed, Aug 21, 2019 at 11:17:23PM +0300, Vladimir Oltean wrote: > > Of course PPS with a dedicated hardware receiver that can take input > > compare timestamps is always preferable. However non-Ethernet > > synchronization in the field look

Re: [PATCH net-next v2 1/3] net: ethernet: mediatek: Add basic PHYLINK support

2019-08-22 Thread René van Dorst
Hi Russell, Quoting Russell King - ARM Linux admin : On Wed, Aug 21, 2019 at 04:43:34PM +0200, René van Dorst wrote: +static void mtk_mac_link_down(struct phylink_config *config, unsigned int mode, + phy_interface_t interface) +{ + struct mtk_mac *mac = cont

Re: [PATCH v2 bpf-next 1/4] bpf: unprivileged BPF access via /dev/bpf

2019-08-22 Thread Andy Lutomirski
On Thu, Aug 22, 2019 at 7:17 AM Daniel Borkmann wrote: > > On 8/7/19 7:24 AM, Andy Lutomirski wrote: > > On Mon, Aug 5, 2019 at 6:11 PM Alexei Starovoitov > > wrote: > >> On Mon, Aug 05, 2019 at 02:25:35PM -0700, Andy Lutomirski wrote: > >>> It tries to make the kernel respect the access modes fo

RFC: very rough draft of a bpf permission model

2019-08-22 Thread Andy Lutomirski
BPF security strawman, v0.1 This is very rough. Most of this, especially the API details, needs work before it's ready to implement. The whole concept also needs review. = Goals = The overall goal is to make it possible to use eBPF without having what is effectively administrator access. For

Re: [RFC bpf-next 4/5] iproute2: Allow compiling against libbpf

2019-08-22 Thread Toke Høiland-Jørgensen
Daniel Borkmann writes: > On 8/22/19 3:38 PM, Toke Høiland-Jørgensen wrote: >> Daniel Borkmann writes: >>> On 8/22/19 2:04 PM, Toke Høiland-Jørgensen wrote: Daniel Borkmann writes: > On 8/22/19 12:43 PM, Toke Høiland-Jørgensen wrote: >> Daniel Borkmann writes: >>> On 8/20/19 1

Re: [PATCH rdma-next 0/3] RDMA RX RoCE Steering Support

2019-08-22 Thread Doug Ledford
On Wed, 2019-08-21 at 17:02 +0300, Leon Romanovsky wrote: > On Tue, Aug 20, 2019 at 01:54:59PM -0400, Doug Ledford wrote: > > On Mon, 2019-08-19 at 14:36 +0300, Leon Romanovsky wrote: > > > From: Leon Romanovsky > > > > > > Hi, > > > > > > This series from Mark extends mlx5 with RDMA_RX RoCE flo

Aw: [PATCH net-next v2 0/3] net: dsa: mt7530: Convert to PHYLINK and add support for port 5

2019-08-22 Thread Frank Wunderlich
Hi, tested on BPI-R2 (mt7623) with 2 Problems (already reported to Rene, just to inform everyone)...maybe anybody has an idea - linux-next (i know it's not part of the series, but a pitfall on testing other devices) seems to break power-regulator somewhere here: priv->core_pwr = devm_regulator

Re: [PATCH rdma-next 0/3] RDMA RX RoCE Steering Support

2019-08-22 Thread Leon Romanovsky
On Thu, Aug 22, 2019 at 11:29:02AM -0400, Doug Ledford wrote: > On Wed, 2019-08-21 at 17:02 +0300, Leon Romanovsky wrote: > > On Tue, Aug 20, 2019 at 01:54:59PM -0400, Doug Ledford wrote: > > > On Mon, 2019-08-19 at 14:36 +0300, Leon Romanovsky wrote: > > > > From: Leon Romanovsky > > > > > > > >

Re: [PATCH spi for-5.4 0/5] Deterministic SPI latency with NXP DSPI driver

2019-08-22 Thread Richard Cochran
On Thu, Aug 22, 2019 at 05:58:49PM +0300, Vladimir Oltean wrote: > I don't think I understand the problem here. On the contrary, I do. > You'd have something like this: > > Master (DSA master port) Slave (switch CPU port) > > || Tstamps known >

Re: [PATCH spi for-5.4 0/5] Deterministic SPI latency with NXP DSPI driver

2019-08-22 Thread Richard Cochran
On Thu, Aug 22, 2019 at 05:58:49PM +0300, Vladimir Oltean wrote: > If you mean the latter, then yes, having HWTSTAMP_FILTER_ALL in the > rx_filter of the DSA master is a hard requirement. And to clear, the marvell only recognizes PTP frames. That means that DSA frames cannot be time stamped. Tha

Re: [PATCH spi for-5.4 0/5] Deterministic SPI latency with NXP DSPI driver

2019-08-22 Thread Vladimir Oltean
On Thu, 22 Aug 2019 at 19:05, Richard Cochran wrote: > > On Thu, Aug 22, 2019 at 05:58:49PM +0300, Vladimir Oltean wrote: > > I don't think I understand the problem here. > > On the contrary, I do. > You do think that I understand the problem? But I don't! > > You'd have something like this: > >

Aw: [PATCH net-next v2 0/3] net: dsa: mt7530: Convert to PHYLINK and add support for port 5

2019-08-22 Thread Frank Wunderlich
tested now also on bpi-r64 (mt7622) v0.1 (rtl8367 switch), without linux-next to avoid power-regulator-problems like on bpi-r2 dmesg without warnings/errors caused by this patches link came up as desired iperf3 looks good: 943 Mbits/sec in both directions and no other issues so it is currently o

Re: New skb extension for use by LSMs (skb "security blob")?

2019-08-22 Thread Paul Moore
On Thu, Aug 22, 2019 at 3:03 AM Florian Westphal wrote: > Paul Moore wrote: > > Hello netdev, > > > > I was just made aware of the skb extension work, and it looks very > > appealing from a LSM perspective. As some of you probably remember, > > we (the LSM folks) have wanted a proper security bl

Re: [PATCH net-next 03/10] net: dsa: mv88e6xxx: move hidden registers operations in own file

2019-08-22 Thread Vivien Didelot
Hi Marek, Andrew, On Thu, 22 Aug 2019 15:10:47 +0200, Andrew Lunn wrote: > On Thu, Aug 22, 2019 at 01:27:17AM +0200, Marek Behún wrote: > > This patch moves the functions operating on the hidden debug registers > > into it's own file, hidden.c. > > Humm, actually... > > These are in the port re

Re: [PATCH net] openvswitch: Fix conntrack cache with timeout

2019-08-22 Thread kbuild test robot
Hi Yi-Hung, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net/master] url: https://github.com/0day-ci/linux/commits/Yi-Hung-Wei/openvswitch-Fix-conntrack-cache-with-timeout/20190822-212539 reproduce: # apt-get install sparse # sparse

Re: [PATCH spi for-5.4 2/5] spi: Add a PTP system timestamp to the transfer structure

2019-08-22 Thread Mark Brown
On Sun, Aug 18, 2019 at 09:25:57PM +0300, Vladimir Oltean wrote: > @@ -1391,6 +1402,13 @@ static void __spi_pump_messages(struct spi_controller > *ctlr, bool in_kthread) > goto out; > } > > + if (!ctlr->ptp_sts_supported) { > + list_for_each_entry(xfer, &mesg

Re: [PATCH spi for-5.4 3/5] spi: spi-fsl-dspi: Use poll mode in case the platform IRQ is missing

2019-08-22 Thread Mark Brown
On Sun, Aug 18, 2019 at 09:25:58PM +0300, Vladimir Oltean wrote: > On platforms like LS1021A which use TCFQ mode, an interrupt needs to be > processed after each byte is TXed/RXed. I tried to make the DSPI > implementation on this SoC operate in other, more efficient modes (EOQ, > DMA) but it looks

Re: [PATCH net] openvswitch: Fix conntrack cache with timeout

2019-08-22 Thread Yi-Hung Wei
onntrack-cache-with-timeout/20190822-212539 > reproduce: > # apt-get install sparse > # sparse version: v0.6.1-rc1-7-g2b96cd8-dirty > make ARCH=x86_64 allmodconfig > make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' > > If you fix the issue,

Re: [PATCH bpf-next v5 03/11] xsk: add support to allow unaligned chunk placement

2019-08-22 Thread Jonathan Lemon
On 21 Aug 2019, at 18:44, Kevin Laatz wrote: Currently, addresses are chunk size aligned. This means, we are very restricted in terms of where we can place chunk within the umem. For example, if we have a chunk size of 2k, then our chunks can only be placed at 0,2k,4k,6k,8k... and so on (ie

Re: [PATCHv4 net 1/2] ipv4/icmp: fix rt dst dev null pointer dereference

2019-08-22 Thread Julian Anastasov
Hello, On Thu, 22 Aug 2019, Hangbin Liu wrote: > In __icmp_send() there is a possibility that the rt->dst.dev is NULL, > e,g, with tunnel collect_md mode, which will cause kernel crash. > Here is what the code path looks like, for GRE: > > - ip6gre_tunnel_xmit > - ip6gre_xmit_ipv4 >

Re: New skb extension for use by LSMs (skb "security blob")?

2019-08-22 Thread Casey Schaufler
On 8/21/2019 8:54 PM, David Miller wrote: > From: Paul Moore > Date: Wed, 21 Aug 2019 23:27:03 -0400 > >> On Wed, Aug 21, 2019 at 6:50 PM David Miller wrote: >>> From: Paul Moore >>> Date: Wed, 21 Aug 2019 18:00:09 -0400 >>> I was just made aware of the skb extension work, and it looks very

Re: [PATCH net-next v2 2/3] net: ethernet: mediatek: Re-add support SGMII

2019-08-22 Thread René van Dorst
Hi Russell, Quoting Russell King - ARM Linux admin : On Wed, Aug 21, 2019 at 04:43:35PM +0200, René van Dorst wrote: + if (MTK_HAS_CAPS(mac->hw->soc->caps, MTK_SGMII)) { + if (state->interface != PHY_INTERFACE_MODE_2500BASEX) { phylink_set(mask, 1000

Re: New skb extension for use by LSMs (skb "security blob")?

2019-08-22 Thread Casey Schaufler
On 8/22/2019 9:32 AM, Paul Moore wrote: > On Thu, Aug 22, 2019 at 3:03 AM Florian Westphal wrote: >> Paul Moore wrote: >>> Hello netdev, >>> >>> I was just made aware of the skb extension work, and it looks very >>> appealing from a LSM perspective. As some of you probably remember, >>> we (the

Wohltätigkeitsspende von 2.000.000 Millionen Euro

2019-08-22 Thread ''Tayeb Souami''
Lieber Freund, Ich bin Herr Tayeb Souami, New Jersey, Vereinigte Staaten von Amerika, der Mega-Gewinner von $ 315million In Mega Millions Jackpot, spende ich an 5 zufällige Personen, wenn Sie diese E-Mail erhalten, dann wurde Ihre E-Mail nach einem Spinball ausgewählt.Ich habe den größten Teil

[PATCH net-next 0/6] net: dsa: explicit programmation of VLAN on CPU ports

2019-08-22 Thread Vivien Didelot
When a VLAN is programmed on a user port, every switch of the fabric also program the CPU ports and the DSA links as part of the VLAN. To do that, DSA makes use of bitmaps to prepare all members of a VLAN. While this is expected for DSA links which are used as conduit between interconnected switch

  1   2   3   >