> -----邮件原件----- > 发件人: Ido Schimmel [mailto:ido...@idosch.org] > 发送时间: 2019年8月22日 20:00 > 收件人: Li,Rongqing <lirongq...@baidu.com> > 抄送: netdev@vger.kernel.org; ido...@mellanox.com > 主题: Re: [PATCH][net-next] net: drop_monitor: change the stats variable to > u64 in net_dm_stats_put > > On Thu, Aug 22, 2019 at 02:22:33PM +0800, Li RongQing wrote: > > only the element drop of struct net_dm_stats is used, so simplify it > > to u64 > > Thanks for the patch, but I don't really see the value here. The struct > allows for > easy extensions in the future. What do you gain from this change? We merely > read stats and report them to user space, so I guess it's not about > performance either. >
I think u64 can reduce to call memset and dereference stats.drop If it is for future, keep it -RongQing
