Re: [RFC PATCH net-next 2/2] net: tls: export protocol version and cipher to socket diag

2019-06-06 Thread Boris Pismenny
Hi Davide, TLS statistics are long overdue. I'd like to extend this later for the tls_device code, e.g. device_decrypted vs. software_decrypted. On 6/5/2019 6:39 PM, Davide Caratti wrote: > > +static int tls_get_info(struct sock *sk, struct sk_buff *skb) > +{ > + struct tls_context *ctx

Re: [pull request][for-next 0/9] Generic DIM lib for netdev and RDMA

2019-06-06 Thread Leon Romanovsky
On Wed, Jun 05, 2019 at 11:24:31PM +, Saeed Mahameed wrote: > Hi Dave, Doug & Jason > > This series improves DIM - Dynamically-tuned Interrupt > Moderation- to be generic for netdev and RDMA use-cases. > > From Tal and Yamin: > The first 7 patches provide the necessary refactoring to current ne

Re: [ipsec-next:testing 4/6] net/xfrm/xfrm_state.c:1792:9: error: '__xfrm6_tmpl_sort_cmp' undeclared; did you mean 'xfrm_tmpl_sort'?

2019-06-06 Thread Florian Westphal
Steffen Klassert wrote: > On Wed, Jun 05, 2019 at 02:40:45PM +0200, Florian Westphal wrote: > > > > Steffen, as this is still only in your testing branch, I suggest you > > squash this snipped into commit 8dc6e3891a4be64c0cca5e8fe2c3ad33bc06543e > > ("xfrm: remove state and template sort indirect

Re: [pull request][for-next 0/9] Generic DIM lib for netdev and RDMA

2019-06-06 Thread Max Gurtovoy
On 6/6/2019 10:14 AM, Leon Romanovsky wrote: On Wed, Jun 05, 2019 at 11:24:31PM +, Saeed Mahameed wrote: Hi Dave, Doug & Jason This series improves DIM - Dynamically-tuned Interrupt Moderation- to be generic for netdev and RDMA use-cases. From Tal and Yamin: The first 7 patches provide

[PATCH net 0/2] ipv6: fix EFAULT on sendto with icmpv6 and hdrincl

2019-06-06 Thread Olivier Matz
The following code returns EFAULT (Bad address): s = socket(AF_INET6, SOCK_RAW, IPPROTO_ICMPV6); setsockopt(s, SOL_IPV6, IPV6_HDRINCL, 1); sendto(ipv6_icmp6_packet, addr); /* returns -1, errno = EFAULT */ The problem is fixed in the second patch. The first one aligns the code to ipv4, to

[PATCH net 1/2] ipv6: use READ_ONCE() for inet->hdrincl as in ipv4

2019-06-06 Thread Olivier Matz
As it was done in commit 8f659a03a0ba ("net: ipv4: fix for a race condition in raw_sendmsg") and commit 20b50d79974e ("net: ipv4: emulate READ_ONCE() on ->hdrincl bit-field in raw_sendmsg()") for ipv4, copy the value of inet->hdrincl in a local variable, to avoid introducing a race condition in the

[PATCH net 2/2] ipv6: fix EFAULT on sendto with icmpv6 and hdrincl

2019-06-06 Thread Olivier Matz
The following code returns EFAULT (Bad address): s = socket(AF_INET6, SOCK_RAW, IPPROTO_ICMPV6); setsockopt(s, SOL_IPV6, IPV6_HDRINCL, 1); sendto(ipv6_icmp6_packet, addr); /* returns -1, errno = EFAULT */ The IPv4 equivalent code works. A workaround is to use IPPROTO_RAW instead of IPPROT

Re: EoGRE sends undersized frames without padding

2019-06-06 Thread Steinar H. Gunderson
On Wed, Jun 05, 2019 at 06:17:51PM -0700, Cong Wang wrote: > Hmm, sounds like openvswitch should pad the packets in this scenario, > like hardware switches padding those on real wires. Well, openvswitch say that they just throw packets around and assume they're valid... :-) In any case, if you ta

Re: questions about AF_PACKET V4 and AF_XDP

2019-06-06 Thread Björn Töpel
On 2019-06-05 19:56, Junsong Zhao (junszhao) wrote: Hi Magnus and Bjorn, I saw your articles and presentation about AF_PACKET V4. It is exciting to know that the kernel socket can have 40G throughput. But it seems the code is not in the 4.19 or 5.1 kernel. Instead there is a new feature AF_X

Re: [pull request][for-next 0/9] Generic DIM lib for netdev and RDMA

2019-06-06 Thread Leon Romanovsky
On Thu, Jun 06, 2019 at 10:19:41AM +0300, Max Gurtovoy wrote: > > On 6/6/2019 10:14 AM, Leon Romanovsky wrote: > > On Wed, Jun 05, 2019 at 11:24:31PM +, Saeed Mahameed wrote: > > > Hi Dave, Doug & Jason > > > > > > This series improves DIM - Dynamically-tuned Interrupt > > > Moderation- to be g

[PATCH 1/1] net: rds: fix memory leak in rds_ib_flush_mr_pool

2019-06-06 Thread Zhu Yanjun
When the following tests last for several hours, the problem will occur. Server: rds-stress -r 1.1.1.16 -D 1M Client: rds-stress -r 1.1.1.14 -s 1.1.1.16 -D 1M -T 30 The following will occur. " Starting up tsks tx/s rx/s tx+rx K/smbi K/smbo K/s tx us/c rtt us cpu % 1

Re: likely invalid CVE assignment for commit 95baa60a0da80a0143e3ddd4d3725758b4513825

2019-06-06 Thread Marcus Meissner
Hi, Dave does not like private-only emails, so again for netdev list: On Wed, Jun 05, 2019 at 11:20:29AM +0200, Marcus Meissner wrote: > Hi Gen Zhang, > > looking at > https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/commit/?id=95baa60a0da80a0143e3ddd4d3725758b4513825 > > ip

Re: [PATCH] net: phy: marvell10g: allow PHY to probe without firmware

2019-06-06 Thread Russell King - ARM Linux admin
On Wed, Jun 05, 2019 at 06:48:27PM -0700, David Miller wrote: > From: Russell King > Date: Wed, 05 Jun 2019 11:43:16 +0100 > > > + (state == PHY_UP || state == PHY_RESUMING)) { > > drivers/net/phy/marvell10g.c: In function ‘mv3310_link_change_notify’: > drivers/net/phy/marvell10g.c:268:35:

Re: likely invalid CVE assignment for commit 95baa60a0da80a0143e3ddd4d3725758b4513825

2019-06-06 Thread Gen Zhang
On Thu, Jun 06, 2019 at 09:55:07AM +0200, Marcus Meissner wrote: > Hi, > > Dave does not like private-only emails, so again for netdev list: > > On Wed, Jun 05, 2019 at 11:20:29AM +0200, Marcus Meissner wrote: > > Hi Gen Zhang, > > > > looking at > > https://git.kernel.org/pub/scm/linux/kernel/

Re: [PATCH net] pktgen: do not sleep with the thread lock held.

2019-06-06 Thread Paolo Abeni
Hi, Thank you for the feedback. On Wed, 2019-06-05 at 12:05 -0700, David Miller wrote: > From: Paolo Abeni > Date: Wed, 5 Jun 2019 14:34:46 +0200 > > > @@ -3062,20 +3062,49 @@ static int thread_is_running(const struct > > pktgen_thread *t) > > return 0; > > } > > > > -static int pktg

[PATCH net-next v2 0/3] dpaa2-eth: Add support for MQPRIO offloading

2019-06-06 Thread Ioana Radulescu
Add support for adding multiple TX traffic classes with mqprio. We can have up to one netdev queue and hardware frame queue per TC per core. Ioana Radulescu (3): dpaa2-eth: Refactor xps code dpaa2-eth: Support multiple traffic classes on Tx dpaa2-eth: Add mqprio support drivers/net/etherne

[PATCH net-next v2 1/3] dpaa2-eth: Refactor xps code

2019-06-06 Thread Ioana Radulescu
Move the code configuring xps on the netdev TX queues to a separate function. A subsequent patch will need to call this in another context as well. Signed-off-by: Ioana Radulescu --- v2: no changes drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 45 +--- 1 file changed, 3

[PATCH net-next v2 2/3] dpaa2-eth: Support multiple traffic classes on Tx

2019-06-06 Thread Ioana Radulescu
DPNI objects can have multiple traffic classes, as reflected by the num_tc attribute. Until now we ignored its value and only used traffic class 0. This patch adds support for multiple Tx traffic classes; the skb priority information received from the stack is used to select the hardware Tx queue

Re: [PATCH net-next 7/9] mlxsw: spectrum_ptp: Add implementation for physical hardware clock operations

2019-06-06 Thread Shalom Toledo
On 06/06/2019 5:43, Richard Cochran wrote: > On Wed, Jun 05, 2019 at 07:28:38PM +, Shalom Toledo wrote: >> So, there is an HW machine which responsible for adding UTC timestamp on >> R-SPAN mirror packets and there is no connection to the HW free running >> counter. > > If there is no connecti

[PATCH net-next v2 3/3] dpaa2-eth: Add mqprio support

2019-06-06 Thread Ioana Radulescu
Implement mqprio qdisc support by mapping traffic classes to different hardware enqueue priorities. The maximum number of supported traffic classes is an attribute of each DPNI object. The traffic classes map to hardware priorities from highest (0) to lowest (highest prio number). The driver assig

Re: [PATCH net-next 7/9] mlxsw: spectrum_ptp: Add implementation for physical hardware clock operations

2019-06-06 Thread Shalom Toledo
On 06/06/2019 11:50, Shalom Toledo wrote: > On 06/06/2019 5:43, Richard Cochran wrote: >> On Wed, Jun 05, 2019 at 07:28:38PM +, Shalom Toledo wrote: >>> So, there is an HW machine which responsible for adding UTC timestamp on >>> R-SPAN mirror packets and there is no connection to the HW free r

Re: [PATCH net-next 4/9] mlxsw: reg: Add Management UTC Register

2019-06-06 Thread Shalom Toledo
On 06/06/2019 5:37, Richard Cochran wrote: > On Wed, Jun 05, 2019 at 06:55:18PM +, Shalom Toledo wrote: >> On 05/06/2019 20:23, Richard Cochran wrote: >>> On Wed, Jun 05, 2019 at 11:30:06AM +, Shalom Toledo wrote: On 04/06/2019 17:17, Richard Cochran wrote: > On Mon, Jun 03, 2019 a

Re: [PATCH bpf-next v2 1/2] xsk: remove AF_XDP socket from map when the socket is released

2019-06-06 Thread Björn Töpel
On Mon, 3 Jun 2019 at 11:25, Björn Töpel wrote: > > On Sun, 2 Jun 2019 at 00:32, Song Liu wrote: > > > > On Wed, May 22, 2019 at 6:38 AM Björn Töpel wrote: > > > > > > From: Björn Töpel > > > > > > When an AF_XDP socket is released/closed the XSKMAP still holds a > > > reference to the socket i

Re: DSA with MV88E6321 and imx28

2019-06-06 Thread Benjamin Beckmeyer
>> I removed all phy-handle for the internal ports and in the mdio part >> is only port 2 and 6 by now. But the Serdes ports are still not be >> recognized. So maybe there is still something wrong? > What do you mean by SERDES? Do you mean they are connected to an SFP > cage? If so, you need to ad

Re: [PATCH net-next v2] netfilter: ipv6: Fix undefined symbol nf_ct_frag6_gather

2019-06-06 Thread Pablo Neira Ayuso
On Sun, Jun 02, 2019 at 09:49:26PM +0800, we...@ucloud.cn wrote: > From: wenxu > > CONFIG_NETFILTER=m and CONFIG_NF_DEFRAG_IPV6 is not set > > ERROR: "nf_ct_frag6_gather" [net/ipv6/ipv6.ko] undefined! Applied to nf-next, thanks.

Re: [PATCH net-next 1/2] bpf_xdp_redirect_map: Add flag to return XDP_PASS on map lookup failure

2019-06-06 Thread Toke Høiland-Jørgensen
Jesper Dangaard Brouer writes: > On Tue, 04 Jun 2019 17:24:10 +0200 > Toke Høiland-Jørgensen wrote: > >> The bpf_redirect_map() helper used by XDP programs doesn't return any >> indication of whether it can successfully redirect to the map index it was >> given. Instead, BPF programs have to tra

[RFC v2] vsock: proposal to support multiple transports at runtime

2019-06-06 Thread Stefano Garzarella
Hi all, this is a v2 of a proposal addressing the comments made by Dexuan, Stefan, and Jorgen. v1: https://www.spinics.net/lists/netdev/msg570274.html We can define two types of transport that we have to handle at the same time (e.g. in a nested VM we would have both types of transport runnin

Re: [PATCH net-next 4/9] mlxsw: reg: Add Management UTC Register

2019-06-06 Thread Petr Machata
Shalom Toledo writes: > On 06/06/2019 5:37, Richard Cochran wrote: >> Okay, so then you want to convert it into TAI (for PTP) rather than UTC. > > No, the HW interface is in UTC format. This is part of the HW machine that > responsible for adding the UTC time stamping on R-SPAN mirror packets.

Re: [PATCH net-next 7/9] mlxsw: spectrum_ptp: Add implementation for physical hardware clock operations

2019-06-06 Thread Petr Machata
Richard Cochran writes: > On Wed, Jun 05, 2019 at 09:00:09AM +, Petr Machata wrote: >> We don't build the PTP module at all unless CONFIG_PTP_1588_CLOCK is >> enabled, and fall back to inline stubs unless it IS_REACHABLE. I believe >> this should be OK. > > Please use "imply PTP_1588_CLOCK"

RE: [PATCH V2 net 00/11] Extending the ena driver to support new features and enhance performance

2019-06-06 Thread Jubran, Samih
As of today there are no flags exposed by ENA NIC device, however, we are planning to use them in the near future. We want to provide customers with extra methods to identify (and differentiate) multiple network interfaces that can be attached to a single VM. Currently, customers can identify a

Re: [PATCH v2 bpf-next 1/2] xdp: Add tracepoint for bulk XDP_TX

2019-06-06 Thread Toshiaki Makita
On 2019/06/05 16:59, Jesper Dangaard Brouer wrote: On Wed, 5 Jun 2019 14:36:12 +0900 Toshiaki Makita wrote: This is introduced for admins to check what is happening on XDP_TX when bulk XDP_TX is in use, which will be first introduced in veth in next commit. Is the plan that this tracepoint

[PATCH rdma-next 2/3] RDMA/mlx5: Consider eswitch encap mode

2019-06-06 Thread Leon Romanovsky
From: Maor Gottlieb When flow steering is created, then the encap support should consider the eswitch encap mode. If the eswitch flow table (FDB) supports encap then it shouldn't be supported on NIC RX flow tables. Fixes: 4adda1122c490 ('RDMA/mlx5: Enable decap and packet reformat on flow table

[PATCH mlx5-next 1/3] net/mlx5: Expose eswitch encap mode

2019-06-06 Thread Leon Romanovsky
From: Maor Gottlieb Add API to get the current Eswitch encap mode. It will be used in downstream patches to check if flow table can be created with encap support or not. Signed-off-by: Maor Gottlieb Signed-off-by: Leon Romanovsky --- drivers/net/ethernet/mellanox/mlx5/core/eswitch.c | 10

[PATCH rdma-next 0/3] Expose ENCAP mode to mlx5_ib

2019-06-06 Thread Leon Romanovsky
From: Leon Romanovsky Hi, This is short series from Maor to expose and use enacap mode inside mlx5_ib. Thanks Maor Gottlieb (3): net/mlx5: Expose eswitch encap mode RDMA/mlx5: Consider eswitch encap mode RDMA/mlx5: Enable decap and packet reformat on FDB drivers/infiniband/hw/mlx5/main

[PATCH rdma-next 3/3] RDMA/mlx5: Enable decap and packet reformat on FDB

2019-06-06 Thread Leon Romanovsky
From: Maor Gottlieb If FDB flow tables support decap operation, enable it on creation, This allows to perform decapsulation of tunnelled packets by steering rules. If FDB flow tables support reformat operation, enable it on creation as well. Signed-off-by: Maor Gottlieb Signed-off-by: Leon Roma

[PATCH iproute2-next] devlink: Increase bus,device buffer size to 64 bytes

2019-06-06 Thread Parav Pandit
Device name on mdev bus is 36 characters long which follow standard uuid RFC 4122. This is probably the longest name that a kernel will return for a device. Hence increase the buffer size to 64 bytes. Acked-by: Jiri Pirko Signed-off-by: Parav Pandit --- devlink/devlink.c | 4 ++-- 1 file chan

Re: [PATCH net 2/2] ipv6: fix EFAULT on sendto with icmpv6 and hdrincl

2019-06-06 Thread Nicolas Dichtel
Le 06/06/2019 à 09:15, Olivier Matz a écrit : > The following code returns EFAULT (Bad address): > > s = socket(AF_INET6, SOCK_RAW, IPPROTO_ICMPV6); > setsockopt(s, SOL_IPV6, IPV6_HDRINCL, 1); > sendto(ipv6_icmp6_packet, addr); /* returns -1, errno = EFAULT */ > > The IPv4 equivalent code

[PATCH V1 net-next 0/6] Support for dynamic queue size changes

2019-06-06 Thread sameehj
From: Sameeh Jubran This patchset introduces the following: * add new admin command for supporting different queue size for Tx/Rx * add support for Tx/Rx queues size modification through ethtool * allow queues allocation backoff when low on memory * update driver version Arthur Kiyanovski (1):

[PATCH V1 net-next 5/6] net: ena: add ethtool function for changing io queue sizes

2019-06-06 Thread sameehj
From: Sameeh Jubran Implement the set_ringparam() function of the ethtool interface to enable the changing of io queue sizes. Signed-off-by: Arthur Kiyanovski Signed-off-by: Sameeh Jubran --- drivers/net/ethernet/amazon/ena/ena_ethtool.c | 25 +++ drivers/net/ethernet/amazon/e

[PATCH V1 net-next 6/6] net: ena: update driver version from 2.0.3 to 2.1.0

2019-06-06 Thread sameehj
From: Sameeh Jubran Update driver version to match device specification. Signed-off-by: Sameeh Jubran --- drivers/net/ethernet/amazon/ena/ena_netdev.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.h b/drivers/net/ethernet/am

[PATCH V1 net-next 2/6] net: ena: enable negotiating larger Rx ring size

2019-06-06 Thread sameehj
From: Sameeh Jubran Use MAX_QUEUES_EXT get feature capability to query the device. Signed-off-by: Netanel Belgazal Signed-off-by: Sameeh Jubran --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 144 --- drivers/net/ethernet/amazon/ena/ena_netdev.h | 15 ++ 2 files changed, 1

[PATCH V1 net-next 1/6] net: ena: add MAX_QUEUES_EXT get feature admin command

2019-06-06 Thread sameehj
From: Arthur Kiyanovski Add a new admin command to support different queue size for Tx/Rx queues (the change also support different SQ/CQ sizes) Signed-off-by: Arthur Kiyanovski Signed-off-by: Sameeh Jubran --- .../net/ethernet/amazon/ena/ena_admin_defs.h | 56 +- drivers/net/eth

[PATCH V1 net-next 3/6] net: ena: make ethtool show correct current and max queue sizes

2019-06-06 Thread sameehj
From: Sameeh Jubran Currently ethtool -g shows the same size for current and max queue sizes. Signed-off-by: Arthur Kiyanovski Signed-off-by: Sameeh Jubran --- drivers/net/ethernet/amazon/ena/ena_ethtool.c | 10 -- drivers/net/ethernet/amazon/ena/ena_netdev.c | 2 ++ 2 files changed

[PATCH V1 net-next 4/6] net: ena: allow queue allocation backoff when low on memory

2019-06-06 Thread sameehj
From: Sameeh Jubran If there is not enough memory to allocate io queues the driver will try to allocate smaller queues. The backoff algorithm is as follows: 1. Try to allocate TX and RX and if successful. 1.1. return success 2. Divide by 2 the size of the larger of RX and TX queues (or both if

Re: [PATCH rdma-next 2/3] RDMA/mlx5: Consider eswitch encap mode

2019-06-06 Thread Petr Vorel
Hi, > From: Maor Gottlieb > When flow steering is created, then the encap support should > consider the eswitch encap mode. If the eswitch flow table (FDB) > supports encap then it shouldn't be supported on NIC RX flow tables. > Fixes: 4adda1122c490 ('RDMA/mlx5: Enable decap and packet reformat

Re: [PATCH rdma-next 3/3] RDMA/mlx5: Enable decap and packet reformat on FDB

2019-06-06 Thread Petr Vorel
Hi, > From: Maor Gottlieb > If FDB flow tables support decap operation, enable it on creation, > This allows to perform decapsulation of tunnelled packets by steering > rules. If FDB flow tables support reformat operation, enable it on > creation as well. > Signed-off-by: Maor Gottlieb > Signe

Re: [PATCH mlx5-next 1/3] net/mlx5: Expose eswitch encap mode

2019-06-06 Thread Petr Vorel
Hi, > From: Maor Gottlieb > Add API to get the current Eswitch encap mode. > It will be used in downstream patches to check if > flow table can be created with encap support or not. > Signed-off-by: Maor Gottlieb > Signed-off-by: Leon Romanovsky Reviewed-by: Petr Vorel Kind regards, Petr

Re: [PATCH net-next] net: phy: Add detection of 1000BaseX link mode support

2019-06-06 Thread Andrew Lunn
On Thu, Jun 06, 2019 at 08:05:31AM +0200, Heiner Kallweit wrote: > On 06.06.2019 03:42, David Miller wrote: > > From: Robert Hancock > > Date: Tue, 4 Jun 2019 16:15:01 -0600 > > > >> Add 1000BaseX to the link modes which are detected based on the > >> MII_ESTATUS register as per 802.3 Clause 22.

Re: [PATCH] net: phy: marvell10g: allow PHY to probe without firmware

2019-06-06 Thread Andrew Lunn
> This link notifier change also screws up my long-standing patches > to add support for SFP for the PHYs on Macchiatobin which I was > going to post next. Hi Russell Is that with the SFP hanging off the Marvell 10G PHY? We are seeing that sort of chain more often, so it is something i would like

[PATCH net-next] net: fec: Do not use netdev messages too early

2019-06-06 Thread Fabio Estevam
When a valid MAC address is not found the current messages are shown: fec 2188000.ethernet (unnamed net_device) (uninitialized): Invalid MAC address: 00:00:00:00:00:00 fec 2188000.ethernet (unnamed net_device) (uninitialized): Using random MAC address: aa:9f:25:eb:7e:aa Since the network device

Re: [PATCH] net: phy: marvell10g: allow PHY to probe without firmware

2019-06-06 Thread Andrew Lunn
On Thu, Jun 06, 2019 at 08:59:19AM +0100, Russell King - ARM Linux admin wrote: > On Wed, Jun 05, 2019 at 06:48:27PM -0700, David Miller wrote: > > From: Russell King > > Date: Wed, 05 Jun 2019 11:43:16 +0100 > > > > > + (state == PHY_UP || state == PHY_RESUMING)) { > > > > drivers/net/phy/m

[RFC net-next v2 1/1] net: sched: protect against loops in TC filter hooks

2019-06-06 Thread John Hurley
TC hooks allow the application of filters and actions to packets at both ingress and egress of the network stack. It is possible, with poor configuration, that this can produce loops whereby an ingress hook calls a mirred egress action that has an egress hook that redirects back to the first ingres

Re: [PATCH 1/8] drivers: net: dsa: realtek: fix warning same module names

2019-06-06 Thread Andrew Lunn
On Thu, Jun 06, 2019 at 11:47:07AM +0200, Anders Roxell wrote: > When building with CONFIG_NET_DSA_REALTEK_SMI and CONFIG_REALTEK_PHY > enabled as loadable modules, we see the following warning: > > warning: same module names found: > drivers/net/phy/realtek.ko > drivers/net/dsa/realtek.ko >

[PATCH 6/6] usb: hso: remove bogus check for EINPROGRESS

2019-06-06 Thread Oliver Neukum
This check makes no sense. It is an inherent race. Signed-off-by: Oliver Neukum --- drivers/net/usb/hso.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index 489024f0ae62..f7976a6fa570 100644 --- a/drivers/net/usb/hso.c +++ b/

[PATCH 1/6] usb: hso: correct debug message

2019-06-06 Thread Oliver Neukum
If you do not find the OUT endpoint, you should say so, rather than copy the error message for the IN endpoint. Presumably a copy and paste error. Signed-off-by: Oliver Neukum --- drivers/net/usb/hso.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/usb/hso.c b/dr

[PATCH 3/6] usb: hso: switch definitions to the BIT macro

2019-06-06 Thread Oliver Neukum
This is just a minor improvement in readability. Signed-off-by: Oliver Neukum --- drivers/net/usb/hso.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index fe1d7bdc8afe..ab18dbe169f3 100644 --- a/drivers/net/usb/h

[PATCH 5/6] usb: hso: obey DMA rules in tiocmget

2019-06-06 Thread Oliver Neukum
The serial state information must not be embedded into another data structure, as this interferes with cache handling for DMA. Allocating it separately. Signed-off-by: Oliver Neukum --- drivers/net/usb/hso.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/driver

[PATCH 2/6] usb: hso: no complaint about kmalloc failure

2019-06-06 Thread Oliver Neukum
If this fails, kmalloc() will print a report including a stack trace. There is no need for a separate complaint. Signed-off-by: Oliver Neukum --- drivers/net/usb/hso.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index 6a0

[PATCH 4/6] usb: hso: declare endianness

2019-06-06 Thread Oliver Neukum
The driver declares data structures with defined endianness as u16. Be more precise. Signed-off-by: Oliver Neukum --- drivers/net/usb/hso.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index ab18dbe169f3..7379df01cd9

Re: [PATCH 6/8] drivers: net: phy: fix warning same module names

2019-06-06 Thread Andrew Lunn
On Thu, Jun 06, 2019 at 11:47:26AM +0200, Anders Roxell wrote: > When building with CONFIG_ASIX_PHY and CONFIG_USB_NET_AX8817X enabled as > loadable modules, we see the following warning: > > warning: same module names found: > drivers/net/phy/asix.ko > drivers/net/usb/asix.ko > > Rework so m

Re: [RFC net-next v2 1/1] net: sched: protect against loops in TC filter hooks

2019-06-06 Thread Florian Westphal
John Hurley wrote: > TC hooks allow the application of filters and actions to packets at both > ingress and egress of the network stack. It is possible, with poor > configuration, that this can produce loops whereby an ingress hook calls > a mirred egress action that has an egress hook that redire

Re: [pull request][for-next 0/9] Generic DIM lib for netdev and RDMA

2019-06-06 Thread Jason Gunthorpe
On Thu, Jun 06, 2019 at 10:19:41AM +0300, Max Gurtovoy wrote: > > > Solution: > > > - Common logic is declared in include/linux/dim.h and implemented in > > >lib/dim/dim.c > > > - Net DIM (existing) logic is declared in include/linux/net_dim.h and > > >implemented in lib/dim/net_dim.c, whic

RE: [PATCH mlx5-next 1/3] net/mlx5: Expose eswitch encap mode

2019-06-06 Thread Parav Pandit
> -Original Message- > From: linux-rdma-ow...@vger.kernel.org ow...@vger.kernel.org> On Behalf Of Leon Romanovsky > Sent: Thursday, June 6, 2019 4:36 PM > To: Doug Ledford ; Jason Gunthorpe > > Cc: Leon Romanovsky ; RDMA mailing list r...@vger.kernel.org>; Maor Gottlieb ; Mark Bloch >

[PATCH net-next v2 2/2] devmap: Allow map lookups from eBPF

2019-06-06 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen We don't currently allow lookups into a devmap from eBPF, because the map lookup returns a pointer directly to the dev->ifindex, which shouldn't be modifiable from eBPF. However, being able to do lookups in devmaps is useful to know (e.g.) whether forwarding to a spe

[PATCH net-next v2 0/2] xdp: Allow lookup into devmaps before redirect

2019-06-06 Thread Toke Høiland-Jørgensen
When using the bpf_redirect_map() helper to redirect packets from XDP, the eBPF program cannot currently know whether the redirect will succeed, which makes it impossible to gracefully handle errors. To properly fix this will probably require deeper changes to the way TX resources are allocated, bu

[PATCH net-next v2 1/2] bpf_xdp_redirect_map: Add flag to return XDP_PASS on map lookup failure

2019-06-06 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen The bpf_redirect_map() helper used by XDP programs doesn't return any indication of whether it can successfully redirect to the map index it was given. Instead, BPF programs have to track this themselves, leading to programs using duplicate maps to track which entries

Re: [RFC net-next v2 1/1] net: sched: protect against loops in TC filter hooks

2019-06-06 Thread John Hurley
On Thu, Jun 6, 2019 at 1:58 PM Florian Westphal wrote: > > John Hurley wrote: > > TC hooks allow the application of filters and actions to packets at both > > ingress and egress of the network stack. It is possible, with poor > > configuration, that this can produce loops whereby an ingress hook

Re: DSA with MV88E6321 and imx28

2019-06-06 Thread Benjamin Beckmeyer
On 06.06.19 14:24, Andrew Lunn wrote: > On Thu, Jun 06, 2019 at 10:49:08AM +0200, Benjamin Beckmeyer wrote: I removed all phy-handle for the internal ports and in the mdio part is only port 2 and 6 by now. But the Serdes ports are still not be recognized. So maybe there is still s

Re: [PATCH net-next v2 2/2] devmap: Allow map lookups from eBPF

2019-06-06 Thread Jesper Dangaard Brouer
On Thu, 06 Jun 2019 15:24:14 +0200 Toke Høiland-Jørgensen wrote: > From: Toke Høiland-Jørgensen > > We don't currently allow lookups into a devmap from eBPF, because the map > lookup returns a pointer directly to the dev->ifindex, which shouldn't be > modifiable from eBPF. > > However, being a

Re: DSA with MV88E6321 and imx28

2019-06-06 Thread Andrew Lunn
> >From our hardware developer I know now that we are using a "mini" SFF > which has no i2c eeprom. O.K. Does this mini SFF have LOS, TX-Disable, etc? Are these connected to GPIOs? I assume the SFF is fibre? And it needs the SERDES to speak 1000BaseX, not SGMII? > Switch

[PATCH net v2] pktgen: do not sleep with the thread lock held.

2019-06-06 Thread Paolo Abeni
Currently, the process issuing a "start" command on the pktgen procfs interface, acquires the pktgen thread lock and never release it, until all pktgen threads are completed. The above can blocks indefinitely any other pktgen command and any (even unrelated) netdevice removal - as the pktgen netdev

Re: DSA with MV88E6321 and imx28

2019-06-06 Thread Benjamin Beckmeyer
On 06.06.19 15:35, Andrew Lunn wrote: >> >From our hardware developer I know now that we are using a "mini" SFF >> which has no i2c eeprom. > O.K. Does this mini SFF have LOS, TX-Disable, etc? Are these connected > to GPIOs? I assume the SFF is fibre? And it needs the SERDES to speak > 1000Base

Re: [PATCH net-next v2 2/2] devmap: Allow map lookups from eBPF

2019-06-06 Thread Toke Høiland-Jørgensen
Jesper Dangaard Brouer writes: > On Thu, 06 Jun 2019 15:24:14 +0200 > Toke Høiland-Jørgensen wrote: > >> From: Toke Høiland-Jørgensen >> >> We don't currently allow lookups into a devmap from eBPF, because the map >> lookup returns a pointer directly to the dev->ifindex, which shouldn't be >>

Re: DSA with MV88E6321 and imx28

2019-06-06 Thread Andrew Lunn
On Thu, Jun 06, 2019 at 03:47:06PM +0200, Benjamin Beckmeyer wrote: > > On 06.06.19 15:35, Andrew Lunn wrote: > >> >From our hardware developer I know now that we are using a "mini" SFF > >> which has no i2c eeprom. > > O.K. Does this mini SFF have LOS, TX-Disable, etc? Are these connected > > t

Re: [RFC net-next v2 1/1] net: sched: protect against loops in TC filter hooks

2019-06-06 Thread Florian Westphal
John Hurley wrote: > On Thu, Jun 6, 2019 at 1:58 PM Florian Westphal wrote: > > I dislike this, why can't we just use a pcpu counter? > > > > The only problem is with recursion/nesting; whenever we > > hit something that queues the skb for later we're safe. > > > > Hi Florian, > The per cpu coun

Re: [PATCH net-next v4 02/20] net: axienet: Use standard IO accessors

2019-06-06 Thread Andrew Lunn
On Wed, Jun 05, 2019 at 02:42:15PM -0600, Robert Hancock wrote: > This driver was using in_be32 and out_be32 IO accessors which do not > exist on most platforms. Also, the use of big-endian accessors does not > seem correct as this hardware is accessed over an AXI bus which, to the > extent it has

Re: [PATCH net-next v4 03/20] net: axienet: fix MDIO bus naming

2019-06-06 Thread Andrew Lunn
On Wed, Jun 05, 2019 at 02:42:16PM -0600, Robert Hancock wrote: > The MDIO bus for this driver was being named using the result of > of_address_to_resource on a node which may not have any resource on it, > but the return value of that call was not checked so it was using some > random value in the

Re: [PATCH net-next v4 16/20] net: axienet: document device tree mdio child node

2019-06-06 Thread Andrew Lunn
On Wed, Jun 05, 2019 at 02:42:29PM -0600, Robert Hancock wrote: > The mdio child node for the MDIO bus is generally required when using > this driver but was not documented other than being shown in the > example. Document it as an optional (but usually required) parameter. > > Signed-off-by: Robe

[PATCH bpf v2 2/4] bpf: sync tooling uapi header

2019-06-06 Thread Daniel Borkmann
Sync BPF uapi header in order to pull in BPF_CGROUP_UDP{4,6}_RECVMSG attach types. This is done and preferred as an extra patch in order to ease sync of libbpf. Signed-off-by: Daniel Borkmann --- tools/include/uapi/linux/bpf.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/include/u

[PATCH bpf v2 0/4] Fix unconnected bpf cgroup hooks

2019-06-06 Thread Daniel Borkmann
Please refer to the patch 1/4 as the main patch with the details on the current sendmsg hook API limitations and proposal to fix it in order to work with basic applications like DNS. Remaining patches are the usual uapi and tooling updates as well as test cases. Thanks a lot! v1 -> v2: - Split o

[PATCH bpf v2 4/4] bpf: add further msg_name rewrite tests to test_sock_addr

2019-06-06 Thread Daniel Borkmann
Extend test_sock_addr for recvmsg test cases, bigger parts of the sendmsg code can be reused for this. Below are the strace view of the recvmsg rewrites; the sendmsg side does not have a BPF prog connected to it for the context of this test: IPv4 test case: [pid 4846] bpf(BPF_PROG_ATTACH, {tar

[PATCH bpf v2 3/4] bpf, bpftool: enable recvmsg attach types

2019-06-06 Thread Daniel Borkmann
Trivial patch to bpftool in order to complete enabling attaching programs to BPF_CGROUP_UDP{4,6}_RECVMSG. Signed-off-by: Daniel Borkmann --- tools/bpf/bpftool/Documentation/bpftool-cgroup.rst | 6 +- tools/bpf/bpftool/Documentation/bpftool-prog.rst | 2 +- tools/bpf/bpftool/bash-completion

[PATCH bpf v2 1/4] bpf: fix unconnected udp hooks

2019-06-06 Thread Daniel Borkmann
Intention of cgroup bind/connect/sendmsg BPF hooks is to act transparently to applications as also stated in original motivation in 7828f20e3779 ("Merge branch 'bpf-cgroup-bind-connect'"). When recently integrating the latter two hooks into Cilium to enable host based load-balancing with Kubernetes

Re: [PATCH V1 net-next 5/6] net: ena: add ethtool function for changing io queue sizes

2019-06-06 Thread Michal Kubecek
On Thu, Jun 06, 2019 at 02:55:19PM +0300, same...@amazon.com wrote: > From: Sameeh Jubran > > Implement the set_ringparam() function of the ethtool interface > to enable the changing of io queue sizes. > > Signed-off-by: Arthur Kiyanovski > Signed-off-by: Sameeh Jubran > --- > drivers/net/eth

Re: [PATCH iproute2-next] devlink: Increase bus,device buffer size to 64 bytes

2019-06-06 Thread Stephen Hemminger
On Thu, 6 Jun 2019 06:49:19 -0500 Parav Pandit wrote: > Device name on mdev bus is 36 characters long which follow standard uuid > RFC 4122. > This is probably the longest name that a kernel will return for a > device. > > Hence increase the buffer size to 64 bytes. > > Acked-by: Jiri Pirko >

Re: [PATCH net] ipv6: fix the check before getting the cookie in rt6_get_cookie

2019-06-06 Thread David Ahern
On 6/2/19 5:10 AM, Xin Long wrote: > In Jianlin's testing, netperf was broken with 'Connection reset by peer', > as the cookie check failed in rt6_check() and ip6_dst_check() always > returned NULL. Any particular test or setup that is causing the reset? I do not see that problem in general.

Re: [PATCH V2] Fix memory leak in sctp_process_init

2019-06-06 Thread Marcelo Ricardo Leitner
On Wed, Jun 05, 2019 at 07:20:10AM -0400, Neil Horman wrote: > On Wed, Jun 05, 2019 at 04:16:24AM +0800, Xin Long wrote: > > On Tue, Jun 4, 2019 at 4:34 AM Neil Horman wrote: > > > > > > syzbot found the following leak in sctp_process_init > > > BUG: memory leak > > > unreferenced object 0x888

Re: [PATCH net-next v2 1/2] bpf_xdp_redirect_map: Add flag to return XDP_PASS on map lookup failure

2019-06-06 Thread Daniel Borkmann
On 06/06/2019 03:24 PM, Toke Høiland-Jørgensen wrote: > From: Toke Høiland-Jørgensen > > The bpf_redirect_map() helper used by XDP programs doesn't return any > indication of whether it can successfully redirect to the map index it was > given. Instead, BPF programs have to track this themselves,

Re: [PATCH net-next v2 1/2] bpf_xdp_redirect_map: Add flag to return XDP_PASS on map lookup failure

2019-06-06 Thread Alexei Starovoitov
On Thu, Jun 6, 2019 at 8:51 AM Daniel Borkmann wrote: > > On 06/06/2019 03:24 PM, Toke Høiland-Jørgensen wrote: > > From: Toke Høiland-Jørgensen > > > > The bpf_redirect_map() helper used by XDP programs doesn't return any > > indication of whether it can successfully redirect to the map index it

Re: [PATCH 1/1] net: rds: fix memory leak in rds_ib_flush_mr_pool

2019-06-06 Thread santosh . shilimkar
On 6/6/19 1:00 AM, Zhu Yanjun wrote: When the following tests last for several hours, the problem will occur. Server: rds-stress -r 1.1.1.16 -D 1M Client: rds-stress -r 1.1.1.14 -s 1.1.1.16 -D 1M -T 30 The following will occur. " Starting up tsks tx/s rx/s tx+rx K/smbi K

Re: [PATCH bpf v2 0/4] Fix unconnected bpf cgroup hooks

2019-06-06 Thread Martin Lau
On Thu, Jun 06, 2019 at 04:35:13PM +0200, Daniel Borkmann wrote: > Please refer to the patch 1/4 as the main patch with the details > on the current sendmsg hook API limitations and proposal to fix > it in order to work with basic applications like DNS. Remaining > patches are the usual uapi and to

Re: [PATCH net] ipv6: fix the check before getting the cookie in rt6_get_cookie

2019-06-06 Thread Xin Long
On Thu, Jun 6, 2019 at 11:35 PM David Ahern wrote: > > On 6/2/19 5:10 AM, Xin Long wrote: > > In Jianlin's testing, netperf was broken with 'Connection reset by peer', > > as the cookie check failed in rt6_check() and ip6_dst_check() always > > returned NULL. > > Any particular test or setup that

Re: [PATCH net-next v2 1/2] bpf_xdp_redirect_map: Add flag to return XDP_PASS on map lookup failure

2019-06-06 Thread Toke Høiland-Jørgensen
Alexei Starovoitov writes: > On Thu, Jun 6, 2019 at 8:51 AM Daniel Borkmann wrote: >> >> On 06/06/2019 03:24 PM, Toke Høiland-Jørgensen wrote: >> > From: Toke Høiland-Jørgensen >> > >> > The bpf_redirect_map() helper used by XDP programs doesn't return any >> > indication of whether it can succ

Re: [PATCH net] vrf: Increment Icmp6InMsgs on the original netdev

2019-06-06 Thread David Ahern
On 6/1/19 12:14 PM, Stephen Suryaputra wrote: > On Fri, May 31, 2019 at 05:06:16PM -0600, David Ahern wrote: >> On 5/29/19 11:08 PM, Stephen Suryaputra wrote: >>> diff --git a/net/ipv6/reassembly.c b/net/ipv6/reassembly.c >>> index 1a832f5e190b..9b365c345c34 100644 >>> --- a/net/ipv6/reassembly.c >

Re: [RFC PATCH bpf-next 6/8] libbpf: allow specifying map definitions using BTF

2019-06-06 Thread Lorenz Bauer
Thanks for sending this RFC! For me, the biggest draw is that map-in-map would be so much nicer to use, plus automatic dumping of map values. Others on the thread have raised this point already: not everybody lives on the bleeding edge or can control all of their dependencies. To me this means tha

Re: [PATCH net] neighbor: Reset gc_entries counter if new entry is released before insert

2019-06-06 Thread Jeremy Cline
Hi, On Sat, May 04, 2019 at 12:41:00AM -0400, David Miller wrote: > From: David Ahern > Date: Wed, 1 May 2019 18:08:34 -0700 > > > From: David Ahern > > > > Ian and Alan both reported seeing overflows after upgrades to 5.x kernels: > > neighbour: arp_cache: neighbor table overflow! > > > >

Re: [PATCH net] neighbor: Reset gc_entries counter if new entry is released before insert

2019-06-06 Thread David Ahern
On 6/6/19 11:07 AM, Jeremy Cline wrote: > > Did this get lost in the shuffle? I see it in mainline, but I don't see > it in stable. Folks are encountering it with recent 5.1 kernels in > Fedora: https://bugzilla.redhat.com/show_bug.cgi?id=1708717. > > Thanks, > Jeremy > Still in the queue: http

Re: [PATCH V1 net-next 5/6] net: ena: add ethtool function for changing io queue sizes

2019-06-06 Thread Michal Kubecek
On Thu, Jun 06, 2019 at 02:55:19PM +0300, same...@amazon.com wrote: > diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c > b/drivers/net/ethernet/amazon/ena/ena_netdev.c > index 938aca254..7d3837c13 100644 > --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c > +++ b/drivers/net/ethernet/ama

Re: [PATCH v2 bpf-next 1/2] bpf: add a new API libbpf_num_possible_cpus()

2019-06-06 Thread Martin Lau
On Thu, Jun 06, 2019 at 09:58:36AM -0700, Hechao Li wrote: > Adding a new API libbpf_num_possible_cpus() that helps user with > per-CPU map operations. > > Signed-off-by: Hechao Li > --- > tools/lib/bpf/libbpf.c | 53 > tools/lib/bpf/libbpf.h | 16 +++

Re: [PATCH V2 net 00/11] Extending the ena driver to support new features and enhance performance

2019-06-06 Thread Jakub Kicinski
Hi Samih! Please don't top post on Linux kernel mailing lists. On Thu, 6 Jun 2019 10:23:40 +, Jubran, Samih wrote: > As of today there are no flags exposed by ENA NIC device, however, we > are planning to use them in the near future. We want to provide > customers with extra methods to identi

  1   2   3   >