On Wed, Jun 05, 2019 at 06:48:27PM -0700, David Miller wrote:
> From: Russell King <rmk+ker...@armlinux.org.uk>
> Date: Wed, 05 Jun 2019 11:43:16 +0100
>
> > + (state == PHY_UP || state == PHY_RESUMING)) {
>
> drivers/net/phy/marvell10g.c: In function ‘mv3310_link_change_notify’:
> drivers/net/phy/marvell10g.c:268:35: error: ‘PHY_RESUMING’ undeclared (first
> use in this function); did you mean ‘RPM_RESUMING’?
> (state == PHY_UP || state == PHY_RESUMING)) {
> ^~~~~~~~~~~~
> RPM_RESUMING
> drivers/net/phy/marvell10g.c:268:35: note: each undeclared identifier is
> reported only once for each function it appears in
> At top level:
> drivers/net/phy/marvell10g.c:262:13: warning: ‘mv3310_link_change_notify’
> defined but not used [-Wunused-function]
> static void mv3310_link_change_notify(struct phy_device *phydev)
> ^~~~~~~~~~~~~~~~~~~~~~~~~
Hmm. Looks like Heiner's changes in net-next _totally_ screw this
approach - it's not just about PHY_RESUMING being removed, it's
also about the link change notifier being moved. :(
This link notifier change also screws up my long-standing patches
to add support for SFP for the PHYs on Macchiatobin which I was
going to post next.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
