Re: mvpp2: oops on first received packet

2019-05-15 Thread Yanko Kaneti
On Tue, 2019-05-14 at 16:25 +0300, Yanko Kaneti wrote: > On Tue, 2019-05-14 at 14:32 +0200, Maxime Chevallier wrote: > > Hi Yanko, > > > > > On Tue, 14 May 2019 10:29:31 +0300 > > > Yanko Kaneti wrote: > > > > > > > Hello, > > > > > > > > I am trying to get some Fedora working on the MACCHIATOb

[RFC 0/2] netvsc fixes to VF frame handling

2019-05-15 Thread Stephen Hemminger
XDP generic would not work with the transparent VF support in the netvsc device. This problem is generic and probably also happens with failsafe, team, bridge, bond and any other device with a receive handler. Stephen Hemminger (2): netvsc: invoke xdp_generic from VF frame handler netvsc: unsh

[RFC 1/2] netvsc: invoke xdp_generic from VF frame handler

2019-05-15 Thread Stephen Hemminger
XDP generic does not work correctly with the Hyper-V/Azure netvsc device because of packet processing order. Only packets on the synthetic path get seen by the XDP program. The VF device packets are not seen. By the time the packets that arrive on the VF are handled by netvsc after the first pass

[RFC 2/2] netvsc: unshare skb in VF rx handler

2019-05-15 Thread Stephen Hemminger
The netvsc VF skb handler should make sure that skb is not shared. Similar logic already exists in bonding and team device drivers. This does not happen in practice because the mlx device driver does not return shared skb's. Fixes: 0c195567a8f6 ("netvsc: transparent VF management") Signed-off-by:

Re: [RFC 1/2] netvsc: invoke xdp_generic from VF frame handler

2019-05-15 Thread Jason Wang
On 2019/5/15 下午4:03, Stephen Hemminger wrote: XDP generic does not work correctly with the Hyper-V/Azure netvsc device because of packet processing order. Only packets on the synthetic path get seen by the XDP program. The VF device packets are not seen. By the time the packets that arrive on

Re: [RFC 2] Validate required parameters in inet6_validate_link_af

2019-05-15 Thread Maxim Mikityanskiy
On 2019-05-15 02:32, Jakub Kicinski wrote: > On Mon, 13 May 2019 15:05:30 +, Maxim Mikityanskiy wrote: >> +err = -EINVAL; >> + >> +if (tb[IFLA_INET6_ADDR_GEN_MODE]) { >> +u8 mode = nla_get_u8(tb[IFLA_INET6_ADDR_GEN_MODE]); >> + >> +if (check_addr_gen_mode(mode) <

Re: [PATCH v4 1/2] Bluetooth: hci_qca: Load customized NVM based on the device property

2019-05-15 Thread Rocky Liao
Hi Bala, On 2019-05-15 13:32, Balakrishna Godavarthi wrote: Hi Rocky, On 2019-05-12 08:49, Rocky Liao wrote: QCA BTSOC NVM is a customized firmware file and different vendors may want to have different BTSOC configuration (e.g. Configure SCO over PCM or I2S, Setting Tx power, etc.) via this

FW: [PATCH] net: phy: aquantia: readd XGMII support for AQR107

2019-05-15 Thread Madalin-cristian Bucur
XGMII interface mode no longer works on AQR107 after the recent changes, adding back support. Signed-off-by: Madalin Bucur --- drivers/net/phy/aquantia_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/phy/aquantia_main.c b/drivers/net/phy/aquantia_main.c index eed4fe3d871f.

Re: IP-Aliasing for IPv6?

2019-05-15 Thread Matthias May
On 14/05/2019 20:49, M. Buecher wrote: > Preamble: I'm just a network hobbyist at home, so please bear with me if > something in this mail is "stupid" from an expert's point of view. > > According to the documentation [1] "IP-Aliasing" is an obsolete way to > manage multiple IP[v4]-addresses/masks

Re: [PATCH net-next,RFC 2/2] netfilter: nf_tables: add hardware offload support

2019-05-15 Thread Pablo Neira Ayuso
On Wed, May 15, 2019 at 01:03:31AM +0200, Pablo Neira Ayuso wrote: > On Tue, May 14, 2019 at 07:01:08PM +0200, Jiri Pirko wrote: > > Thu, May 09, 2019 at 06:39:51PM CEST, pa...@netfilter.org wrote: > > >This patch adds hardware offload support for nftables through the > > >existing netdev_ops->ndo_

Re: IP-Aliasing for IPv6?

2019-05-15 Thread Michal Kubecek
On Tue, May 14, 2019 at 08:49:12PM +0200, M. Buecher wrote: > According to the documentation [1] "IP-Aliasing" is an obsolete way to > manage multiple IP[v4]-addresses/masks on an interface. > For having multiple IP[v4]-addresses on an interface this is absolutely > true. > > For me "IP-Aliasing"

[PATCH] ipvs: Fix use-after-free in ip_vs_in

2019-05-15 Thread YueHaibing
BUG: KASAN: use-after-free in ip_vs_in.part.29+0xe8/0xd20 [ip_vs] Read of size 4 at addr 8881e9b26e2c by task sshd/5603 CPU: 0 PID: 5603 Comm: sshd Not tainted 4.19.39+ #30 Hardware name: Red Hat KVM, BIOS 0.5.1 01/01/2011 Call Trace: dump_stack+0x71/0xab print_address_description+0x6a/0x270

[PATCH] net/mlx5e: restrict the real_dev of vlan device is the same as uplink device

2019-05-15 Thread wenxu
From: wenxu When register indr block for vlan device, it should check the real_dev of vlan device is same as uplink device. Or it will set offload rule to mlx5e which will never hit. Signed-off-by: wenxu --- drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 2 +- 1 file changed, 1 insertion(+

Re: [PATCH] arm64: do_csum: implement accelerated scalar version

2019-05-15 Thread Will Deacon
On Mon, Apr 15, 2019 at 07:18:22PM +0100, Robin Murphy wrote: > On 12/04/2019 10:52, Will Deacon wrote: > > I'm waiting for Robin to come back with numbers for a C implementation. > > > > Robin -- did you get anywhere with that? > > Still not what I would call finished, but where I've got so far

RE: [PATCH] arm64: do_csum: implement accelerated scalar version

2019-05-15 Thread David Laight
... > > ptr = (u64 *)(buff - offset); > > shift = offset * 8; > > > > /* > > * Head: zero out any excess leading bytes. Shifting back by the same > > * amount should be at least as fast as any other way of handling the > > * odd/even alignment, and means we can ignore it

Re: [PATCH] arm64: do_csum: implement accelerated scalar version

2019-05-15 Thread Robin Murphy
On 15/05/2019 11:15, David Laight wrote: ... ptr = (u64 *)(buff - offset); shift = offset * 8; /* * Head: zero out any excess leading bytes. Shifting back by the same * amount should be at least as fast as any other way of handling the * odd/ev

[PATCH 3.18 21/86] net: ibm: fix possible object reference leak

2019-05-15 Thread Greg Kroah-Hartman
[ Upstream commit be693df3cf9dd113ff1d2c0d8150199efdba37f6 ] The call to ehea_get_eth_dn returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: ./drivers/net/ethernet/ibm/ehea/ehea_main.c:31

[PATCH 4.4 100/266] net: xilinx: fix possible object reference leak

2019-05-15 Thread Greg Kroah-Hartman
[ Upstream commit fa3a419d2f674b431d38748cb58fb7da17ee8949 ] The call to of_parse_phandle returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: ./drivers/net/ethernet/xilinx/xilinx_axienet_

[PATCH 4.4 102/266] net: ethernet: ti: fix possible object reference leak

2019-05-15 Thread Greg Kroah-Hartman
[ Upstream commit 75eac7b5f68b0a0671e795ac636457ee27cc11d8 ] The call to of_get_child_by_name returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: ./drivers/net/ethernet/ti/netcp_ethss.c:3

[PATCH 4.4 263/266] bonding: fix arp_validate toggling in active-backup mode

2019-05-15 Thread Greg Kroah-Hartman
From: Jarod Wilson [ Upstream commit a9b8a2b39ce65df45687cf9ef648885c2a99fe75 ] There's currently a problem with toggling arp_validate on and off with an active-backup bond. At the moment, you can start up a bond, like so: modprobe bonding mode=1 arp_interval=100 arp_validate=0 arp_ip_targets=

[PATCH 4.9 47/51] bonding: fix arp_validate toggling in active-backup mode

2019-05-15 Thread Greg Kroah-Hartman
From: Jarod Wilson [ Upstream commit a9b8a2b39ce65df45687cf9ef648885c2a99fe75 ] There's currently a problem with toggling arp_validate on and off with an active-backup bond. At the moment, you can start up a bond, like so: modprobe bonding mode=1 arp_interval=100 arp_validate=0 arp_ip_targets=

[PATCH v5 2/2] dt-bindings: net: bluetooth: Add device property firmware-name for QCA6174

2019-05-15 Thread Rocky Liao
This patch adds an optional device property "firmware-name" to allow the driver to load customized nvm firmware file based on this property. Signed-off-by: Rocky Liao Reviewed-by: Rob Herring --- Changes in v5: * Made the change applicable to the wcn399x series chip sets --- Documentation/dev

[PATCH 5.1 14/46] bonding: fix arp_validate toggling in active-backup mode

2019-05-15 Thread Greg Kroah-Hartman
From: Jarod Wilson [ Upstream commit a9b8a2b39ce65df45687cf9ef648885c2a99fe75 ] There's currently a problem with toggling arp_validate on and off with an active-backup bond. At the moment, you can start up a bond, like so: modprobe bonding mode=1 arp_interval=100 arp_validate=0 arp_ip_targets=

[PATCH 5.0 105/137] bonding: fix arp_validate toggling in active-backup mode

2019-05-15 Thread Greg Kroah-Hartman
From: Jarod Wilson [ Upstream commit a9b8a2b39ce65df45687cf9ef648885c2a99fe75 ] There's currently a problem with toggling arp_validate on and off with an active-backup bond. At the moment, you can start up a bond, like so: modprobe bonding mode=1 arp_interval=100 arp_validate=0 arp_ip_targets=

[PATCH] net: bpfilter: fallback to netfilter if failed to load bpfilter kernel module

2019-05-15 Thread Konstantin Khlebnikov
If bpfilter is not available return ENOPROTOOPT to fallback to netfilter. Function request_module() returns both errors and userspace exit codes. Just ignore them. Rechecking bpfilter_ops is enough. Fixes: d2ba09c17a06 ("net: add skeleton of bpfilter kernel module") Signed-off-by: Konstantin Khle

[PATCH 4.19 088/113] bonding: fix arp_validate toggling in active-backup mode

2019-05-15 Thread Greg Kroah-Hartman
From: Jarod Wilson [ Upstream commit a9b8a2b39ce65df45687cf9ef648885c2a99fe75 ] There's currently a problem with toggling arp_validate on and off with an active-backup bond. At the moment, you can start up a bond, like so: modprobe bonding mode=1 arp_interval=100 arp_validate=0 arp_ip_targets=

[PATCH 4.14 099/115] bonding: fix arp_validate toggling in active-backup mode

2019-05-15 Thread Greg Kroah-Hartman
From: Jarod Wilson [ Upstream commit a9b8a2b39ce65df45687cf9ef648885c2a99fe75 ] There's currently a problem with toggling arp_validate on and off with an active-backup bond. At the moment, you can start up a bond, like so: modprobe bonding mode=1 arp_interval=100 arp_validate=0 arp_ip_targets=

[PATCH v5 1/2] Bluetooth: hci_qca: Load customized NVM based on the device property

2019-05-15 Thread Rocky Liao
QCA BTSOC NVM is a customized firmware file and different vendors may want to have different BTSOC configuration (e.g. Configure SCO over PCM or I2S, Setting Tx power, etc.) via this file. This patch will allow vendors to download different NVM firmware file by reading a device property "firmware-n

[PATCH RFC] proc/meminfo: add NetBuffers counter for socket buffers

2019-05-15 Thread Konstantin Khlebnikov
Socket buffers always were dark-matter that lives by its own rules. This patch adds line NetBuffers that exposes most common kinds of them. TCP and UDP are most important species. SCTP is added as example of modular protocol. UNIX have no memory counter for now, should be easy to add. Signed-off-

RE: [PATCH] arm64: do_csum: implement accelerated scalar version

2019-05-15 Thread David Laight
From: Robin Murphy > Sent: 15 May 2019 11:58 > To: David Laight; 'Will Deacon' > Cc: Zhangshaokun; Ard Biesheuvel; linux-arm-ker...@lists.infradead.org; > netdev@vger.kernel.org; > ilias.apalodi...@linaro.org; huanglingyan (A); steve.cap...@arm.com > Subject: Re: [PATCH] arm64: do_csum: implement

[PATCH 4.4 101/266] net: ibm: fix possible object reference leak

2019-05-15 Thread Greg Kroah-Hartman
[ Upstream commit be693df3cf9dd113ff1d2c0d8150199efdba37f6 ] The call to ehea_get_eth_dn returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: ./drivers/net/ethernet/ibm/ehea/ehea_main.c:31

Re: [PATCH] arm64: do_csum: implement accelerated scalar version

2019-05-15 Thread Robin Murphy
On 15/05/2019 10:47, Will Deacon wrote: On Mon, Apr 15, 2019 at 07:18:22PM +0100, Robin Murphy wrote: On 12/04/2019 10:52, Will Deacon wrote: I'm waiting for Robin to come back with numbers for a C implementation. Robin -- did you get anywhere with that? Still not what I would call finished,

[PATCH 3.18 83/86] bonding: fix arp_validate toggling in active-backup mode

2019-05-15 Thread Greg Kroah-Hartman
From: Jarod Wilson [ Upstream commit a9b8a2b39ce65df45687cf9ef648885c2a99fe75 ] There's currently a problem with toggling arp_validate on and off with an active-backup bond. At the moment, you can start up a bond, like so: modprobe bonding mode=1 arp_interval=100 arp_validate=0 arp_ip_targets=

Re: [PATCH] libertas/libertas_tf: fix spelling mistake "Donwloading" -> "Downloading"

2019-05-15 Thread Mukesh Ojha
On 5/15/2019 2:44 AM, Colin King wrote: From: Colin Ian King There is are two spelling mistakes in lbtf_deb_usb2 messages, fix these. Signed-off-by: Colin Ian King Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- drivers/net/wireless/marvell/libertas/if_usb.c| 2 +- drivers/net/wire

Re: FW: [PATCH] net: phy: aquantia: readd XGMII support for AQR107

2019-05-15 Thread Andrew Lunn
On Wed, May 15, 2019 at 08:46:26AM +, Madalin-cristian Bucur wrote: > XGMII interface mode no longer works on AQR107 after the recent changes, > adding back support. Hi Madalin Please provide a Fixes: tag for fixes like this: Fixes: 570c8a7d5303 ("net: phy: aquantia: check for supported inte

dsa: using multi-gbps speeds on CPU port

2019-05-15 Thread Maxime Chevallier
Hello everyone, I'm working on a setup where I have a 88e6390X DSA switch connected to a CPU (an armada 8040) with 2500BaseX and RXAUI interfaces (we only use one at a time). I'm facing a limitation with the current way to represent that link, where we use a fixed-link description in the CPU port

Re: [PATCH] arm64: do_csum: implement accelerated scalar version

2019-05-15 Thread Robin Murphy
On 15/05/2019 12:13, David Laight wrote: From: Robin Murphy Sent: 15 May 2019 11:58 To: David Laight; 'Will Deacon' Cc: Zhangshaokun; Ard Biesheuvel; linux-arm-ker...@lists.infradead.org; netdev@vger.kernel.org; ilias.apalodi...@linaro.org; huanglingyan (A); steve.cap...@arm.com Subject: Re: [P

Re: dsa: using multi-gbps speeds on CPU port

2019-05-15 Thread Andrew Lunn
On Wed, May 15, 2019 at 02:39:36PM +0200, Maxime Chevallier wrote: > Hello everyone, > > I'm working on a setup where I have a 88e6390X DSA switch connected to > a CPU (an armada 8040) with 2500BaseX and RXAUI interfaces (we only use > one at a time). Hi Maxime RXAUI should just work. By default

[PATCH bpf v1 0/3] Test the 32bit narrow reads

2019-05-15 Thread Krzesimir Nowak
These patches try to test the fix made in commit e2f7fc0ac695 ("bpf: fix undefined behavior in narrow load handling"). The problem existed in the generated BPF bytecode that was doing a 32bit narrow read of a 64bit field, so to test it the code would need to be executed. Currently the only such fie

[PATCH bpf v1 1/3] selftests/bpf: Test correctness of narrow 32bit read on 64bit field

2019-05-15 Thread Krzesimir Nowak
Test the correctness of the 32bit narrow reads by reading both halves of the 64 bit field and doing a binary or on them to see if we get the original value. This isn't really tested - the program is not being run, because BPF_PROG_TYPE_PERF_EVENT is not supported by bpf_test_run_prog. Signed-off-

[PATCH bpf v1 2/3] selftests/bpf: Print a message when tester could not run a program

2019-05-15 Thread Krzesimir Nowak
This prints a message when the error is about program type being not supported by the test runner or because of permissions problem. This is to see if the program we expected to run was actually executed. The messages are open-coded because strerror(ENOTSUPP) returns "Unknown error 524". Signed-o

[PATCH bpf v1 3/3] selftests/bpf: Avoid a clobbering of errno

2019-05-15 Thread Krzesimir Nowak
Save errno right after bpf_prog_test_run returns, so we later check the error code actually set by bpf_prog_test_run, not by some libcap function. Cc: Jakub Kicinski Fixes: 5a8d5209ac022 ("selftests: bpf: add trivial JSET tests") Signed-off-by: Krzesimir Nowak --- tools/testing/selftests/bpf/te

RE: [PATCH] arm64: do_csum: implement accelerated scalar version

2019-05-15 Thread David Laight
From: Robin Murphy > Sent: 15 May 2019 13:40 > On 15/05/2019 12:13, David Laight wrote: > > From: Robin Murphy > >> Sent: 15 May 2019 11:58 > >> To: David Laight; 'Will Deacon' > >> Cc: Zhangshaokun; Ard Biesheuvel; linux-arm-ker...@lists.infradead.org; > >> netdev@vger.kernel.org; > >> ilias.apal

Re: dsa: using multi-gbps speeds on CPU port

2019-05-15 Thread Maxime Chevallier
Hi Andrew, On Wed, 15 May 2019 15:27:01 +0200 Andrew Lunn wrote: >I think you are getting your terminology wrong. 'master' is eth0 in >the example you gave above. CPU and DSA ports don't have netdev >structures, and so any PHY used with them is not corrected to a >netdev. Ah yes sorry, I'm stil

Re: [PATCH net-next] sctp: remove unused cmd SCTP_CMD_GEN_INIT_ACK

2019-05-15 Thread Neil Horman
On Sun, May 12, 2019 at 01:52:48PM +0800, Xin Long wrote: > On Fri, May 10, 2019 at 7:27 PM Neil Horman wrote: > > > > On Thu, May 09, 2019 at 09:39:13AM -0700, David Miller wrote: > > > From: Neil Horman > > > Date: Thu, 9 May 2019 07:32:35 -0400 > > > > > > > This is definately a valid cleanup,

Re: [PATCH 2/3] aqc111: fix writing to the phy on BE

2019-05-15 Thread Igor Russkikh
>>> - aqc111_write32_cmd(dev, AQ_PHY_OPS, 0, 0, &aqc111_data->phy_cfg); >>> + phy_on_the_wire = aqc111_data->phy_cfg; >>> + aqc111_write32_cmd(dev, AQ_PHY_OPS, 0, 0, &phy_on_the_wire); >> >> Hi Oliver, >> >> I see all write32_cmd and write16_cmd are using a temporary variable to do an >> int

[PATCH net-next] net: stmmac: socfpga: add RMII phy mode

2019-05-15 Thread Dinh Nguyen
Add option for enabling RMII phy mode. Signed-off-by: Wei Liang Lim Signed-off-by: Dinh Nguyen --- drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c b/drivers/net/ethernet/stmicro/stmma

[PATCH v2] net: phy: aquantia: readd XGMII support for AQR107

2019-05-15 Thread Madalin-cristian Bucur
XGMII interface mode no longer works on AQR107 after the recent changes, adding back support. Fixes: 570c8a7d5303 ("net: phy: aquantia: check for supported interface modes in config_init") Signed-off-by: Madalin Bucur --- drivers/net/phy/aquantia_main.c | 1 + 1 file changed, 1 insertion(+) d

RFC: Fixing SK_REUSEPORT from sk_lookup_* helpers

2019-05-15 Thread Lorenz Bauer
In the BPF-based TPROXY session with Joe Stringer [1], I mentioned that the sk_lookup_* helpers currently return inconsistent results if SK_REUSEPORT programs are in play. SK_REUSEPORT programs are a hook point in inet_lookup. They get access to the full packet that triggered the look up. To suppo

Re: [RFC 1/2] netvsc: invoke xdp_generic from VF frame handler

2019-05-15 Thread Stephen Hemminger
On Wed, 15 May 2019 16:12:42 +0800 Jason Wang wrote: > On 2019/5/15 下午4:03, Stephen Hemminger wrote: > > XDP generic does not work correctly with the Hyper-V/Azure netvsc > > device because of packet processing order. Only packets on the > > synthetic path get seen by the XDP program. The VF devi

Re: [PATCH net-next] net: stmmac: socfpga: add RMII phy mode

2019-05-15 Thread Andrew Lunn
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c > @@ -251,6 +251,9 @@ static int socfpga_dwmac_set_phy_mode(struct > socfpga_dwmac *dwmac) > case PHY_INTERFACE_MODE_SGMII: > val = SYSMGR_EMACGRP_CTRL_PHYSEL

[PATCH 1/1] net: usb: qmi_wwan: add Telit 0x1260 and 0x1261 compositions

2019-05-15 Thread Daniele Palmas
Added support for Telit LE910Cx 0x1260 and 0x1261 compositions. Signed-off-by: Daniele Palmas --- lsusb output for the compositions: Bus 003 Device 004: ID 1bc7:1260 Telit Wireless Solutions Device Descriptor: bLength18 bDescriptorType 1 bcdUSB 2.00

Re: CFP: 4th RDMA Mini-Summit at LPC 2019

2019-05-15 Thread Yuval Shaia
On Tue, May 14, 2019 at 03:23:21PM +0300, Leon Romanovsky wrote: > This is a call for proposals for the 4th RDMA mini-summit at the Linux > Plumbers Conference in Lisbon, Portugal, which will be happening on > September 9-11h, 2019. > > We are looking for topics with focus on active audience discu

Re: [PATCH] net: sh_eth: fix mdio access in sh_eth_close() for some SoCs

2019-05-15 Thread Sergei Shtylyov
Hello! It's not "some SoCs", it's only R-Car gen2 and RZ/G1 SoCs. On 05/15/2019 08:36 AM, Yoshihiro Shimoda wrote: > The sh_eth_close() resets the MAC and then calls phy_stop() > so that mdio read access result is incorrect without any error > according to kernel trace like below: > > ifconf

Re: [PATCH -next] 9p/xen: Add cleanup path in p9_trans_xen_init

2019-05-15 Thread Dominique Martinet
YueHaibing wrote on Tue, Apr 30, 2019: > If xenbus_register_frontend() fails in p9_trans_xen_init, > we should call v9fs_unregister_trans() to do cleanup. > > Fixes: 868eb122739a ("xen/9pfs: introduce Xen 9pfs transport driver") > Signed-off-by: YueHaibing Thanks, queued both in my repo - sorry

Re: IPv6 PMTU discovery fails with source-specific routing

2019-05-15 Thread David Ahern
On 5/14/19 1:33 PM, Wei Wang wrote: > I think the bug is because when creating exceptions, src_addr is not > always set even though fib6_info is in the subtree. (because of > rt6_is_gw_or_nonexthop() check) > However, when looking up for exceptions, we always set src_addr to the > passed in flow->s

Re: [PATCH net] ipv6: fix src addr routing with the exception table

2019-05-15 Thread David Ahern
On 5/14/19 6:46 PM, Wei Wang wrote: > From: Wei Wang > > When inserting route cache into the exception table, the key is > generated with both src_addr and dest_addr with src addr routing. > However, current logic always assumes the src_addr used to generate the > key is a /128 host address. This

Re: [PATCH 1/1] net: usb: qmi_wwan: add Telit 0x1260 and 0x1261 compositions

2019-05-15 Thread Bjørn Mork
Daniele Palmas writes: > Added support for Telit LE910Cx 0x1260 and 0x1261 compositions. Thanks. Acked-by: Bjørn Mork

[PATCH net 2/3] enetc: Allow to disable Tx SG

2019-05-15 Thread Claudiu Manoil
The fact that the Tx SG flag is fixed to 'on' is only an oversight. Non-SG mode is also supported. Fix this by allowing to turn SG off. Signed-off-by: Claudiu Manoil --- drivers/net/ethernet/freescale/enetc/enetc_pf.c | 2 +- drivers/net/ethernet/freescale/enetc/enetc_vf.c | 2 +- 2 files change

[PATCH net 3/3] enetc: Add missing link state info for ethtool

2019-05-15 Thread Claudiu Manoil
Just hook get_link to standard ethtool_op_get_link, nothing special needed at this point. Signed-off-by: Claudiu Manoil --- drivers/net/ethernet/freescale/enetc/enetc_ethtool.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c b/drivers/n

[PATCH net 1/3] enetc: Fix NULL dma address unmap for Tx BD extensions

2019-05-15 Thread Claudiu Manoil
For the unlikely case of TxBD extensions (i.e. ptp) the driver tries to unmap the tx_swbd corresponding to the extension, which is bogus as it has no buffer attached. Signed-off-by: Claudiu Manoil --- drivers/net/ethernet/freescale/enetc/enetc.c | 4 +++- 1 file changed, 3 insertions(+), 1 delet

Re: dsa: using multi-gbps speeds on CPU port

2019-05-15 Thread Florian Fainelli
On 5/15/19 7:02 AM, Maxime Chevallier wrote: > Hi Andrew, > > On Wed, 15 May 2019 15:27:01 +0200 > Andrew Lunn wrote: > >> I think you are getting your terminology wrong. 'master' is eth0 in >> the example you gave above. CPU and DSA ports don't have netdev >> structures, and so any PHY used wit

[PATCH net] tcp: do not recycle cloned skbs

2019-05-15 Thread Eric Dumazet
It is illegal to change arbitrary fields in skb_shared_info if the skb is cloned. Before calling skb_zcopy_clear() we need to ensure this rule, therefore we need to move the test from sk_stream_alloc_skb() to sk_wmem_free_skb() Fixes: 4f661542a402 ("tcp: fix zerocopy and notsent_lowat issues") Si

Re: dsa: using multi-gbps speeds on CPU port

2019-05-15 Thread Russell King - ARM Linux admin
On Wed, May 15, 2019 at 03:27:01PM +0200, Andrew Lunn wrote: > On the master interface, the armada 8040, eth0, you still need > something. However, if you look at phylink_parse_fixedlink(), it puts > the speed etc into a phylink_link_state. It never instantiates a > fixed-phy. So i think that could

Re: [PATCH net 1/3] enetc: Fix NULL dma address unmap for Tx BD extensions

2019-05-15 Thread David Miller
From: Claudiu Manoil Date: Wed, 15 May 2019 19:08:56 +0300 > For the unlikely case of TxBD extensions (i.e. ptp) > the driver tries to unmap the tx_swbd corresponding > to the extension, which is bogus as it has no buffer > attached. > > Signed-off-by: Claudiu Manoil Applied.

Re: [PATCH net 3/3] enetc: Add missing link state info for ethtool

2019-05-15 Thread David Miller
From: Claudiu Manoil Date: Wed, 15 May 2019 19:08:58 +0300 > Just hook get_link to standard ethtool_op_get_link, > nothing special needed at this point. > > Signed-off-by: Claudiu Manoil Applied.

Re: [PATCH net 2/3] enetc: Allow to disable Tx SG

2019-05-15 Thread David Miller
From: Claudiu Manoil Date: Wed, 15 May 2019 19:08:57 +0300 > The fact that the Tx SG flag is fixed to 'on' is only > an oversight. Non-SG mode is also supported. Fix this > by allowing to turn SG off. > > Signed-off-by: Claudiu Manoil Applied.

Re: [PATCH net-next] net: stmmac: socfpga: add RMII phy mode

2019-05-15 Thread Florian Fainelli
On 5/15/19 8:24 AM, Andrew Lunn wrote: >> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c >> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c >> @@ -251,6 +251,9 @@ static int socfpga_dwmac_set_phy_mode(struct >> socfpga_dwmac *dwmac) >> case PHY_INTERFACE_MODE_SGMII: >>

Re: [PATCH net-next] net: stmmac: socfpga: add RMII phy mode

2019-05-15 Thread Florian Fainelli
On 5/15/19 7:46 AM, Dinh Nguyen wrote: > Add option for enabling RMII phy mode. > > Signed-off-by: Wei Liang Lim > Signed-off-by: Dinh Nguyen Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v2] net: phy: aquantia: readd XGMII support for AQR107

2019-05-15 Thread Florian Fainelli
On 5/15/19 8:07 AM, Madalin-cristian Bucur wrote: > XGMII interface mode no longer works on AQR107 after the recent changes, > adding back support. > > Fixes: 570c8a7d5303 ("net: phy: aquantia: check for supported interface modes > in config_init") > > Signed-off-by: Madalin Bucur Just so you

Re: dsa: using multi-gbps speeds on CPU port

2019-05-15 Thread Russell King - ARM Linux admin
On Wed, May 15, 2019 at 09:09:26AM -0700, Florian Fainelli wrote: > Vladimir mentioned a few weeks ago that he is considering adding support > for PHYLIB and PHYLINK to run without a net_device instance, you two > should probably coordinate with each other and make sure both of your > requirements

Re: [PATCH net] tcp: do not recycle cloned skbs

2019-05-15 Thread David Miller
From: Eric Dumazet Date: Wed, 15 May 2019 09:10:15 -0700 > It is illegal to change arbitrary fields in skb_shared_info if the > skb is cloned. > > Before calling skb_zcopy_clear() we need to ensure this rule, > therefore we need to move the test from sk_stream_alloc_skb() > to sk_wmem_free_skb()

Re: [PATCH net] tcp: do not recycle cloned skbs

2019-05-15 Thread Eric Dumazet
On Wed, May 15, 2019 at 9:24 AM David Miller wrote: > > From: Eric Dumazet > Date: Wed, 15 May 2019 09:10:15 -0700 > > > It is illegal to change arbitrary fields in skb_shared_info if the > > skb is cloned. > > > > Before calling skb_zcopy_clear() we need to ensure this rule, > > therefore we nee

Re: [PATCH net-next] net: stmmac: socfpga: add RMII phy mode

2019-05-15 Thread Andrew Lunn
On Wed, May 15, 2019 at 09:18:15AM -0700, Florian Fainelli wrote: > On 5/15/19 8:24 AM, Andrew Lunn wrote: > >> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c > >> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c > >> @@ -251,6 +251,9 @@ static int socfpga_dwmac_set_phy_mode(str

Re: CFP: 4th RDMA Mini-Summit at LPC 2019

2019-05-15 Thread Leon Romanovsky
On Wed, May 15, 2019 at 06:30:51PM +0300, Yuval Shaia wrote: > On Tue, May 14, 2019 at 03:23:21PM +0300, Leon Romanovsky wrote: > > This is a call for proposals for the 4th RDMA mini-summit at the Linux > > Plumbers Conference in Lisbon, Portugal, which will be happening on > > September 9-11h, 201

Re: [PATCH net] ipv6: fix src addr routing with the exception table

2019-05-15 Thread David Ahern
On 5/15/19 9:56 AM, David Ahern wrote: > You can add a 'cache' hook to ip/iproute.c to delete the cached routes > and verify that it works. I seem to have misplaced my patch to do it. found it. From 7a328753a93321a07a5228fb32ed881d82d7a537 Mon Sep 17 00:00:00 2001 From: David Ahern Date: Mon, 6 M

Re: [PATCH net] tcp: do not recycle cloned skbs

2019-05-15 Thread David Miller
From: Eric Dumazet Date: Wed, 15 May 2019 09:26:54 -0700 > On Wed, May 15, 2019 at 9:24 AM David Miller wrote: >> >> From: Eric Dumazet >> Date: Wed, 15 May 2019 09:10:15 -0700 >> >> > It is illegal to change arbitrary fields in skb_shared_info if the >> > skb is cloned. >> > >> > Before callin

Re: [PATCH net] tcp: do not recycle cloned skbs

2019-05-15 Thread Eric Dumazet
On Wed, May 15, 2019 at 9:41 AM David Miller wrote: > > From: Eric Dumazet > Date: Wed, 15 May 2019 09:26:54 -0700 > > > On Wed, May 15, 2019 at 9:24 AM David Miller wrote: > >> > >> From: Eric Dumazet > >> Date: Wed, 15 May 2019 09:10:15 -0700 > >> > >> > It is illegal to change arbitrary fiel

Re: [PATCH next] sysctl: add proc_dointvec_jiffies_minmax to limit the min/max write value

2019-05-15 Thread Kees Cook
On Wed, May 15, 2019 at 10:53:55PM +0800, Zhiqiang Liu wrote: > Friendly ping... > > 在 2019/4/24 12:04, Zhiqiang Liu 写道: > > > > Friendly ping... Hi! (Please include akpm on CC for next versions of this, as he's likely the person to take this patch.) > > > >> From: Zhiqiang Liu > >> > >> In

Re: RFC: Fixing SK_REUSEPORT from sk_lookup_* helpers

2019-05-15 Thread Joe Stringer
On Wed, May 15, 2019 at 8:11 AM Lorenz Bauer wrote: > > In the BPF-based TPROXY session with Joe Stringer [1], I mentioned > that the sk_lookup_* helpers currently return inconsistent results if > SK_REUSEPORT programs are in play. > > SK_REUSEPORT programs are a hook point in inet_lookup. They ge

Re: NVMEM address DT post processing [Was: Re: [PATCH net 0/3] add property "nvmem_macaddr_swap" to swap macaddr bytes order]

2019-05-15 Thread Srinivas Kandagatla
On 14/05/2019 18:44, Petr Štetiar wrote: Srinivas Kandagatla [2019-05-14 16:13:22]: On 13/05/2019 12:16, Petr Štetiar wrote: Srinivas Kandagatla [2019-05-13 11:06:48]: On 13/05/2019 10:07, Petr Štetiar wrote: Srinivas Kandagatla [2019-05-13 09:25:55]: My initial idea was to add comp

Re: [PATCH net] ipv6: fix src addr routing with the exception table

2019-05-15 Thread Wei Wang
> > What about rt6_remove_exception_rt? > > You can add a 'cache' hook to ip/iproute.c to delete the cached routes > and verify that it works. I seem to have misplaced my patch to do it. I don't think rt6_remove_exception_rt() needs any change. It is because it gets the route cache rt6_info as the

Re: [PATCH v2] net: phy: aquantia: readd XGMII support for AQR107

2019-05-15 Thread Heiner Kallweit
On 15.05.2019 18:19, Florian Fainelli wrote: > On 5/15/19 8:07 AM, Madalin-cristian Bucur wrote: >> XGMII interface mode no longer works on AQR107 after the recent changes, >> adding back support. >> >> Fixes: 570c8a7d5303 ("net: phy: aquantia: check for supported interface >> modes in config_init

Re: [PATCH net] ipv6: fix src addr routing with the exception table

2019-05-15 Thread Wei Wang
From: Wei Wang Date: Wed, May 15, 2019 at 10:25 AM To: David Ahern Cc: Wei Wang, David Miller, Linux Kernel Network Developers, Martin KaFai Lau, Mikael Magnusson, Eric Dumazet > > > > What about rt6_remove_exception_rt? > > > > You can add a 'cache' hook to ip/iproute.c to delete the cached rout

Re: [RFC net-next v2 00/14] net: stmmac: Selftests

2019-05-15 Thread Corentin Labbe
On Tue, May 14, 2019 at 05:45:22PM +0200, Jose Abreu wrote: > [ Submitting with net-next closed for proper review and testing. ] > > This introduces selftests support in stmmac driver. We add 9 basic sanity > checks and MAC loopback support for all cores within the driver. This way > more tests ca

[PATCH net] net: test nouarg before dereferencing zerocopy pointers

2019-05-15 Thread Willem de Bruijn
From: Willem de Bruijn Zerocopy skbs without completion notification were added for packet sockets with PACKET_TX_RING user buffers. Those signal completion through the TP_STATUS_USER bit in the ring. Zerocopy annotation was added only to avoid premature notification after clone or orphan, by tri

Re: FW: [PATCH] net: phy: aquantia: readd XGMII support for AQR107

2019-05-15 Thread Heiner Kallweit
On 15.05.2019 10:46, Madalin-cristian Bucur wrote: > XGMII interface mode no longer works on AQR107 after the recent changes, > adding back support. > I'd like to check the configuration of the system with the AQR107. Which board is it, and which DT config is used? > Signed-off-by: Madalin Bucur

Re: [PATCH net] ipv6: fix src addr routing with the exception table

2019-05-15 Thread David Ahern
On 5/15/19 11:28 AM, Wei Wang wrote: > From: Wei Wang > Date: Wed, May 15, 2019 at 10:25 AM > To: David Ahern > Cc: Wei Wang, David Miller, Linux Kernel Network Developers, Martin > KaFai Lau, Mikael Magnusson, Eric Dumazet > >>> >>> What about rt6_remove_exception_rt? >>> >>> You can add a 'cach

Re: [PATCH net] ipv6: fix src addr routing with the exception table

2019-05-15 Thread Wei Wang
From: David Ahern Date: Wed, May 15, 2019 at 10:33 AM To: Wei Wang Cc: Wei Wang, David Miller, Linux Kernel Network Developers, Martin KaFai Lau, Mikael Magnusson, Eric Dumazet > On 5/15/19 11:28 AM, Wei Wang wrote: > > From: Wei Wang > > Date: Wed, May 15, 2019 at 10:25 AM > > To: David Ahern >

Re: [PATCH net] ipv6: fix src addr routing with the exception table

2019-05-15 Thread David Ahern
On 5/15/19 11:45 AM, Wei Wang wrote: >> >> you have to pass in a device. The first line in ip6_del_cached_rt: >> >> if (cfg->fc_ifindex && rt->dst.dev->ifindex != cfg->fc_ifindex) >> goto out; >> >> 'ip route get' is one way to check if it has been deleted. We really >> need to add

RE: [RFC 1/2] netvsc: invoke xdp_generic from VF frame handler

2019-05-15 Thread Haiyang Zhang
> -Original Message- > From: Stephen Hemminger > Sent: Wednesday, May 15, 2019 4:03 AM > To: KY Srinivasan ; Haiyang Zhang > ; da...@davemloft.net > Cc: netdev@vger.kernel.org; Stephen Hemminger > Subject: [RFC 1/2] netvsc: invoke xdp_generic from VF frame handler > > XDP generic does

Re: [RFC 1/2] netvsc: invoke xdp_generic from VF frame handler

2019-05-15 Thread Stephen Hemminger
On Wed, 15 May 2019 17:50:25 + Haiyang Zhang wrote: > > -Original Message- > > From: Stephen Hemminger > > Sent: Wednesday, May 15, 2019 4:03 AM > > To: KY Srinivasan ; Haiyang Zhang > > ; da...@davemloft.net > > Cc: netdev@vger.kernel.org; Stephen Hemminger > > Subject: [RFC 1/2] n

RE: [RFC 1/2] netvsc: invoke xdp_generic from VF frame handler

2019-05-15 Thread Haiyang Zhang
> -Original Message- > From: Stephen Hemminger > Sent: Wednesday, May 15, 2019 1:54 PM > To: Haiyang Zhang > Cc: KY Srinivasan ; da...@davemloft.net; > netdev@vger.kernel.org; Stephen Hemminger > Subject: Re: [RFC 1/2] netvsc: invoke xdp_generic from VF frame handler > > On Wed, 15 M

Re: IPv6 PMTU discovery fails with source-specific routing

2019-05-15 Thread Martin Lau
On Tue, May 14, 2019 at 12:33:25PM -0700, Wei Wang wrote: > I think the bug is because when creating exceptions, src_addr is not > always set even though fib6_info is in the subtree. (because of > rt6_is_gw_or_nonexthop() check) > However, when looking up for exceptions, we always set src_addr to t

Re: CFP: 4th RDMA Mini-Summit at LPC 2019

2019-05-15 Thread Yuval Shaia
On Wed, May 15, 2019 at 07:36:26PM +0300, Leon Romanovsky wrote: > On Wed, May 15, 2019 at 06:30:51PM +0300, Yuval Shaia wrote: > > On Tue, May 14, 2019 at 03:23:21PM +0300, Leon Romanovsky wrote: > > > This is a call for proposals for the 4th RDMA mini-summit at the Linux > > > Plumbers Conference

Re: IPv6 PMTU discovery fails with source-specific routing

2019-05-15 Thread Wei Wang
On Wed, May 15, 2019 at 11:06 AM Martin Lau wrote: > > On Tue, May 14, 2019 at 12:33:25PM -0700, Wei Wang wrote: > > I think the bug is because when creating exceptions, src_addr is not > > always set even though fib6_info is in the subtree. (because of > > rt6_is_gw_or_nonexthop() check) > > Howe

Re: [PATCH v2] net: phy: aquantia: readd XGMII support for AQR107

2019-05-15 Thread Andrew Lunn
On Wed, May 15, 2019 at 07:25:14PM +0200, Heiner Kallweit wrote: > On 15.05.2019 18:19, Florian Fainelli wrote: > > On 5/15/19 8:07 AM, Madalin-cristian Bucur wrote: > >> XGMII interface mode no longer works on AQR107 after the recent changes, > >> adding back support. > >> > >> Fixes: 570c8a7d5303

Re: [PATCH v2] net: phy: aquantia: readd XGMII support for AQR107

2019-05-15 Thread Heiner Kallweit
On 15.05.2019 20:44, Andrew Lunn wrote: > On Wed, May 15, 2019 at 07:25:14PM +0200, Heiner Kallweit wrote: >> On 15.05.2019 18:19, Florian Fainelli wrote: >>> On 5/15/19 8:07 AM, Madalin-cristian Bucur wrote: XGMII interface mode no longer works on AQR107 after the recent changes, adding

[RFC PATCH v2 net-next 0/3] flow_offload: Re-add per-action statistics

2019-05-15 Thread Edward Cree
When the flow_offload infrastructure was added, per-action statistics, which were previously possible for drivers to support in TC offload, were not plumbed through, perhaps because the drivers in the tree did not implement them. In TC (and in the previous offload API) statistics are per-action,

[RFC PATCH v2 net-next 1/3] flow_offload: copy tcfa_index into flow_action_entry

2019-05-15 Thread Edward Cree
Required for support of shared counters (and possibly other shared per- action entities in future). Signed-off-by: Edward Cree --- include/net/flow_offload.h | 1 + net/sched/cls_api.c| 1 + 2 files changed, 2 insertions(+) diff --git a/include/net/flow_offload.h b/include/net/flow_off

  1   2   >