>>> - aqc111_write32_cmd(dev, AQ_PHY_OPS, 0, 0, &aqc111_data->phy_cfg); >>> + phy_on_the_wire = aqc111_data->phy_cfg; >>> + aqc111_write32_cmd(dev, AQ_PHY_OPS, 0, 0, &phy_on_the_wire); >> >> Hi Oliver, >> >> I see all write32_cmd and write16_cmd are using a temporary variable to do an >> internal cpu_to_le32. Why this extra temporary storage is needed? >> >> The question is actually for both 2nd and third patch. >> In all the cases BE machine will store temporary bswap conversion in tmp >> variable and will not actually touch actual field. > > Hi, > > I am most terribly sorry. I overlooked the copy. Shall I revert or will > you. > > Sorry > Oliver
Hi Oliver, I'll submit the reverts. Regards, Igor
