Re: [PATCH rdma-next 3/6] RDMA/ucontext: Do not allow BAR mappings to be executable

2019-04-18 Thread Jason Gunthorpe
On Thu, Apr 18, 2019 at 01:30:07AM -0500, Kees Cook wrote: > Anything running with READ_IMPLIES_EXEC (i.e. a gnu stack marked WITH > execute) should be considered broken. Now, the trouble is that this > personality flag is carried across execve(), so if you have a launcher > that doesn't fix up th

Re: [PATCH 1/1] be2net: Detach interface for avoiding a system crash

2019-04-18 Thread Firo
On 4/2/19 12:25 AM, Saeed Mahameed wrote: > On Mon, 2019-04-01 at 20:24 +0800, Firo Yang wrote: >> This crash is triggered by a user-after-free since lake of >> the synchronization of a race condition between >> be_update_queues() modifying multi-purpose channels of >> network device and be_tx_

Re: linux-next: build failure after merge of the bpf-next tree

2019-04-18 Thread Magnus Karlsson
On Thu, Apr 18, 2019 at 8:51 AM Alexei Starovoitov wrote: > > On Thu, Apr 18, 2019 at 08:25:22AM +0200, Magnus Karlsson wrote: > > On Thu, Apr 18, 2019 at 8:18 AM Alexei Starovoitov > > wrote: > > > > > > On Thu, Apr 18, 2019 at 07:55:30AM +0200, Magnus Karlsson wrote: > > > > On Thu, Apr 18, 201

[PATCH net 3/3] mlxsw: spectrum: Fix autoneg status in ethtool

2019-04-18 Thread Ido Schimmel
From: Amit Cohen If link is down and autoneg is set to on/off, the status in ethtool does not change. The reason is when the link is down the function returns with zero before changing autoneg value. Move the checking of link state (up/down) to be performed after setting autoneg value, in order

[PATCH net 1/3] mlxsw: spectrum: Put MC TCs into DWRR mode

2019-04-18 Thread Ido Schimmel
From: Petr Machata Both Spectrum-1 and Spectrum-2 chips are currently configured such that pairs of TC n (which is used for UC traffic) and TC n+8 (which is used for MC traffic) are feeding into the same subgroup. Strict prioritization is configured between the two TCs, and by enabling MC-aware m

[PATCH net 0/3] mlxsw: Few small fixes

2019-04-18 Thread Ido Schimmel
Patch #1, from Petr, adjusts mlxsw to provide the same QoS behavior for both Spectrum-1 and Spectrum-2. The fix is required due to a difference in the behavior of Spectrum-2 compared to Spectrum-1. The problem and solution are described in the detail in the changelog. Patch #2 increases the time p

[PATCH net 2/3] mlxsw: pci: Reincrease PCI reset timeout

2019-04-18 Thread Ido Schimmel
During driver initialization the driver sends a reset to the device and waits for the firmware to signal that it is ready to continue. Commit d2f372ba0914 ("mlxsw: pci: Increase PCI SW reset timeout") increased the timeout to 13 seconds due to longer PHY calibration in Spectrum-2 compared to Spect

[PATCH bpf-next] libbpf: remove compile time warning from libbpf_util.h

2019-04-18 Thread Magnus Karlsson
Having a helpful compile time warning in libbpf_util.h is not a good idea since all warnings are treated as errors. Change this into a comment in the code instead. Fixes: b7e3a28019c9 ("libbpf: remove dependency on barrier.h in xsk.h") Signed-off-by: Magnus Karlsson --- tools/lib/bpf/libbpf_util

Re: [patch net-next rfc 00/15] netdevsim: impement proper device model

2019-04-18 Thread Jiri Pirko
Tue, Apr 16, 2019 at 08:04:59PM CEST, jakub.kicin...@netronome.com wrote: >On Tue, 16 Apr 2019 10:59:37 +0200, Jiri Pirko wrote: >> >> 4) netdevsim instances are created by "ip link add" which is great for >> >>soft devices with no hw backend. The rtnl core allocates netdev and >> >>calls i

Re: [PATCH rdma-next 3/6] RDMA/ucontext: Do not allow BAR mappings to be executable

2019-04-18 Thread Kees Cook
On Thu, Apr 18, 2019 at 2:01 AM Jason Gunthorpe wrote: > > On Thu, Apr 18, 2019 at 01:30:07AM -0500, Kees Cook wrote: > > > Anything running with READ_IMPLIES_EXEC (i.e. a gnu stack marked WITH > > execute) should be considered broken. Now, the trouble is that this > > personality flag is carried

Re: [PATCH net-next 08/15] dsa: Keep link list of tag drivers

2019-04-18 Thread David Miller
From: Andrew Lunn Date: Thu, 18 Apr 2019 04:31:13 +0200 > +static int dsa_tag_driver_register(struct dsa_device_ops *ops, > +struct module *owner) > +{ > + ops->owner = owner; > + > + mutex_lock(&dsa_tag_drivers_lock); > + list_add_tail(&ops->list, &dsa

Re: [PATCH net-next] xsk: Have xsk_umem_peek_addr_rq() return chunk-aligned handles.

2019-04-18 Thread Björn Töpel
On Wed, 17 Apr 2019 at 21:53, Jonathan Lemon wrote: > > xkq_peek_addr() returns chunk-aligned handles, so have the rq behave > the same way. Clean up callsites. > Nice cleanup! This should go to the bpf-next tree, and the non-upstreamed mlx5 parts should obviously be removed (but I have to admi

Re: [PATCH net-next] macvlan: pass get_ts_info and SIOC[SG]HWTSTAMP ioctl to real device

2019-04-18 Thread Miroslav Lichvar
On Wed, Apr 17, 2019 at 08:31:57PM -0700, Richard Cochran wrote: > On Wed, Apr 17, 2019 at 08:59:58PM +0200, Jiri Benc wrote: > > The problem here is this patch gives access to physical interface > > settings through a virtual interface layered on top of it. Whenever > > such thing is done, the vir

Re: [PATCH 1/2 net-next] mlx5: Set AF_XDP data pointer correctly.

2019-04-18 Thread Maxim Mikityanskiy
On 2019-04-17 22:56, Jonathan Lemon wrote: > data starts at handle + headroom, so adjust appropriately. > > Signed-off-by: Jonathan Lemon > --- > drivers/net/ethernet/mellanox/mlx5/core/en/xsk/rx.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet

Re: [PATCH net-next 08/15] dsa: Keep link list of tag drivers

2019-04-18 Thread Sergei Shtylyov
On 18.04.2019 5:31, Andrew Lunn wrote: Let the tag drivers register themselves with the DSA core, keeping them in a linked list. Signed-off-by: Andrew Lunn --- include/net/dsa.h | 2 ++ net/dsa/dsa.c | 35 ++- 2 files changed, 36 insertions(+), 1 deleti

Re: [PATCH RFC] xdp: Support zero-copy XDP_TX from AF_XDP sockets.

2019-04-18 Thread Björn Töpel
On Wed, 17 Apr 2019 at 21:58, Jonathan Lemon wrote: > > When the XDP program attached to a zero-copy AF_XDP socket returns XDP_TX, > queue the umem frame on the XDP TX ring, and arrange for it to be released > via the ZCA free routine, which should place it back onto the reuseq. > There are a bun

Re: [PATCH net-next v2 1/5] vlan: support binding link state to vlan member bridge ports

2019-04-18 Thread Nikolay Aleksandrov
On 17/04/2019 21:16, Mike Manning wrote: > In the case of vlan filtering on bridges, the bridge may also have the > corresponding vlan devices as upper devices. Currently the link state > of vlan devices is transferred from the lower device. So this is up if > the bridge is in admin up state and th

Re: [PATCH net-next v2 2/5] vlan: do not transfer link state in vlan bridge binding mode

2019-04-18 Thread Nikolay Aleksandrov
On 17/04/2019 21:16, Mike Manning wrote: > In vlan bridge binding mode, the link state is no longer transferred > from the lower device. Instead it is set by the bridge module according > to the state of bridge ports that are members of the vlan. > > Signed-off-by: Mike Manning > --- > net/8021q

Re: [PATCH net-next v2 3/5] bridge: support binding vlan dev link state to vlan member bridge ports

2019-04-18 Thread Nikolay Aleksandrov
On 17/04/2019 21:16, Mike Manning wrote: > In the case of vlan filtering on bridges, the bridge may also have the > corresponding vlan devices as upper devices. A vlan bridge binding mode > is added to allow the link state of the vlan device to track only the > state of the subset of bridge ports t

Re: [PATCH net-next v2 4/5] bridge: update vlan dev state when port added to or deleted from vlan

2019-04-18 Thread Nikolay Aleksandrov
On 17/04/2019 21:16, Mike Manning wrote: > If vlan bridge binding is enabled, then the link state of a vlan device > that is an upper device of the bridge should track the state of bridge > ports that are members of that vlan. So if a bridge port becomes or > stops being a member of a vlan, then up

Re: [PATCH net-next v2 0/5] net: support binding vlan dev link state to vlan member bridge ports

2019-04-18 Thread Nikolay Aleksandrov
On 17/04/2019 21:16, Mike Manning wrote: > For vlan filtering on bridges, the bridge may also have vlan devices > as upper devices. For switches, these are used to provide L3 packet > processing for ports that are members of a given vlan. > > While it is correct that the admin state for these vlan

Re: [PATCH net-next v2 5/5] bridge: update vlan dev link state for bridge netdev changes

2019-04-18 Thread Nikolay Aleksandrov
On 17/04/2019 21:16, Mike Manning wrote: > If vlan bridge binding is enabled, then the link state of a vlan device > that is an upper device of the bridge tracks the state of bridge ports > that are members of that vlan. But this can only be done when the link > state of the bridge is up. If it is

Re: Question re. skb_orphan for TPROXY

2019-04-18 Thread Lorenz Bauer
Hello Florian, Thank you, that makes sense. I guess that technically early demux also relies on the skb_orphan call to function? I think that's what confused me. Best Lorenz On Tue, 16 Apr 2019 at 17:00, Florian Westphal wrote: > > Lorenz Bauer wrote: > > Apologies for contacting you out of th

[PATCH v7 0/2] net: phy: mscc: Improvements to VSC8514 PHY driver.

2019-04-18 Thread Kavyasree.Kotagiri
The VSC8514 PHY is a 4-ports PHY that is 10/100/1000BASE-T, 100BASE-FX, 1000BASE-X, can communicate with the MAC via QSGMII. The MAC interface protocol for each port within QSGMII can be either 1000BASE-X or SGMII, if the QSGMII MAC that the VSC8514 is connecting to supports thi

[PATCH v7 1/2] net: phy: mscc: add support for VSC8514 PHY.

2019-04-18 Thread Kavyasree.Kotagiri
From: Kavya Sree Kotagiri The VSC8514 PHY is a 4-ports PHY that is 10/100/1000BASE-T, 100BASE-FX, 1000BASE-X, can communicate with the MAC via QSGMII. The MAC interface protocol for each port within QSGMII can be either 1000BASE-X or SGMII, if the QSGMII MAC that the VSC8514 is connecting to supp

[PATCH v7 2/2] net: phy: vitesse: Remove support for VSC8514.

2019-04-18 Thread Kavyasree.Kotagiri
From: Kavya Sree Kotagiri Add support for VSC8514 in Microsemi driver (mscc.c) with more features. Signed-off-by: Kavya Sree Kotagiri --- Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None drivers/net/phy/vitesse.c | 1

[PATCH iproute2-next v2] ip fou: Support binding FOU ports

2019-04-18 Thread Kristian Evensen
This patch adds support for binding FOU ports using iproute2. Kernel-support was added in 1713cb37bf67 ("fou: Support binding FoU socket"). The parse function now handles new arguments for setting the binding-related attributes, while the print function writes the new attributes if they are set. A

Re: [PATCH net-next 08/15] dsa: Keep link list of tag drivers

2019-04-18 Thread Andrew Lunn
On Thu, Apr 18, 2019 at 12:35:44PM +0300, Sergei Shtylyov wrote: > On 18.04.2019 5:31, Andrew Lunn wrote: > > >Let the tag drivers register themselves with the DSA core, keeping > >them in a linked list. > > > >Signed-off-by: Andrew Lunn > >--- > > include/net/dsa.h | 2 ++ > > net/dsa/dsa.c

Reading MAC addresses with NVMEM under MTD partition [Was: Re: [PATCH v3 1/3] nvmem: Update the OF binding to use a subnode for the cells list]

2019-04-18 Thread Petr Štetiar
Hi, I'm wondering what is the status of this patch? I'm currently trying to do following with modified of_get_mac_address[1] which uses nvmem_get_mac_address under the hood: flash@0 { partitions { compatible = "fixed-partitions"; art: partition@fe {

[patch net-next 02/15] netdevsim: create devlink instance per netdevsim instance

2019-04-18 Thread Jiri Pirko
From: Jiri Pirko Currently there is one devlink instance created per network namespace. That is quite odd considering the fact that devlink instance should represent an ASIC. The following patches are going to move the devlink instance even more down to a bus device, but until then, have one devl

[patch net-next 03/15] netdevsim: rename devlink.c to dev.c to contain per-dev(asic) items

2019-04-18 Thread Jiri Pirko
From: Jiri Pirko The existing devlink.c code is going to be extended to represent asic device on a bus. As this is about more than just devlink, rename the file. Do appropriate prefix renaming alongside with that. Signed-off-by: Jiri Pirko --- rfc->v1: - remove the trailing "\" from the makefil

[patch net-next 04/15] netdevsim: put netdevsim bus code into separate file

2019-04-18 Thread Jiri Pirko
From: Jiri Pirko As the code related to netdevsim bus is going to get bigger, move the existing code to a separate file. Signed-off-by: Jiri Pirko --- rfc->v1: - rebased --- drivers/net/netdevsim/Makefile| 2 +- drivers/net/netdevsim/bus.c | 24 drivers/net/

[patch net-next 08/15] netdevsim: add bus attributes to add new and delete devices

2019-04-18 Thread Jiri Pirko
From: Jiri Pirko Add a way to add new netdevsim device on netdevsim bus and also to delete existing netdevsim device from the bus. Track the bus devices in using a list. Signed-off-by: Jiri Pirko --- drivers/net/netdevsim/bus.c | 97 ++- drivers/net/netdevsim/

[patch net-next 12/15] netdevsim: change debugfs tree topology

2019-04-18 Thread Jiri Pirko
From: Jiri Pirko With the model where dev is represented by devlink and ports are represented by devlink ports, make debugfs file names independent on netdev names. Change the topology to the one illustrated by the following example: $ ls /sys/kernel/debug/netdevsim/ netdevsim1 $ ls /sys/kernel/

[patch net-next 05/15] netdevsim: move device registration and related code to bus.c

2019-04-18 Thread Jiri Pirko
From: Jiri Pirko Move netdevsim device registration into bus.c and alongside with that the related sysfs attributes. Introduce new struct nsim_bus_dev to represent a netdevsim device on netdevsim bus. Signed-off-by: Jiri Pirko --- drivers/net/netdevsim/bus.c | 142 +-

[patch net-next 13/15] netdevsim: implement dev probe/remove skeleton with port initialization

2019-04-18 Thread Jiri Pirko
From: Jiri Pirko Implement netdevsim bus probing of netdevsim devices. For every probed device create a devlink instance. According to the user-passed value, create a number of ports represented by devlink port instances. Signed-off-by: Jiri Pirko --- drivers/net/netdevsim/bus.c | 29 ++

[patch net-next 11/15] netdevsim: generate random switch id instead of using dev id

2019-04-18 Thread Jiri Pirko
From: Jiri Pirko Current implementation of parent_id/switch_id does not follow the original idea of being unique. The values are "0", "1", etc. Instead of that, generate 32 random bytes. Signed-off-by: Jiri Pirko --- drivers/net/netdevsim/dev.c | 3 +++ drivers/net/netdevsim/netdev.c

[patch net-next 14/15] netdevsim: move netdev creation/destruction to dev probe

2019-04-18 Thread Jiri Pirko
From: Jiri Pirko Remove the existing way to create netdevsim over rtnetlink and move the netdev creation/destruction to dev probe, so for every probed port, a netdevsim-netdev instance is created. Adjust selftests to work with new interface. Signed-off-by: Jiri Pirko --- rfc->v1: - adjusted al

[patch net-next 06/15] netdevsim: add stub netdevsim driver implementation

2019-04-18 Thread Jiri Pirko
From: Jiri Pirko In order to bus probing to work correctly, register a simple netdevsim driver implementation. Signed-off-by: Jiri Pirko --- drivers/net/netdevsim/bus.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/drivers/net/netdevsim/bus.c b/driv

[patch net-next 15/15] netdevsim: implement ndo_get_devlink_port

2019-04-18 Thread Jiri Pirko
From: Jiri Pirko Implement ndo_get_devlink_port and allow switch_id and port_name to be handled by devlink. Signed-off-by: Jiri Pirko --- drivers/net/netdevsim/netdev.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/netdevsim/netdev.c b/drivers/net/netdevsim/netdev.c i

[patch net-next 07/15] netdevsim: use ida for bus device ids

2019-04-18 Thread Jiri Pirko
From: Jiri Pirko Instead of increments of u32 value, use ida to manage bus device ids. Signed-off-by: Jiri Pirko --- drivers/net/netdevsim/bus.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/net/netdevsim/bus.c b/drivers/net/netdevsim/bus.c index 5b

[patch net-next 10/15] netdevsim: merge sdev into dev

2019-04-18 Thread Jiri Pirko
From: Jiri Pirko As previously introduce dev which is mapped 1:1 to a bus device covers the purpose of the original shared device, merge the sdev code into dev. Signed-off-by: Jiri Pirko --- rfc->v1: - rebased --- drivers/net/netdevsim/Makefile | 2 +- drivers/net/netdevsim/bpf.c

[patch net-next 01/15] netdevsim: move device registration on bus to be done earlier in init

2019-04-18 Thread Jiri Pirko
From: Jiri Pirko As a dependency of the subsequent patch, mode device registration to be done earlier, directly in nsim_newlink(). Signed-off-by: Jiri Pirko --- drivers/net/netdevsim/netdev.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drive

[patch net-next 09/15] netdevsim: rename dev_init/exit() functions and make them independent on ns

2019-04-18 Thread Jiri Pirko
From: Jiri Pirko These functions are going to be called from bus probe/release(), therefore make them independent on ns struct and rename accordingly. Signed-off-by: Jiri Pirko --- drivers/net/netdevsim/dev.c | 31 --- drivers/net/netdevsim/netdev.c| 14 ++

[patch net-next 00/15] netdevsim: impement proper device model

2019-04-18 Thread Jiri Pirko
From: Jiri Pirko Currently the model of netdevsim is a bit odd in multiple ways. 1) devlink instance is not in any way related with actual netdevsim netdevices. Instead, it is created per-namespace. 2) multi-port netdevsim device is done using "link" attribute. 3) netdevsim bus is there only t

Re: [PATCH net-next 08/15] dsa: Keep link list of tag drivers

2019-04-18 Thread Sergei Shtylyov
On 04/18/2019 04:19 PM, Andrew Lunn wrote: >>> Let the tag drivers register themselves with the DSA core, keeping >>> them in a linked list. >>> >>> Signed-off-by: Andrew Lunn >>> --- >>> include/net/dsa.h | 2 ++ >>> net/dsa/dsa.c | 35 ++- >>> 2 files chang

Re: [PATCH net-next v2 3/5] bridge: support binding vlan dev link state to vlan member bridge ports

2019-04-18 Thread Mike Manning
On 18/04/2019 12:28, Nikolay Aleksandrov wrote: > On 17/04/2019 21:16, Mike Manning wrote: >> In the case of vlan filtering on bridges, the bridge may also have the >> corresponding vlan devices as upper devices. A vlan bridge binding mode >> is added to allow the link state of the vlan device to t

[net-next 05/15] ice: Add code for DCB initialization part 2/4

2019-04-18 Thread Jeff Kirsher
From: Anirudh Venkataramanan This patch introduces a new top level function ice_init_dcb (and related lower level helper functions) which continues the DCB init flow. This function uses ice_get_dcb_cfg to get, parse and store the DCB configuration. Once this is done, it sets itself up to be noti

[net-next 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2019-04-18

2019-04-18 Thread Jeff Kirsher
This series contains updates to the ice driver only. Anirudh fixes up code comments which had typos. Added support for DCB into the ice driver, which required a bit of refactoring of the existing code. Also fixed a potential race condition between closing and opening the VSI for a MIB change eve

[net-next 08/15] ice: Add code to process LLDP MIB change events

2019-04-18 Thread Jeff Kirsher
From: Anirudh Venkataramanan This patch adds support to process LLDP MIB change notifications sent by the firmware. Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/ice_dcb.c | 5 ++- drivers/net/ethernet/intel

[net-next 15/15] ice: Calculate ITR increment based on direct calculation

2019-04-18 Thread Jeff Kirsher
From: Brett Creeley Currently when calculating how much to increment ITR by inside of ice_update_itr() we do some estimations and intermediate calculations. Instead of doing estimations, just do the calculation directly. This allows for a more accurate value and it makes it easier for the next pe

[net-next 12/15] ice: Add code for DCB rebuild

2019-04-18 Thread Jeff Kirsher
From: Anirudh Venkataramanan This patch introduces a new function ice_dcb_rebuild which reinitializes DCB after a reset. Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/ice_dcb_lib.c | 78 driv

[net-next 14/15] ice: Bump driver version

2019-04-18 Thread Jeff Kirsher
From: Anirudh Venkataramanan Update driver version to 0.7.4 Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/ice_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/

[net-next 07/15] ice: Add code for DCB initialization part 4/4

2019-04-18 Thread Jeff Kirsher
From: Anirudh Venkataramanan When the firmware doesn't support LLDP or DCBX, the driver should switch to "software LLDP mode". This patch adds support for the same. Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/i

[net-next 11/15] ice: Add code to get DCB related statistics

2019-04-18 Thread Jeff Kirsher
From: Anirudh Venkataramanan This patch adds a new function ice_update_dcb_stats to get DCB stats from the hardware and ethtool support for displaying these stats. Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/ic

[net-next 02/15] ice: Fix incorrect use of abbreviations

2019-04-18 Thread Jeff Kirsher
From: Anirudh Venkataramanan Capitalize abbreviations and spell out some that aren't obvious. Reviewed-by: Bruce Allan Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/ice.h | 10 +- .../net/ethernet/inte

[net-next 03/15] ice: Bump version

2019-04-18 Thread Jeff Kirsher
From: Anirudh Venkataramanan Bump driver version to 0.7.3 Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/ice_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ic

[net-next 13/15] ice: Add code to control FW LLDP and DCBX

2019-04-18 Thread Jeff Kirsher
From: Anirudh Venkataramanan This patch adds code to start or stop LLDP and DCBX in firmware through use of ethtool private flags. Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/ice.h | 2 + .../net/ethe

[net-next 10/15] ice: Add priority information into VLAN header

2019-04-18 Thread Jeff Kirsher
From: Anirudh Venkataramanan This patch introduces a new function ice_tx_prepare_vlan_flags_dcb to insert 802.1p priority information into the VLAN header Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/ice_dcb_lib

[net-next 09/15] ice: Update rings based on TC information

2019-04-18 Thread Jeff Kirsher
From: Anirudh Venkataramanan This patch adds a new function ice_vsi_cfg_dcb_rings which updates a VSI's rings based on DCB traffic class information. Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/ice_dcb_lib.c |

[net-next 06/15] ice: Add code for DCB initialization part 3/4

2019-04-18 Thread Jeff Kirsher
From: Anirudh Venkataramanan This patch adds a new function ice_pf_dcb_cfg (and related helpers) which applies the DCB configuration obtained from the firmware. As part of this, VSIs/netdevs are updated with traffic class information. This patch requires a bit of a refactor of existing code. 1.

[net-next 01/15] ice: Fix typos in code comments

2019-04-18 Thread Jeff Kirsher
From: Anirudh Venkataramanan This patch fixes typos in code comments. Reviewed-by: Bruce Allan Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/ice.h | 2 +- drivers/net/ethernet/intel/ice/ice_common.c

[net-next 04/15] ice: Add code for DCB initialization part 1/4

2019-04-18 Thread Jeff Kirsher
From: Anirudh Venkataramanan This patch introduces a skeleton for ice_init_pf_dcb, the top level function for DCB initialization. Subsequent patches will add to this DCB init flow. In this patch, ice_init_pf_dcb checks if DCB is a supported capability. If so, an admin queue call to start the LLD

Re: [PATCH 1/2 net-next] mlx5: Set AF_XDP data pointer correctly.

2019-04-18 Thread Jonathan Lemon
On 18 Apr 2019, at 2:11, Maxim Mikityanskiy wrote: On 2019-04-17 22:56, Jonathan Lemon wrote: data starts at handle + headroom, so adjust appropriately. Signed-off-by: Jonathan Lemon --- drivers/net/ethernet/mellanox/mlx5/core/en/xsk/rx.c | 3 ++- 1 file changed, 2 insertions(+), 1 dele

Re: [PATCH v2] ethtool: Add bash-completion script

2019-04-18 Thread John W. Linville
On Tue, Apr 16, 2019 at 08:53:33PM -0600, Kevin Locke wrote: > On Tue, 2019-04-16 at 14:37 -0400, John W. Linville wrote: > > Overall, it looks good to me. But when I build with "make distcheck", > > I get this output: > > > > [...] > > > > It looks like somewhere you are using "$(bashcompletiond

Re: [RFC PATCH net-next] net: sched: flower: refactor reoffload for concurrent access

2019-04-18 Thread Vlad Buslov
On Wed 17 Apr 2019 at 19:34, Jakub Kicinski wrote: > On Wed, 17 Apr 2019 07:29:36 +, Vlad Buslov wrote: >> On Wed 17 Apr 2019 at 00:49, Jakub Kicinski >> wrote: >> > On Tue, 16 Apr 2019 17:20:47 +0300, Vlad Buslov wrote: >> >> @@ -1551,6 +1558,10 @@ static int fl_change(struct net *net, st

Re: [patch net-next rfc 00/15] netdevsim: impement proper device model

2019-04-18 Thread Jakub Kicinski
On Thu, 18 Apr 2019 09:22:56 +0200, Jiri Pirko wrote: > Tue, Apr 16, 2019 at 08:04:59PM CEST, jakub.kicin...@netronome.com wrote: > >On Tue, 16 Apr 2019 10:59:37 +0200, Jiri Pirko wrote: > >> >> 4) netdevsim instances are created by "ip link add" which is great for > >> >>soft devices with no

[PATCH v4 net-next 0/6] exthdrs: Make ext. headers & options useful - Part I

2019-04-18 Thread Tom Herbert
Extension headers are the mechanism of extensibility for the IPv6 protocol, however to date they have only seen limited deployment. The reasons for that are because intermediate devices don't handle them well, and there haven't really be any useful extension headers defined. In particular, Destinat

[PATCH v4 net-next 5/6] ip6tlvs: Add netlink interface

2019-04-18 Thread Tom Herbert
Add a netlink interface to manage the TX TLV parameters. Managed parameters include those for validating and sending TLVs being sent such as alignment, TLV ordering, length limits, etc. --- include/net/ipv6.h | 18 +++ include/uapi/linux/in6.h | 31 + net/ipv6/exthdrs_core.c| 2

[PATCH v4 net-next 2/6] exthdrs: Move generic EH functions to exthdrs_core.c

2019-04-18 Thread Tom Herbert
Move generic functions in exthdrs.c to exthdrs_core.c so that exthdrs.c only contains functions that are specific to IPv6 processing, and exthdrs_core.c contains functions that are generic. --- net/ipv6/exthdrs.c | 138 --- net/ipv6/exthdrs_core.c |

[PATCH v4 net-next 6/6] ip6tlvs: Validation of TX Destination and Hop-by-Hop options

2019-04-18 Thread Tom Herbert
Validate Destination and Hop-by-Hop options. This uses the information in the TLV parameters table to validate various aspects of both individual TLVs as well as a list of TLVs in an extension header. There are two levels of validation that can be performed: simple checks and deep checks. Simple c

[PATCH v4 net-next 4/6] exthdrs: Add TX parameters

2019-04-18 Thread Tom Herbert
Define a number of transmit parameters for TLV Parameter table definitions. These will be used for validating TLVs that are set on a socket. --- include/net/ipv6.h | 26 - include/uapi/linux/in6.h | 8 +++ net/ipv6/exthdrs.c | 2 +- net/ipv6/exthdrs_core

[PATCH v4 net-next 1/6] exthdrs: Create exthdrs_options.c

2019-04-18 Thread Tom Herbert
Create exthdrs_options.c to hold code related to specific Hop-by-Hop and Destination extension header options. Move related functions in exthdrs.c to the new file. --- include/net/ipv6.h | 15 net/ipv6/Makefile | 2 +- net/ipv6/exthdrs.c | 204 -

[PATCH v4 net-next 3/6] exthdrs: Registration of TLV handlers and parameters

2019-04-18 Thread Tom Herbert
Create a single TLV parameter table that holds meta information for IPv6 Hop-by-Hop and Destination TLVs. The data structure is composed of a 256 element array of u8's (one entry for each TLV type to allow O(1) lookup). Each entry provides an offset into an array of TLV proc data structures which f

Re: [patch net-next 01/15] netdevsim: move device registration on bus to be done earlier in init

2019-04-18 Thread Jakub Kicinski
On Thu, 18 Apr 2019 16:06:00 +0200, Jiri Pirko wrote: > From: Jiri Pirko > > As a dependency of the subsequent patch, mode device registration to be > done earlier, directly in nsim_newlink(). > > Signed-off-by: Jiri Pirko Acked-by: Jakub Kicinski

Re: [patch net-next 03/15] netdevsim: rename devlink.c to dev.c to contain per-dev(asic) items

2019-04-18 Thread Jakub Kicinski
On Thu, 18 Apr 2019 16:06:02 +0200, Jiri Pirko wrote: > From: Jiri Pirko > > The existing devlink.c code is going to be extended to represent asic > device on a bus. As this is about more than just devlink, > rename the file. Do appropriate prefix renaming alongside with that. Again, devlink !=

Re: [patch net-next 14/15] netdevsim: move netdev creation/destruction to dev probe

2019-04-18 Thread Jakub Kicinski
On Thu, 18 Apr 2019 16:06:13 +0200, Jiri Pirko wrote: > @@ -1279,24 +1312,13 @@ try: > start_test("Test multi-dev ASIC cross-dev destruction...") > bpftool_prog_list_wait(expected=2) > > -simA.remove() > +simdevA.remove() > bpftool_prog_list_wait(expected=1) > > ifna

[PATCH net-next v3 1/5] vlan: support binding link state to vlan member bridge ports

2019-04-18 Thread Mike Manning
In the case of vlan filtering on bridges, the bridge may also have the corresponding vlan devices as upper devices. Currently the link state of vlan devices is transferred from the lower device. So this is up if the bridge is in admin up state and there is at least one bridge port that is up, regar

[PATCH net-next v3 3/5] bridge: support binding vlan dev link state to vlan member bridge ports

2019-04-18 Thread Mike Manning
In the case of vlan filtering on bridges, the bridge may also have the corresponding vlan devices as upper devices. A vlan bridge binding mode is added to allow the link state of the vlan device to track only the state of the subset of bridge ports that are also members of the vlan, rather than tha

Re: [PATCH net-next 01/15] dsa: Add SPDX header to tag drivers.

2019-04-18 Thread Florian Fainelli
On 4/17/2019 7:31 PM, Andrew Lunn wrote: > Add an SPDX header, and remove the license boilerplate text. > > Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli -- Florian

[PATCH net-next v3 4/5] bridge: update vlan dev state when port added to or deleted from vlan

2019-04-18 Thread Mike Manning
If vlan bridge binding is enabled, then the link state of a vlan device that is an upper device of the bridge should track the state of bridge ports that are members of that vlan. So if a bridge port becomes or stops being a member of a vlan, then update the link state of the vlan device if necessa

[PATCH net-next v3 5/5] bridge: update vlan dev link state for bridge netdev changes

2019-04-18 Thread Mike Manning
If vlan bridge binding is enabled, then the link state of a vlan device that is an upper device of the bridge tracks the state of bridge ports that are members of that vlan. But this can only be done when the link state of the bridge is up. If it is down, then the link state of the vlan devices mus

[PATCH net-next v3 0/5] net: support binding vlan dev link state to vlan member bridge ports

2019-04-18 Thread Mike Manning
For vlan filtering on bridges, the bridge may also have vlan devices as upper devices. For switches, these are used to provide L3 packet processing for ports that are members of a given vlan. While it is correct that the admin state for these vlan devices is either set directly for the device or i

[PATCH net-next v3 2/5] vlan: do not transfer link state in vlan bridge binding mode

2019-04-18 Thread Mike Manning
In vlan bridge binding mode, the link state is no longer transferred from the lower device. Instead it is set by the bridge module according to the state of bridge ports that are members of the vlan. Signed-off-by: Mike Manning --- net/8021q/vlan.c | 18 ++ net/8021q/vlan_dev

Re: [PATCH net-next 02/15] dsa: Move tagger name into its ops structure

2019-04-18 Thread Florian Fainelli
On 4/17/2019 7:31 PM, Andrew Lunn wrote: > Rather than keep a list to map a tagger ops to a name, place the name > into the ops structure. This removes the hard coded list, a stop > towards making the taggers more dynamic. > > Signed-off-by: Andrew Lunn > --- [snip] > diff --git a/include/ne

Re: [PATCH net 0/3] mlxsw: Few small fixes

2019-04-18 Thread David Miller
From: Ido Schimmel Date: Thu, 18 Apr 2019 07:14:12 + > Patch #1, from Petr, adjusts mlxsw to provide the same QoS behavior for > both Spectrum-1 and Spectrum-2. The fix is required due to a difference > in the behavior of Spectrum-2 compared to Spectrum-1. The problem and > solution are descr

Re: [RFC PATCH net-next] net: sched: flower: refactor reoffload for concurrent access

2019-04-18 Thread Jakub Kicinski
On Thu, 18 Apr 2019 16:33:22 +, Vlad Buslov wrote: > Considering this, I tried to improve my solution to remove possibility > of multiple adds of same filter and it seems to me that it would be > enough to move hw_filters list management in flower offloads functions: > add filter to list while

Re: [PATCH net-next 04/15] dsa: Add MODULE_LICENSE to tag drivers

2019-04-18 Thread Florian Fainelli
On 4/17/2019 7:31 PM, Andrew Lunn wrote: > All the tag drivers are some variant of GPL. Add a MODULE_LICENSE() > indicating this, so the drivers can later be compiled as modules. > > Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH RFC] xdp: Support zero-copy XDP_TX from AF_XDP sockets.

2019-04-18 Thread Jonathan Lemon
On 18 Apr 2019, at 3:10, Björn Töpel wrote: On Wed, 17 Apr 2019 at 21:58, Jonathan Lemon wrote: When the XDP program attached to a zero-copy AF_XDP socket returns XDP_TX, queue the umem frame on the XDP TX ring, and arrange for it to be released via the ZCA free routine, which should place

Re: [RFC PATCH net-next] net: sched: flower: refactor reoffload for concurrent access

2019-04-18 Thread Jakub Kicinski
On Thu, 18 Apr 2019 17:58:26 +, Vlad Buslov wrote: > On Thu 18 Apr 2019 at 20:46, Jakub Kicinski > wrote: > > On Thu, 18 Apr 2019 16:33:22 +, Vlad Buslov wrote: > >> Considering this, I tried to improve my solution to remove possibility > >> of multiple adds of same filter and it seems

Re: [RFC PATCH net-next] net: sched: flower: refactor reoffload for concurrent access

2019-04-18 Thread Vlad Buslov
On Thu 18 Apr 2019 at 21:02, Jakub Kicinski wrote: > On Thu, 18 Apr 2019 17:58:26 +, Vlad Buslov wrote: >> On Thu 18 Apr 2019 at 20:46, Jakub Kicinski >> wrote: >> > On Thu, 18 Apr 2019 16:33:22 +, Vlad Buslov wrote: >> >> Considering this, I tried to improve my solution to remove po

Re: [RFC PATCH net-next] net: sched: flower: refactor reoffload for concurrent access

2019-04-18 Thread Jakub Kicinski
On Thu, 18 Apr 2019 18:13:37 +, Vlad Buslov wrote: > On Thu 18 Apr 2019 at 21:02, Jakub Kicinski > wrote: > > On Thu, 18 Apr 2019 17:58:26 +, Vlad Buslov wrote: > >> On Thu 18 Apr 2019 at 20:46, Jakub Kicinski > >> wrote: > >> > On Thu, 18 Apr 2019 16:33:22 +, Vlad Buslov wrote:

Re: [PATCH 1/1] be2net: Detach interface for avoiding a system crash

2019-04-18 Thread Saeed Mahameed
On Thu, 2019-04-18 at 15:05 +0800, Firo wrote: > > On 4/2/19 12:25 AM, Saeed Mahameed wrote: > > On Mon, 2019-04-01 at 20:24 +0800, Firo Yang wrote: > > > This crash is triggered by a user-after-free since lake of > > > the synchronization of a race condition between > > > be_update_queues() modi

Re: [net-next 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2019-04-18

2019-04-18 Thread David Miller
From: Jeff Kirsher Date: Thu, 18 Apr 2019 08:59:01 -0700 > This series contains updates to the ice driver only. > > Anirudh fixes up code comments which had typos. Added support for DCB > into the ice driver, which required a bit of refactoring of the existing > code. Also fixed a potential ra

[PATCH] net: socionext: replace napi_alloc_frag with the netdev variant on init

2019-04-18 Thread Ilias Apalodimas
Use netdev_alloc_frag during the Rx ring setup instead napi_alloc_frag Fixes: 4acb20b46214 ("net: socionext: different approach on DMA") Signed-off-by: Ilias Apalodimas --- drivers/net/ethernet/socionext/netsec.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/dri

Re: [PATCH net 0/3] mlxsw: Few small fixes

2019-04-18 Thread Ido Schimmel
On Thu, Apr 18, 2019 at 10:38:01AM -0700, David Miller wrote: > Series applied, thank you. > > Would you like me to queue these up for -stable as well? Yes, please. Thanks, David.

Re: [PATCH net-next 06/15] dsa: Remove const from tag driver ops structure

2019-04-18 Thread Florian Fainelli
On 4/17/2019 7:31 PM, Andrew Lunn wrote: > A later patch will create a linked list of tag driver ops structures, > using a list_head in the structure. So the structure cannot be const. Can't we encapsulate the existing dsa_device_ops, while leaving them const into another structure which is not

Re: [RFC PATCH net-next] net: sched: flower: refactor reoffload for concurrent access

2019-04-18 Thread Vlad Buslov
On Thu 18 Apr 2019 at 20:46, Jakub Kicinski wrote: > On Thu, 18 Apr 2019 16:33:22 +, Vlad Buslov wrote: >> Considering this, I tried to improve my solution to remove possibility >> of multiple adds of same filter and it seems to me that it would be >> enough to move hw_filters list managemen

Re: [PATCH net 0/3] mlxsw: Few small fixes

2019-04-18 Thread David Miller
From: Ido Schimmel Date: Thu, 18 Apr 2019 18:02:16 + > On Thu, Apr 18, 2019 at 10:38:01AM -0700, David Miller wrote: >> Series applied, thank you. >> >> Would you like me to queue these up for -stable as well? > > Yes, please. Ok, done.

Re: [PATCH] net: socionext: replace napi_alloc_frag with the netdev variant on init

2019-04-18 Thread Ard Biesheuvel
On Thu, 18 Apr 2019 at 11:27, Ilias Apalodimas wrote: > > Use netdev_alloc_frag during the Rx ring setup instead napi_alloc_frag > Why? > Fixes: 4acb20b46214 ("net: socionext: different approach on DMA") > Signed-off-by: Ilias Apalodimas > --- > drivers/net/ethernet/socionext/netsec.c | 11 +++

  1   2   >