On Thu, 18 Apr 2019 16:06:13 +0200, Jiri Pirko wrote: > @@ -1279,24 +1312,13 @@ try: > start_test("Test multi-dev ASIC cross-dev destruction...") > bpftool_prog_list_wait(expected=2) > > - simA.remove() > + simdevA.remove() > bpftool_prog_list_wait(expected=1) > > ifnameB = bpftool("prog show %s" % (progB))[1]["dev"]["ifname"] > fail(ifnameB != simB1['ifname'], "program not bound to originial device") > - simB1.remove() > - bpftool_prog_list_wait(expected=1) > - > - start_test("Test multi-dev ASIC cross-dev destruction - move...") > - ifnameB = bpftool("prog show %s" % (progB))[1]["dev"]["ifname"] > - fail(ifnameB not in (simB2['ifname'], simB3['ifname']), > - "program not bound to remaining devices") > - > - simB2.remove() > - ifnameB = bpftool("prog show %s" % (progB))[1]["dev"]["ifname"] > - fail(ifnameB != simB3['ifname'], "program not bound to remaining device") > > - simB3.remove() > + simdevB.remove() > bpftool_prog_list_wait(expected=0) > > start_test("Test multi-dev ASIC cross-dev destruction - orphaned...")
You're removing existing tests in the name of reshuffling the code? Hard no. Once devlink can do what we need here, we can reorg netdevsim. netdevsim is for testing real interfaces.