Hi Stephen,
On Thu, 4 Apr 2019 10:13:36 -0700
Stephen Hemminger wrote:
> On Thu, 4 Apr 2019 19:07:38 +0300
> Eyal Birger wrote:
>
> > The XFRMA_IF_ID attribute is set in policies/states for them to be
> > associated with an XFRM interface (4.19+).
> >
> > Add support for setting / displaying
On 2019-04-05 09:11, Rafał Miłecki wrote:
> On 05.04.2019 07:48, Rafał Miłecki wrote:
>> On 05.04.2019 06:26, Toshiaki Makita wrote:
>>> My test results:
>>>
>>> Receiving packets from eth0.10, forwarding them to eth0.20 and applying
>>> MASQUERADE on eth0.20, using i40e 25G NIC on kernel 4.20.13.
On 05.04.2019 07:48, Rafał Miłecki wrote:
On 05.04.2019 06:26, Toshiaki Makita wrote:
My test results:
Receiving packets from eth0.10, forwarding them to eth0.20 and applying
MASQUERADE on eth0.20, using i40e 25G NIC on kernel 4.20.13.
Disabled rxvlan by ethtool -K to exercise vlan_gro_receive(
On 2019/04/05 16:14, Felix Fietkau wrote:
> On 2019-04-05 09:11, Rafał Miłecki wrote:
>> On 05.04.2019 07:48, Rafał Miłecki wrote:
>>> On 05.04.2019 06:26, Toshiaki Makita wrote:
My test results:
Receiving packets from eth0.10, forwarding them to eth0.20 and applying
MASQUERADE
On Thu 04 Apr 2019 at 14:03, John Hurley wrote:
> On Wed, Apr 3, 2019 at 5:42 PM Vlad Buslov wrote:
>>
>>
>> On Wed 03 Apr 2019 at 15:37, John Hurley wrote:
>> > Recent refactoring of fl_change aims to use the classifier spinlock to
>> > avoid the need for rtnl lock. In doing so, the fl_hw_rep
On 05.04.2019 09:58, Toshiaki Makita wrote:
On 2019/04/05 16:14, Felix Fietkau wrote:
On 2019-04-05 09:11, Rafał Miłecki wrote:
I guess its GRO + csum_partial() to be blamed for this performance drop.
Maybe csum_partial() is very fast on your powerful machine and few extra calls
don't make a d
On 05.04.2019 10:12, Rafał Miłecki wrote:
On 05.04.2019 09:58, Toshiaki Makita wrote:
On 2019/04/05 16:14, Felix Fietkau wrote:
On 2019-04-05 09:11, Rafał Miłecki wrote:
I guess its GRO + csum_partial() to be blamed for this performance drop.
Maybe csum_partial() is very fast on your powerful
> From: Lorenzo Bianconi
> Date: Thu, 4 Apr 2019 16:37:53 +0200
>
> > ipip6 tunnels run iptunnel_pull_header on received skbs. This can
> > determine the following use-after-free accessing iph pointer since
> > the packet will be 'uncloned' running pskb_expand_head if it is a
> > cloned gso skb
Toshiaki Makita writes:
> On 2019/04/05 16:14, Felix Fietkau wrote:
>> On 2019-04-05 09:11, Rafał Miłecki wrote:
>>> On 05.04.2019 07:48, Rafał Miłecki wrote:
On 05.04.2019 06:26, Toshiaki Makita wrote:
> My test results:
>
> Receiving packets from eth0.10, forwarding them to eth
Toke Høiland-Jørgensen wrote:
> As a first approximation, maybe just:
>
> if (!has_hardware_cksum_offload(netdev) && link_rate(netdev) <= 1Gbps)
> disable_gro();
I don't think its a good idea. For local delivery case, there is no
way to avoid the checksum cost, so might as well have GRO enabl
On 04/05/2019 03:51 AM, Florian Westphal wrote:
> Toke Høiland-Jørgensen wrote:
>> As a first approximation, maybe just:
>>
>> if (!has_hardware_cksum_offload(netdev) && link_rate(netdev) <= 1Gbps)
>> disable_gro();
>
> I don't think its a good idea. For local delivery case, there is no
> w
This is a follow up of the commit 0db6f8befc32 ("net/sched: fix ->get
helper of the matchall cls").
To test it:
$ cd tools/testing/selftests/tc-testing
$ ln -s ../plugin-lib/nsPlugin.py plugins/20-nsPlugin.py
$ ./tdc.py -n -e 2638
Signed-off-by: Nicolas Dichtel
---
I'm not sure to understand th
Hi,
XFRM offloading is not working if there are VLAN interfaces or macvlan
interfaces on top of base NIC interface and where base NIC interface registers
for xfrm offload.
Also, if there are PPP interfaces (say PPPoE), xfrm crypto is not offloading to
NIC.
Regards,
Mahipati
On Thu, Apr 04, 2019 at 10:49:50AM -0700, David Ahern wrote:
> From: David Ahern
>
> Signed-off-by: David Ahern
Reviewed-by: Ido Schimmel
> +static int eafnosupport_fib6_nh_init(struct net *net, struct fib6_nh
> *fib6_nh,
> + struct fib6_config *cfg, gfp_t gf
On Thu, Apr 04, 2019 at 10:49:51AM -0700, David Ahern wrote:
> From: David Ahern
>
> Add ipv6 helpers to handle ndisc references via the stub. Update
> bpf_ipv6_fib_lookup to use __ipv6_neigh_lookup_noref_stub instead of
> the open code ___neigh_lookup_noref with the stub.
>
> Signed-off-by: Dav
Hi Stephen,
It seems that commit c7c1a1ef51aea ("bridge: colorize output and use JSON print
library") broke
bridge mdb's json output. The json after that commit is invalid, more below.
Setup: 2 bridges - virbr0 and br-test
non-json bridge mdb show:
3: virbr0 vnet3 239.10.10.50 temp
3: virbr0
commit 4b454433221de445f6d3d73b0ac27b4f7da25b83 upstream.
The logic in cake_select_tin() was getting a bit hairy, and it turns out we
can simplify it quite a bit. This also allows us to get rid of one of the
two diffserv parsing functions, which has the added benefit that
already-zeroed DSCP field
On Thu, Apr 04, 2019 at 10:49:52AM -0700, David Ahern wrote:
> From: David Ahern
>
> Allow the gateway in a fib_nh_common to be from a different address
> family than the outer fib{6}_nh. To that end, replace nhc_has_gw with
> nhc_gw_family and update users of nhc_has_gw to check nhc_gw_family.
>
On Thu, Apr 04, 2019 at 10:49:53AM -0700, David Ahern wrote:
> From: David Ahern
>
> To allow the gateway to be either an IPv4 or IPv6 address, remove
> rt_uses_gateway from rtable and replace with rt_gw_family. If
> rt_gw_family is set it implies rt_uses_gateway. Rename rt_gateway
> to rt_gw4 to
On Thu, Apr 04, 2019 at 10:49:54AM -0700, David Ahern wrote:
> From: David Ahern
>
> Similar to rtable, fib_config needs to allow the gateway to be either an
> IPv4 or an IPv6 address. To that end, rename fc_gw to fc_gw4 to mean an
> IPv4 address and add fc_gw_family. Check on 'is a gateway set'
On Thu, Apr 04, 2019 at 10:49:55AM -0700, David Ahern wrote:
> From: David Ahern
>
> Add support for an IPv6 gateway to rtable. Since a gateway is either
> IPv4 or IPv6, make it a union with rt_gw4 where rt_gw_family decides
> which address is in use.
>
> When dumping the route data, encode an i
On Thu, Apr 04, 2019 at 10:49:56AM -0700, David Ahern wrote:
> From: David Ahern
>
> Add support for an IPv6 gateway to fib_config. Since a gateway is either
> IPv4 or IPv6, make it a union with fc_gw4 where fc_gw_family decides
> which address is in use. Update current checks on family and gw4 t
On Thu, Apr 04, 2019 at 10:49:57AM -0700, David Ahern wrote:
> From: David Ahern
>
> fib_check_nh is currently huge covering multiple uses cases - device only,
> device + gateway, and device + gateway with ONLINK. The next patch adds
> validation checks for IPv6 which only further complicates it.
On Thu, Apr 04, 2019 at 10:49:58AM -0700, David Ahern wrote:
> From: David Ahern
>
> Add helper to validate nexthop spec with an IPv6 gateway.
>
> Signed-off-by: David Ahern
Reviewed-by: Ido Schimmel
On Thu, Apr 04, 2019 at 10:50:00AM -0700, David Ahern wrote:
> From: David Ahern
>
> A common them in the output path is looking up a neigh entry for a
s/them/theme/
> nexthop, either the gateway in an rtable or a fallback to the daddr
> in the skb:
>
> nexthop = (__force u32)rt_nextho
On 4/5/19 6:46 AM, Ido Schimmel wrote:
> On Thu, Apr 04, 2019 at 10:49:50AM -0700, David Ahern wrote:
>> From: David Ahern
>>
>> Signed-off-by: David Ahern
>
> Reviewed-by: Ido Schimmel
>
>> +static int eafnosupport_fib6_nh_init(struct net *net, struct fib6_nh
>> *fib6_nh,
>> +
How are you ? I am a banker by profession, I do not know if we can
work together in transferring the sum of $4,500,000.USD from my bank
to your bank account. If you are interested I shall provide you with
more details.
Thanks
allenm6...@gmail.com
On Thu, Apr 04, 2019 at 10:50:05AM -0700, David Ahern wrote:
> From: David Ahern
>
> Until support is added to the offload drivers, they need to be able to
> reject routes with an IPv6 gateway. To that end add a flag to fib_info
> that indicates if any fib_nh has a v6 gateway. The flag allows the
On 04/04/2019 08:22 AM, Andrey Ignatov wrote:
> v2->v3:
> - sanity check max value for variable offset.
>
> v1->v2:
> - rely on meta = NULL to reject var_off stack access to uninit buffer.
>
> This patch set is a follow-up for discussion [1].
>
> It fixes variable offset stack access handling fo
On 04/04/2019 11:37 PM, Alexei Starovoitov wrote:
> clang started to error on invalid asm clobber usage in x86 headers
> and many bpf program samples failed to build with the message:
>
> CLANG-bpf /data/users/ast/bpf-next/samples/bpf/xdp_redirect_kern.o
> In file included from
> /data/users/a
This test is split in two, the first part checks if a report creates a
corresponding mdb entry and if traffic is properly forwarded to it, and
the second part checks if the mdb entry is deleted after a leave and
if traffic is *not* forwarded to it. Since the mcast querier is enabled
we should see s
On Fri, Apr 5, 2019 at 2:51 AM Matteo Croce wrote:
>
> On Fri, Apr 5, 2019 at 2:20 AM David Miller wrote:
> >
> > From: Matteo Croce
> > Date: Wed, 3 Apr 2019 01:11:36 +0200
> >
> > > The thunderx driver forbids to load an eBPF program if the MTU is
> > > higher than 1500 bytes, but this can be
On Thu, Apr 04, 2019 at 10:49:49AM -0700, David Ahern wrote:
> From: David Ahern
>
> Last set of three with the end goal of enabling IPv6 gateways with IPv4
> routes.
>
> This set adds fib6_nh_init and release to the IPv6 stubs, and adds neighbor
> helpers that IPv4 code invokes to resolve an IP
I know it affects 4.9, 4.14, 4.19.
I have not tested the older LTS kernels.
But any LTS kernel that previously received this commit is affected:
... commit a8444b1ccb20339774af58e40ad42296074fb484
... ipv6: defrag: drop non-last frags smaller than min mtu
On Thu, Apr 4, 2019 at 10:50 PM Greg K
On Fri, 5 Apr 2019 15:59:03 +0300
Nikolay Aleksandrov wrote:
> Hi Stephen,
> It seems that commit c7c1a1ef51aea ("bridge: colorize output and use JSON
> print library") broke
> bridge mdb's json output. The json after that commit is invalid, more below.
>
> Setup: 2 bridges - virbr0 and br-test
On Thu, Apr 4, 2019 at 1:35 AM Dan Carpenter wrote:
>
> On Wed, Apr 03, 2019 at 04:08:34PM -0700, Cong Wang wrote:
> > static void hci_le_ext_adv_report_evt(struct hci_dev *hdev, struct sk_buff
> > *skb)
> > {
> > - u8 num_reports = skb->data[0];
> > - void *ptr = &skb->data[1];
> > +
John reports:
Recent refactoring of fl_change aims to use the classifier spinlock to
avoid the need for rtnl lock. In doing so, the fl_hw_replace_filer()
function was moved to before the lock is taken. This can create problems
for drivers if duplicate filters are created (commmon in ovs tc offload
There's a significant number of reports that re-enabling ASPM causes
different issues, ranging from decreased performance to system not
booting at all. This affects only a minority of users, but the number
of affected users is big enough that we better switch off ASPM again.
This will hurt noteboo
On Wed, Apr 03, 2019 at 07:45:29PM +0200, Heiner Kallweit wrote:
> On 03.04.2019 15:14, Bjorn Helgaas wrote:
> > On Wed, Apr 03, 2019 at 07:53:40AM +0200, Heiner Kallweit wrote:
> >> On 02.04.2019 23:57, Bjorn Helgaas wrote:
> >>> On Tue, Apr 02, 2019 at 10:41:20PM +0200, Heiner Kallweit wrote:
> >
genphy_read_status() so far checks phydev->supported, not the actual
PHY capabilities. This can make a difference if the supported speeds
have been limited by of_set_phy_supported() or phy_set_max_speed().
It seems that this issue only affects the link partner advertisements
as displayed by ethtoo
On 05.04.2019 21:10, Bjorn Helgaas wrote:
> On Wed, Apr 03, 2019 at 07:45:29PM +0200, Heiner Kallweit wrote:
>> On 03.04.2019 15:14, Bjorn Helgaas wrote:
>>> On Wed, Apr 03, 2019 at 07:53:40AM +0200, Heiner Kallweit wrote:
On 02.04.2019 23:57, Bjorn Helgaas wrote:
> On Tue, Apr 02, 2019 at
I recently submitted v3 of the patch, please take a look there.
> Question: is it easy to add "if_id" to "ip link show" output?
Yes, it should show up under the detailed output for the interface (-d).
- Matt
--
Please be advised that this email may contain confidential information.
If you
On Fri, Apr 05, 2019 at 09:23:13PM +0200, Heiner Kallweit wrote:
> genphy_read_status() so far checks phydev->supported, not the actual
> PHY capabilities. This can make a difference if the supported speeds
> have been limited by of_set_phy_supported() or phy_set_max_speed().
>
> It seems that thi
On 05.04.2019 21:48, Andrew Lunn wrote:
> On Fri, Apr 05, 2019 at 09:23:13PM +0200, Heiner Kallweit wrote:
>> genphy_read_status() so far checks phydev->supported, not the actual
>> PHY capabilities. This can make a difference if the supported speeds
>> have been limited by of_set_phy_supported() o
On Thu, Apr 04, 2019 at 11:51:31AM -0700, Stanislav Fomichev wrote:
> Add new set of arguments to bpf_attr for BPF_PROG_TEST_RUN:
> * ctx_in/ctx_size_in - input context
> * ctx_out/ctx_size_out - output context
>
> The intended use case is to pass some meta data to the test runs that
> operate on
As I explained in my email, the original code is buggy if
num_reports > 1 (probably uncommon), but your code is buggy for
num_reports >= 1 (everything).
regards,
dan carpenter
From: Johannes Berg
The nested policy here should be established using the
NLA_POLICY_NESTED() macro so the length is properly
filled in.
Fixes: 81e54d08d9d8 ("cfg80211: support FTM responder configuration/statistics")
Signed-off-by: Johannes Berg
---
net/wireless/nl80211.c | 6 ++
1 file
Now that it's working, here's the first draft of the code to
expose the netlink policy to userspace.
One thing I didn't think I would do but did anyway now is to
map the NLA_* type to a new attribute, and translate it for
userspace. This may not be the most convenient, but I think we
would prefer
From: Johannes Berg
Add helpers to get the policy's signed/unsigned range
validation data.
Signed-off-by: Johannes Berg
---
include/net/netlink.h | 5 +++
lib/nlattr.c | 95 +--
2 files changed, 79 insertions(+), 21 deletions(-)
diff --git a/i
From: Johannes Berg
Use a validation type instead, so we can later expose
the NLA_* values to userspace for policy descriptions.
Signed-off-by: Johannes Berg
---
include/net/netlink.h | 15 ---
lib/nlattr.c | 16 ++--
2 files changed, 18 insertions(+), 13 delet
From: Johannes Berg
In the netlink policy, we currently have a void *validation_data
that's pointing to different things:
* a u32 value for bitfield32,
* the netlink policy for nested/nested array
* the string for NLA_REJECT
Remove the pointer and place appropriate type-safe items in the
unio
From: Johannes Berg
Using a pointer to a struct indicating the min/max values,
extend the ability to do range validation for arbitrary
values. Small values in the s16 range can be kept in the
policy directly.
Signed-off-by: Johannes Berg
---
include/net/netlink.h | 45 +
lib/n
From: Johannes Berg
Add, and use in generic netlink, helpers to dump out a netlink
policy to userspace, including all the range validation data,
nested policies etc.
This lets userspace discover what the kernel understands.
For families/commands other than generic netlink, the helpers
need to b
From: Johannes Berg
Since NLA_MSECS is really equivalent to NLA_U64, allow
it to have range validation as well.
Signed-off-by: Johannes Berg
---
include/net/netlink.h | 6 --
lib/nlattr.c | 2 ++
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/include/net/netlink.h
On Fri, Apr 05, 2019 at 10:04:22PM +0200, Heiner Kallweit wrote:
> On 05.04.2019 21:48, Andrew Lunn wrote:
> > On Fri, Apr 05, 2019 at 09:23:13PM +0200, Heiner Kallweit wrote:
> >> genphy_read_status() so far checks phydev->supported, not the actual
> >> PHY capabilities. This can make a difference
On 05.04.2019 22:27, Andrew Lunn wrote:
> On Fri, Apr 05, 2019 at 10:04:22PM +0200, Heiner Kallweit wrote:
>> On 05.04.2019 21:48, Andrew Lunn wrote:
>>> On Fri, Apr 05, 2019 at 09:23:13PM +0200, Heiner Kallweit wrote:
genphy_read_status() so far checks phydev->supported, not the actual
P
On Wed, Apr 3, 2019 at 9:52 PM David Miller wrote:
>
> From: Saeed Mahameed
> Date: Tue, 2 Apr 2019 16:03:42 -0700
>
> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> > b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> > index 7c1ea0a17024..d3a507be72d4 100644
> > --- a/drive
> Right. BMSR_ESTATEN should not be set on a Fast PHY. Handling of this
> case didn't change.
>
> > A Fast MAC connected to a Giga PHY. The MAC driver will of used
> > phy_set_max_speed() to indicate its limits. In that case, MII_STAT1000
> > does exist and we should report what the peer is advert
> On 26 Mar 2019, at 18:44, Edward Cree wrote:
>
> On 26/03/2019 18:05, Jiong Wang wrote:
>> eBPF ISA specification requires high 32-bit cleared when low 32-bit
>> sub-register is written. This applies to destination register of ALU32 etc.
>> JIT back-ends must guarantee this semantic when doin
On Thu, Apr 4, 2019 at 4:46 AM Gal Pressman wrote:
>
> On 03-Apr-19 02:03, Saeed Mahameed wrote:
> > From: Tariq Toukan
> >
> > Soften the memory barrier call of mb() by a sufficient wmb() in the
> > consumer index update of the event queues.
> >
> > Signed-off-by: Tariq Toukan
> > Signed-off-by
On 05.04.2019 22:43, Andrew Lunn wrote:
>> Right. BMSR_ESTATEN should not be set on a Fast PHY. Handling of this
>> case didn't change.
>>
>>> A Fast MAC connected to a Giga PHY. The MAC driver will of used
>>> phy_set_max_speed() to indicate its limits. In that case, MII_STAT1000
>>> does exist an
This adds libbpf support for BTF Var and DataSec kinds. Main point
here is that libbpf needs to do some preparatory work before the
whole BTF object can be loaded into the kernel, that is, fixing up
of DataSec size taken from the ELF section size and non-static
variable offset which needs to be tak
This work adds kernel-side verification, logging and seq_show dumping
of BTF Var and DataSec kinds which are emitted with latest LLVM. The
following constraints apply:
BTF Var must have:
- Its kind_flag is 0
- Its vlen is 0
- Must point to a valid type
- Type must not resolve to a forward type
-
Pull in latest changes from both headers, so we can make use of
them in libbpf.
Signed-off-by: Daniel Borkmann
---
tools/include/uapi/linux/bpf.h | 24 ++--
tools/include/uapi/linux/btf.h | 32
2 files changed, 50 insertions(+), 6 deletions(-)
This work adds two new map creation flags BPF_F_RDONLY_PROG
and BPF_F_WRONLY_PROG in order to allow for read-only or
write-only BPF maps from a BPF program side.
Today we have BPF_F_RDONLY and BPF_F_WRONLY, but this only
applies to system call side, meaning the BPF program has full
read/write acce
From: Joe Stringer
Adjust the code for relocations slightly with no functional changes,
so that upcoming patches that will introduce support for relocations
into the .data, .rodata and .bss sections can be added independent
of these changes.
Signed-off-by: Joe Stringer
Signed-off-by: Daniel Bor
This series is a major rework of previously submitted libbpf
patches [0] in order to add global data support for BPF. The
kernel has been extended to add proper infrastructure that allows
for full .bss/.data/.rodata sections on BPF loader side based
upon feedback from LPC discussions [1]. Latter su
Both BPF_F_WRONLY / BPF_F_RDONLY flags are tied to the map file
descriptor, but not to the map object itself! Meaning, at map
creation time BPF_F_RDONLY can be set to make the map read-only
from syscall side, but this holds only for the returned fd, so
any other fd either retrieved via bpf file sys
Trivial addition to allow '.' aside from '_' as "special" characters
in the object name. Used to allow for substrings in maps from loader
side such as ".bss", ".data", ".rodata", but could also be useful for
other purposes.
Signed-off-by: Daniel Borkmann
Acked-by: Andrii Nakryiko
---
kernel/bpf
From: Joe Stringer
Add tests for libbpf relocation of static variable references
into the .data, .rodata and .bss sections of the ELF, also add
read-only test for .rodata. All passing:
# ./test_progs
[...]
test_global_data:PASS:load program 0 nsec
test_global_data:PASS:pass global data r
This patch adds a new BPF_MAP_FREEZE command which allows to
"freeze" the map globally as read-only / immutable from syscall
side.
Map permission handling has been refactored into map_get_sys_perms()
and drops FMODE_CAN_WRITE in case of locked map. Main use case is
to allow for setting up .rodata
Given we'll be reusing BPF array maps for global data/bss/rodata
sections, we need a way to associate BTF DataSec type as its map
value type. In usual cases we have this ugly BPF_ANNOTATE_KV_PAIR()
macro hack e.g. via 38d5d3b3d5db ("bpf: Introduce BPF_ANNOTATE_KV_PAIR")
to get initial map to type a
Extend test_verifier with various test cases around the two kernel
extensions, that is, {rd,wr}only map support as well as direct map
value access. All passing, one skipped due to xskmap not present
on test machine:
# ./test_verifier
[...]
#920/p XDP pkt read, pkt_data <= pkt_meta', bad acce
Add the ability to bpftool to handle BTF Var and DataSec kinds
in order to dump them out of btf_dumper_type(). The value has a
single object with the section name, which itself holds an array
of variables it dumps. A single variable is an object by itself
printed along with its name. From there fur
This generic extension to BPF maps allows for directly loading an
address residing inside a BPF map value as a single BPF ldimm64
instruction!
The idea is similar to what BPF_PSEUDO_MAP_FD does today, which
is a special src_reg flag for ldimm64 instruction that indicates
that inside the first part
This adds the BTF specification and UAPI bits for supporting BTF Var
and DataSec kinds. This is following LLVM upstream commit ac4082b77e07
("[BPF] Add BTF Var and DataSec Support") which has been merged recently.
Var itself is for describing a global variable and DataSec to describe
ELF sections e
This work adds BPF loader support for global data sections
to libbpf. This allows to write BPF programs in more natural
C-like way by being able to define global variables and const
data.
Back at LPC 2018 [0] we presented a first prototype which
implemented support for global data sections by exte
Extend test_btf with various positive and negative tests around
BTF verification of kind Var and DataSec. All passing as well:
# ./test_btf
[...]
BTF raw test[4] (global data test #1): OK
BTF raw test[5] (global data test #2): OK
BTF raw test[6] (global data test #3): OK
BTF raw test[7
Tested-by: Antony Antony
On Fri, Apr 05, 2019 at 03:46:02PM -0400, Matt Ellison wrote:
> I recently submitted v3 of the patch, please take a look there.
great. I am testing v3 now.
One comment. It seems to accept -ve value for if_id and quietly set to 0
may be throw an error for -ve values? o
On 4/5/19 1:51 PM, Heiner Kallweit wrote:
> On 05.04.2019 22:43, Andrew Lunn wrote:
>>> Right. BMSR_ESTATEN should not be set on a Fast PHY. Handling of this
>>> case didn't change.
>>>
A Fast MAC connected to a Giga PHY. The MAC driver will of used
phy_set_max_speed() to indicate its lim
On 05.04.2019 23:11, Florian Fainelli wrote:
> On 4/5/19 1:51 PM, Heiner Kallweit wrote:
>> On 05.04.2019 22:43, Andrew Lunn wrote:
Right. BMSR_ESTATEN should not be set on a Fast PHY. Handling of this
case didn't change.
> A Fast MAC connected to a Giga PHY. The MAC driver will
> One comment. It seems to accept -ve value for if_id and quietly set
> to 0 may be throw an error for -ve values? or take it as u32?
> in my opinion setting to 0 is confusing
Ah good catch. I'll add the check in my version.
--
Please be advised that this email may contain confidential info
From: Max Gurtovoy
Delete mutex_init call of a lock that's initialized in inner function.
Fixes: eca8cc389535 ("net/mlx5: E-Switch, Refactor offloads flow steering
init/cleanup")
Signed-off-by: Max Gurtovoy
Reviewed-by: Roi Dayan
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellan
From: Eli Britstein
Offload TC rule on a VLAN device by matching the VLAN properties
of the VLAN device and emulating vlan pop actions.
Signed-off-by: Eli Britstein
Reviewed-by: Roi Dayan
Signed-off-by: Saeed Mahameed
---
.../net/ethernet/mellanox/mlx5/core/en_rep.c | 3 +-
.../net/etherne
Hi Dave,
This series adds misc updates to mlx5 driver.
For more information please see tag log below.
Please pull and let me know if there is any problem.
v1->v2:
remove inline keywords from static functions in c files.
Please note that the series starts with a merge of mlx5-next branch,
to
From: Eli Britstein
Upon redirection to an uplink VLAN device, emulate vlan push actions
according to the VLAN properties of the VLAN device and redirect to
the uplink.
Signed-off-by: Eli Britstein
Reviewed-by: Roi Dayan
Signed-off-by: Saeed Mahameed
---
.../net/ethernet/mellanox/mlx5/core/e
From: Eli Britstein
The headers criteria and value pointers may be either of the inner
packet, if a tunnel exists, or of the outer. Simplify the code by using
helper functions to retrieve them.
Signed-off-by: Eli Britstein
Reviewed-by: Roi Dayan
Signed-off-by: Saeed Mahameed
---
.../net/ethe
From: Eli Britstein
Changing the prio field of the VLAN is not supported. With
commit 37410902874c ("net/mlx5e: Support VLAN modify action") zero
value indicated "no-change". Allow the vid rewrite if the prio match
is the same as the prio set value.
Fixes: 37410902874c ("net/mlx5e: Support VLAN
From: Tonghao Zhang
This patch is a little improvement. Simplify the parse_tc_fdb_actions().
Signed-off-by: Tonghao Zhang
Reviewed-by: Roi Dayan
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -
From: Tonghao Zhang
* Now the encapsulation is not supported for mlx5 VFs. When we try to
offload that action, the -EINVAL is returned, but not -EOPNOTSUPP.
This patch changes the returned value and ignore to confuse user.
The command is shown as below [1].
* When max modify header action is zer
From: Tonghao Zhang
This patch deletes unnecessary setting of the esw_attr->parse_attr
to parse_attr in parse_tc_fdb_actions() because it is already done
by the mlx5e_flow_esw_attr_init() function.
Signed-off-by: Tonghao Zhang
Reviewed-by: Roi Dayan
Signed-off-by: Saeed Mahameed
---
drivers/
From: Aya Levin
Handle event of power state change in the PCIE slot. When the event
occurs, check if query power state and PCI power fields is supported. If
so, read these fields from MPEIN (management PCIE info) register and
issue a corresponding message.
Signed-off-by: Aya Levin
Signed-off-by
From: Tonghao Zhang
If we try to offload decapsulation actions to VFs hw, we get the log [1].
It's not friendly, because the kind of net device is null, and we don't
know what '0' means.
[1] "mlx5_core :05:01.2 vf_0: decapsulation offload is not supported for
net device (0)"
Signed-off-by
From: Eli Britstein
Rewrite of the packet in the VLAN offset may corrupt the packet if it's
not VLAN tagged. Deny the rewrite in this case.
Fixes: 37410902874c ("net/mlx5e: Support VLAN modify action")
Signed-off-by: Eli Britstein
Reviewed-by: Roi Dayan
Signed-off-by: Saeed Mahameed
---
driv
From: Tariq Toukan
Expose a new helper that wraps the logic for setting the
netdevice's MTU boundaries.
Use it for the different components (Eth, rep, IPoIB).
Set the netdevice min MTU to ETH_MIN_MTU, and the max according
to both the FW capability and the kernel definition.
Signed-off-by: Tari
From: Eli Britstein
If we have a match for the same value of a rewrite field, there is no
point for the rewrite. In order to save rewrite actions, and avoid
entirely rewrite actions (if all rewrites are the same), ignore such
rewrite fields.
Signed-off-by: Eli Britstein
Reviewed-by: Roi Dayan
From: Tariq Toukan
The LRO WQE size is a constant, obsolete the parameter field
that holds it.
Signed-off-by: Tariq Toukan
Reviewed-by: Maxim Mikityanskiy
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/en.h | 1 -
drivers/net/ethernet/mellanox/mlx5/core/en_mai
From: Tariq Toukan
Soften the memory barrier call of mb() by a sufficient wmb() in the
consumer index update of the event queues.
Signed-off-by: Tariq Toukan
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/eq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
d
On 05.04.2019 23:16, Heiner Kallweit wrote:
> On 05.04.2019 23:11, Florian Fainelli wrote:
>> On 4/5/19 1:51 PM, Heiner Kallweit wrote:
>>> On 05.04.2019 22:43, Andrew Lunn wrote:
> Right. BMSR_ESTATEN should not be set on a Fast PHY. Handling of this
> case didn't change.
>
>> A Fa
On 4/5/19 2:20 PM, Heiner Kallweit wrote:
> On 05.04.2019 23:16, Heiner Kallweit wrote:
>> On 05.04.2019 23:11, Florian Fainelli wrote:
>>> On 4/5/19 1:51 PM, Heiner Kallweit wrote:
On 05.04.2019 22:43, Andrew Lunn wrote:
>> Right. BMSR_ESTATEN should not be set on a Fast PHY. Handling of
1 - 100 of 135 matches
Mail list logo
