> Right. BMSR_ESTATEN should not be set on a Fast PHY. Handling of this
> case didn't change.
> 
> > A Fast MAC connected to a Giga PHY. The MAC driver will of used
> > phy_set_max_speed() to indicate its limits. In that case, MII_STAT1000
> > does exist and we should report what the peer is advertising.
> > 
> That's what we're doing now with this patch.

Hi Heiner

What i don't get is why we need to do anything based on the MAC. All
we need to do is look at BMSR_ESTATEN, and from that decided if we
should look at MII_STAT1000 or not. When reporting what the peer can
do, we should not care what the local MAC can do.

    Andrew

Reply via email to