Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-04 Thread Jiri Pirko
Sat, Mar 02, 2019 at 08:48:47PM CET, jakub.kicin...@netronome.com wrote: >On Sat, 2 Mar 2019 10:41:16 +0100, Jiri Pirko wrote: >> Fri, Mar 01, 2019 at 07:04:50PM CET, jakub.kicin...@netronome.com wrote: >> >PCI endpoint corresponds to a PCI device, but such device >> >can have one more more logical

[PATCH 4.14 51/52] MIPS: eBPF: Fix icache flush end address

2019-03-04 Thread Greg Kroah-Hartman
4.14-stable review patch. If anyone has any objections, please let me know. -- From: Paul Burton commit d1a2930d8a992fb6ac2529449f81a0056e1b98d1 upstream. The MIPS eBPF JIT calls flush_icache_range() in order to ensure the icache observes the code that we just wrote. Unfortuna

[PATCH net v2 1/2] net/mlx5: Avoid panic when setting vport mac, getting vport config

2019-03-04 Thread xiangxia . m . yue
From: Tonghao Zhang If we try to set VFs mac address on a VF (not PF) net device, the kernel will be crash. The commands are show as below: $ echo 2 > /sys/class/net/$MLX_PF0/device/sriov_numvfs $ ip link set $MLX_VF0 vf 0 mac 00:11:22:33:44:00 [exception RIP: mlx5_eswitch_set_vport_mac+41] [ff

[PATCH 4.19 77/78] MIPS: eBPF: Fix icache flush end address

2019-03-04 Thread Greg Kroah-Hartman
4.19-stable review patch. If anyone has any objections, please let me know. -- From: Paul Burton commit d1a2930d8a992fb6ac2529449f81a0056e1b98d1 upstream. The MIPS eBPF JIT calls flush_icache_range() in order to ensure the icache observes the code that we just wrote. Unfortuna

[PATCH 4.20 87/88] MIPS: eBPF: Fix icache flush end address

2019-03-04 Thread Greg Kroah-Hartman
4.20-stable review patch. If anyone has any objections, please let me know. -- From: Paul Burton commit d1a2930d8a992fb6ac2529449f81a0056e1b98d1 upstream. The MIPS eBPF JIT calls flush_icache_range() in order to ensure the icache observes the code that we just wrote. Unfortuna

Re: [PATCH net] net: vrf: fix remove vrf module error when there's no reference

2019-03-04 Thread kbuild test robot
Hi Miaohe, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net/master] url: https://github.com/0day-ci/linux/commits/linmiaohe/net-vrf-fix-remove-vrf-module-error-when-there-s-no-reference/20190303-082433 config: x86_64-randconfig-u0-03041013 (attached as .

RE: [net-next 02/12] i40e: Implement DDP support in i40e driver

2019-03-04 Thread Loktionov, Aleksandr
Good day dear ALL Yes this link is 90% about DDP in DPDK usage, but other 10% about DDP. IMHO we need to provide a link so interested users can find what DDP is. Alex ND ITP Linux 40G base driver TL -Original Message- From: Jakub Kicinski [mailto:jakub.kicin...@netronome.com] Sent:

How does the broadcom NIC distribute incoming traffic between the receive queues ?

2019-03-04 Thread jianchao.wang
Dear all Would anyone please help to explain, how does the broadcom NIC distribute incoming traffic between the receive queues ? hash based on dst,src,port ? Thanks in advance Jianchao

[PATCH net v2 2/2] net/mlx5: Avoid panic when setting vport rate

2019-03-04 Thread xiangxia . m . yue
From: Tonghao Zhang If we try to set VFs rate on a VF (not PF) net device, the kernel will be crash. The commands are show as below: $ echo 2 > /sys/class/net/$MLX_PF0/device/sriov_numvfs $ ip link set $MLX_VF0 vf 0 max_tx_rate 2 min_tx_rate 1 If not applied the first patch ("net/mlx5: Avoid pa

Re: [PATCH 1/2] net/mlx5: Avoid panic when setting vport mac, getting vport config

2019-03-04 Thread Tonghao Zhang
On Mon, Mar 4, 2019 at 3:06 PM Roi Dayan wrote: > > > > On 04/03/2019 03:04, Tonghao Zhang wrote: > > On Sun, Mar 3, 2019 at 8:42 PM Roi Dayan wrote: > >> > >> > >> > >> On 03/03/2019 11:56, xiangxia.m@gmail.com wrote: > >>> From: Tonghao Zhang > >>> > >>> If we try to set VFs mac address on

Re: [PATCH] net: xfrm: Add '_rcu' tag for rcu protected pointer in netns_xfrm

2019-03-04 Thread Sergei Shtylyov
Hello! On 04.03.2019 8:46, Su Yanjun wrote: For rcu protected pointers, we'd bettter add '__rcu' for them. 2 t's were enough. :-) No functional change. Signed-off-by: Su Yanjun [...] MBR, Sergei

[PATCH v1] mellanox: Switch to bitmap_zalloc()

2019-03-04 Thread Andy Shevchenko
Switch to bitmap_zalloc() to show clearly what we are allocating. Besides that it returns pointer of bitmap type instead of opaque void *. Signed-off-by: Andy Shevchenko --- drivers/net/ethernet/mellanox/mlx4/alloc.c | 5 ++--- drivers/net/ethernet/mellanox/mlx5/core/alloc.c| 9 +++

Re: [PATCH v3 bpf-next 1/2] bpf: Fix bpf_tcp_sock and bpf_sk_fullsock issue related to bpf_sk_release

2019-03-04 Thread Daniel Borkmann
On 03/02/2019 09:21 PM, Martin Lau wrote: > On Sat, Mar 02, 2019 at 10:03:03AM -0800, Alexei Starovoitov wrote: >> On Sat, Mar 02, 2019 at 08:10:10AM -0800, Martin KaFai Lau wrote: >>> Lorenz Bauer [thanks!] reported that a ptr returned by bpf_tcp_sock(sk) >>> can still be accessed after bpf_sk_rel

Re: [PATCH] xfrm: policy: Fix out-of-bound array accesses in __xfrm_policy_unlink

2019-03-04 Thread Steffen Klassert
On Thu, Feb 28, 2019 at 03:52:27PM +0800, Herbert Xu wrote: > On Thu, Feb 28, 2019 at 03:18:59PM +0800, Yue Haibing wrote: > > From: YueHaibing > > > > UBSAN report this: > > > > UBSAN: Undefined behaviour in net/xfrm/xfrm_policy.c:1289:24 > > index 6 is out of range for type 'unsigned int [6]'

bpf-next is CLOSED

2019-03-04 Thread Daniel Borkmann
>From this point onwards please only submit bug fixes targeted to bpf tree given the merge window. We will send out the last bpf-next PR to David today. Thanks everyone, Daniel

[PATCH v1] net-sysfs: Switch to bitmap_zalloc()

2019-03-04 Thread Andy Shevchenko
Switch to bitmap_zalloc() to show clearly what we are allocating. Besides that it returns pointer of bitmap type instead of opaque void *. Signed-off-by: Andy Shevchenko --- net/core/net-sysfs.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/net/core/net-sysfs.c

Re: [PATCH 3/3] net: dsa: Add Vitesse VSC73xx DSA router driver

2019-03-04 Thread Linus Walleij
Hi Vladimir, On Sun, Mar 3, 2019 at 1:08 PM Vladimir Oltean wrote: > I am writing a DSA driver for a switch that doesn't support port separation > through switch tagging, and came across this discussion. > Would you mind to share some thoughts on how port separation with > DSA_TAG_PROTO_NONE wou

[PATCH UEK5-{Master,U2,U1},UEK4-QU7] rds: Add per peer RDS socket send buffer

2019-03-04 Thread Ka-Cheong Poon
Currently, an RDS socket's send buffer is shared by all the peers this socket communicates with. When one or more peers are slow to receive, their unacknowledged data can consume a large portion of the socket's buffer. This will affect the communication with other peers of the socket. To resolve

Re: [PATCH UEK5-{Master,U2,U1},UEK4-QU7] rds: Add per peer RDS socket send buffer

2019-03-04 Thread Ka-Cheong Poon
Please ignore this review request. It was sent to the wrong alias. I'm sorry about this. On 3/4/19 6:32 PM, Ka-Cheong Poon wrote: Currently, an RDS socket's send buffer is shared by all the peers this socket communicates with. When one or more peers are slow to receive, their unacknowledged

Re: [PATCH net-next v2 3/3] net: phy: marvell10g: set the PHY in low power by default

2019-03-04 Thread Antoine Tenart
Hi Florian, On Fri, Mar 01, 2019 at 07:08:56PM -0800, Florian Fainelli wrote: > On 3/1/2019 7:07 AM, Antoine Tenart wrote: > > On Fri, Mar 01, 2019 at 03:19:53PM +0100, Andrew Lunn wrote: > >> On Fri, Mar 01, 2019 at 12:00:47PM +0100, Antoine Tenart wrote: > >>> When the Marvell 10G PHYs are set o

Re: [PATCH] tools: testing: selftests: Remove duplicate headers

2019-03-04 Thread Souptick Joarder
On Tue, Feb 26, 2019 at 10:59 AM Souptick Joarder wrote: > > On Tue, Feb 26, 2019 at 7:18 AM Michael Ellerman wrote: > > > > Souptick Joarder writes: > > > Remove duplicate headers which are included twice. > > > > > > Signed-off-by: Sabyasachi Gupta > > > Signed-off-by: Souptick Joarder > > >

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-04 Thread Jiri Pirko
Fri, Mar 01, 2019 at 07:04:50PM CET, jakub.kicin...@netronome.com wrote: >PCI endpoint corresponds to a PCI device, but such device >can have one more more logical device ports associated with it. >We need a way to distinguish those. Add a PCI subport in the >dumps and print the info in phys_port_n

pull-request: bpf-next 2019-03-04

2019-03-04 Thread Daniel Borkmann
Hi David, The following pull-request contains BPF updates for your *net-next* tree. The main changes are: 1) Add AF_XDP support to libbpf. Rationale is to facilitate writing AF_XDP applications by offering higher-level APIs that hide many of the details of the AF_XDP uapi. Sample programs

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-04 Thread Jiri Pirko
Sat, Mar 02, 2019 at 08:48:47PM CET, jakub.kicin...@netronome.com wrote: >On Sat, 2 Mar 2019 10:41:16 +0100, Jiri Pirko wrote: >> Fri, Mar 01, 2019 at 07:04:50PM CET, jakub.kicin...@netronome.com wrote: >> >PCI endpoint corresponds to a PCI device, but such device >> >can have one more more logical

Re: [RFC v2 5/6] mlx4: report errors through extack

2019-03-04 Thread Tariq Toukan
On 2/28/2019 11:54 PM, Stephen Hemminger wrote: > XDP errors should be reported via extack (back to command) > rather than on console. > > Signed-off-by: Stephen Hemminger > --- > drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 14 +- > 1 file changed, 9 insertions(+), 5 deletio

Re: [PATCH net-next] cxgb4: Prefix adapter flags with CXGB4

2019-03-04 Thread Arjun Vynipadath
On Friday, March 03/01/19, 2019 at 23:17:47 -0800, David Miller wrote: > From: Arjun Vynipadath > Date: Fri, 1 Mar 2019 15:40:24 +0530 > > > - FULL_INIT_DONE = (1 << 0), > ... > > + CXGB4_FULL_INIT_DONE= (1 << 0), > > Looks like you missed some of this conversion. > > Oh w

Re: [PATCH net-next v3 2/3] xdp: Always use a devmap for XDP_REDIRECT to a device

2019-03-04 Thread Toke Høiland-Jørgensen
Hi Jakub Thanks for the review! A few comments/questions below. > On Fri, 01 Mar 2019 15:12:30 +0100, Toke Høiland-Jørgensen wrote: >> An XDP program can redirect packets between interfaces using either the >> xdp_redirect() helper or the xdp_redirect_map() helper. Apart from the >> flexibility o

Re: [PATCH v1] mellanox: Switch to bitmap_zalloc()

2019-03-04 Thread Tariq Toukan
On 3/4/2019 10:57 AM, Andy Shevchenko wrote: > Switch to bitmap_zalloc() to show clearly what we are allocating. > Besides that it returns pointer of bitmap type instead of opaque void *. > > Signed-off-by: Andy Shevchenko > --- > drivers/net/ethernet/mellanox/mlx4/alloc.c | 5 ++---

Re: [PATCH v1] mellanox: Switch to bitmap_zalloc()

2019-03-04 Thread Jiri Pirko
Mon, Mar 04, 2019 at 09:57:00AM CET, andriy.shevche...@linux.intel.com wrote: >Switch to bitmap_zalloc() to show clearly what we are allocating. >Besides that it returns pointer of bitmap type instead of opaque void *. > >Signed-off-by: Andy Shevchenko Acked-by: Jiri Pirko Hoever, net-next is c

Re: [PATCH net] sctp: call iov_iter_revert() after sending ABORT

2019-03-04 Thread Neil Horman
On Sun, Mar 03, 2019 at 04:50:26PM +0800, Xin Long wrote: > The user msg is also copied to the abort packet when doing SCTP_ABORT in > sctp_sendmsg_check_sflags(). When SCTP_SENDALL is set, iov_iter_revert() > should have been called for sending abort on the next asoc with copying > this msg. Other

[PATCH net-next v2] cxgb4/chtls: Prefix adapter flags with CXGB4

2019-03-04 Thread Arjun Vynipadath
Some of these macros were conflicting with global namespace, hence prefixing them with CXGB4. Signed-off-by: Arjun Vynipadath Signed-off-by: Vishal Kulkarni --- v2: - Fixed build issues in chtls driver --- drivers/crypto/chelsio/chtls/chtls_cm.c| 2 +- drivers/net/ethernet/chelsio

Re: [PATCH 3/3] net: dsa: Add Vitesse VSC73xx DSA router driver

2019-03-04 Thread Vladimir Oltean
On Mon, 4 Mar 2019 at 11:52, Linus Walleij wrote: > > Hi Vladimir, Hi Linus, > > On Sun, Mar 3, 2019 at 1:08 PM Vladimir Oltean wrote: > > > I am writing a DSA driver for a switch that doesn't support port separation > > through switch tagging, and came across this discussion. > > Would you min

Re: [PATCH 3/3] net: dsa: Add Vitesse VSC73xx DSA router driver

2019-03-04 Thread Linus Walleij
Hi Vladimir, On Mon, Mar 4, 2019 at 1:14 PM Vladimir Oltean wrote: > I may be in error, but I don't think we have the same understanding of what > VLAN filtering is. As far as I understand, no VLAN filtering means that > hardware is required to not parse, push or pop VLAN tags in whatever frames

Re: [PATCH v2 2/2] dpaa2-eth: add XDP_REDIRECT support

2019-03-04 Thread Jesper Dangaard Brouer
On Fri, 1 Mar 2019 17:47:24 + Ioana Ciornei wrote: > +static int dpaa2_eth_xdp_xmit_frame(struct net_device *net_dev, > + struct xdp_frame *xdpf) > +{ > + struct dpaa2_eth_priv *priv = netdev_priv(net_dev); > + struct device *dev = net_dev->dev.parent;

Re: BUG: unable to handle kernel paging request in bpf_prog_kallsyms_add

2019-03-04 Thread Daniel Borkmann
On 03/04/2019 08:45 AM, Dmitry Vyukov wrote: > On Mon, Sep 10, 2018 at 10:31 AM syzbot > wrote: >> >> Hello, >> >> syzbot found the following crash on: >> >> HEAD commit:f6f3bac08ff9 tools/bpf: bpftool: add net support >> git tree: bpf-next >> console output: https://syzkaller.appspot.co

[PATCH -next] net: dsa: mv88e6xxx: Fix build warning when CONFIG_NET_DSA_LEGACY is n

2019-03-04 Thread Shaokun Zhang
When CONFIG_NET_DSA_LEGACY is n, there is a GCC bulid warning: drivers/net/dsa/mv88e6xxx/chip.c:4623:13: warning: ???mv88e6xxx_ports_cmode_init??? defined but not used [-Wunused-function] static void mv88e6xxx_ports_cmode_init(struct mv88e6xxx_chip *chip) Let's fix it. Fixes: ed8fe20205ac ("net:

Re: [PATCH net-next v3 1/3] xdp: Refactor devmap code in preparation for subsequent additions

2019-03-04 Thread Toke Høiland-Jørgensen
Jakub Kicinski writes: > On Fri, 01 Mar 2019 15:12:30 +0100, Toke Høiland-Jørgensen wrote: >> The subsequent commits introducing default maps and a hash-based ifindex >> devmap require a bit of refactoring of the devmap code. Perform this first >> so the subsequent commits become easier to read.

question about memory leak in ip_mc_del1_src

2019-03-04 Thread maowenan
Hi, There is one report shows that memory in ip_mc_msfilter. details as below: 00:13:12 executing program 0: r0 = socket$inet_udp(0x2, 0x2, 0x0) setsockopt$inet_mreqn(r0, 0x0, 0x23, &(0x7f000400)={@multicast2, @remote}, 0xc) getsockopt$inet_udp_int(r0, 0x11, 0x66, &(0x7f00), &(0x7f00

Re: [PATCH] tcp: detect use sendpage for slab-based objects

2019-03-04 Thread Vasily Averin
On 2/21/19 7:00 PM, Eric Dumazet wrote: > On Thu, Feb 21, 2019 at 7:30 AM Vasily Averin wrote: >> >> There was few incidents when XFS over network block device generates >> IO requests with slab-based metadata. If these requests are processed >> via sendpage path tcp_sendpage() calls skb_can_coale

RE: [PATCH v2 2/2] dpaa2-eth: add XDP_REDIRECT support

2019-03-04 Thread Ioana Ciocoi Radulescu
> -Original Message- > From: Jesper Dangaard Brouer > Sent: Monday, March 4, 2019 2:30 PM > To: Ioana Ciornei > Cc: netdev@vger.kernel.org; da...@davemloft.net; Ioana Ciocoi Radulescu > ; ilias.apalodi...@linaro.org; > t...@redhat.com; bro...@redhat.com > Subject: Re: [PATCH v2 2/2] dpaa2

[RFC PATCH] net: dsa: mv88e6xxx: support single chip sw_addr offset

2019-03-04 Thread Rasmus Villemoes
From: Per Noergaard Christensen The 88e6250 does not support multi-chip addressing. However, one can still have two of them on the same mdio bus, since the device only uses 16 of the 32 possible addresses, either addresses 0x00-0x0F or 0x10-0x1F depending on the ADDR4 pin at reset [since ADDR4 is

Re: [PATCH] net: dsa: read mac address from DT for slave device

2019-03-04 Thread Andrew Lunn
> The following example shows three switches on three MDIO busses, > @@ -99,6 +103,7 @@ linked into one DSA cluster. > port@1 { > reg = <1>; > label = "lan1"; > + local-mac-address = [

Re: [PATCH -next] net: dsa: mv88e6xxx: Fix build warning when CONFIG_NET_DSA_LEGACY is n

2019-03-04 Thread Andrew Lunn
On Mon, Mar 04, 2019 at 08:43:01PM +0800, Shaokun Zhang wrote: > When CONFIG_NET_DSA_LEGACY is n, there is a GCC bulid warning: > drivers/net/dsa/mv88e6xxx/chip.c:4623:13: warning: > ‘mv88e6xxx_ports_cmode_init’ defined but not used [-Wunused-function] > static void mv88e6xxx_ports_cmode_init(stru

Re: [RFC PATCH] net: dsa: mv88e6xxx: support single chip sw_addr offset

2019-03-04 Thread Andrew Lunn
On Mon, Mar 04, 2019 at 12:59:42PM +, Rasmus Villemoes wrote: > From: Per Noergaard Christensen > > The 88e6250 does not support multi-chip addressing. However, one can > still have two of them on the same mdio bus, since the device only > uses 16 of the 32 possible addresses, either addresse

Re: [PATCH v5 perf,bpf 12/15] perf, bpf: enable annotation of bpf program

2019-03-04 Thread Jiri Olsa
On Wed, Feb 27, 2019 at 09:06:40PM -0800, Song Liu wrote: SNIP > +#ifdef DISASM_FOUR_ARGS_SIGNATURE > + disassemble = disassembler(info.arch, > +bfd_big_endian(bfdf), > +info.mach, > +bfdf); > +#el

Re: [PATCH v5 perf,bpf 07/15] perf, bpf: save bpf_prog_info information as headers to perf.data

2019-03-04 Thread Jiri Olsa
On Wed, Feb 27, 2019 at 09:06:35PM -0800, Song Liu wrote: SNIP > +static int process_bpf_prog_info(struct feat_fd *ff, > + void *data __maybe_unused) > +{ > + struct bpf_prog_info_linear *info_linear; > + struct bpf_prog_info_node *info_node; > + struct pe

Re: [PATCH v5 perf,bpf 09/15] perf, bpf: save btf information as headers to perf.data

2019-03-04 Thread Jiri Olsa
On Wed, Feb 27, 2019 at 09:06:37PM -0800, Song Liu wrote: SNIP > > +static int process_bpf_btf(struct feat_fd *ff, void *data __maybe_unused) > +{ > + struct perf_env *env = &ff->ph->env; > + u32 count, i; > + > + if (do_read_u32(ff, &count)) > + return -1; > + > + d

Re: [PATCH v5 perf,bpf 08/15] perf, bpf: save btf in a rbtree in perf_env

2019-03-04 Thread Jiri Olsa
On Wed, Feb 27, 2019 at 09:06:36PM -0800, Song Liu wrote: > btf contains information necessary to annotate bpf programs. This patch > saves btf for bpf programs loaded in the system. > > Signed-off-by: Song Liu > --- > tools/perf/util/bpf-event.c | 24 ++ > tools/perf/util/bpf-event.

Re: [PATCH v5 perf,bpf 07/15] perf, bpf: save bpf_prog_info information as headers to perf.data

2019-03-04 Thread Jiri Olsa
On Wed, Feb 27, 2019 at 09:06:35PM -0800, Song Liu wrote: SNIP > +static int process_bpf_prog_info(struct feat_fd *ff, > + void *data __maybe_unused) > +{ > + struct bpf_prog_info_linear *info_linear; > + struct bpf_prog_info_node *info_node; > + struct pe

Re: [PATCH v5 perf,bpf 07/15] perf, bpf: save bpf_prog_info information as headers to perf.data

2019-03-04 Thread Jiri Olsa
On Wed, Feb 27, 2019 at 09:06:35PM -0800, Song Liu wrote: > This patch enables perf-record to save bpf_prog_info information as > headers to perf.data. A new header type HEADER_BPF_PROG_INFO is > introduced for this data. > > Signed-off-by: Song Liu > --- > tools/perf/util/header.c | 143 +++

Re: [PATCH 3/3] net: dsa: Add Vitesse VSC73xx DSA router driver

2019-03-04 Thread Andrew Lunn
> I do see that neither vitesse-vsc73xx nor rtl8366 do implement the bridge > membership callbacks, and as I don't happen to know nearly enough about DSA, I > wonder at what moment in time does forwarding get activated between ports. If those callbacks are not implement, it means the software brid

Re: [PATCH v5 perf,bpf 07/15] perf, bpf: save bpf_prog_info information as headers to perf.data

2019-03-04 Thread Jiri Olsa
On Wed, Feb 27, 2019 at 09:06:35PM -0800, Song Liu wrote: > This patch enables perf-record to save bpf_prog_info information as > headers to perf.data. A new header type HEADER_BPF_PROG_INFO is > introduced for this data. > > Signed-off-by: Song Liu > --- > tools/perf/util/header.c | 143 +++

Re: [PATCH v5 perf,bpf 13/15] perf, bpf: process PERF_BPF_EVENT_PROG_LOAD for annotation

2019-03-04 Thread Jiri Olsa
On Wed, Feb 27, 2019 at 09:06:41PM -0800, Song Liu wrote: > This patch adds processing of PERF_BPF_EVENT_PROG_LOAD, which sets proper > DSO type/id/etc of memory regions mapped to BPF programs to > DSO_BINARY_TYPE__BPF_PROG_INFO > > Signed-off-by: Song Liu > --- > tools/perf/util/bpf-event.c | 5

Re: [PATCH v5 perf,bpf 12/15] perf, bpf: enable annotation of bpf program

2019-03-04 Thread Jiri Olsa
On Wed, Feb 27, 2019 at 09:06:40PM -0800, Song Liu wrote: SNIP > + > + disassemble_init_for_target(&info); > + > +#ifdef DISASM_FOUR_ARGS_SIGNATURE > + disassemble = disassembler(info.arch, > +bfd_big_endian(bfdf), > +info.ma

Re: [PATCH v5 perf,bpf 08/15] perf, bpf: save btf in a rbtree in perf_env

2019-03-04 Thread Jiri Olsa
On Wed, Feb 27, 2019 at 09:06:36PM -0800, Song Liu wrote: > btf contains information necessary to annotate bpf programs. This patch > saves btf for bpf programs loaded in the system. > > Signed-off-by: Song Liu > --- > tools/perf/util/bpf-event.c | 24 ++ > tools/perf/util/bpf-event.

Re: [PATCH v4 perf,bpf 14/15] perf: introduce side band thread

2019-03-04 Thread Jiri Olsa
On Wed, Feb 27, 2019 at 05:52:52PM +, Song Liu wrote: > > > > On Feb 27, 2019, at 5:21 AM, Jiri Olsa wrote: > > > > On Mon, Feb 25, 2019 at 04:20:18PM -0800, Song Liu wrote: > > > > SNIP > > > >> diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c > >> index 8c902276d4b4..61b

Re: [PATCH v5 perf,bpf 12/15] perf, bpf: enable annotation of bpf program

2019-03-04 Thread Jiri Olsa
On Wed, Feb 27, 2019 at 09:06:40PM -0800, Song Liu wrote: SNIP > + fflush(s); > + do { > + const struct bpf_line_info *linfo = NULL; > + struct disasm_line *dl; > + size_t prev_buf_size; > + const char *srcline; > + u64 addr; > +

[PATCH] proc/sysctl: Fix NULL pointer dereference in put_links

2019-03-04 Thread Yue Haibing
From: YueHaibing Syzkaller report this: kasan: GPF could be caused by NULL-ptr deref or user memory access general protection fault: [#1] SMP KASAN PTI CPU: 1 PID: 5373 Comm: syz-executor.0 Not tainted 5.0.0-rc8+ #3 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.10.2-1ubuntu1

Re: [PATCH net-next] net: sched: set dedicated tcf_walker flag when tp is empty

2019-03-04 Thread Vlad Buslov
On Sat 02 Mar 2019 at 01:17, Cong Wang wrote: > On Thu, Feb 28, 2019 at 7:49 AM Vlad Buslov wrote: >> >> However, if we revert NULL fixes dump will print general tp information >> for same tp twice (once correctly before dumping all filters on the tp, and >> second time when called for bogus NU

Re: [PATCH 3/3] net: dsa: Add Vitesse VSC73xx DSA router driver

2019-03-04 Thread Vladimir Oltean
On Mon, 4 Mar 2019 at 15:53, Andrew Lunn wrote: > > > I do see that neither vitesse-vsc73xx nor rtl8366 do implement the bridge > > membership callbacks, and as I don't happen to know nearly enough about > > DSA, I > > wonder at what moment in time does forwarding get activated between ports. > >

RE: [PATCH v1 iproute2-next 1/4] rdma: add helper rd_sendrecv_msg()

2019-03-04 Thread Steve Wise
> > > > > > On 2/23/2019 3:26 AM, Leon Romanovsky wrote: > > > > On Thu, Feb 21, 2019 at 08:19:03AM -0800, Steve Wise wrote: > > > >> This function sends the constructed netlink message and then > > > >> receives the response, displaying any error text. > > > >> > > > >> Change 'rdma dev set' to

Re: [PATCH net-next] net: sched: don't release block->lock when dumping chains

2019-03-04 Thread Vlad Buslov
On Sat 02 Mar 2019 at 00:08, Cong Wang wrote: > On Thu, Feb 28, 2019 at 6:53 AM Vlad Buslov wrote: >> >> >> On Wed 27 Feb 2019 at 23:03, Cong Wang wrote: >> > On Tue, Feb 26, 2019 at 8:10 AM Vlad Buslov wrote: >> >> >> >> >> >> On Tue 26 Feb 2019 at 00:15, Cong Wang wrote: >> >> > On Mon, Fe

Re: [PATCH -next] net: dsa: mv88e6xxx: Fix build warning when CONFIG_NET_DSA_LEGACY is n

2019-03-04 Thread Zhangshaokun
Hi Andrew, On 2019/3/4 21:26, Andrew Lunn wrote: > On Mon, Mar 04, 2019 at 08:43:01PM +0800, Shaokun Zhang wrote: >> When CONFIG_NET_DSA_LEGACY is n, there is a GCC bulid warning: >> drivers/net/dsa/mv88e6xxx/chip.c:4623:13: warning: >> ‘mv88e6xxx_ports_cmode_init’ defined but not used [-Wunused-

Re: [PATCH net-next v2 04/12] net: sched: flower: track filter deletion with flag

2019-03-04 Thread Vlad Buslov
On Fri 01 Mar 2019 at 23:51, Stefano Brivio wrote: > Hi Vlad, > > On Wed, 27 Feb 2019 12:12:18 +0200 > Vlad Buslov wrote: > >> -static bool __fl_delete(struct tcf_proto *tp, struct cls_fl_filter *f, >> -struct netlink_ext_ack *extack) >> +static int __fl_delete(struct tcf_pr

[PATCH] can: m_can: implement errata "Needless activation of MRAF irq"

2019-03-04 Thread Eugen.Hristev
From: Eugen Hristev During frame reception while the MCAN is in Error Passive state and the Receive Error Counter has thevalue MCAN_ECR.REC = 127, it may happen that MCAN_IR.MRAF is set although there was no Message RAM access failure. If MCAN_IR.MRAF is enabled, an interrupt to the Host CPU is g

net-next: new CL45 regression

2019-03-04 Thread S-k, Shyam-sundar
Hi Heiner, We noticed that, the recent changes for CL45 in net-next tree causing regression on AMD platforms. The following is the commit: 3ce2a02 net: phy: marvell10g: check for newly set aneg Now, I see that, this code is moved to phy-c45.c with newer commit 1af9f16 net: phy: add genphy_c45_

Re: [PATCH -next] net: dsa: mv88e6xxx: Fix build warning when CONFIG_NET_DSA_LEGACY is n

2019-03-04 Thread Andrew Lunn
On Mon, Mar 04, 2019 at 10:16:08PM +0800, Zhangshaokun wrote: > Hi Andrew, > > On 2019/3/4 21:26, Andrew Lunn wrote: > > On Mon, Mar 04, 2019 at 08:43:01PM +0800, Shaokun Zhang wrote: > >> When CONFIG_NET_DSA_LEGACY is n, there is a GCC bulid warning: > >> drivers/net/dsa/mv88e6xxx/chip.c:4623:13:

Re: [PATCH] net/bluetooth: Fix bound check in event handling

2019-03-04 Thread Dan Carpenter
Hi Tomas, url: https://github.com/0day-ci/linux/commits/Tomas-Bortoli/net-bluetooth-Fix-bound-check-in-event-handling/20190301-213647 base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master smatch warnings: net/bluetooth/hci_event.c:3986 hci_inquiry_resul

Re: [PATCH net 2/2] net: phy: Use C45 Helpers in PHY_FORCING state

2019-03-04 Thread Jose Abreu
Hi Andrew, On 3/1/2019 1:53 PM, Andrew Lunn wrote: > On Fri, Mar 01, 2019 at 11:54:24AM +0100, Jose Abreu wrote: >> +static inline int phy_update_link(struct phy_device *phydev) >> +{ >> +if (!phydev->drv) >> +return -EIO; >> + >> +if (phydev->drv->read_status) >> +

Re: [PATCH net-next 4/5] net: phy: don't export gen10g_read_status

2019-03-04 Thread Jose Abreu
On 3/3/2019 4:12 PM, Heiner Kallweit wrote: > Not sure whether anybody is relying on the gen10g driver currently. I do for stmmac (code not upstreamed yet) and it works okay. For debug purposes I ended up writing my own phy driver but this is a plain copy of Generic 10G driver + reset and suspend/

Re: [PATCH net 2/2] net: phy: Use C45 Helpers in PHY_FORCING state

2019-03-04 Thread Andrew Lunn
On Mon, Mar 04, 2019 at 03:07:24PM +, Jose Abreu wrote: > Hi Andrew, > > On 3/1/2019 1:53 PM, Andrew Lunn wrote: > > On Fri, Mar 01, 2019 at 11:54:24AM +0100, Jose Abreu wrote: > >> +static inline int phy_update_link(struct phy_device *phydev) > >> +{ > >> + if (!phydev->drv) > >> +

Re: [PATCH] tcp: detect use sendpage for slab-based objects

2019-03-04 Thread Eric Dumazet
On 03/04/2019 04:58 AM, Vasily Averin wrote: > On 2/21/19 7:00 PM, Eric Dumazet wrote: >> On Thu, Feb 21, 2019 at 7:30 AM Vasily Averin wrote: >>> >>> There was few incidents when XFS over network block device generates >>> IO requests with slab-based metadata. If these requests are processed >

Re: [PATCH net-next 4/5] net: phy: don't export gen10g_read_status

2019-03-04 Thread Andrew Lunn
On Mon, Mar 04, 2019 at 03:26:56PM +, Jose Abreu wrote: > On 3/3/2019 4:12 PM, Heiner Kallweit wrote: > > Not sure whether anybody is relying on the gen10g driver currently. > > I do for stmmac (code not upstreamed yet) and it works okay. For > debug purposes I ended up writing my own phy driv

Re: [PATCH net v2 2/2] net/mlx5: Avoid panic when setting vport rate

2019-03-04 Thread Roi Dayan
On 04/03/2019 10:27, xiangxia.m@gmail.com wrote: > From: Tonghao Zhang > > If we try to set VFs rate on a VF (not PF) net device, the kernel > will be crash. The commands are show as below: > > $ echo 2 > /sys/class/net/$MLX_PF0/device/sriov_numvfs > $ ip link set $MLX_VF0 vf 0 max_tx_rate

Re: [PATCH net v2 1/2] net/mlx5: Avoid panic when setting vport mac, getting vport config

2019-03-04 Thread Roi Dayan
On 04/03/2019 10:27, xiangxia.m@gmail.com wrote: > From: Tonghao Zhang > > If we try to set VFs mac address on a VF (not PF) net device, > the kernel will be crash. The commands are show as below: > > $ echo 2 > /sys/class/net/$MLX_PF0/device/sriov_numvfs > $ ip link set $MLX_VF0 vf 0 mac

Re: [PATCH bpf-next v2 1/7] bpf: implement lookup-free direct value access

2019-03-04 Thread Daniel Borkmann
On 03/04/2019 07:03 AM, Andrii Nakryiko wrote: > On Thu, Feb 28, 2019 at 3:31 PM Daniel Borkmann wrote: [...] >> @@ -6664,8 +6669,10 @@ static int replace_map_fd_with_map_ptr(struct >> bpf_verifier_env *env) >> } >> >> if (insn[0].code == (BPF_LD | BPF_IMM | BPF_DW

Re: [PATCH net-next v2 3/3] net: phy: marvell10g: set the PHY in low power by default

2019-03-04 Thread Russell King - ARM Linux admin
On Mon, Mar 04, 2019 at 11:47:00AM +0100, Antoine Tenart wrote: > Hi Florian, > > I agree having a per-driver behaviour is not something we want. As I > understand it, there is no behaviour enforced currently regarding this > matter. I agree both cases have their pros and cons: > - It's weird to h

Re: [PATCH net-next 4/8] devlink: allow subports on devlink PCI ports

2019-03-04 Thread Jason Gunthorpe
On Wed, Feb 27, 2019 at 10:30:00AM -0800, Jakub Kicinski wrote: > On Wed, 27 Feb 2019 13:37:53 +0100, Jiri Pirko wrote: > > Tue, Feb 26, 2019 at 07:24:32PM CET, jakub.kicin...@netronome.com wrote: > > >PCI endpoint corresponds to a PCI device, but such device > > >can have one more more logical dev

RE: [RFC net-next 8/8] net/mlx5: Add subdev driver to bind to subdev devices

2019-03-04 Thread Parav Pandit
Hi Saeed, > -Original Message- > From: Saeed Mahameed > Sent: Friday, March 1, 2019 4:12 PM > To: Jiri Pirko ; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org; Parav Pandit ; > da...@davemloft.net; gre...@linuxfoundation.org; > michal.l...@markovi.net > Subject: Re: [RFC net-next 8

Re: [PATCH v6 1/4] can: m_can: Create a m_can platform framework

2019-03-04 Thread Wolfgang Grandegger
Hello Dan, the series already looks quite good. I still realized a few (minor) issues while browsing the patch/code... Am 01.03.19 um 19:50 schrieb Dan Murphy: > Create a m_can platform framework that peripherial > devices can register to and use common code and register sets. > The peripherial d

Re: [PATCH net-next v3 1/3] xdp: Refactor devmap code in preparation for subsequent additions

2019-03-04 Thread Jakub Kicinski
On Mon, 04 Mar 2019 13:47:47 +0100, Toke Høiland-Jørgensen wrote: > In an earlier version I had a namespace enter/exit notifier in devmap.c > as well, to react to new namespaces. And that notifier has a comment > about avoiding calls to synchronize_rcu(). But since this version > doesn't actually n

Re: [PATCH v6 1/4] can: m_can: Create a m_can platform framework

2019-03-04 Thread Dan Murphy
Wolfgang On 3/4/19 10:56 AM, Wolfgang Grandegger wrote: > Hello Dan, > > the series already looks quite good. I still realized a few (minor) > issues while browsing the patch/code... > Thanks for the review. It is getting there. > Am 01.03.19 um 19:50 schrieb Dan Murphy: >> Create a m_can pla

Re: [PATCH v6 2/4] can: m_can: Rename m_can_priv to m_can_classdev

2019-03-04 Thread Wolfgang Grandegger
Hello, there are still "LTL" after renaming m_can_priv to m_can_classdev. Am 01.03.19 um 19:50 schrieb Dan Murphy: > Rename the common m_can_priv class structure to > m_can_classdev as this is more descriptive. If you change the struct name, I think you should also change the variable name to so

Re: [PATCH bpf-next v2 1/7] bpf: implement lookup-free direct value access

2019-03-04 Thread Andrii Nakryiko
On Mon, Mar 4, 2019 at 7:59 AM Daniel Borkmann wrote: > > On 03/04/2019 07:03 AM, Andrii Nakryiko wrote: > > On Thu, Feb 28, 2019 at 3:31 PM Daniel Borkmann > > wrote: > [...] > >> @@ -6664,8 +6669,10 @@ static int replace_map_fd_with_map_ptr(struct > >> bpf_verifier_env *env) > >>

Re: [PATCH net-next v3 1/3] xdp: Refactor devmap code in preparation for subsequent additions

2019-03-04 Thread Toke Høiland-Jørgensen
Jakub Kicinski writes: > On Mon, 04 Mar 2019 13:47:47 +0100, Toke Høiland-Jørgensen wrote: >> In an earlier version I had a namespace enter/exit notifier in devmap.c >> as well, to react to new namespaces. And that notifier has a comment >> about avoiding calls to synchronize_rcu(). But since thi

Re: [PATCH v3 bpf-next 1/2] bpf: Fix bpf_tcp_sock and bpf_sk_fullsock issue related to bpf_sk_release

2019-03-04 Thread Martin Lau
On Mon, Mar 04, 2019 at 10:33:46AM +0100, Daniel Borkmann wrote: > On 03/02/2019 09:21 PM, Martin Lau wrote: > > On Sat, Mar 02, 2019 at 10:03:03AM -0800, Alexei Starovoitov wrote: > >> On Sat, Mar 02, 2019 at 08:10:10AM -0800, Martin KaFai Lau wrote: > >>> Lorenz Bauer [thanks!] reported that a pt

Re: [PATCH net-next v3 2/3] xdp: Always use a devmap for XDP_REDIRECT to a device

2019-03-04 Thread Jakub Kicinski
On Mon, 04 Mar 2019 12:58:51 +0100, Toke Høiland-Jørgensen wrote: > >> diff --git a/include/net/netns/xdp.h b/include/net/netns/xdp.h > >> index e5734261ba0a..4935dfe1cf43 100644 > >> --- a/include/net/netns/xdp.h > >> +++ b/include/net/netns/xdp.h > >> @@ -4,10 +4,21 @@ > >> > >> #include > >>

Re: [PATCH net 2/2] net: phy: Use C45 Helpers in PHY_FORCING state

2019-03-04 Thread Heiner Kallweit
On 04.03.2019 16:44, Andrew Lunn wrote: > On Mon, Mar 04, 2019 at 03:07:24PM +, Jose Abreu wrote: >> Hi Andrew, >> >> On 3/1/2019 1:53 PM, Andrew Lunn wrote: >>> On Fri, Mar 01, 2019 at 11:54:24AM +0100, Jose Abreu wrote: +static inline int phy_update_link(struct phy_device *phydev) +

Re: [PATCH v6 1/4] can: m_can: Create a m_can platform framework

2019-03-04 Thread Wolfgang Grandegger
Am 04.03.19 um 18:22 schrieb Dan Murphy: > Wolfgang > > On 3/4/19 10:56 AM, Wolfgang Grandegger wrote: >> Hello Dan, >> >> the series already looks quite good. I still realized a few (minor) >> issues while browsing the patch/code... >> > > Thanks for the review. It is getting there. > >> Am

Re: [PATCH v6 2/4] can: m_can: Rename m_can_priv to m_can_classdev

2019-03-04 Thread Dan Murphy
Wolfgang On 3/4/19 11:31 AM, Wolfgang Grandegger wrote: > Hello, > > there are still "LTL" after renaming m_can_priv to m_can_classdev. > Yes I know but some of those become unreadable if I break them apart. But if you want me to break them I can do it. For instance struct m_can_plat_

Re: pull-request: bpf-next 2019-03-04

2019-03-04 Thread David Miller
From: Daniel Borkmann Date: Mon, 4 Mar 2019 12:19:19 +0100 > The following pull-request contains BPF updates for your *net-next* tree. > > The main changes are: ... > Please consider pulling these changes from: > > git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git Pulled, thank

Re: [PATCH v1] mellanox: Switch to bitmap_zalloc()

2019-03-04 Thread David Miller
From: Jiri Pirko Date: Mon, 4 Mar 2019 12:59:46 +0100 > Mon, Mar 04, 2019 at 09:57:00AM CET, andriy.shevche...@linux.intel.com wrote: >>Switch to bitmap_zalloc() to show clearly what we are allocating. >>Besides that it returns pointer of bitmap type instead of opaque void *. >> >>Signed-off-by:

[PATCH] selftest/net: Remove duplicate header

2019-03-04 Thread Souptick Joarder
Remove duplicate header which is included twice. Signed-off-by: Sabyasachi Gupta Signed-off-by: Souptick Joarder --- tools/testing/selftests/net/udpgso.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/testing/selftests/net/udpgso.c b/tools/testing/selftests/net/udpgso.c index e279051

Re: question about memory leak in ip_mc_del1_src

2019-03-04 Thread David Miller
From: maowenan Date: Mon, 4 Mar 2019 20:47:42 +0800 > pmc->tomb = psf; > rv = 1; //if it does not kfree(psf), will it > lead to memory leak after this line? pmc->tomb points to psf, why should we free it?

Re: [PATCH -next] net: dsa: mv88e6xxx: Fix build warning when CONFIG_NET_DSA_LEGACY is n

2019-03-04 Thread Heiner Kallweit
On 04.03.2019 15:57, Andrew Lunn wrote: > On Mon, Mar 04, 2019 at 10:16:08PM +0800, Zhangshaokun wrote: >> Hi Andrew, >> >> On 2019/3/4 21:26, Andrew Lunn wrote: >>> On Mon, Mar 04, 2019 at 08:43:01PM +0800, Shaokun Zhang wrote: When CONFIG_NET_DSA_LEGACY is n, there is a GCC bulid warning: >>

Re: [PATCH v1] mellanox: Switch to bitmap_zalloc()

2019-03-04 Thread David Miller
From: Andy Shevchenko Date: Mon, 4 Mar 2019 10:57:00 +0200 > Switch to bitmap_zalloc() to show clearly what we are allocating. > Besides that it returns pointer of bitmap type instead of opaque void *. > > Signed-off-by: Andy Shevchenko Applied.

Re: [PATCH net-next v2] cxgb4/chtls: Prefix adapter flags with CXGB4

2019-03-04 Thread David Miller
From: Arjun Vynipadath Date: Mon, 4 Mar 2019 17:43:02 +0530 > Some of these macros were conflicting with global namespace, > hence prefixing them with CXGB4. > > Signed-off-by: Arjun Vynipadath > Signed-off-by: Vishal Kulkarni > --- > v2: > - Fixed build issues in chtls driver Applied, thank

Re: [PATCH v1] net-sysfs: Switch to bitmap_zalloc()

2019-03-04 Thread David Miller
From: Andy Shevchenko Date: Mon, 4 Mar 2019 11:48:56 +0200 > Switch to bitmap_zalloc() to show clearly what we are allocating. > Besides that it returns pointer of bitmap type instead of opaque void *. > > Signed-off-by: Andy Shevchenko Applied, thanks Andy.

Re: [PATCH net-next v2 0/7] devlink: expose PF and VF representors as ports

2019-03-04 Thread David Miller
From: Jakub Kicinski Date: Fri, 1 Mar 2019 10:04:46 -0800 > This series is a long overdue follow up to Jiri's work on providing > a common .ndo_phys_port_name implementation based on devlink ports. I think this needs enough discussion still that it will have to wait until the next merge window.

Re: [PATCH -next] net: dsa: mv88e6xxx: Fix build warning when CONFIG_NET_DSA_LEGACY is n

2019-03-04 Thread Florian Fainelli
On 3/4/19 10:18 AM, Heiner Kallweit wrote: > On 04.03.2019 15:57, Andrew Lunn wrote: >> On Mon, Mar 04, 2019 at 10:16:08PM +0800, Zhangshaokun wrote: >>> Hi Andrew, >>> >>> On 2019/3/4 21:26, Andrew Lunn wrote: On Mon, Mar 04, 2019 at 08:43:01PM +0800, Shaokun Zhang wrote: > When CONFIG_NE

  1   2   3   >