[PATCH net 6/9] net/smc: longer delay for client link group removal

2017-09-21 Thread Ursula Braun
Client link group creation always follows the server linkgroup creation. If peer creates a new server link group, client has to create a new client link group. If peer reuses a server link group for a new connection, client has to reuse its client link group as well. This patch introduces a longer

[PATCH net 7/9] net/smc: terminate link group if out-of-sync is received

2017-09-21 Thread Ursula Braun
An out-of-sync condition can just be detected by the client. If the server receives a CLC DECLINE message indicating an out-of-sync condition for the link groups, the server must clean up the out-of-sync link group. There is no need for an extra third parameter in smc_clc_send_decline(). Signed-of

[PATCH net 3/9] net/smc: take RCU read lock for routing cache lookup

2017-09-21 Thread Ursula Braun
smc_netinfo_by_tcpsk() looks up the routing cache. Such a lookup requires protection by an RCU read lock. Signed-off-by: Ursula Braun --- net/smc/af_smc.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c index 8c6d24b2995d..2e8d2d

[PATCH net 2/9] net/smc: add receive timeout check

2017-09-21 Thread Ursula Braun
From: Hans Wippel The SMC receive function currently lacks a timeout check under the condition that no data were received and no data are available. This patch adds such a check. Signed-off-by: Hans Wippel Signed-off-by: Ursula Braun --- net/smc/smc_rx.c | 2 ++ 1 file changed, 2 insertions(+

[PATCH net 4/9] net/smc: adjust net_device refcount

2017-09-21 Thread Ursula Braun
smc_pnet_fill_entry() uses dev_get_by_name() adding a refcount to ndev. The following smc_pnet_enter() has to reduce the refcount if the entry to be added exists already in the pnet table. Signed-off-by: Ursula Braun --- net/smc/smc_pnet.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

[PATCH net 8/9] net/smc: introduce a delay

2017-09-21 Thread Ursula Braun
The number of outstanding work requests is limited. If all work requests are in use, tx processing is postponed to another scheduling of the tx worker. Switch to a delayed worker to have a gap for tx completion queue events before the next retry. Signed-off-by: Ursula Braun --- net/smc/smc.h

[PATCH net 5/9] net/smc: adapt send request completion notification

2017-09-21 Thread Ursula Braun
The solicited flag is meaningful for the receive completion queue. Ask for next work completion of any type on the send queue. Signed-off-by: Ursula Braun --- net/smc/smc_wr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/smc/smc_wr.c b/net/smc/smc_wr.c index ab56bda667

[PATCH net 9/9] net/smc: no close wait in case of process shut down

2017-09-21 Thread Ursula Braun
Usually socket closing is delayed if there is still data available in the send buffer to be transmitted. If a process is killed, the delay should be avoided. Signed-off-by: Ursula Braun --- net/smc/smc_close.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/ne

[PATCH net-next 1/1] net/smc: parameter cleanup in smc_cdc_get_free_slot()

2017-09-21 Thread Ursula Braun
Use the smc_connection as first parameter with smc_cdc_get_free_slot(). This is just a small code cleanup, no functional change. Signed-off-by: Ursula Braun --- net/smc/smc_cdc.c | 7 --- net/smc/smc_cdc.h | 3 ++- net/smc/smc_tx.c | 6 ++ 3 files changed, 8 insertions(+), 8 deletions(-

[PATCH net 1/9] net/smc: add missing dev_put

2017-09-21 Thread Ursula Braun
From: Hans Wippel In the infiniband part, SMC currently uses get_netdev which calls dev_hold on the returned net device. However, the SMC code never calls dev_put on that net device resulting in a wrong reference count. This patch adds a dev_put after the usage of the net device to fix the issue

[PATCH net 0/9] net/smc: bug fixes 2017-09-20

2017-09-21 Thread Ursula Braun
Hi Dave, here is a collection of small smc-patches built for net fixing smc problems in different areas. Thanks, Ursula *** BLURB HERE *** Hans Wippel (2): net/smc: add missing dev_put net/smc: add receive timeout check Ursula Braun (7): net/smc: take RCU read lock for routing cache looku

Re: [PATCHv3 iproute2 1/2] lib/libnetlink: re malloc buff if size is not enough

2017-09-21 Thread Hangbin Liu
Hi Stephen, On Wed, Sep 20, 2017 at 09:56:05AM -0700, Stephen Hemminger wrote: > > +realloc: > > + bufp = realloc(buf, buf_len); > > + > > + if (bufp == NULL) { > > Minor personal style issue: > To me, blank lines are like paragraphs in writing. > Code reads better assignment and condition che

[PATCH net-next] cxgb4: avoid stall while shutting down the adapter

2017-09-21 Thread Ganesh Goudar
do not wait for completion while deleting the filters when the adapter is shutting down because we may not get the response as interrupts will be disabled. Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h| 1 + drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c

[PATCH net-next 1/4] cxgb4: add tc flower offload skeleton

2017-09-21 Thread Rahul Lakkireddy
From: Kumar Sanghvi Add basic skeleton to prepare for offloading tc-flower flows. Signed-off-by: Kumar Sanghvi Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/Makefile| 4 +- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c| 22

[PATCH net-next 4/4] cxgb4: fetch stats for offloaded tc flower flows

2017-09-21 Thread Rahul Lakkireddy
From: Kumar Sanghvi Add support to retrieve stats from hardware for offloaded tc flower flows. Also, poll for the stats of offloaded flows via timer callback. Signed-off-by: Kumar Sanghvi Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/cxg

[PATCH net-next 2/4] cxgb4: add basic tc flower offload support

2017-09-21 Thread Rahul Lakkireddy
From: Kumar Sanghvi Add support to add/remove flows for offload. Following match and action are supported for offloading a flow: Match: ether-protocol, IPv4/IPv6 addresses, L4 ports (TCP/UDP) Action: drop, redirect to another port on the device. The qualifying flows can have accompanying mask

Re: [PATCHv3 iproute2 1/2] lib/libnetlink: re malloc buff if size is not enough

2017-09-21 Thread Michal Kubecek
On Thu, Sep 21, 2017 at 03:20:02PM +0800, Hangbin Liu wrote: > > Or maybe we can set buf_len very small first. Then it will force to realloc at > the second time. And the code would like > > int buf_len = 16; > bufp = realloc(buf, buf_len); > /* check bufp and set msg */ > >

[PATCH net-next 0/4] cxgb4: add support to offload tc flower

2017-09-21 Thread Rahul Lakkireddy
This series of patches add support to offload tc flower onto Chelsio NICs. Patch 1 adds basic skeleton to prepare for offloading tc flower flows. Patch 2 adds support to add/remove flows for offload. Flows can have accompanying masks. Following match and action are currently supported for offlo

[PATCH net-next 3/4] cxgb4: add support to offload action vlan

2017-09-21 Thread Rahul Lakkireddy
From: Kumar Sanghvi Add support for offloading tc-flower flows having vlan actions: pop, push and modify. Signed-off-by: Kumar Sanghvi Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- .../net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c | 43 ++ 1 file chang

[PATCH iproute2 master 0/2] BPF/XDP json follow-up

2017-09-21 Thread Daniel Borkmann
After merging net-next branch into master, Stephen asked to fix up json dump for XDP as there were some merge conflicts, so here it is. Thanks! Daniel Borkmann (2): json: move json printer to common library bpf: properly output json for xdp include/json_print.h | 71 ip/Ma

[PATCH iproute2 master 2/2] bpf: properly output json for xdp

2017-09-21 Thread Daniel Borkmann
After merging net-next branch into master, Stephen asked to fix up json dump for XDP. Thus, rework the json dump a bit, such that 'ip -json l' looks as below. [{ "ifindex": 1, "ifname": "lo", "flags": ["LOOPBACK","UP","LOWER_UP"], "mtu": 65536, "xdp": {

[PATCH iproute2 master 1/2] json: move json printer to common library

2017-09-21 Thread Daniel Borkmann
Move the json printer which is based on json writer into the iproute2 library, so it can be used by library code and tools other than ip. Should probably have been done from the beginning like that given json writer is in the library already anyway. No functional changes. Signed-off-by: Daniel Bor

Re: [PATCH net-next 3/4] cxgb4: add support to offload action vlan

2017-09-21 Thread Jiri Pirko
Thu, Sep 21, 2017 at 09:33:36AM CEST, rahul.lakkire...@chelsio.com wrote: >From: Kumar Sanghvi > >Add support for offloading tc-flower flows having >vlan actions: pop, push and modify. > >Signed-off-by: Kumar Sanghvi >Signed-off-by: Rahul Lakkireddy >Signed-off-by: Ganesh Goudar >--- > .../net/

Re: [PATCH net-next 0/4] cxgb4: add support to offload tc flower

2017-09-21 Thread Jiri Pirko
Thu, Sep 21, 2017 at 09:33:33AM CEST, rahul.lakkire...@chelsio.com wrote: >This series of patches add support to offload tc flower onto Chelsio >NICs. > >Patch 1 adds basic skeleton to prepare for offloading tc flower flows. > >Patch 2 adds support to add/remove flows for offload. Flows can have >

Re: Latest net-next from GIT panic

2017-09-21 Thread Paweł Staszewski
W dniu 2017-09-21 o 03:17, Eric Dumazet pisze: On Wed, 2017-09-20 at 18:09 -0700, Wei Wang wrote: Thanks very much Pawel for the feedback. I was looking into the code (specifically IPv4 part) and found that in free_fib_info_rcu(), we call free_nh_exceptions() without holding the fnhe_lock. I

Re: [PATCH net-next 2/5] net: allow early demux to fetch noref socket

2017-09-21 Thread Paolo Abeni
On Wed, 2017-09-20 at 18:54 +0200, Paolo Abeni wrote: > We must be careful to avoid leaking such sockets outside > the RCU section containing the early demux call; we clear > them on nonlocal delivery. > > For ipv4 we must take care of local mcast delivery, too, > since udp early demux works also

Re: [PATCH net-next 1/5] net: add support for noref skb->sk

2017-09-21 Thread Paolo Abeni
Hi, Thank you for looking at it! On Wed, 2017-09-20 at 10:41 -0700, Eric Dumazet wrote: > On Wed, 2017-09-20 at 18:54 +0200, Paolo Abeni wrote: > > Noref sk do not carry a socket refcount, are valid > > only inside the current RCU section and must be > > explicitly cleared before exiting such sec

Product Enquiry

2017-09-21 Thread Carol Merck
Dear Sir, We recently visited your website and we are interested in your models, We will like to make an order from your list of products. However, we would like to see your company's latest catalogs with the; minimum order quantity, delivery time/FOB, payment terms etc. Official order placemen

[PATCH 2/2] ip_tunnel: add mpls over gre encapsulation

2017-09-21 Thread Amine Kherbouche
This commit introduces the MPLSoGRE support (RFC 4023), using ip tunnel API. Encap: - Add a new iptunnel type mpls. Decap: - pull gre hdr and call mpls_forward(). Signed-off-by: Amine Kherbouche --- include/net/gre.h | 3 +++ include/uapi/linux/if_tunnel.h | 1 + net/ipv4/gr

[RFC PATCH 0/0] Introduce MPLS over GRE

2017-09-21 Thread Amine Kherbouche
This series introduces the MPLS over GRE encapsulation (RFC 4023). Various applications of MPLS make use of label stacks with multiple entries. In some cases, it is possible to replace the top label of the stack with an IP-based encapsulation, thereby, it is possible for two LSRs that are adjacen

[PATCH 1/2] mpls: expose stack entry function

2017-09-21 Thread Amine Kherbouche
Exposing mpls_forward() function to be able to be called from elsewhere such as MPLS over GRE in the next commit. Signed-off-by: Amine Kherbouche --- include/linux/mpls.h | 3 +++ net/mpls/af_mpls.c | 5 +++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/include/linux/mpls.h

Re: [PATCH v3 10/31] befs: Define usercopy region in befs_inode_cache slab cache

2017-09-21 Thread Luis de Bethencourt
On 09/20/2017 09:45 PM, Kees Cook wrote: From: David Windsor befs symlink pathnames, stored in struct befs_inode_info.i_data.symlink and therefore contained in the befs_inode_cache slab cache, need to be copied to/from userspace. cache object allocation: fs/befs/linuxvfs.c: befs_

Re: [PATCH net-next 0/5] net: introduce noref sk

2017-09-21 Thread Paolo Abeni
Hi, Thanks for the feedback! On Wed, 2017-09-20 at 20:20 -0700, David Miller wrote: > From: Paolo Abeni > Date: Wed, 20 Sep 2017 18:54:00 +0200 > > > This series introduce the infrastructure to store inside the skb a socket > > pointer without carrying a refcount to the socket. > > > > Such in

[PATCH net-next 0/2] lan9303: Add basic offloading of unicast traffic

2017-09-21 Thread Egil Hjelmeland
This series add basic offloading of unicast traffic to the lan9303 DSA driver. Comments welcome! Egil Hjelmeland (2): net: dsa: lan9303: Move tag setup to new lan9303_setup_tagging net: dsa: lan9303: Add basic offloading of unicast traffic drivers/net/dsa/lan9303-core.c | 130 ++

[PATCH net-next 1/2] net: dsa: lan9303: Move tag setup to new lan9303_setup_tagging

2017-09-21 Thread Egil Hjelmeland
Prepare for next patch: Move tag setup from lan9303_separate_ports() to new function lan9303_setup_tagging() Signed-off-by: Egil Hjelmeland --- drivers/net/dsa/lan9303-core.c | 42 +- 1 file changed, 25 insertions(+), 17 deletions(-) diff --git a/drivers/

[PATCH net-next 2/2] net: dsa: lan9303: Add basic offloading of unicast traffic

2017-09-21 Thread Egil Hjelmeland
When both user ports are joined to the same bridge, the normal HW MAC learning is enabled. This means that unicast traffic is forwarded in HW. If one of the user ports leave the bridge, the ports goes back to the initial separated operation. Port separation relies on disabled HW MAC learning. Hen

Re: [PATCH net-next v2] bridge: also trigger RTM_NEWLINK when interface is released from bridge

2017-09-21 Thread Vincent Bernat
❦ 20 septembre 2017 16:21 -0700, Stephen Hemminger  : > The one concern is that ports added or removed through ioctl should > cause same events as doing the same thing via netlink. Some users use > brctl (ioctl) and others use newer bridge (netlink) API. I'll make a third iteration to have the

[net-next v3] bridge: trigger RTM_NEWLINK when interface is modified by bridge ioctl

2017-09-21 Thread Vincent Bernat
Currently, there is a difference in netlink events received when an interface is modified through bridge ioctl() or through netlink. This patch generates additional events when an interface is added to or removed from a bridge via ioctl(). When adding then removing an interface from a bridge with

Re: [PATCH net-next 1/5] net: add support for noref skb->sk

2017-09-21 Thread Eric Dumazet
On Thu, 2017-09-21 at 11:14 +0200, Paolo Abeni wrote: > Hi, > > Thank you for looking at it! > > On Wed, 2017-09-20 at 10:41 -0700, Eric Dumazet wrote: > > On Wed, 2017-09-20 at 18:54 +0200, Paolo Abeni wrote: > > > Noref sk do not carry a socket refcount, are valid > > > only inside the current

Re: [PATCH net-next 0/5] net: introduce noref sk

2017-09-21 Thread Eric Dumazet
On Thu, 2017-09-21 at 11:42 +0200, Paolo Abeni wrote: > Hi, > > Thanks for the feedback! > > On Wed, 2017-09-20 at 20:20 -0700, David Miller wrote: > > From: Paolo Abeni > > Date: Wed, 20 Sep 2017 18:54:00 +0200 > > > > > This series introduce the infrastructure to store inside the skb a socket

[PATCH net 0/4] net:ethernet:aquantia: Atlantic driver bugfixes and improvements

2017-09-21 Thread Igor Russkikh
This series contains bugfixes for aQuantia Atlantic driver. Igor Russkikh (3): net:ethernet:aquantia: Setup max_mtu in ndev to enable jumbo frames net:ethernet:aquantia: Fix Tx queue hangups net:ethernet:aquantia: Fix transient invalid link down/up indications Pavel Belous (1): net:ethern

[PATCH net 1/4] net:ethernet:aquantia: Setup max_mtu in ndev to enable jumbo frames

2017-09-21 Thread Igor Russkikh
Although hardware is capable for almost 16K MTU, without max_mtu field correctly set it only allows standard MTU to be used. This patch enables max MTU, calculating it from hardware maximum frame size of 16352 octets (including FCS). Fixes: 5513e16421cb ("net: ethernet: aquantia: Fixes for aq_ndev

[PATCH net 3/4] net:ethernet:aquantia: Fix transient invalid link down/up indications

2017-09-21 Thread Igor Russkikh
Due to a bug in aquantia atlantic card firmware, it sometimes reports invalid link speed bits. That caused driver to report link down events, although link itself is totally fine. This patch ignores such out of blue readings. Signed-off-by: Pavel Belous Signed-off-by: Igor Russkikh --- drivers

[PATCH net 2/4] net:ethernet:aquantia: Fix Tx queue hangups

2017-09-21 Thread Igor Russkikh
Driver did a poor job in managing its Tx queues: Sometimes it could stop tx queues due to link down condition in aq_nic_xmit - but never waked up them. That led to Tx path total suspend. This patch fixes this and improves generic queue management: - introduces queue restart counter - uses generic n

[PATCH net 4/4] net:ethernet:atlantic: fix iommu errors

2017-09-21 Thread Igor Russkikh
From: Pavel Belous Call skb_frag_dma_map multiple times if tx length is greater than device max and avoid processing tx ring until entire packet has been sent. Signed-off-by: Igor Russkikh Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 43 ++

Re: [PATCH net-next 2/4] cxgb4: add basic tc flower offload support

2017-09-21 Thread Yunsheng Lin
Hi, Kumar On 2017/9/21 15:33, Rahul Lakkireddy wrote: > From: Kumar Sanghvi > > Add support to add/remove flows for offload. Following match > and action are supported for offloading a flow: > > Match: ether-protocol, IPv4/IPv6 addresses, L4 ports (TCP/UDP) > Action: drop, redirect to another

[PATCH 1/1] net:nfc: use setup_timer

2017-09-21 Thread Allen Pais
Use setup_timer function instead of initializing timer with the function and data fields. Signed-off-by: Allen Pais --- net/nfc/core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/net/nfc/core.c b/net/nfc/core.c index 5cf33df..e5e23c2 100644 --- a/net/nfc/core

Re: Latest net-next from GIT panic

2017-09-21 Thread Eric Dumazet
On Thu, 2017-09-21 at 11:06 +0200, Paweł Staszewski wrote: > > W dniu 2017-09-21 o 03:17, Eric Dumazet pisze: > > On Wed, 2017-09-20 at 18:09 -0700, Wei Wang wrote: > >>> Thanks very much Pawel for the feedback. > >>> > >>> I was looking into the code (specifically IPv4 part) and found that in > >

Re: Latest net-next from GIT panic

2017-09-21 Thread Paweł Staszewski
W dniu 2017-09-21 o 13:03, Eric Dumazet pisze: On Thu, 2017-09-21 at 11:06 +0200, Paweł Staszewski wrote: W dniu 2017-09-21 o 03:17, Eric Dumazet pisze: On Wed, 2017-09-20 at 18:09 -0700, Wei Wang wrote: Thanks very much Pawel for the feedback. I was looking into the code (specifically IPv4

Re: Latest net-next from GIT panic

2017-09-21 Thread Paweł Staszewski
W dniu 2017-09-21 o 13:12, Paweł Staszewski pisze: W dniu 2017-09-21 o 13:03, Eric Dumazet pisze: On Thu, 2017-09-21 at 11:06 +0200, Paweł Staszewski wrote: W dniu 2017-09-21 o 03:17, Eric Dumazet pisze: On Wed, 2017-09-20 at 18:09 -0700, Wei Wang wrote: Thanks very much Pawel for the fee

Re: [PATCH net] bpf: one perf event close won't free bpf program attached by another perf event

2017-09-21 Thread Peter Zijlstra
On Wed, Sep 20, 2017 at 10:20:13PM -0700, Yonghong Song wrote: > > (2). trace_event_call->perf_events are per cpu data structure, that > > means, some filtering logic is needed to avoid the same perf_event prog > > is executing twice. > > What I mean here is that the trace_event_call->perf_events

Re: [patch net-next 03/12] ipmr: Add FIB notification access functions

2017-09-21 Thread Nikolay Aleksandrov
On 21/09/17 09:43, Jiri Pirko wrote: > From: Yotam Gigi > > Make the ipmr module register as a FIB notifier. To do that, implement both > the ipmr_seq_read and ipmr_dump ops. > > The ipmr_seq_read op returns a sequence counter that is incremented on > every notification related operation done by

Re: [PATCH net 2/4] net:ethernet:aquantia: Fix Tx queue hangups

2017-09-21 Thread Yunsheng Lin
Hi, Igor On 2017/9/21 18:53, Igor Russkikh wrote: > Driver did a poor job in managing its Tx queues: Sometimes it could stop > tx queues due to link down condition in aq_nic_xmit - but never waked up > them. That led to Tx path total suspend. > This patch fixes this and improves generic queue mana

[PATCH net-next 10/10] net: hns3: Add mqprio support when interacting with network stack

2017-09-21 Thread Yunsheng Lin
When using tc qdisc to configure DCB parameter, dcb_ops->setup_tc is used to tell hclge_dcb module to do the setup. When using lldptool to configure DCB parameter, hclge_dcb module call the client_ops->setup_tc to tell network stack which queue and priority is using for specific tc. Signed-off-by:

[PATCH net-next 08/10] net: hns3: Add dcb netlink interface for the support of DCB feature

2017-09-21 Thread Yunsheng Lin
This patch add dcb netlink interface by calling the interface from hclge_dcb module. This patch also update Makefile in order to build hns3_dcbnl module. Signed-off-by: Yunsheng Lin --- .../net/ethernet/hisilicon/hns3/hns3pf/Makefile| 2 + .../ethernet/hisilicon/hns3/hns3pf/hns3_dcbnl.c

[PATCH net-next 05/10] net: hns3: Add tc-based TM support for sriov enabled port

2017-09-21 Thread Yunsheng Lin
When sriov is enabled and TM is in tc-based mode, vf's TM parameters is not set in TM initialization process. This patch add the tc_based TM support for sriov enabled using the information in vport struct. Signed-off-by: Yunsheng Lin --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c | 49 ++

[PATCH net-next 09/10] net: hns3: Setting for fc_mode and dcb enable flag in TM module

2017-09-21 Thread Yunsheng Lin
After the DCB feature is supported, fc_mode and dcb enable flag must be set according to the DCB parameter. Signed-off-by: Yunsheng Lin --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c | 34 +++--- 1 file changed, 30 insertions(+), 4 deletions(-) diff --git a/drivers/net/e

[PATCH net-next 04/10] net: hns3: Add support for port shaper setting in TM module

2017-09-21 Thread Yunsheng Lin
This patch add a tm_port_shaper cmd and set port shaper to HCLGE_ETHER_MAX_RATE on TM initialization process. Signed-off-by: Yunsheng Lin --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c | 33 ++ .../net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.h | 4 +++ 2 files chang

[PATCH net-next 07/10] net: hns3: Add hclge_dcb module for the support of DCB feature

2017-09-21 Thread Yunsheng Lin
The hclge_dcb module calls the interface from hclge_main/tm and provide interface for the dcb netlink interface. This patch also update Makefiles required to build the DCB supported code in HNS3 Ethernet driver and update the existing Kconfig file in the hisilicon folder. Signed-off-by: Yunsheng

[PATCH net-next 06/10] net: hns3: Add some interface for the support of DCB feature

2017-09-21 Thread Yunsheng Lin
This patch add some interface and export some interface from hclge_tm and hclgc_main to support the upcoming DCB feature. Signed-off-by: Yunsheng Lin --- .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 3 +- .../ethernet/hisilicon/hns3/hns3pf/hclge_main.h| 3 ++ .../net/ethernet/hisil

[PATCH net-next 01/10] net: hns3: Support for dynamically assigning tx buffer to TC

2017-09-21 Thread Yunsheng Lin
This patch add support of dynamically assigning tx buffer to TC when the TC is enabled. It will save buffer for rx direction to avoid packet loss. Signed-off-by: Yunsheng Lin --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 1 + .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 69 ++

[PATCH net-next 02/10] net: hns3: Add support for dynamically buffer reallocation

2017-09-21 Thread Yunsheng Lin
Current buffer allocation can only happen at init, when doing buffer reallocation after init, care must be taken care of memory which priv_buf points to. This patch fixes it by using a dynamic allocated temporary memory. Because we only do buffer reallocation at init or when setting up the DCB para

[PATCH] net: phy: Fix truncation of large IRQ numbers in phy_attached_print()

2017-09-21 Thread Geert Uytterhoeven
Given NR_IRQS is 2048 on sparc64, and even 32784 on alpha, 3 digits is not enough to represent interrupt numbers on all architectures. Hence PHY interrupt numbers may be truncated during printing. Increase the buffer size from 4 to 8 bytes to fix this. Fixes: 5e369aefdce4818c ("net: stmmac: Dele

Re: [patch net-next 05/12] net: ipmr: Add MFC offload indication

2017-09-21 Thread Nikolay Aleksandrov
On 21/09/17 09:43, Jiri Pirko wrote: > From: Yotam Gigi > > Allow drivers, registered to the fib notification chain indicate whether a > multicast MFC route is offloaded or not, similarly to unicast routes. The > indication of whether a route is offloaded is done using the mfc_flags > field on an

[PATCH net-next 03/10] net: hns3: Add support for PFC setting in TM module

2017-09-21 Thread Yunsheng Lin
This patch add a pfc_pause_en cmd, and use it to configure PFC option according to fc_mode in hdev->tm_info. Signed-off-by: Yunsheng Lin --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c | 68 -- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.h | 5 ++ 2 files changed

[PATCH net-next 00/10] Add support for DCB feature in hns3 driver

2017-09-21 Thread Yunsheng Lin
The patchset contains some enhancement related to DCB before adding support for DCB feature. This patchset depends on the following patchset: https://patchwork.ozlabs.org/cover/815646/ https://patchwork.ozlabs.org/cover/816145/ High Level Architecture: [ tc qdisc ][ lldpad ]

Re: Latest net-next from GIT panic

2017-09-21 Thread Paweł Staszewski
W dniu 2017-09-21 o 13:03, Eric Dumazet pisze: OK we have two problems here 1) We need to unify skb_dst_force() ( for net tree ) 2) Vlan devices should try to correctly handle IFF_XMIT_DST_RELEASE from lower device. This will considerably help your performance. For 1), this is what I had i

Re: [patch net-next 04/12] ipmr: Send FIB notifications on MFC and VIF entries

2017-09-21 Thread Nikolay Aleksandrov
On 21/09/17 09:43, Jiri Pirko wrote: > From: Yotam Gigi > > Use the newly introduced notification chain to send events upon VIF and MFC > addition and deletion. The MFC notifications are sent only on resolved MFC > entries, as unresolved cannot be offloaded. > > Signed-off-by: Yotam Gigi > Revi

Re: [patch net-next 02/12] ipmr: Add reference count to MFC entries

2017-09-21 Thread Nikolay Aleksandrov
On 21/09/17 09:43, Jiri Pirko wrote: > From: Yotam Gigi > > Next commits will introduce MFC notifications through the atomic > fib_notification chain, thus allowing modules to be aware of MFC entries. > > Due to the fact that modules may need to hold a reference to an MFC entry, > add reference

Re: [PATCH net-next 2/3] net: ethernet: socionext: add AVE ethernet driver

2017-09-21 Thread Kunihiko Hayashi
On Mon, 11 Sep 2017 15:55:56 +0900 wrote: > > > +static int ave_set_rxdesc(struct net_device *ndev, int entry) > > > +{ > > > + struct ave_private *priv = netdev_priv(ndev); > > > + struct sk_buff *skb; > > > + unsigned long align; > > > + dma_addr_t paddr; > > > + void *buffptr; > > > + int ret

[PATCH 1/1] net: wan : hdlc: use setup_timer() helper

2017-09-21 Thread Allen Pais
Use setup_timer function instead of initializing timer with the function and data fields. Signed-off-by: Allen Pais --- drivers/net/wan/hdlc_fr.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/wan/hdlc_fr.c b/drivers/net/wan/hdlc_fr.c index 78596e4..

[PATCH 1/1] net: usb: catc: use setup_timer() helper

2017-09-21 Thread Allen Pais
Use setup_timer function instead of initializing timer with the function and data fields. Signed-off-by: Allen Pais --- drivers/net/usb/catc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/usb/catc.c b/drivers/net/usb/catc.c index dbc9031..aeb62e1 100

[PATCH 1/1] net: ti: netcp: use setup_timer

2017-09-21 Thread Allen Pais
Use setup_timer function instead of initializing timer with the function and data fields. Signed-off-by: Allen Pais --- drivers/net/ethernet/ti/netcp_ethss.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/ti/netcp_ethss.c b/drivers/net/ethe

Re: [PATCH net-next] bpf: Optimize lpm trie delete

2017-09-21 Thread Craig Gallek
On Wed, Sep 20, 2017 at 6:56 PM, Daniel Mack wrote: > On 09/20/2017 08:51 PM, Craig Gallek wrote: >> On Wed, Sep 20, 2017 at 12:51 PM, Daniel Mack wrote: >>> Hi Craig, >>> >>> Thanks, this looks much cleaner already :) >>> >>> On 09/20/2017 06:22 PM, Craig Gallek wrote: diff --git a/kernel/b

Re: Latest net-next from GIT panic

2017-09-21 Thread Paweł Staszewski
W dniu 2017-09-21 o 13:31, Paweł Staszewski pisze: W dniu 2017-09-21 o 13:03, Eric Dumazet pisze: OK we have two problems here 1) We need to unify skb_dst_force()  ( for net tree ) 2) Vlan devices should try to correctly handle IFF_XMIT_DST_RELEASE from lower device. This will considerably

[net-next 0/2] add device MTU validation check

2017-09-21 Thread Zhang Shengju
This patch serial add device MTU validation check, so that only valid mtu value can be set when adding new device. Zhang Shengju (2): dummy: add device MTU validation check ifb: add device MTU validation check drivers/net/dummy.c | 8 drivers/net/ifb.c | 8 2 files chang

[net-next 1/2] dummy: add device MTU validation check

2017-09-21 Thread Zhang Shengju
Currently, any mtu value can be assigned when adding a new dummy device: [~]# ip link add name dummy1 mtu 10 type dummy [~]# ip link show dummy1 15: dummy1: mtu 10 qdisc noop state DOWN mode DEFAULT group default qlen 1000 link/ether 0a:61:6b:16:14:ce brd ff:ff:ff:ff:ff:ff This patch

[net-next 2/2] ifb: add device MTU validation check

2017-09-21 Thread Zhang Shengju
Currently, any mtu value can be assigned when adding a new ifb device: [~]# ip link add name ifb2 mtu 10 type ifb [~]# ip link show ifb2 18: ifb2: mtu 10 qdisc noop state DOWN mode DEFAULT group default qlen 32 link/ether 7a:bf:f4:63:da:d1 brd ff:ff:ff:ff:ff:ff This patch adds device

[PATCH net-next] net: mvpp2: phylink support

2017-09-21 Thread Antoine Tenart
Convert the PPv2 driver to use phylink, which models the MAC to PHY link. The phylink support is made such a way the GoP link IRQ can still be used: the two modes are incompatible and the GoP link IRQ will be used if no PHY is described in the device tree. This is the same behaviour as before. Sig

Re: [PATCH net] bpf: one perf event close won't free bpf program attached by another perf event

2017-09-21 Thread Steven Rostedt
On Thu, 21 Sep 2017 13:17:06 +0200 Peter Zijlstra wrote: > I suspect that would break a fair bunch of bpf proglets, since the data > access to the trace data would be completely different, but it would be > much nicer to not have this distinction based on event type. Maybe this would be a good t

Re: [v2,1/3] can: m_can: Make hclk optional

2017-09-21 Thread Sekhar Nori
On Thursday 21 September 2017 06:01 AM, Franklin S Cooper Jr wrote: > > > On 08/24/2017 03:00 AM, Sekhar Nori wrote: >> + some OMAP folks and Linux OMAP list >> >> On Tuesday 25 July 2017 04:21 AM, Franklin Cooper wrote: >>> Hclk is the MCAN's interface clock. However, for OMAP based devices such

Re: [PATCH net-next 2/2] net: dsa: lan9303: Add basic offloading of unicast traffic

2017-09-21 Thread Andrew Lunn
Hi Egil > +static void lan9303_bridge_ports(struct lan9303 *chip) > +{ > + /* ports bridged: remove mirroring */ > + lan9303_write_switch_reg(chip, LAN9303_SWE_PORT_MIRROR, 0); > +} Could you replace the 0 with something symbolic which makes this easier to understand. #define LAN9303_SWE

Re: RTL8192EE PCIe Wireless Network Adapter crashed with linux-4.13

2017-09-21 Thread Larry Finger
On 09/21/2017 06:37 AM, Zwindl wrote: Hi, I've reported to archlinux's bugzilla, and finally found out the flag which caused that issue, it's the `CONFIG_INTEL_IOMMU_DEFAULT_ON=y` flag, I think may this is a kernel bug, more details at https://bugs.archlinux.org/task/55665 My standard kernel h

tg3 pxe weirdness

2017-09-21 Thread Berend De Schouwer
Hi, I've got a machine with a Broadcom bcm5762c, using the tg3 driver, that fails to receive network packets under some very specific conditions. It works perfectly using a 1Gbps switch. If, however, it first uses PXE and then loads the Linux tg3 driver, and the switch is 100Mbps, it no longer r

Re: [PATCH net 1/3] net: mvpp2: fix the dma_mask and coherent_dma_mask settings for PPv2.2

2017-09-21 Thread Antoine Tenart
Hi David, On Mon, Sep 18, 2017 at 05:18:58PM -0700, David Miller wrote: > From: Antoine Tenart > Date: Mon, 18 Sep 2017 15:04:06 +0200 > > > The dev->dma_mask usually points to dev->coherent_dma_mask. This is an > > issue as setting both of them will override the other. This is > > problematic h

Re: [PATCH net-next 2/2] net: dsa: lan9303: Add basic offloading of unicast traffic

2017-09-21 Thread Vivien Didelot
Hi Egil, Egil Hjelmeland writes: > When both user ports are joined to the same bridge, the normal > HW MAC learning is enabled. This means that unicast traffic is forwarded > in HW. > > If one of the user ports leave the bridge, > the ports goes back to the initial separated operation. > > Port

Re: [PATCH net 2/4] net:ethernet:aquantia: Fix Tx queue hangups

2017-09-21 Thread Igor Russkikh
Thanks for the comments, Yunsheng, >> >> +static int aq_nic_update_link_status(struct aq_nic_s *self) >> +{ >> +int err = self->aq_hw_ops.hw_get_link_status(self->aq_hw); >> + >> +if (err < 0) >> +return -1; > why not just return err? Agreed, that could be improved. >> +

Re: [PATCH net-next 1/2] net: dsa: lan9303: Move tag setup to new lan9303_setup_tagging

2017-09-21 Thread Vivien Didelot
Hi Egil, Egil Hjelmeland writes: > Prepare for next patch: > Move tag setup from lan9303_separate_ports() to new function > lan9303_setup_tagging() > > Signed-off-by: Egil Hjelmeland Minor styling issues, otherwise LGTM: Reviewed-by: Vivien Didelot > +/* forward special tagged packets from

Re: RTL8192EE PCIe Wireless Network Adapter crashed with linux-4.13

2017-09-21 Thread Kalle Valo
Larry Finger writes: > On 09/21/2017 06:37 AM, Zwindl wrote: >> Hi, I've reported to archlinux's bugzilla, and finally found out the >> flag which caused that issue, it's the >> `CONFIG_INTEL_IOMMU_DEFAULT_ON=y` flag, I think may this is a kernel >> bug, more details at https://bugs.archlinux.org

[PATCH net-next] net: vrf: remove skb_dst_force() after skb_dst_set()

2017-09-21 Thread Eric Dumazet
From: Eric Dumazet skb_dst_set(skb, dst) installs a normal (refcounted) dst, there is no point using skb_dst_force(skb) Signed-off-by: Eric Dumazet --- drivers/net/vrf.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/vrf.c b/drivers/net/vrf.c index 9b243e6f3008bb5319844412c

Re: [PATCH net-next] net: vrf: remove skb_dst_force() after skb_dst_set()

2017-09-21 Thread David Ahern
On 9/21/17 8:50 AM, Eric Dumazet wrote: > From: Eric Dumazet > > skb_dst_set(skb, dst) installs a normal (refcounted) dst, there is no > point using skb_dst_force(skb) > > Signed-off-by: Eric Dumazet > --- > drivers/net/vrf.c |1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/

Re: Latest net-next from GIT panic

2017-09-21 Thread Eric Dumazet
On Thu, 2017-09-21 at 15:18 +0200, Paweł Staszewski wrote: > ok after adding patch all is working from now for about 1 hour of normal > traffic witc all bgp sessions connected and about 600k prefixes in kernel. Great, I am doing to submit an official patch, uniting skb_dst_force() and skb_dst_f

Re: [net-next 1/2] dummy: add device MTU validation check

2017-09-21 Thread Eric Dumazet
On Thu, 2017-09-21 at 21:32 +0800, Zhang Shengju wrote: > Currently, any mtu value can be assigned when adding a new dummy device: > [~]# ip link add name dummy1 mtu 10 type dummy > [~]# ip link show dummy1 > 15: dummy1: mtu 10 qdisc noop state DOWN mode DEFAULT > group default qlen 1000

Re: [PATCH] ath10: mark PM functions as __maybe_unused

2017-09-21 Thread Kalle Valo
Arnd Bergmann writes: > When CONFIG_PM_SLEEP is disabled, we get a compile-time > warning: > > drivers/net/wireless/ath/ath10k/pci.c:3417:12: error: 'ath10k_pci_pm_resume' > defined but not used [-Werror=unused-function] > static int ath10k_pci_pm_resume(struct device *dev) > ^~

Fw: [Bug 197015] New: Message at boot

2017-09-21 Thread Stephen Hemminger
Begin forwarded message: Date: Thu, 21 Sep 2017 11:45:01 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 197015] New: Message at boot https://bugzilla.kernel.org/show_bug.cgi?id=197015 Bug ID: 197015 Summary: Message at boot

Re: [PATCH net-next v2] bridge: also trigger RTM_NEWLINK when interface is released from bridge

2017-09-21 Thread Roopa Prabhu
On Thu, Sep 21, 2017 at 3:04 AM, Vincent Bernat wrote: > ❦ 20 septembre 2017 16:21 -0700, Stephen Hemminger > : > >> The one concern is that ports added or removed through ioctl should >> cause same events as doing the same thing via netlink. Some users use >> brctl (ioctl) and others use newer

[PATCH net-next] bpf/verifier: improve disassembly of BPF_END instructions

2017-09-21 Thread Edward Cree
print_bpf_insn() was treating all BPF_ALU[64] the same, but BPF_END has a different structure: it has a size in insn->imm (even if it's BPF_X) and uses the BPF_SRC (X or K) to indicate which endianness to use. So it needs different code to print it. Signed-off-by: Edward Cree --- It's not the

Re: [net-next 2/2] ifb: add device MTU validation check

2017-09-21 Thread Stephen Hemminger
On Thu, 21 Sep 2017 21:32:02 +0800 Zhang Shengju wrote: > Currently, any mtu value can be assigned when adding a new ifb device: > [~]# ip link add name ifb2 mtu 10 type ifb > [~]# ip link show ifb2 > 18: ifb2: mtu 10 qdisc noop state DOWN mode DEFAULT > group default qlen 32 > link

Re: [net-next v3] bridge: trigger RTM_NEWLINK when interface is modified by bridge ioctl

2017-09-21 Thread Stephen Hemminger
On Thu, 21 Sep 2017 12:05:25 +0200 Vincent Bernat wrote: > Currently, there is a difference in netlink events received when an > interface is modified through bridge ioctl() or through netlink. This > patch generates additional events when an interface is added to or > removed from a bridge via i

Re: [PATCH net-next v5 1/4] bpf: add helper bpf_perf_event_read_value for perf event array map

2017-09-21 Thread Alexei Starovoitov
On 9/20/17 4:07 PM, David Miller wrote: From: Peter Zijlstra Date: Wed, 20 Sep 2017 19:26:51 +0200 Dave, could we have this in a topic tree of sorts, because I have a pending series to rework all the timekeeping and it might be nice to not have sfr run into all sorts of conflicts. If you wan

  1   2   3   4   >