On Fri 2017-09-29 18:45:19, tristram...@microchip.com wrote:
> > > > > > Similar code will be needed by other drivers, right?
> > > > >
> > > > > Although KSZ8795 and KSZ8895 may use the same code, the other
> > > > > chips will have different code.
> > > >
> > > > Ok, please make sure code is shar
On Fri, Sep 29, 2017 at 07:19:17PM +, tristram...@microchip.com wrote:
> > > My concern is if a task is already running with SPI access to a lot
> > > of registers like reading the 32 MIB counters in every port of the
> > > switch, another register access has to wait until they are finished.
>
> > My concern is if a task is already running with SPI access to a lot
> > of registers like reading the 32 MIB counters in every port of the
> > switch, another register access has to wait until they are finished.
>
> Why does it have to wait? Looking at the code in
> ksz_get_ethtool_stats(), yo
> On Mon 2017-09-18 20:27:13, tristram...@microchip.com wrote:
> > > > +/**
> > > > + * Some counters do not need to be read too often because they are
> less
> > > likely
> > > > + * to increase much.
> > > > + */
> > >
> > > What does comment mean? Are you caching statistics, and updating
> > > d
> My concern is if a task is already running with SPI access to a lot
> of registers like reading the 32 MIB counters in every port of the
> switch, another register access has to wait until they are finished.
Why does it have to wait? Looking at the code in
ksz_get_ethtool_stats(), you don't take
> > > > > Similar code will be needed by other drivers, right?
> > > >
> > > > Although KSZ8795 and KSZ8895 may use the same code, the other
> > > > chips will have different code.
> > >
> > > Ok, please make sure code is shared between these two.
> >
> > The exact function probably cannot be share
; nathan.leigh.con...@gmail.com; vivien.dide...@savoirfairelinux.com;
> f.faine...@gmail.com; netdev@vger.kernel.org; linux-
> ker...@vger.kernel.org; Woojung Huh - C21699
> Subject: Re: [PATCH RFC 3/5] Add KSZ8795 switch driver
>
> On Fri, Sep 29, 2017 at 09:14:26AM +, David La
On Fri, Sep 29, 2017 at 09:14:26AM +, David Laight wrote:
> From: Andrew Lunn
> > Sent: 28 September 2017 20:34
> ...
> > > There are 34 counters. In normal case using generic bus I/O or PCI to
> > > read them
> > > is very quick, but the switch is mostly accessed using SPI, or even I2C.
>
From: Andrew Lunn
> Sent: 28 September 2017 20:34
...
> > There are 34 counters. In normal case using generic bus I/O or PCI to read
> > them
> > is very quick, but the switch is mostly accessed using SPI, or even I2C.
> > As the SPI
> > access is very slow.
>
> How slow is it? The Marvell swi
On Mon, Sep 18, 2017 at 08:27:13PM +, tristram...@microchip.com wrote:
> > > +/**
> > > + * Some counters do not need to be read too often because they are less
> > likely
> > > + * to increase much.
> > > + */
> >
> > What does comment mean? Are you caching statistics, and updating
> > differ
On 09/28/2017 11:40 AM, Pavel Machek wrote:
> Hi!
>
> On Mon 2017-09-18 20:27:13, tristram...@microchip.com wrote:
+/**
+ * Some counters do not need to be read too often because they are less
>>> likely
+ * to increase much.
+ */
>>>
>>> What does comment mean? Are you caching
Hi!
On Mon 2017-09-18 20:27:13, tristram...@microchip.com wrote:
> > > +/**
> > > + * Some counters do not need to be read too often because they are less
> > likely
> > > + * to increase much.
> > > + */
> >
> > What does comment mean? Are you caching statistics, and updating
> > different value
> > > > Similar code will be needed by other drivers, right?
> > >
> > > Although KSZ8795 and KSZ8895 may use the same code, the other
> > > chips will have different code.
> >
> > Ok, please make sure code is shared between these two.
>
> The exact function probably cannot be shared between KSZ8
> > +/**
> > + * Some counters do not need to be read too often because they are less
> likely
> > + * to increase much.
> > + */
>
> What does comment mean? Are you caching statistics, and updating
> different values at different rates?
>
There are 34 counters. In normal case using generic bus
nathan.leigh.con...@gmail.com;
> > vivien.dide...@savoirfairelinux.com; f.faine...@gmail.com;
> > netdev@vger.kernel.org; linux-ker...@vger.kernel.org; Woojung Huh -
> > C21699
> > Subject: Re: [PATCH RFC 3/5] Add KSZ8795 switch driver
> >
> > Hi!
>
mail.com;
> netdev@vger.kernel.org; linux-ker...@vger.kernel.org; Woojung Huh -
> C21699
> Subject: Re: [PATCH RFC 3/5] Add KSZ8795 switch driver
>
> Hi!
>
> > > > + default:
> > > > + processed = false;
> > > >
Hi!
> > > + default:
> > > + processed = false;
> > > + break;
> > > + }
> > > + if (processed)
> > > + *val = data;
> > > +}
> >
> > Similar code will be needed by other drivers, right?
>
> Although KSZ8795 and KSZ8895 may use the same code, the other
> chips will have d
> > > > @@ -0,0 +1,2066 @@
> > > > +/*
> > > > + * Microchip KSZ8795 switch driver
> > > > + *
> > > > + * Copyright (C) 2017 Microchip Technology Inc.
> > > > + * Tristram Ha
> > > > + *
> > > > + * Permission to use, copy, modify, and/or distribute this software for
> any
> > > > + * purpose
> > > @@ -0,0 +1,2066 @@
> > > +/*
> > > + * Microchip KSZ8795 switch driver
> > > + *
> > > + * Copyright (C) 2017 Microchip Technology Inc.
> > > + * Tristram Ha
> > > + *
> > > + * Permission to use, copy, modify, and/or distribute this software for
> > > any
> > > + * purpose with or wi
mail.com;
> netdev@vger.kernel.org; linux-ker...@vger.kernel.org; Woojung Huh - C21699
> Subject: Re: [PATCH RFC 3/5] Add KSZ8795 switch driver
>
> On Thu 2017-09-07 21:17:16, tristram...@microchip.com wrote:
> > From: Tristram Ha
> >
> > Add KSZ8795 switch support with function
On Thu 2017-09-07 21:17:16, tristram...@microchip.com wrote:
> From: Tristram Ha
>
> Add KSZ8795 switch support with function code.
English? "Add KSZ8795 switch support." ?
> Signed-off-by: Tristram Ha
> ---
> diff --git a/drivers/net/dsa/microchip/ksz8795.c
> b/drivers/net/dsa/microchip/ksz8
On Thu, Sep 07, 2017 at 09:17:16PM +, tristram...@microchip.com wrote:
> From: Tristram Ha
>
> Add KSZ8795 switch support with function code.
>
> Signed-off-by: Tristram Ha
> ---
> diff --git a/drivers/net/dsa/microchip/ksz8795.c
> b/drivers/net/dsa/microchip/ksz8795.c
> new file mode 1006
22 matches
Mail list logo
