> > > > > Similar code will be needed by other drivers, right? > > > > > > > > Although KSZ8795 and KSZ8895 may use the same code, the other > > > > chips will have different code. > > > > > > Ok, please make sure code is shared between these two. > > > > The exact function probably cannot be shared between KSZ8795 > > and KSZ8895 drivers because although the register constants look > > the same but their exact locations are different in the 2 chips. > > Put the code into header as static inline and include it from both > places? >
Although KSZ8795 and KSZ8895 share the same code when simulating the PHY register access, even though the exact registers are not the same, this code needs a little modification for another chip. It also looks too large to put in a header.
