Re: [patch v2] net/mlx5: missing error code in esw_create_offloads_fdb_table()

2016-07-14 Thread Leon Romanovsky
On Wed, Jul 13, 2016 at 11:54:54AM -0600, Jason Gunthorpe wrote: > On Wed, Jul 13, 2016 at 02:48:44PM +0300, Dan Carpenter wrote: > > We accidentally return success when we had intended to return an error > > code. > > > > Fixes: 69697b6e2086 ('net/mlx5: E-Switch, Add support for the sriov > > of

Re: [patch v2] net/mlx5: missing error code in esw_create_offloads_fdb_table()

2016-07-13 Thread Jason Gunthorpe
On Wed, Jul 13, 2016 at 02:48:44PM +0300, Dan Carpenter wrote: > We accidentally return success when we had intended to return an error > code. > > Fixes: 69697b6e2086 ('net/mlx5: E-Switch, Add support for the sriov offloads > mode') > Signed-off-by: Dan Carpenter > v2: return -ENOTSUPP instead

Re: [patch v2] net/mlx5: missing error code in esw_create_offloads_fdb_table()

2016-07-13 Thread Leon Romanovsky
On Wed, Jul 13, 2016 at 02:48:44PM +0300, Dan Carpenter wrote: > We accidentally return success when we had intended to return an error > code. > > Fixes: 69697b6e2086 ('net/mlx5: E-Switch, Add support for the sriov offloads > mode') > Signed-off-by: Dan Carpenter > --- > v2: return -ENOTSUPP in

Re: [patch v2] net/mlx5: missing error code in esw_create_offloads_fdb_table()

2016-07-13 Thread Matan Barak
On 13/07/2016 14:48, Dan Carpenter wrote: We accidentally return success when we had intended to return an error code. Fixes: 69697b6e2086 ('net/mlx5: E-Switch, Add support for the sriov offloads mode') Signed-off-by: Dan Carpenter --- v2: return -ENOTSUPP instead --EINVAL diff --git a/driver

Re: [patch v2] net/mlx5: missing error code in esw_create_offloads_fdb_table()

2016-07-13 Thread Matan Barak
On 13/07/2016 16:04, Leon Romanovsky wrote: On Wed, Jul 13, 2016 at 02:48:44PM +0300, Dan Carpenter wrote: We accidentally return success when we had intended to return an error code. Fixes: 69697b6e2086 ('net/mlx5: E-Switch, Add support for the sriov offloads mode') Signed-off-by: Dan Carpent