On 10/20/20 12:45 AM, Jiri Pirko wrote:
> I prefer long and easy to understand.
and the code needs to be readable as well. There is middle ground here
and reasonable naming schemes.
Nelson
>> Subject: Re: [iproute2-next v3] devlink: display elapsed time during flash
>> update
>>
>> On 10/14/20 4:31 PM, Jacob Keller wrote:
>> > For some devices, updating the flash can take significant time during
>> > operations where no status can mean
On 10/19/20 1:20 PM, Jakub Kicinski wrote:
> On Mon, 19 Oct 2020 19:05:34 + Keller, Jacob E wrote:
>>> The DEVLINK attributes are ridiculously long --
>>> DEVLINK_ATTR_FLASH_UPDATE_STATUS_TIMEOUT is 40 characters -- which
>>> forces really long code lines or oddly wrapped lines. Going forward
>
On Mon, 19 Oct 2020 19:05:34 + Keller, Jacob E wrote:
> > The DEVLINK attributes are ridiculously long --
> > DEVLINK_ATTR_FLASH_UPDATE_STATUS_TIMEOUT is 40 characters -- which
> > forces really long code lines or oddly wrapped lines. Going forward
> > please consider abbreviations on name comp
> -Original Message-
> From: David Ahern
> Sent: Saturday, October 17, 2020 8:35 AM
> To: Keller, Jacob E ; netdev@vger.kernel.org; Jiri
> Pirko
>
> Cc: Shannon Nelson
> Subject: Re: [iproute2-next v3] devlink: display elapsed time during flash
> update
>
On 10/14/20 4:31 PM, Jacob Keller wrote:
> For some devices, updating the flash can take significant time during
> operations where no status can meaningfully be reported. This can be
> somewhat confusing to a user who sees devlink appear to hang on the
> terminal waiting for the device to update.
Thu, Oct 15, 2020 at 12:31:04AM CEST, jacob.e.kel...@intel.com wrote:
>For some devices, updating the flash can take significant time during
>operations where no status can meaningfully be reported. This can be
>somewhat confusing to a user who sees devlink appear to hang on the
>terminal waiting f
For some devices, updating the flash can take significant time during
operations where no status can meaningfully be reported. This can be
somewhat confusing to a user who sees devlink appear to hang on the
terminal waiting for the device to update.
Recent changes to the kernel interface allow suc
