On 10/19/20 1:20 PM, Jakub Kicinski wrote: > On Mon, 19 Oct 2020 19:05:34 +0000 Keller, Jacob E wrote: >>> The DEVLINK attributes are ridiculously long -- >>> DEVLINK_ATTR_FLASH_UPDATE_STATUS_TIMEOUT is 40 characters -- which >>> forces really long code lines or oddly wrapped lines. Going forward >>> please consider abbreviations on name components to reduce their lengths. >> >> This is probably a larger discussion, since basically every devlink >> attribute name is long. >> >> Jiri, Jakub, any thoughts on this? I'd like to see whatever abbreviation >> scheme we use be consistent. > > As David said - let's keep an eye on this going forward. We already > pushed back with Moshe's live reload work. > > If you really want to make things better for this particular name > you could probably drop the word _STATUS from it. >
and typical strategies - like dropping vowels. DEVLINK_ATTR_ is the established prefix so every attribute starts at 13 characters. In this case dropping STATUS and shortening TIMEOUT so it becomes DEVLINK_ATTR_FLASH_UPDATE_TMOUT does not overly harm the readability yet drops the char count to 31. Still long but is an example of what can be done.
