Re: [Patch net-next 2/2] net: dump whole skb data in netdev_rx_csum_fault()

2019-01-10 Thread Willem de Bruijn
On Wed, Dec 5, 2018 at 12:33 PM Peter Oskolkov wrote: > > FWIW, I find the patch really useful - I applied it to my local dev > repo (with minor changes) and use skb_dump() a lot now. It would be > great if it makes its way into net-next in some form. +1 very informative. skb_warn_bad_offload wo

Re: [Patch net-next 2/2] net: dump whole skb data in netdev_rx_csum_fault()

2018-12-05 Thread Peter Oskolkov
FWIW, I find the patch really useful - I applied it to my local dev repo (with minor changes) and use skb_dump() a lot now. It would be great if it makes its way into net-next in some form. On Fri, Nov 30, 2018 at 12:15 PM Saeed Mahameed wrote: > > On Thu, 2018-11-22 at 17:45 -0800, Cong Wang wrot

Re: [Patch net-next 2/2] net: dump whole skb data in netdev_rx_csum_fault()

2018-11-30 Thread Saeed Mahameed
On Thu, 2018-11-22 at 17:45 -0800, Cong Wang wrote: > On Wed, Nov 21, 2018 at 11:33 AM Saeed Mahameed > wrote: > > On Wed, 2018-11-21 at 10:26 -0800, Eric Dumazet wrote: > > > On Wed, Nov 21, 2018 at 10:17 AM Cong Wang < > > > xiyou.wangc...@gmail.com> > > > wrote: > > > > On Wed, Nov 21, 2018 at

Re: [Patch net-next 2/2] net: dump whole skb data in netdev_rx_csum_fault()

2018-11-22 Thread Cong Wang
On Wed, Nov 21, 2018 at 11:33 AM Saeed Mahameed wrote: > > On Wed, 2018-11-21 at 10:26 -0800, Eric Dumazet wrote: > > On Wed, Nov 21, 2018 at 10:17 AM Cong Wang > > wrote: > > > On Wed, Nov 21, 2018 at 5:05 AM Eric Dumazet < > > > eric.duma...@gmail.com> wrote: > > > > > > > > > > > > On 11/20/20

Re: [Patch net-next 2/2] net: dump whole skb data in netdev_rx_csum_fault()

2018-11-22 Thread Cong Wang
On Wed, Nov 21, 2018 at 10:26 AM Eric Dumazet wrote: > > On Wed, Nov 21, 2018 at 10:17 AM Cong Wang wrote: > > > > On Wed, Nov 21, 2018 at 5:05 AM Eric Dumazet wrote: > > > > > > > > > > > > On 11/20/2018 06:13 PM, Cong Wang wrote: > > > > Currently, we only dump a few selected skb fields in > >

Re: [Patch net-next 2/2] net: dump whole skb data in netdev_rx_csum_fault()

2018-11-21 Thread Saeed Mahameed
On Wed, 2018-11-21 at 10:26 -0800, Eric Dumazet wrote: > On Wed, Nov 21, 2018 at 10:17 AM Cong Wang > wrote: > > On Wed, Nov 21, 2018 at 5:05 AM Eric Dumazet < > > eric.duma...@gmail.com> wrote: > > > > > > > > > On 11/20/2018 06:13 PM, Cong Wang wrote: > > > > Currently, we only dump a few sele

Re: [Patch net-next 2/2] net: dump whole skb data in netdev_rx_csum_fault()

2018-11-21 Thread Eric Dumazet
On Wed, Nov 21, 2018 at 10:17 AM Cong Wang wrote: > > On Wed, Nov 21, 2018 at 5:05 AM Eric Dumazet wrote: > > > > > > > > On 11/20/2018 06:13 PM, Cong Wang wrote: > > > Currently, we only dump a few selected skb fields in > > > netdev_rx_csum_fault(). It is not suffient for debugging checksum > >

Re: [Patch net-next 2/2] net: dump whole skb data in netdev_rx_csum_fault()

2018-11-21 Thread Cong Wang
On Wed, Nov 21, 2018 at 5:05 AM Eric Dumazet wrote: > > > > On 11/20/2018 06:13 PM, Cong Wang wrote: > > Currently, we only dump a few selected skb fields in > > netdev_rx_csum_fault(). It is not suffient for debugging checksum > > fault. This patch introduces skb_dump() which dumps skb mac header

Re: [Patch net-next 2/2] net: dump whole skb data in netdev_rx_csum_fault()

2018-11-21 Thread Eric Dumazet
On 11/20/2018 06:13 PM, Cong Wang wrote: > Currently, we only dump a few selected skb fields in > netdev_rx_csum_fault(). It is not suffient for debugging checksum > fault. This patch introduces skb_dump() which dumps skb mac header, > network header and its whole skb->data too. > > Cc: Herbert

[Patch net-next 2/2] net: dump whole skb data in netdev_rx_csum_fault()

2018-11-20 Thread Cong Wang
Currently, we only dump a few selected skb fields in netdev_rx_csum_fault(). It is not suffient for debugging checksum fault. This patch introduces skb_dump() which dumps skb mac header, network header and its whole skb->data too. Cc: Herbert Xu Cc: Eric Dumazet Cc: David Miller Signed-off-by: