On 11/20/2018 06:13 PM, Cong Wang wrote:
> Currently, we only dump a few selected skb fields in
> netdev_rx_csum_fault(). It is not suffient for debugging checksum
> fault. This patch introduces skb_dump() which dumps skb mac header,
> network header and its whole skb->data too.
>
> Cc: Herbert Xu <herb...@gondor.apana.org.au>
> Cc: Eric Dumazet <eduma...@google.com>
> Cc: David Miller <da...@davemloft.net>
> Signed-off-by: Cong Wang <xiyou.wangc...@gmail.com>
> ---
> + print_hex_dump(level, "skb data: ", DUMP_PREFIX_OFFSET, 16, 1,
> + skb->data, skb->len, false);
As I mentioned to David, we want all the bytes that were maybe already pulled
(skb->head starting point, not skb->data)
Also we will miss the trimmed bytes if there were padding data.
And it seems the various bugs we have are all tied to the pulled or trimmed
bytes.
Thanks.
