Re: [PATCH net-next] net/sched: pkt_cls: change tc actions order to be as the user sets

2016-09-27 Thread Hadar Hen Zion
On Mon, Sep 26, 2016 at 11:34 PM, Cong Wang wrote: > On Sun, Sep 25, 2016 at 11:02 PM, Hadar Hen Zion > wrote: >> On Mon, Sep 26, 2016 at 7:31 AM, Cong Wang wrote: >>> On Sun, Sep 25, 2016 at 7:39 AM, Jamal Hadi Salim wrote: On 16-09-25 10:08 AM, Hadar Hen Zion wrote: > > Currently

Re: [PATCH net-next] net/sched: pkt_cls: change tc actions order to be as the user sets

2016-09-26 Thread Cong Wang
On Sun, Sep 25, 2016 at 11:02 PM, Hadar Hen Zion wrote: > On Mon, Sep 26, 2016 at 7:31 AM, Cong Wang wrote: >> On Sun, Sep 25, 2016 at 7:39 AM, Jamal Hadi Salim wrote: >>> On 16-09-25 10:08 AM, Hadar Hen Zion wrote: Currently the created tc actions list is reversed against the order >>

Re: [PATCH net-next] net/sched: pkt_cls: change tc actions order to be as the user sets

2016-09-26 Thread Jamal Hadi Salim
On 16-09-25 10:08 AM, Hadar Hen Zion wrote: Currently the created tc actions list is reversed against the order set by the user. Change the actions list order to be the same as was set by the user. Signed-off-by: Hadar Hen Zion Acked-by: Jamal Hadi Salim cheers, jamal

Re: [PATCH net-next] net/sched: pkt_cls: change tc actions order to be as the user sets

2016-09-26 Thread Jamal Hadi Salim
On 16-09-26 02:02 AM, Hadar Hen Zion wrote: On Mon, Sep 26, 2016 at 7:31 AM, Cong Wang wrote: The reason is we use action->order as an nested attribute, so the order in the list doesn't matter, only action->order itself matters. The order in the list matters for offload drivers who use the

Re: [PATCH net-next] net/sched: pkt_cls: change tc actions order to be as the user sets

2016-09-25 Thread Hadar Hen Zion
On Mon, Sep 26, 2016 at 7:31 AM, Cong Wang wrote: > On Sun, Sep 25, 2016 at 7:39 AM, Jamal Hadi Salim wrote: >> On 16-09-25 10:08 AM, Hadar Hen Zion wrote: >>> >>> Currently the created tc actions list is reversed against the order >>> set by the user. >>> Change the actions list order to be the

Re: [PATCH net-next] net/sched: pkt_cls: change tc actions order to be as the user sets

2016-09-25 Thread Cong Wang
On Sun, Sep 25, 2016 at 7:39 AM, Jamal Hadi Salim wrote: > On 16-09-25 10:08 AM, Hadar Hen Zion wrote: >> >> Currently the created tc actions list is reversed against the order >> set by the user. >> Change the actions list order to be the same as was set by the user. >> > > > Did something break?

Re: [PATCH net-next] net/sched: pkt_cls: change tc actions order to be as the user sets

2016-09-25 Thread Jamal Hadi Salim
On 16-09-25 10:08 AM, Hadar Hen Zion wrote: Currently the created tc actions list is reversed against the order set by the user. Change the actions list order to be the same as was set by the user. Did something break? It seems to matter most for dumping. But even that didnt breaking. Looking

[PATCH net-next] net/sched: pkt_cls: change tc actions order to be as the user sets

2016-09-25 Thread Hadar Hen Zion
Currently the created tc actions list is reversed against the order set by the user. Change the actions list order to be the same as was set by the user. Signed-off-by: Hadar Hen Zion --- include/net/pkt_cls.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/net/pkt_cl