On Sun, Sep 25, 2016 at 11:02 PM, Hadar Hen Zion <had...@dev.mellanox.co.il> wrote: > On Mon, Sep 26, 2016 at 7:31 AM, Cong Wang <xiyou.wangc...@gmail.com> wrote: >> On Sun, Sep 25, 2016 at 7:39 AM, Jamal Hadi Salim <j...@mojatatu.com> wrote: >>> On 16-09-25 10:08 AM, Hadar Hen Zion wrote: >>>> >>>> Currently the created tc actions list is reversed against the order >>>> set by the user. >>>> Change the actions list order to be the same as was set by the user. >>>> >>> >>> >>> Did something break? It seems to matter most for dumping. But even that >>> didnt breaking. Looking at the latest net tree, i tried: >>> >> >> The reason is we use action->order as an nested attribute, so >> the order in the list doesn't matter, only action->order itself matters. > > The order in the list matters for offload drivers who use the > "tcf_exts_to_list" function and action->order parameter isn't usable > for them. > Why not keeping the actions in the same order as the user? isn't it > more elegant?
I don't object this patch since it affects offloading, I just explained why it doesn't affect dumping. Please add this to your changelog, to make it obvious. Thanks!
