Re: [PATCH iproute2] ip route: Make name of protocol 0 consistent

2017-02-07 Thread Stephen Hemminger
On Tue, 7 Feb 2017 14:51:45 -0700 David Ahern wrote: > On 2/7/17 2:40 PM, Stephen Hemminger wrote: > >> Reading the file changes the string in rtnl_rtprot_tab for > >> RTPROT_UNSPEC. Both string values -- "none" and "unspec" come from > >> iproute2, so my point is that string is inconsistent with

Re: [PATCH iproute2] ip route: Make name of protocol 0 consistent

2017-02-07 Thread David Ahern
On 2/7/17 2:40 PM, Stephen Hemminger wrote: >> Reading the file changes the string in rtnl_rtprot_tab for >> RTPROT_UNSPEC. Both string values -- "none" and "unspec" come from >> iproute2, so my point is that string is inconsistent within iproute2. > > Why not change the value in the table rtnl_rt

Re: [PATCH iproute2] ip route: Make name of protocol 0 consistent

2017-02-07 Thread Stephen Hemminger
On Mon, 6 Feb 2017 16:03:35 -0700 David Ahern wrote: > On 2/6/17 3:01 PM, Stephen Hemminger wrote: > > On Thu, 2 Feb 2017 09:22:06 -0800 > > David Ahern wrote: > > > >> iproute2 can inconsistently show the name of protocol 0 if a route with > >> a custom protocol is added. For example: > >>

Re: [PATCH iproute2] ip route: Make name of protocol 0 consistent

2017-02-07 Thread David Ahern
On 2/6/17 4:03 PM, David Ahern wrote: >> This doesn't look like a good solution, you loose the value of unspec. >> >> Just to clarify. You added a custom protocol value to netlink. >> And then you are using upstream iproute2 source to display the value. > > no. I am saying the string displayed for

Re: [PATCH iproute2] ip route: Make name of protocol 0 consistent

2017-02-06 Thread David Ahern
On 2/6/17 3:01 PM, Stephen Hemminger wrote: > On Thu, 2 Feb 2017 09:22:06 -0800 > David Ahern wrote: > >> iproute2 can inconsistently show the name of protocol 0 if a route with >> a custom protocol is added. For example: >> dsa@cartman:~$ ip -6 ro ls table all | egrep 'proto none|proto unspec

Re: [PATCH iproute2] ip route: Make name of protocol 0 consistent

2017-02-06 Thread Stephen Hemminger
On Thu, 2 Feb 2017 09:22:06 -0800 David Ahern wrote: > iproute2 can inconsistently show the name of protocol 0 if a route with > a custom protocol is added. For example: > dsa@cartman:~$ ip -6 ro ls table all | egrep 'proto none|proto unspec' > local ::1 dev lo table local proto none metr

[PATCH iproute2] ip route: Make name of protocol 0 consistent

2017-02-02 Thread David Ahern
iproute2 can inconsistently show the name of protocol 0 if a route with a custom protocol is added. For example: dsa@cartman:~$ ip -6 ro ls table all | egrep 'proto none|proto unspec' local ::1 dev lo table local proto none metric 0 pref medium local fe80::225:90ff:fecb:1c18 dev lo table