Re: [PATCH bpf-next 07/11] bpf: Add helper to retrieve socket in BPF

2018-09-14 Thread kbuild test robot
Hi Joe, Thank you for the patch! Yet something to improve: [auto build test ERROR on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Joe-Stringer/Add-socket-lookup-support/20180914-134632 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master config: x

Re: [PATCH bpf-next 07/11] bpf: Add helper to retrieve socket in BPF

2018-09-13 Thread kbuild test robot
Hi Joe, Thank you for the patch! Yet something to improve: [auto build test ERROR on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Joe-Stringer/Add-socket-lookup-support/20180914-134632 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master config: x

Re: [PATCH bpf-next 07/11] bpf: Add helper to retrieve socket in BPF

2018-09-13 Thread Alexei Starovoitov
On Thu, Sep 13, 2018 at 02:24:03PM -0700, Joe Stringer wrote: > On Thu, 13 Sep 2018 at 14:22, Alexei Starovoitov > wrote: > > > > On Thu, Sep 13, 2018 at 02:17:17PM -0700, Joe Stringer wrote: > > > On Thu, 13 Sep 2018 at 14:02, Alexei Starovoitov > > > wrote: > > > > > > > > On Thu, Sep 13, 2018

Re: [PATCH bpf-next 07/11] bpf: Add helper to retrieve socket in BPF

2018-09-13 Thread Joe Stringer
On Thu, 13 Sep 2018 at 14:22, Alexei Starovoitov wrote: > > On Thu, Sep 13, 2018 at 02:17:17PM -0700, Joe Stringer wrote: > > On Thu, 13 Sep 2018 at 14:02, Alexei Starovoitov > > wrote: > > > > > > On Thu, Sep 13, 2018 at 01:55:01PM -0700, Joe Stringer wrote: > > > > On Thu, 13 Sep 2018 at 12:06,

Re: [PATCH bpf-next 07/11] bpf: Add helper to retrieve socket in BPF

2018-09-13 Thread Alexei Starovoitov
On Thu, Sep 13, 2018 at 02:17:17PM -0700, Joe Stringer wrote: > On Thu, 13 Sep 2018 at 14:02, Alexei Starovoitov > wrote: > > > > On Thu, Sep 13, 2018 at 01:55:01PM -0700, Joe Stringer wrote: > > > On Thu, 13 Sep 2018 at 12:06, Alexei Starovoitov > > > wrote: > > > > > > > > On Wed, Sep 12, 2018

Re: [PATCH bpf-next 07/11] bpf: Add helper to retrieve socket in BPF

2018-09-13 Thread Joe Stringer
On Thu, 13 Sep 2018 at 14:02, Alexei Starovoitov wrote: > > On Thu, Sep 13, 2018 at 01:55:01PM -0700, Joe Stringer wrote: > > On Thu, 13 Sep 2018 at 12:06, Alexei Starovoitov > > wrote: > > > > > > On Wed, Sep 12, 2018 at 5:06 PM, Alexei Starovoitov > > > wrote: > > > > On Tue, Sep 11, 2018 at 0

Re: [PATCH bpf-next 07/11] bpf: Add helper to retrieve socket in BPF

2018-09-13 Thread Alexei Starovoitov
On Thu, Sep 13, 2018 at 01:55:01PM -0700, Joe Stringer wrote: > On Thu, 13 Sep 2018 at 12:06, Alexei Starovoitov > wrote: > > > > On Wed, Sep 12, 2018 at 5:06 PM, Alexei Starovoitov > > wrote: > > > On Tue, Sep 11, 2018 at 05:36:36PM -0700, Joe Stringer wrote: > > >> This patch adds new BPF helpe

Re: [PATCH bpf-next 07/11] bpf: Add helper to retrieve socket in BPF

2018-09-13 Thread Joe Stringer
On Thu, 13 Sep 2018 at 13:55, Joe Stringer wrote: > struct bpf_sock_tuple4 { > __be32 saddr; > __be32 daddr; > __be16 sport; > __be16 dport; > __u8 family; > }; > > struct bpf_sock_tuple6 { > __be32 saddr[4]; > __be32 daddr[4]; > __be16 sport; >

Re: [PATCH bpf-next 07/11] bpf: Add helper to retrieve socket in BPF

2018-09-13 Thread Joe Stringer
On Thu, 13 Sep 2018 at 12:06, Alexei Starovoitov wrote: > > On Wed, Sep 12, 2018 at 5:06 PM, Alexei Starovoitov > wrote: > > On Tue, Sep 11, 2018 at 05:36:36PM -0700, Joe Stringer wrote: > >> This patch adds new BPF helper functions, bpf_sk_lookup_tcp() and > >> bpf_sk_lookup_udp() which allows B

Re: [PATCH bpf-next 07/11] bpf: Add helper to retrieve socket in BPF

2018-09-13 Thread Alexei Starovoitov
On Wed, Sep 12, 2018 at 5:06 PM, Alexei Starovoitov wrote: > On Tue, Sep 11, 2018 at 05:36:36PM -0700, Joe Stringer wrote: >> This patch adds new BPF helper functions, bpf_sk_lookup_tcp() and >> bpf_sk_lookup_udp() which allows BPF programs to find out if there is a >> socket listening on this hos

Re: [PATCH bpf-next 07/11] bpf: Add helper to retrieve socket in BPF

2018-09-12 Thread Alexei Starovoitov
On Tue, Sep 11, 2018 at 05:36:36PM -0700, Joe Stringer wrote: > This patch adds new BPF helper functions, bpf_sk_lookup_tcp() and > bpf_sk_lookup_udp() which allows BPF programs to find out if there is a > socket listening on this host, and returns a socket pointer which the > BPF program can then

[PATCH bpf-next 07/11] bpf: Add helper to retrieve socket in BPF

2018-09-11 Thread Joe Stringer
This patch adds new BPF helper functions, bpf_sk_lookup_tcp() and bpf_sk_lookup_udp() which allows BPF programs to find out if there is a socket listening on this host, and returns a socket pointer which the BPF program can then access to determine, for instance, whether to forward or drop traffic.