Re: [PATCH] net: phy: phylink: fix SFP interface autodetection

2018-09-22 Thread Russell King - ARM Linux
On Sat, Sep 22, 2018 at 10:09:44PM +0300, Baruch Siach wrote: > When connecting a PHY to phylink use the detected interface. Otherwise, > the link fails to come up when the configured 'phy-mode' differs from > the SFP detected mode. > > This fixes 1GB SFP module link up on eth3 of the Macchiatobin

[PATCH] net: phy: phylink: fix SFP interface autodetection

2018-09-22 Thread Baruch Siach
When connecting a PHY to phylink use the detected interface. Otherwise, the link fails to come up when the configured 'phy-mode' differs from the SFP detected mode. This fixes 1GB SFP module link up on eth3 of the Macchiatobin board that is configured in the DT to "2500base-x" phy-mode. Fixes: 95

Re: [PATCH] net: phy: phylink: fix SFP interface autodetection

2018-09-17 Thread Baruch Siach
Hi Russell, Russell King - ARM Linux writes: > On Mon, Sep 17, 2018 at 05:19:57PM +0300, Baruch Siach wrote: >> When the switching to the SFP detected link mode update the main >> link_interface field as well. Otherwise, the link fails to come up when >> the configured 'phy-mode' defers from the

Re: [PATCH] net: phy: phylink: fix SFP interface autodetection

2018-09-17 Thread Russell King - ARM Linux
On Mon, Sep 17, 2018 at 05:19:57PM +0300, Baruch Siach wrote: > When the switching to the SFP detected link mode update the main > link_interface field as well. Otherwise, the link fails to come up when > the configured 'phy-mode' defers from the SFP detected mode. > > This fixes 1GB SFP module li

[PATCH] net: phy: phylink: fix SFP interface autodetection

2018-09-17 Thread Baruch Siach
When the switching to the SFP detected link mode update the main link_interface field as well. Otherwise, the link fails to come up when the configured 'phy-mode' defers from the SFP detected mode. This fixes 1GB SFP module link up on eth3 of the Macchiatobin board that is configured in the DT to