On Sat, Sep 22, 2018 at 10:09:44PM +0300, Baruch Siach wrote: > When connecting a PHY to phylink use the detected interface. Otherwise, > the link fails to come up when the configured 'phy-mode' differs from > the SFP detected mode. > > This fixes 1GB SFP module link up on eth3 of the Macchiatobin board that > is configured in the DT to "2500base-x" phy-mode.
What I actually meant is that a PHY attached from a SFP interface should use link_config.interface. A PHY attached as not part of a SFP interface should continue using the DT-parsed link_interface. What I envisaged seeing is phylink_connect_phy() being renamed to __phylink_connect_phy(), and taking the phy interface, phylink_sfp_connect_phy() calling __phylink_connect_phy() with link_config.interface, and a replacement phylink_connect_phy() which called __phylink_connect_phy() with link_interface. Sorry I wasn't explicit enough last time around. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 13.8Mbps down 630kbps up According to speedtest.net: 13Mbps down 490kbps up
