RD_IP6GRE devices.
>
> Fixes: 5c5670fae430 ("net/sched: Introduce sample tc action")
Reviewed-by: Yotam Gigi
> Signed-off-by: Davide Caratti
> ---
> net/sched/act_sample.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/sched/act_sample.c b/net/sch
errupt
>
> Add a TDC selftest to document that 'rate' is now being validated.
>
> Reported-by: Matteo Croce
> Fixes: 5c5670fae430 ("net/sched: Introduce sample tc action")
> Signed-off-by: Davide Caratti
Acked-by: Yotam Gigi
Thanks!
> ---
>
g
Reviewed-by: Yotam Gigi
> ---
> net/ife/ife.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/net/ife/ife.c b/net/ife/ife.c
> index 8632d2685efb..7c100034fbee 100644
> --- a/net/ife/ife.c
> +++ b/net/ife/ife.c
> @@ -70,6 +70,9 @@ void *ife_decode(struct
de
returns "metalen" - maybe it is better to change it too to return ifehdr_end?
If not, the caller has to calculate it himself for no particular reason.
Having both metalen and ifehdr_end is redundant, so we should stick to only
one of these.
Other than that,
Reviewed-by: Yotam
On Thu, Apr 19, 2018 at 12:35 AM, Alexander Aring wrote:
> We need to record stats for received metadata that we dont know how
> to process. Have find_decode_metaid() return -ENOENT to capture this.
Agree.
>
> Signed-off-by: Alexander Aring
Reviewed-by: Yotam Gigi
> -
On Tue, Mar 13, 2018 at 11:16 PM, Roman Mashak wrote:
Makes sense :)
Acked-by: Yotam Gigi
> Signed-off-by: Roman Mashak
> ---
> tc/m_sample.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tc/m_sample.c b/tc/m_sample.c
> index ff5ee
ot;ip route show"
command.
Example output:
$ ip mroute
(0.0.0.0, 239.255.0.1) Iif: sw1p7 Oifs: t_br0 State: resolved offload
(192.168.1.1, 239.255.0.1) Iif: sw1p7 Oifs: sw1p4 State: resolved offload
Signed-off-by: Yotam Gigi
---
ip/ipmroute.c | 2 ++
1 file changed, 2 insertions(+)
d
On 10/08/2017 12:42 PM, Nikolay Aleksandrov wrote:
> On 08/10/17 12:39, Nikolay Aleksandrov wrote:
>> On 08/10/17 08:23, Yotam Gigi wrote:
>>> On 10/05/2017 03:09 PM, Nikolay Aleksandrov wrote:
>>>> On 05/10/17 13:36, Jiri Pirko wrote:
>>>>> From: Yo
On 10/05/2017 03:09 PM, Nikolay Aleksandrov wrote:
> On 05/10/17 13:36, Jiri Pirko wrote:
>> From: Yotam Gigi
>>
>> Every bridge port is in one of four mcast router port states:
>> - MDB_RTR_TYPE_PERM - the port is set by the user to be an mrouter port
>&
On 10/03/2017 01:53 PM, Dan Carpenter wrote:
> mlxsw_afa_block_create() doesn't return error pointers, it returns NULL
> on error.
>
> Fixes: 0e14cacb ("mlxsw: spectrum: Add the multicast routing hardware
> logic")
> Signed-off-by: Dan Carpenter
Acked-b
On 10/03/2017 01:53 PM, Dan Carpenter wrote:
> We accidentally return success if the kmalloc_array() call fails.
>
> Fixes: 0e14cacb ("mlxsw: spectrum: Add the multicast routing hardware
> logic")
> Signed-off-by: Dan Carpenter
Acked-by: Yotam Gigi
>
> di
ot;Unitialized scalar value")
Thanks for that!
Reviewed-by: Yotam Gigi
>
> Fixes: c011ec1bbfd6 ("mlxsw: spectrum: Add the multicast routing offloading
> logic")
> Signed-off-by: Colin Ian King
> ---
> drivers/net/ethernet/mellanox/mlxsw/spectrum_mr.c | 4 +---
On 09/28/2017 08:56 PM, Florian Fainelli wrote:
> On 09/28/2017 10:34 AM, Jiri Pirko wrote:
>> From: Yotam Gigi
>>
>> Change the ipmr module to not forward packets if:
>> - The packet is marked with the offload_mr_fwd_mark, and
>> - Both input interface an
On 09/29/2017 12:50 PM, Nikolay Aleksandrov wrote:
> On 28/09/17 20:34, Jiri Pirko wrote:
>> From: Yotam Gigi
>>
>> In order to allow the ipmr module to do partial multicast forwarding
>> according to the device parent ID, add the device parent ID field to the
&
On 09/29/2017 12:45 PM, Nikolay Aleksandrov wrote:
> On 29/09/17 12:29, Nikolay Aleksandrov wrote:
>> On 28/09/17 20:34, Jiri Pirko wrote:
>>> From: Yotam Gigi
>>>
>>> In order to allow the ipmr module to do partial multicast forwarding
>>> according t
On 09/25/2017 01:02 PM, Nikolay Aleksandrov wrote:
> On 25/09/17 12:45, Jiri Pirko wrote:
>> Mon, Sep 25, 2017 at 03:28:21AM CEST, linyunsh...@huawei.com wrote:
>>> Hi, Jiri
>>>
>>> On 2017/9/25 1:22, Jiri Pirko wrote:
>>>> From: Yotam Gigi
>>
On 09/25/2017 12:36 PM, Nikolay Aleksandrov wrote:
> On 24/09/17 20:22, Jiri Pirko wrote:
>> From: Yotam Gigi
>>
>> Allow drivers, registered to the fib notification chain indicate whether a
>> multicast MFC route is offloaded or not, similarly to unicast routes. The
On 09/25/2017 01:40 PM, Nikolay Aleksandrov wrote:
> On 24/09/17 20:22, Jiri Pirko wrote:
>> From: Yotam Gigi
>>
>> Add the multicast router offloading logic, which is in charge of handling
>> the VIF and MFC notifications and translating it to the hardware logic API.
On 09/25/2017 04:48 AM, Yunsheng Lin wrote:
> Hi, Jiri
>
> On 2017/9/25 1:22, Jiri Pirko wrote:
>> From: Yotam Gigi
>>
>> Add the multicast router offloading logic, which is in charge of handling
>> the VIF and MFC notifications and translating it to the hardwar
On 09/25/2017 04:28 AM, Yunsheng Lin wrote:
> Hi, Jiri
>
> On 2017/9/25 1:22, Jiri Pirko wrote:
>> From: Yotam Gigi
>>
>> When the ipmr starts, it adds one default FIB rule that matches all packets
>> and sends them to the DEFAULT (multicast) FIB table. A more com
On 09/25/2017 04:19 AM, Yunsheng Lin wrote:
> Hi, Jiri
>
> On 2017/9/25 1:22, Jiri Pirko wrote:
>> From: Yotam Gigi
>>
>> Make the ipmr module register as a FIB notifier. To do that, implement both
>> the ipmr_seq_read and ipmr_dump ops.
>>
>> The ipm
On 09/22/2017 04:21 PM, Andrew Lunn wrote:
> On Fri, Sep 22, 2017 at 11:36:59AM +0300, Yotam Gigi wrote:
>> On 09/21/2017 06:26 PM, Andrew Lunn wrote:
>>>> +static void mlxsw_sp_mr_route_stats_update(struct mlxsw_sp *mlxsw_sp,
>>>> +
On 09/21/2017 06:26 PM, Andrew Lunn wrote:
>> +static void mlxsw_sp_mr_route_stats_update(struct mlxsw_sp *mlxsw_sp,
>> + struct mlxsw_sp_mr_route *mr_route)
>> +{
>> +struct mlxsw_sp_mr *mr = mlxsw_sp->mr;
>> +u64 packets, bytes;
>> +
>> +if (mr_ro
On 09/21/2017 02:19 PM, Nikolay Aleksandrov wrote:
> On 21/09/17 09:43, Jiri Pirko wrote:
>> From: Yotam Gigi
>>
>> Make the ipmr module register as a FIB notifier. To do that, implement both
>> the ipmr_seq_read and ipmr_dump ops.
>>
>> The ipmr_seq_rea
t; +++ b/net/sched/cls_matchall.c
> @@ -32,6 +32,7 @@ static int mall_classify(struct sk_buff *skb, const struct
> tcf_proto *tp,
> if (tc_skip_sw(head->flags))
> return -1;
>
> + *res = head->res;
> return tcf_exts_exec(skb, &head->exts, res);
> }
>
Acked-by: Yotam Gigi
On 07/14/2017 06:30 PM, Vivien Didelot wrote:
> Hi All,
>
> Andrew Lunn writes:
>
>> I've been testing IGMP snooping support with DSA, putting MDB entries
>> into the switch so that traffic only goes out ports where there has
>> been an interest indicated via IGMP. It mostly works, but i've come
>
err = -EINVAL;
> goto err_out;
> }
>
Acked-by: Yotam Gigi
I have been looking into some weird behavior, and I am not sure whether it is
a bug or a feature.
When a VIF with index v gets deleted, the MFC routes does not get updated, which
means that there can be routes pointing to that VIF. On datapath, when packet
hits that route, the VIF validity will be
t; - ip_mr_forward(net, mrt, skb, cache, local);
> + ip_mr_forward(net, mrt, dev, skb, cache, local);
> read_unlock(&mrt_lock);
>
> if (local)
> @@ -2238,7 +2236,7 @@ int ipmr_get_route(struct net *net, struct sk_buff *skb,
> iph->saddr = saddr;
> iph->daddr = daddr;
> iph->version = 0;
> - err = ipmr_cache_unresolved(mrt, vif, skb2);
> + err = ipmr_cache_unresolved(mrt, vif, skb2, dev);
> read_unlock(&mrt_lock);
> rcu_read_unlock();
> return err;
Thanks Donald!
Reviewed-by: Yotam Gigi
*mfa2_file,
> dec_buf.out_pos = 0;
> dec_buf.out_size = size;
> err = mlxfw_mfa2_xz_dec_run(xz_dec, &dec_buf, &finished);
> - if (err)
> - goto out;
> out:
> xz_dec_end(xz_dec);
> return err;
Thanks!
Acked-by: Yotam Gigi
process and take it again before leaving the
callback. This way, the rtnl is not held during the process. To make sure
the device does not get deleted during the flash process, take a reference
to it before releasing the rtnl lock.
Signed-off-by: Yotam Gigi
Reviewed-by: Ido Schimmel
---
drivers
On 05/30/2017 10:22 PM, Kyle McMartin wrote:
> On Mon, May 29, 2017 at 01:42:28PM +0300, Yotam Gigi wrote:
>> Add first firmware for the Mellanox Spectrum switch, as a followup to the
>> recently added commit:
>> 6b7421992b8d ("mlxsw: spectrum: Validate firmware re
ig
> +++ b/drivers/net/ethernet/mellanox/mlxfw/Kconfig
> @@ -4,3 +4,4 @@
>
> config MLXFW
> tristate "mlxfw" if COMPILE_TEST
> + select XZ_DEC
Thanks!
Acked-by: Yotam Gigi
On 05/29/2017 03:17 AM, Jakub Kicinski wrote:
> On Sun, 28 May 2017 10:26:49 +0300, Yotam Gigi wrote:
>> On 05/23/2017 06:38 PM, David Miller wrote:
>>> From: Yotam Gigi
>>> Date: Tue, 23 May 2017 18:14:15 +0300
>>>
>>>> Sorry, I am not sure
On 05/23/2017 06:38 PM, David Miller wrote:
> From: Yotam Gigi
> Date: Tue, 23 May 2017 18:14:15 +0300
>
>> Sorry, I am not sure I understand. You think that drivers should not
>> implement
>> ethtool's flash_device callback anymore? do you have an alternative
On 05/23/2017 06:04 PM, Mintz, Yuval wrote:
Patches 6-8 add the "ethtool -f" and the boot-time firmware upgrade on
>> the
mlxsw spectrum driver.
>>> When we tried using `ethtool -E' for qed we got burned for trying to use
>> the magic
>>> value [1]. When we suggested extending it to allow
vice. Our code can only be used
to transfer firmware to the device, and cannot be used to configure the device.
>
> [1] http://marc.info/?l=linux-netdev&m=146093513926921&w=4
> [2] http://marc.info/?l=linux-netdev&m=146514461214421&w=2
>
>> Patch 9 adds a fix needed
On 05/09/2017 03:31 PM, Tobias Klauser wrote:
> On 2017-05-09 at 14:12:02 +0200, Yotam Gigi wrote:
>> The IFLA_PHYS_PORT_NAME rtnetlink TLV length does not include the
>> terminating NULL character, which is different from other string typed
>> TLVs. Due to the fact that
implement ndo_get_phys_port_name.
Make the fill_phys_port_name function include the terminating NULL in the
TLV size by using the nla_put_string helper function.
Fixes: db24a9044ee1 ("net: add support for phys_port_name")
Signed-off-by: Yotam Gigi
Cc: David Ahern
Reviewed-by: Ido Schimmel
Fix error path order in nbp_vlan_init, so if switchdev_port_attr_set
call failes, the vlan_hash wouldn't be destroyed before inited.
Fixes: efa5356b0d97 ("bridge: per vlan dst_metadata netlink support")
CC: Roopa Prabhu
Signed-off-by: Yotam Gigi
---
net/bridge/br_vlan.c | 2 +-
a" existed in the command line in args 0.
Add the _from variant to those functions, which allows having the command
line option once from a specified index. In the previous example, calling
_tc_once_attr with 4 and "a f g" will suggest "a f g".
Signe
Add support for the matchall classifier and its parameters.
Signed-off-by: Yotam Gigi
---
bash-completion/tc | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/bash-completion/tc b/bash-completion/tc
index e4c6804..80d1297 100644
--- a/bash-completion/tc
+++ b/bash
t from the beginning of
the command line.
Signed-off-by: Yotam Gigi
---
bash-completion/tc | 23 ---
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/bash-completion/tc b/bash-completion/tc
index 04f969e..c854dc0 100644
--- a/bash-completion/tc
+++ b/bash-com
for this
kind of completion by adding the _tc_filter_action_options routine and
invoking it from inside _tc_filter_options.
Signed-off-by: Yotam Gigi
---
bash-completion/tc | 38 +++---
1 file changed, 35 insertions(+), 3 deletions(-)
diff --git a/bash-completion
The QDISC_KIND, FILTER_KIND, ACTION_KIND variables may be used by other
routines, thus make them global variables.
Signed-off-by: Yotam Gigi
---
bash-completion/tc | 21 ++---
1 file changed, 10 insertions(+), 11 deletions(-)
diff --git a/bash-completion/tc b/bash-completion/tc
[...] \
action sample group 10 rate 10 action mirred
actiondev egressindex ingress mirrorredirect
Finally, the last patch adds support in matchall autocompletion.
v1->v2:
- Rebased on top of net-next tree
Yotam Gigi (5):
tc: bash-completion: Add the _f
>-Original Message-
>From: Stephen Hemminger [mailto:step...@networkplumber.org]
>Sent: Tuesday, February 07, 2017 12:11 AM
>To: Yotam Gigi
>Cc: netdev@vger.kernel.org; Elad Raz ; Ido Schimmel
>; Jiri Pirko ; j...@mojatatu.com;
>m...@mojatatu.com
>Subject: Re: [PA
x27;:
>spectrum.c:(.text+0xe357e): undefined reference to `psample_sample_packet'
>
>This adds a Kconfig dependency to enforce usable configurations.
>
>Fixes: 98d0f7b9acda ("mlxsw: spectrum: Add packet sample offloading support")
>Signed-off-by: Arnd Bergmann
Acked-
The QDISC_KIND, FILTER_KIND, ACTION_KIND variables may be used by other
routines, thus make them global variables.
Signed-off-by: Yotam Gigi
---
bash-completion/tc | 21 ++---
1 file changed, 10 insertions(+), 11 deletions(-)
diff --git a/bash-completion/tc b/bash-completion/tc
Add support for the matchall classifier and its parameters.
Signed-off-by: Yotam Gigi
---
bash-completion/tc | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/bash-completion/tc b/bash-completion/tc
index e4c6804..80d1297 100644
--- a/bash-completion/tc
+++ b/bash
for this
kind of completion by adding the _tc_filter_action_options routine and
invoking it from inside _tc_filter_options.
Signed-off-by: Yotam Gigi
---
bash-completion/tc | 38 +++---
1 file changed, 35 insertions(+), 3 deletions(-)
diff --git a/bash-completion
a" existed in the command line in args 0.
Add the _from variant to those functions, which allows having the command
line option once from a specified index. In the previous example, calling
_tc_once_attr with 4 and "a f g" will suggest "a f g".
Signe
t from the beginning of
the command line.
Signed-off-by: Yotam Gigi
---
bash-completion/tc | 23 ---
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/bash-completion/tc b/bash-completion/tc
index 04f969e..c854dc0 100644
--- a/bash-completion/tc
+++ b/bash-com
[...] \
action sample group 10 rate 10 action mirred
actiondev egressindex ingress mirrorredirect
Finally, the last patch adds support in matchall autocompletion.
Yotam Gigi (5):
tc: bash-completion: Add the _from variant to _tc_one* funcs
tc: bash-completion
>-Original Message-
>From: Florian Fainelli [mailto:f.faine...@gmail.com]
>Sent: Sunday, February 05, 2017 10:55 PM
>To: Yotam Gigi ; step...@networkplumber.org;
>netdev@vger.kernel.org; Jiri Pirko ; Elad Raz
>
>Subject: Re: [PATCH iproute2/net-next 1/3] tc: Add supp
>-Original Message-
>From: Florian Fainelli [mailto:f.faine...@gmail.com]
>Sent: Sunday, February 05, 2017 8:37 PM
>To: Yotam Gigi ; step...@networkplumber.org;
>netdev@vger.kernel.org; Jiri Pirko ; Elad Raz
>
>Subject: Re: [PATCH iproute2/net-next 1/3] tc: Add supp
This patchset adds the tc-sample action support and the corresponding man
page. More information about the action and its usage can be found in the
commit message.
Yotam Gigi (3):
tc: Add support for the sample tc action
tc: man: Add man entry for the tc-sample action
tc: man: matchall
Add an example of packet sampling to the tc-matchall man page examples
section. The example uses the matchall classifier and the sample action to
create packet sampling on a port.
Reviewed-by: Jiri Pirko
Signed-off-by: Yotam Gigi
---
man/man8/tc-matchall.8 | 10 ++
1 file changed, 10
: Yotam Gigi
---
bash-completion/tc | 8 +-
include/linux/tc_act/tc_sample.h | 26 ++
tc/Makefile | 1 +
tc/m_sample.c| 186 +++
4 files changed, 220 insertions(+), 1 deletion(-)
create mode 100644
In addition to general information about the tc action, the man entry
contains common usage examples and information about the tlv fields packed
within each sampled packet.
Reviewed-by: Jiri Pirko
Signed-off-by: Yotam Gigi
---
man/man8/Makefile| 2 +-
man/man8/tc-sample.8 | 125
>-Original Message-
>From: Simon Horman [mailto:simon.hor...@netronome.com]
>Sent: Thursday, February 02, 2017 12:17 PM
>To: Yotam Gigi
>Cc: j...@mojatatu.com; da...@davemloft.net; netdev@vger.kernel.org; Jiri Pirko
>; Elad Raz ; Ido Schimmel
>
>Subject: Re: [PAT
>-Original Message-
>From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On
>Behalf Of Stephen Rothwell
>Sent: Thursday, February 02, 2017 3:50 AM
>To: David Miller ; Networking
>Cc: linux-n...@vger.kernel.org; linux-ker...@vger.kernel.org; Yot
header space.
- ife_tlv_meta_decode - decodes one tlv entry from the packet
- ife_tlv_meta_next - advance to the next tlv
Reviewed-by: Jiri Pirko
Signed-off-by: Yotam Gigi
---
MAINTAINERS | 7 +++
include/net/ife.h | 51 +
include/uapi/linux/Kbuild
As the function ife_tlv_meta_encode is not used by any other module,
unexport it and make it static for the act_ife module.
Signed-off-by: Yotam Gigi
---
include/net/tc_act/tc_ife.h | 2 --
net/sched/act_ife.c | 4 ++--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a
hus the symbol does not collide.
Yotam Gigi (3):
net/sched: act_ife: Unexport ife_tlv_meta_encode
net: Introduce ife encapsulation module
net/sched: act_ife: Change to use ife module
MAINTAINERS| 7 ++
include/net/ife.h | 51 +
include/
Use the encode/decode functionality from the ife module instead of using
implementation inside the act_ife.
Reviewed-by: Jiri Pirko
Signed-off-by: Yotam Gigi
---
include/net/tc_act/tc_ife.h| 1 -
include/uapi/linux/tc_act/tc_ife.h | 10 +---
net/sched/Kconfig | 1
>-Original Message-
>From: kbuild test robot [mailto:l...@intel.com]
>Sent: Wednesday, February 01, 2017 1:58 AM
>To: Yotam Gigi
>Cc: kbuild-...@01.org; j...@mojatatu.com; da...@davemloft.net;
>netdev@vger.kernel.org; Jiri Pirko ; Elad Raz
>; Ido Schimmel ; Yota
Extract ife logic from the tc_ife action into an independent module, and
make the tc_ife action use it. This way, the ife encapsulation can be used
by other modules other than tc_ife action.
Yotam Gigi (2):
net: Introduce ife encapsulation module
net/sched: act_ife: Change to use ife module
Use the encode/decode functionality from the ife module instead of using
implementation inside the act_ife.
Reviewed-by: Jiri Pirko
Signed-off-by: Yotam Gigi
---
include/net/tc_act/tc_ife.h| 3 -
include/uapi/linux/tc_act/tc_ife.h | 10 +---
net/sched/Kconfig | 1
header space.
- ife_tlv_meta_decode - decodes one tlv entry from the packet
- ife_tlv_meta_next - advance to the next tlv
Reviewed-by: Jiri Pirko
Signed-off-by: Yotam Gigi
---
MAINTAINERS | 7 +++
include/net/ife.h | 51 +
include/uapi/linux/Kbuild
cls_cgroup.
Fixes: bf3994d2ed31 ("net/sched: introduce Match-all classifier")
Reported-by: Daniel Borkmann
Signed-off-by: Yotam Gigi
Acked-by: Jiri Pirko
---
v1->v2:
- Rebased on net
When net is merged with net-next, this patch will probably conflict with
ec2507d2a306 ("net/s
The man page contains two examples, which have different indentation. Fix
the indentation of the two examples to match.
Reviewed-by: Jiri Pirko
Signed-off-by: Yotam Gigi
---
man/man8/tc-matchall.8 | 1 +
1 file changed, 1 insertion(+)
diff --git a/man/man8/tc-matchall.8 b/man/man8/tc-matchall
Fix error path of in sample init, by releasing the tc hash in case of
failure in psample_group creation.
Fixes: 5c5670fae430 ("net/sched: Introduce sample tc action")
Reported-by: Cong Wang
Reviewed-by: Jiri Pirko
Signed-off-by: Yotam Gigi
---
net/sched/act_sample.c | 5 -
1 fi
Little fixes in sample tc action.
Yotam Gigi (2):
net/sched: act_sample: Fix error path in init
net/sched: act_psample: Remove unnecessary ASSERT_RTNL
net/sched/act_sample.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
--
2.4.11
The ASSERT_RTNL is not necessary in the init function, as it does not
touch any rtnl protected structures, as opposed to the mirred action which
does have to hold a net device.
Reported-by: Cong Wang
Reviewed-by: Jiri Pirko
Signed-off-by: Yotam Gigi
---
net/sched/act_sample.c | 1 -
1 file
>-Original Message-
>From: Yotam Gigi
>Sent: Friday, January 27, 2017 8:09 AM
>To: 'Cong Wang' ; Jiri Pirko
>Cc: Linux Kernel Network Developers ; David Miller
>; Ido Schimmel ; Elad Raz
>; Nogah Frankel ; Or Gerlitz
>; Jamal Hadi Salim ;
>geert
>-Original Message-
>From: Cong Wang [mailto:xiyou.wangc...@gmail.com]
>Sent: Thursday, January 26, 2017 1:30 AM
>To: Jiri Pirko
>Cc: Linux Kernel Network Developers ; David Miller
>; Yotam Gigi ; Ido Schimmel
>; Elad Raz ; Nogah Frankel
>; Or Gerlitz ; Jamal
>-Original Message-
>From: Simon Horman [mailto:simon.hor...@netronome.com]
>Sent: Tuesday, January 24, 2017 10:33 AM
>To: Jiri Pirko
>Cc: netdev@vger.kernel.org; da...@davemloft.net; Yotam Gigi
>; Ido Schimmel ; Elad Raz
>; Nogah Frankel ; Or Gerlitz
>; j...@
cls_cgroup.
Fixes: bf3994d2ed31 ("net/sched: introduce Match-all classifier")
Signed-off-by: Yotam Gigi
Acked-by: Jiri Pirko
---
net/sched/cls_matchall.c | 129 +--
1 file changed, 46 insertions(+), 83 deletions(-)
diff --git a/net/sched/cls_
>-Original Message-
>From: Jamal Hadi Salim [mailto:j...@mojatatu.com]
>Sent: Sunday, January 22, 2017 3:17 PM
>To: Jiri Pirko ; netdev@vger.kernel.org
>Cc: da...@davemloft.net; Yotam Gigi ; Ido Schimmel
>; Elad Raz ; Nogah Frankel
>; Or Gerlitz ;
>geert
>-Original Message-
>From: Simon Horman [mailto:simon.hor...@netronome.com]
>Sent: Wednesday, January 04, 2017 12:43 PM
>To: Yotam Gigi
>Cc: Roopa Prabhu ; Jiri Pirko ;
>netdev@vger.kernel.org; da...@davemloft.net; Ido Schimmel
>; Elad Raz ; Nogah Frank
Fix several error paths in matchall:
- Release reference to actions in case the hardware fails offloading
(relevant to skip_sw only)
- Fix error path in case tcf_exts initialization/validation fail
Fixes: bf3994d2ed31 ("net/sched: introduce Match-all classifier")
Signed-off-by:
>-Original Message-
>From: David Miller [mailto:da...@davemloft.net]
>Sent: Tuesday, January 03, 2017 6:08 PM
>To: Yotam Gigi
>Cc: j...@mojatatu.com; Elad Raz ; Jiri Pirko
>; netdev@vger.kernel.org
>Subject: Re: [PATCH net-next] net/sched: cls_matchall: Fix error pat
Fix several error paths in matchall:
- Release reference to actions in case the hardware fails offloading
(relevant to skip_sw only)
- Fix error path in case tcf_exts initialization fails
Fixes: bf3994d2ed31 ("net/sched: introduce Match-all classifier")
Signed-off-by: Yotam Gigi
>-Original Message-
>From: Roopa Prabhu [mailto:ro...@cumulusnetworks.com]
>Sent: Wednesday, November 16, 2016 6:15 PM
>To: Jiri Pirko
>Cc: netdev@vger.kernel.org; da...@davemloft.net; Yotam Gigi
>; Ido Schimmel ; Elad Raz
>; Nogah Frankel ; Or Gerlitz
>; j...@
>-Original Message-
>From: Simon Horman [mailto:simon.hor...@netronome.com]
>Sent: Friday, November 11, 2016 2:44 PM
>To: Yotam Gigi
>Cc: John Fastabend ; Jiri Pirko ;
>netdev@vger.kernel.org; da...@davemloft.net; Ido Schimmel
>; Elad Raz ; Nogah Frankel
>; Or Gerl
>-Original Message-
>From: Yotam Gigi
>Sent: Thursday, November 10, 2016 9:59 PM
>To: 'John Fastabend' ; Jiri Pirko ;
>netdev@vger.kernel.org
>Cc: da...@davemloft.net; Ido Schimmel ; Elad Raz
>; Nogah Frankel ; Or Gerlitz
>; j...@mojatatu.c
>-Original Message-
>From: John Fastabend [mailto:john.fastab...@gmail.com]
>Sent: Thursday, November 10, 2016 9:38 PM
>To: Jiri Pirko ; netdev@vger.kernel.org
>Cc: da...@davemloft.net; Yotam Gigi ; Ido Schimmel
>; Elad Raz ; Nogah Frankel
>; Or Gerlitz ;
>j...@
>-Original Message-
>From: David Miller [mailto:da...@davemloft.net]
>Sent: Thursday, November 10, 2016 9:18 PM
>To: j...@resnulli.us
>Cc: netdev@vger.kernel.org; Yotam Gigi ; Ido Schimmel
>; Elad Raz ; Nogah Frankel
>; Or Gerlitz ;
>j...@mojatatu.com; geert
tc_act macro addressed a non existing field, and was not used in the
kernel source.
Signed-off-by: Yotam Gigi
Reviewed-by: Jiri Pirko
---
include/net/act_api.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/net/act_api.h b/include/net/act_api.h
index 82f3c91..d8eae87 100644
--- a
>-Original Message-
>From: Anna Schumaker [mailto:anna.schuma...@netapp.com]
>Sent: Wednesday, October 26, 2016 9:17 PM
>To: Jakub Kicinski
>Cc: Yotam Gigi ; Andy Adamson ;
>linux-...@vger.kernel.org; netdev@vger.kernel.org; Trond Myklebust
>; Yotam Gigi ; mlxsw
>
>-Original Message-
>From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On
>Behalf Of Jakub Kicinski
>Sent: Monday, October 17, 2016 10:20 PM
>To: Andy Adamson ; Anna Schumaker
>; linux-...@vger.kernel.org
>Cc: netdev@vger.kernel.org; Trond Myklebust
>Subject: nfs NU
>-Original Message-
>From: Roopa Prabhu [mailto:ro...@cumulusnetworks.com]
>Sent: Wednesday, October 19, 2016 10:33 AM
>To: Yotam Gigi
>Cc: Jamal Hadi Salim ; Jiri Pirko ;
>netdev@vger.kernel.org; da...@davemloft.net; Ido Schimmel
>; Elad Raz ; Nogah Frankel
>;
>-Original Message-
>From: Or Gerlitz [mailto:gerlitz...@gmail.com]
>Sent: Sunday, October 16, 2016 1:27 PM
>To: Jiri Pirko
>Cc: Linux Netdev List ; David Miller
>; Yotam Gigi ; Ido Schimmel
>; Elad Raz ; Nogah Frankel
>; Or Gerlitz ; Jamal Hadi Salim
>; geert
>-Original Message-
>From: Roopa Prabhu [mailto:ro...@cumulusnetworks.com]
>Sent: Tuesday, October 18, 2016 3:17 AM
>To: Jamal Hadi Salim
>Cc: Jiri Pirko ; netdev@vger.kernel.org; da...@davemloft.net;
>Yotam Gigi ; Ido Schimmel ; Elad
>Raz ; Nogah Frankel ; Or
parsing loop.
This fix changes the loop counter to be signed and fixes the encoding to
take into account the tlv type and size.
Fixes: 28a10c426e81 ("net sched: fix encoding to use real length")
Acked-by: Jamal Hadi Salim
Signed-off-by: Yotam Gigi
---
v2->v3
- Fix the encode si
external mac header once the values were not set by user.
This fix takes the internal mac header from the packet, after the call to
skb_cow_head.
Fixes: ef6980b6becb ("net sched: introduce IFE action")
Acked-by: Jamal Hadi Salim
Signed-off-by: Yotam Gigi
---
net/sched/act_ife.c | 3 +
This patch-set contains two bugfixes in the tc-ife action, one fixing some
random behaviour in encode side, and one fixing the decode side packet
parsing logic.
v2->v3
- Fix the encode side instead of the decode side
Yotam Gigi (2):
act_ife: Fix external mac header on encode
act_ife:
>-Original Message-
>From: Jamal Hadi Salim [mailto:j...@mojatatu.com]
>Sent: Monday, September 26, 2016 3:47 AM
>To: Yotam Gigi ; Yotam Gigi ;
>da...@davemloft.net; netdev@vger.kernel.org
>Cc: Jiri Pirko ; Elad Raz ; mlxsw
>; Roman Mashak
>Subject: Re: [PATC
>-Original Message-
>From: Jamal Hadi Salim [mailto:j...@mojatatu.com]
>Sent: Sunday, September 25, 2016 4:46 PM
>To: Yotam Gigi ; da...@davemloft.net;
>netdev@vger.kernel.org; Yotam Gigi
>Subject: Re: [PATCH net v2 0/2] Fix tc-ife bugs
>
>On 16-09-25 08:31 AM, Y
1 - 100 of 110 matches
Mail list logo
