>-----Original Message----- >From: Jamal Hadi Salim [mailto:j...@mojatatu.com] >Sent: Sunday, January 22, 2017 3:17 PM >To: Jiri Pirko <j...@resnulli.us>; netdev@vger.kernel.org >Cc: da...@davemloft.net; Yotam Gigi <yot...@mellanox.com>; Ido Schimmel ><ido...@mellanox.com>; Elad Raz <el...@mellanox.com>; Nogah Frankel ><nog...@mellanox.com>; Or Gerlitz <ogerl...@mellanox.com>; >geert+rene...@glider.be; step...@networkplumber.org; >xiyou.wangc...@gmail.com; li...@roeck-us.net; ro...@cumulusnetworks.com; >john.fastab...@gmail.com; simon.hor...@netronome.com; m...@mojatatu.com >Subject: Re: [patch net-next 2/4] net/sched: Introduce sample tc action > >On 17-01-22 06:44 AM, Jiri Pirko wrote: > >> diff --git a/net/sched/act_sample.c b/net/sched/act_sample.c >> new file mode 100644 >> index 0000000..24e20e4 >> --- /dev/null >> +++ b/net/sched/act_sample.c >> @@ -0,0 +1,274 @@ >> +/* >> + * net/sched/act_sample.c - Packet samplig tc action > >typo: "Sampling"
It took me a while to see it. Will fix :) > > >> +static int tcf_sample(struct sk_buff *skb, const struct tc_action *a, >> + struct tcf_result *res) > > >Can you rename this function because it is also the name of the data >structure? It makes it easier to grep. >I know we have this all over the place in other actions (and i hope >those are cleaned up at some point). OK, makes sense. > >otherwise: >Acked-by: Jamal Hadi Salim <j...@mojatatu.com> Thanks! > >cheers, >jamal
