On 09/25/2017 12:36 PM, Nikolay Aleksandrov wrote:
> On 24/09/17 20:22, Jiri Pirko wrote:
>> From: Yotam Gigi <yot...@mellanox.com>
>>
>> Allow drivers, registered to the fib notification chain indicate whether a
>> multicast MFC route is offloaded or not, similarly to unicast routes. The
>> indication of whether a route is offloaded is done using the mfc_flags
>> field on an mfc_cache struct, and the information is sent to the userspace
>> via the RTNetlink interface only.
>>
>> Currently, MFC routes are either offloaded or not, thus there is no need to
>> add per-VIF offload indication.
>>
>> Signed-off-by: Yotam Gigi <yot...@mellanox.com>
>> Reviewed-by: Ido Schimmel <ido...@mellanox.com>
>> Signed-off-by: Jiri Pirko <j...@mellanox.com>
>> ---
>> v1->v2:
>> - Add comment for the MFC_OFFLOAD flag
>> ---
>> include/linux/mroute.h | 2 ++
>> net/ipv4/ipmr.c | 3 +++
>> 2 files changed, 5 insertions(+)
>>
>> diff --git a/include/linux/mroute.h b/include/linux/mroute.h
>> index 54c5cb8..5566580 100644
>> --- a/include/linux/mroute.h
>> +++ b/include/linux/mroute.h
>> @@ -90,9 +90,11 @@ struct mr_table {
>>
>> /* mfc_flags:
>> * MFC_STATIC - the entry was added statically (not by a routing daemon)
>> + * MFC_OFFLOAD - the entry was offloaded to the hardware
>> */
>> enum {
>> MFC_STATIC = BIT(0),
>> + MFC_OFFLOAD = BIT(1),
>> };
>>
>> struct mfc_cache_cmp_arg {
>> diff --git a/net/ipv4/ipmr.c b/net/ipv4/ipmr.c
>> index ba71bc4..2a795d2 100644
>> --- a/net/ipv4/ipmr.c
>> +++ b/net/ipv4/ipmr.c
>> @@ -2268,6 +2268,9 @@ static int __ipmr_fill_mroute(struct mr_table *mrt,
>> struct sk_buff *skb,
>> nla_put_u32(skb, RTA_IIF,
>> mrt->vif_table[c->mfc_parent].dev->ifindex) < 0)
>> return -EMSGSIZE;
>>
>> + if (c->mfc_flags & MFC_OFFLOAD)
>> + rtm->rtm_flags |= RTNH_F_OFFLOAD;
>> +
>> if (!(mp_attr = nla_nest_start(skb, RTA_MULTIPATH)))
>> return -EMSGSIZE;
>>
>>
> Thanks!
Thank you for reviewing :)
>
> Reviewed-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>
>
