Re: [PATCH V2 net-next 4/6] tun: Add support for SCTP checksum offload

2018-05-02 Thread Vlad Yasevich
On 05/02/2018 10:56 AM, Marcelo Ricardo Leitner wrote: > On Wed, May 02, 2018 at 11:53:47AM -0300, Marcelo Ricardo Leitner wrote: >> On Tue, May 01, 2018 at 10:07:37PM -0400, Vladislav Yasevich wrote: >>> Adds a new tun offload flag to allow for SCTP checksum offload. >>> The flag has to be set by

Re: [PATCH V2 net-next 5/6] macvlan/macvtap: Add support for SCTP checksum offload.

2018-05-02 Thread Vlad Yasevich
On 05/02/2018 10:17 AM, Michael S. Tsirkin wrote: > On Wed, May 02, 2018 at 10:00:14AM -0400, Vlad Yasevich wrote: >> On 05/02/2018 09:46 AM, Michael S. Tsirkin wrote: >>> On Wed, May 02, 2018 at 09:27:00AM -0400, Vlad Yasevich wrote: >>>> On 05/01/2018 11:24 PM, Mich

Re: [PATCH V2 net-next 5/6] macvlan/macvtap: Add support for SCTP checksum offload.

2018-05-02 Thread Vlad Yasevich
On 05/02/2018 09:46 AM, Michael S. Tsirkin wrote: > On Wed, May 02, 2018 at 09:27:00AM -0400, Vlad Yasevich wrote: >> On 05/01/2018 11:24 PM, Michael S. Tsirkin wrote: >>> On Tue, May 01, 2018 at 10:07:38PM -0400, Vladislav Yasevich wrote: >>>> Since we now have suppo

Re: [PATCH V2 net-next 5/6] macvlan/macvtap: Add support for SCTP checksum offload.

2018-05-02 Thread Vlad Yasevich
On 05/01/2018 11:24 PM, Michael S. Tsirkin wrote: > On Tue, May 01, 2018 at 10:07:38PM -0400, Vladislav Yasevich wrote: >> Since we now have support for software CRC32c offload, turn it on >> for macvlan and macvtap devices so that guests can take advantage >> of offload SCTP checksums to the host

Re: [PATCH net-next 0/5] virtio-net: Add SCTP checksum offload support

2018-04-23 Thread Vlad Yasevich
On 04/20/2018 01:22 PM, Marcelo Ricardo Leitner wrote: > On Wed, Apr 18, 2018 at 05:06:46PM +0300, Michael S. Tsirkin wrote: >> On Tue, Apr 17, 2018 at 04:35:18PM -0400, Vlad Yasevich wrote: >>> On 04/02/2018 10:47 AM, Marcelo Ricardo Leitner wrote: >>>> On Mon, Ap

Re: [PATCH net-next 0/5] virtio-net: Add SCTP checksum offload support

2018-04-17 Thread Vlad Yasevich
On 04/02/2018 10:47 AM, Marcelo Ricardo Leitner wrote: > On Mon, Apr 02, 2018 at 09:40:01AM -0400, Vladislav Yasevich wrote: >> Now that we have SCTP offload capabilities in the kernel, we can add >> them to virtio as well. First step is SCTP checksum. > > Thanks. > >> As for GSO, the way sctp G

Re: [PATCH net-next 1/5] virtio: Add support for SCTP checksum offloading

2018-04-17 Thread Vlad Yasevich
On 04/16/2018 01:09 PM, Michael S. Tsirkin wrote: > On Mon, Apr 16, 2018 at 09:45:48AM -0400, Vlad Yasevich wrote: >> On 04/11/2018 06:49 PM, Michael S. Tsirkin wrote: >>> On Mon, Apr 02, 2018 at 09:40:02AM -0400, Vladislav Yasevich wrote: >>>> To support SCTP checksu

Re: [PATCH net-next 1/5] virtio: Add support for SCTP checksum offloading

2018-04-16 Thread Vlad Yasevich
On 04/11/2018 06:49 PM, Michael S. Tsirkin wrote: > On Mon, Apr 02, 2018 at 09:40:02AM -0400, Vladislav Yasevich wrote: >> To support SCTP checksum offloading, we need to add a new feature >> to virtio_net, so we can negotiate support between the hypervisor >> and the guest. >> >> The signalling to

Re: removing bridge in vlan_filtering mode requests delete of attached ports main MAC address

2017-10-26 Thread Vlad Yasevich
On 10/20/2017 08:06 PM, Keller, Jacob E wrote: >> -Original Message- >> From: Keller, Jacob E >> Sent: Friday, October 20, 2017 10:23 AM >> To: netdev@vger.kernel.org >> Cc: Malek, Patryk ; 'Vlad Yasevich' >> >> Subject: removing bridg

Re: [PATCH net 5/6] rtnetlink: check DO_SETLINK_NOTIFY correctly in do_setlink

2017-10-25 Thread Vlad Yasevich
On 10/16/2017 02:20 PM, Nicolas Dichtel wrote: > Le 16/10/2017 à 03:17, David Ahern a écrit : >> [ cc'ed Nicolas ] >> >> On 10/15/17 4:13 AM, Xin Long wrote: >>> The check 'status & DO_SETLINK_NOTIFY' in do_setlink doesn't really >>> work after status & DO_SETLINK_MODIFIED, as: >>> >>> DO_SETLINK

Re: [PATCH net] net: account for current skb length when deciding about UFO

2017-06-19 Thread Vlad Yasevich
f further fragments) for skb == NULL. > > Fixes: e89e9cf539a2 ("[IPv4/IPv6]: UFO Scatter-gather approach") > Fixes: e4c5e13aa45c ("ipv6: Should use consistent conditional judgement for > ip6 fragment between __ip6_append_data and ip6_finish_output") > Signed-off-by:

Re: [PATCH net 4/4] macvlan: Let passthru macvlan correctly restore lower mac address

2017-06-17 Thread Vlad Yasevich
On 06/17/2017 12:35 AM, Girish Moodalbail wrote: > Sorry, it took sometime to wrap around this patch series since they all > change one file > and at times the same function :). > > > On 6/16/17 6:36 AM, Vladislav Yasevich wrote: >> Passthru macvlans directly change the mac address of the lower

Re: [PATCH V6 net-next iproute] ip: Add support for netdev events to monitor

2017-05-31 Thread Vlad Yasevich
On 05/30/2017 02:26 PM, Vlad Yasevich wrote: > On 05/30/2017 01:12 PM, Stephen Hemminger wrote: >> On Sat, 27 May 2017 10:14:36 -0400 >> Vladislav Yasevich wrote: >> >>> >>> +static const char *netdev_events[] = {"NONE&quo

Re: [PATCH V6 net-next iproute] ip: Add support for netdev events to monitor

2017-05-30 Thread Vlad Yasevich
On 05/30/2017 01:12 PM, Stephen Hemminger wrote: > On Sat, 27 May 2017 10:14:36 -0400 > Vladislav Yasevich wrote: > >> >> +static const char *netdev_events[] = {"NONE", >> + "REBOOT", >> + "FEATURE CHANGE", >> +

Re: [PATCH V5 1/2] rtnl: Add support for netdev event to link messages

2017-05-26 Thread Vlad Yasevich
On 05/26/2017 03:40 PM, David Ahern wrote: > On 5/25/17 9:31 AM, Vladislav Yasevich wrote: >> @@ -911,4 +912,14 @@ enum { >> >> #define IFLA_XDP_MAX (__IFLA_XDP_MAX - 1) >> >> +enum { >> +IFLA_EVENT_UNSPEC, >> +IFLA_EVENT_REBOOT, >> +IFLA_EVENT_FEAT_CHANGE, >> +IFLA_EVENT_BONDI

Re: [PATCH net v2] sctp: fix ICMP processing if skb is non-linear

2017-05-25 Thread Vlad Yasevich
e specific reference to INIT chunks. > > Signed-off-by: Davide Caratti Acked-by: Vlad Yasevich -vlad > --- > net/sctp/input.c | 16 +--- > 1 file changed, 9 insertions(+), 7 deletions(-) > > diff --git a/net/sctp/input.c b/net/sctp/input.c > index 0e06a2

Re: [PATCH net 2/2] sctp: set new_asoc temp when processing dupcookie

2017-05-23 Thread Vlad Yasevich
ookie echo packet. > > Reported-by: Jianwen Ji > Signed-off-by: Xin Long Acked-by: Vlad Yasevich -vlad > --- > net/sctp/sm_make_chunk.c | 13 - > net/sctp/sm_statefuns.c | 3 +++ > 2 files changed, 7 insertions(+), 9 deletions(-) > > diff --git a/net/

Re: [PATCH net 1/2] sctp: fix stream update when processing dupcookie

2017-05-23 Thread Vlad Yasevich
> info when processing dupcookie, but would be better to check asoc > state instead. > > Fixes: 3dbcc105d556 ("sctp: alloc stream info when initializing asoc") > Signed-off-by: Xin Long Acked-by: Vlad Yasevich -vlad > --- > net/sctp/associola.c | 4 +++- > 1

Re: [PATCH net 1/3] vlan: Fix tcp checksums offloads for Q-in-Q vlan.

2017-05-23 Thread Vlad Yasevich
On 05/22/2017 07:59 PM, David Miller wrote: > From: Vladislav Yasevich > Date: Thu, 18 May 2017 09:31:03 -0400 > >> It appears that since commit 8cb65d000, Q-in-Q vlans have been >> broken. The series that commit is part of enabled TSO and checksum >> offloading on Q-in-Q vlans. However, most H

Re: [PATCH 3/5] sctp: Fix a typo in a comment line in sctp_init()

2017-05-22 Thread Vlad Yasevich
tialize the SCTP port hash table. > - * Note that order is initalized to start at the max sized > + * Note that order is initialized to start at the max sized >* table we want to support. If we can't get that many pages > * reduce the order and try again >*/ > Acked-by: Vlad Yasevich

Re: [PATCH 5/5] sctp: Adjust one function call together with a variable assignment

2017-05-22 Thread Vlad Yasevich
n_dev = __in_dev_get_rcu(dev); > + if (!in_dev) { > rcu_read_unlock(); > return; > } > Acked-by: Vlad Yasevich -vlad

Re: [PATCH 4/5] sctp: Improve a size determination in sctp_inetaddr_event()

2017-05-22 Thread Vlad Yasevich
tp_sockaddr_entry), GFP_ATOMIC); > + addr = kmalloc(sizeof(*addr), GFP_ATOMIC); > if (addr) { > addr->a.v4.sin_family = AF_INET; > addr->a.v4.sin_port = 0; > Acked-by: Vlad Yasevich -vlad

Re: [PATCH 2/5] sctp: Delete an error message for a failed memory allocation in sctp_init()

2017-05-22 Thread Vlad Yasevich
.5e7c8a344770 100644 > --- a/net/sctp/protocol.c > +++ b/net/sctp/protocol.c > @@ -1447,5 +1447,4 @@ static __init int sctp_init(void) > if (!sctp_ep_hashtable) { > - pr_err("Failed endpoint_hash alloc\n"); > status = -ENOMEM; >

Re: [PATCH 1/5] sctp: Use kmalloc_array() in sctp_init()

2017-05-22 Thread Vlad Yasevich
convention. > > Signed-off-by: Markus Elfring Acked-by: Vlad Yasevich -vlad > --- > net/sctp/protocol.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c > index 989a900383b5..2b1a6215bd2f 10064

Re: [PATCH net 1/3] vlan: Fix tcp checksums offloads for Q-in-Q vlan.

2017-05-19 Thread Vlad Yasevich
On 05/19/2017 04:16 AM, Toshiaki Makita wrote: > On 2017/05/19 16:09, Vlad Yasevich wrote: >> On 05/18/2017 10:13 PM, Toshiaki Makita wrote: >>> On 2017/05/18 22:31, Vladislav Yasevich wrote: >>>> It appears that since commit 8cb65d000, Q-in-Q vlans have been >&g

Re: [PATCH net 1/3] vlan: Fix tcp checksums offloads for Q-in-Q vlan.

2017-05-19 Thread Vlad Yasevich
On 05/18/2017 10:13 PM, Toshiaki Makita wrote: > On 2017/05/18 22:31, Vladislav Yasevich wrote: >> It appears that since commit 8cb65d000, Q-in-Q vlans have been >> broken. The series that commit is part of enabled TSO and checksum >> offloading on Q-in-Q vlans. However, most HW we support can't

Re: [PATCH] vlan: Keep NETIF_F_HW_CSUM similar to other software devices

2017-05-05 Thread Vlad Yasevich
On 05/05/2017 04:01 PM, Alexander Duyck wrote: > On Fri, May 5, 2017 at 12:20 PM, Vladislav Yasevich > wrote: >> Vlan devices, like all other software devices, enable >> NETIF_F_HW_CSUM feature. However, unlike all the othe other >> software devices, vlans will switch to using IP|IPV6_CSUM >> fe

Re: [PATCH net-next V3 2/2] rtnl: Add support for netdev event attribute to link messages

2017-05-01 Thread Vlad Yasevich
On 04/28/2017 12:38 PM, Jiri Pirko wrote: > Thu, Apr 27, 2017 at 09:59:38PM CEST, d...@cumulusnetworks.com wrote: >> On 4/27/17 1:43 PM, Vlad Yasevich wrote: >>>> For example, NETDEV_CHANGEINFODATA is only for bonds though nothing >>>> about the name suggests it is

Re: [PATCH net-next V3 2/2] rtnl: Add support for netdev event attribute to link messages

2017-04-27 Thread Vlad Yasevich
On 04/24/2017 11:14 AM, Roopa Prabhu wrote: > On Sun, Apr 23, 2017 at 6:07 PM, David Ahern wrote: >> >> On 4/21/17 11:31 AM, Vladislav Yasevich wrote: >>> @@ -1276,9 +1277,40 @@ static int rtnl_xdp_fill(struct sk_buff *skb, struct >>> net_device *dev) >>> return err; >>> } >>> >>> +static

Re: [PATCH net-next V3 2/2] rtnl: Add support for netdev event attribute to link messages

2017-04-27 Thread Vlad Yasevich
On 04/23/2017 09:07 PM, David Ahern wrote: > On 4/21/17 11:31 AM, Vladislav Yasevich wrote: >> @@ -1276,9 +1277,40 @@ static int rtnl_xdp_fill(struct sk_buff *skb, struct >> net_device *dev) >> return err; >> } >> >> +static int rtnl_fill_link_event(struct sk_buff *skb, unsigned long event

Re: [PATCH net-next 1/2] rtnetlink: Disable notification for NETDEV_NAMECHANGE event

2017-04-27 Thread Vlad Yasevich
On 04/21/2017 02:08 PM, David Ahern wrote: > On 4/21/17 11:31 AM, Vladislav Yasevich wrote: >> The data signaling name change is already provided at >> the end of do_setlink(). This event handler just generates >> a duplicate announcement. Disable it. >> >> CC: David Ahern >> Signed-off-by: Vlad

Re: [PATCH RFC (resend) net-next 0/6] virtio-net: Add support for virtio-net header extensions

2017-04-21 Thread Vlad Yasevich
On 04/21/2017 12:05 AM, Jason Wang wrote: > > > On 2017年04月20日 23:34, Vlad Yasevich wrote: >> On 04/17/2017 11:01 PM, Jason Wang wrote: >>> >>> On 2017年04月16日 00:38, Vladislav Yasevich wrote: >>>> Curreclty virtion net header is fixed size and addin

Re: [PATCH V2 net] netdevice: Include NETIF_F_HW_CSUM when intersecting features

2017-04-20 Thread Vlad Yasevich
On 04/20/2017 06:31 PM, Alexander Duyck wrote: > On Thu, Apr 20, 2017 at 12:17 PM, Vladislav Yasevich > wrote: >> While hardware device use either NETIF_F_(IP|IPV6)_CSUM or >> NETIF_F_HW_CSUM, all of the software devices use HW_CSUM. >> This results in an interesting situation when the software >>

Re: [PATCH net] netdevice: Prefer NETIF_F_HW_CSUM when intersecting features

2017-04-20 Thread Vlad Yasevich
On 04/20/2017 02:36 PM, Alexander Duyck wrote: > On Wed, Apr 19, 2017 at 6:12 PM, Vladislav Yasevich > wrote: >> While hardware device use either NETIF_F_(IP|IPV6)_CSUM or >> NETIF_F_HW_CSUM, all of the software devices use HW_CSUM. >> This results in an interesting situation when the software >>

Re: [PATCH RFC (resend) net-next 0/6] virtio-net: Add support for virtio-net header extensions

2017-04-20 Thread Vlad Yasevich
On 04/17/2017 11:01 PM, Jason Wang wrote: > > > On 2017年04月16日 00:38, Vladislav Yasevich wrote: >> Curreclty virtion net header is fixed size and adding things to it is rather >> difficult to do. This series attempt to add the infrastructure as well as >> some >> extensions that try to resolve

Re: [PATCH net] netdevice: Prefer NETIF_F_HW_CSUM when intersecting features

2017-04-20 Thread Vlad Yasevich
On 04/20/2017 02:13 AM, Michal Kubecek wrote: > On Wed, Apr 19, 2017 at 09:12:23PM -0400, Vladislav Yasevich wrote: >> While hardware device use either NETIF_F_(IP|IPV6)_CSUM or >> NETIF_F_HW_CSUM, all of the software devices use HW_CSUM. >> This results in an interesting situation when the softwar

Re: [PATCH net-next 1/8] rtnetlink: Do not generate notifications for MTU events

2017-04-14 Thread Vlad Yasevich
On 04/10/2017 11:49 AM, David Ahern wrote: > On 4/10/17 9:39 AM, Vlad Yasevich wrote: >> OK, so this will work for the events that are generated as a result of >> device state change >> (like mtu, address, and others). >> >> However, the original event data may be

Re: [PATCH net-next 1/8] rtnetlink: Do not generate notifications for MTU events

2017-04-10 Thread Vlad Yasevich
On 04/08/2017 02:18 PM, Roopa Prabhu wrote: > On 4/8/17, 11:13 AM, David Ahern wrote: >> On 4/8/17 2:06 PM, Roopa Prabhu wrote: >>> On 4/7/17, 2:25 PM, David Ahern wrote: Changing MTU on a link currently causes 3 messages to be sent to userspace: [LINK]11: dummy1: mtu 1490 qdisc noq

Re: [PATCH net-next 7/8] rtnetlink: Do not generate notifications for NOTIFY_PEERS event

2017-04-08 Thread Vlad Yasevich
On 04/07/2017 05:25 PM, David Ahern wrote: > NOTIFY_PEERS is an internal event; do not generate userspace > notifications. We actually need this event to support macvtap over bonding as well as to resolve some issues with VMs using a bonded uplink on the host. -vlad > > Signed-off-by: David Ahe

Re: [PATCH net-next 1/8] rtnetlink: Do not generate notifications for MTU events

2017-04-08 Thread Vlad Yasevich
On 04/07/2017 05:25 PM, David Ahern wrote: > Changing MTU on a link currently causes 3 messages to be sent to userspace: > > [LINK]11: dummy1: mtu 1490 qdisc noqueue state > UNKNOWN group default event PRE_CHANGE_MTU > link/ether f2:52:5c:6d:21:f3 brd ff:ff:ff:ff:ff:ff > > [LINK]11: dummy1:

Re: [PATCH net-next] rtnl: Add support for netdev event to link messages

2017-03-30 Thread Vlad Yasevich
On 03/30/2017 09:39 AM, Vlad Yasevich wrote: > On 03/29/2017 03:11 PM, David Ahern wrote: >> On 3/29/17 11:05 AM, Vlad Yasevich wrote: >>> On 03/29/2017 12:37 PM, Roopa Prabhu wrote: >>>> On 3/29/17, 5:23 AM, Vlad Yasevich wrote: >>>>> [ resending t

Re: [PATCH net-next] rtnl: Add support for netdev event to link messages

2017-03-30 Thread Vlad Yasevich
On 03/29/2017 03:11 PM, David Ahern wrote: > On 3/29/17 11:05 AM, Vlad Yasevich wrote: >> On 03/29/2017 12:37 PM, Roopa Prabhu wrote: >>> On 3/29/17, 5:23 AM, Vlad Yasevich wrote: >>>> [ resending to list. hit the wrong reply button last time ] >>>> >&

Re: [PATCH net-next] rtnl: Add support for netdev event to link messages

2017-03-29 Thread Vlad Yasevich
On 03/29/2017 12:37 PM, Roopa Prabhu wrote: > On 3/29/17, 5:23 AM, Vlad Yasevich wrote: >> [ resending to list. hit the wrong reply button last time ] >> >> On 03/27/2017 06:58 PM, David Miller wrote: >>> From: Vladislav Yasevich >>> Date: Sat, 25 Mar 2017

Re: [PATCH net-next] rtnl: Add support for netdev event to link messages

2017-03-29 Thread Vlad Yasevich
[ resending to list. hit the wrong reply button last time ] On 03/27/2017 06:58 PM, David Miller wrote: > From: Vladislav Yasevich > Date: Sat, 25 Mar 2017 21:59:47 -0400 > >> RTNL currently generates notifications on some netdev notifier events. >> However, user space has no idea what changed.

Re: [RFC PATCH net-next] virtio_net: Support UDP Tunnel offloads.

2016-12-19 Thread Vlad Yasevich
On 12/15/2016 02:07 AM, Or Gerlitz wrote: > On Fri, Nov 18, 2016 at 1:01 AM, Jarno Rajahalme wrote: >> This patch is a proof-of-concept I did a few months ago for UDP tunnel >> offload support in virtio_net interface [..] > > What's the use case you were considering for a guest running a UDP base

Re: [PATCH net 1/3] sctp: fix the transport dead race check by using atomic_add_unless on refcnt

2016-01-22 Thread Vlad Yasevich
On 01/22/2016 12:18 PM, Marcelo Ricardo Leitner wrote: > On Fri, Jan 22, 2016 at 11:50:20AM -0500, Vlad Yasevich wrote: >> On 01/21/2016 12:49 PM, Xin Long wrote: >>> Now when __sctp_lookup_association is running in BH, it will try to >>> check if t->dead is set, b

Re: [PATCH net 1/3] sctp: fix the transport dead race check by using atomic_add_unless on refcnt

2016-01-22 Thread Vlad Yasevich
gt; > Note that sctp association is not freed using RCU so we can't use > atomic_add_unless() with it as it may just be too late for that either. > > Fixes: 4f0087812648 ("sctp: apply rhashtable api to send/recv path") > Reported-by: Vlad Yasevich > Sig

Re: [PATCH net-next 2/5] sctp: apply rhashtable api to send/recv path

2016-01-05 Thread Vlad Yasevich
On 12/30/2015 10:50 AM, Xin Long wrote: > apply lookup apis to two functions, for __sctp_endpoint_lookup_assoc > and __sctp_lookup_association, it's invoked in the protection of sock > lock, it will be safe, but sctp_lookup_association need to call > rcu_read_lock() and to detect the t->dead to pro

Re: [PATCH net-next 1/5] sctp: add the rhashtable apis for sctp global transport hashtable

2016-01-05 Thread Vlad Yasevich
On 12/30/2015 10:50 AM, Xin Long wrote: > tranport hashtbale will replace the association hashtable to do the > lookup for transport, and then get association by t->assoc, rhashtable > apis will be used because of it's resizable, scalable and using rcu. > > lport + rport + paddr will be the base h

Re: [PATCH net] sctp: sctp should release assoc when sctp_make_abort_user return NULL in sctp_close

2015-12-18 Thread Vlad Yasevich
On 12/17/2015 02:33 PM, Vlad Yasevich wrote: > On 12/17/2015 02:01 PM, Marcelo Ricardo Leitner wrote: >> Em 17-12-2015 16:29, Vlad Yasevich escreveu: >>> On 12/17/2015 09:30 AM, Xin Long wrote: >>>> In sctp_close, sctp_make_abort_user may return NULL because of memo

Re: [PATCH net] sctp: sctp should release assoc when sctp_make_abort_user return NULL in sctp_close

2015-12-17 Thread Vlad Yasevich
On 12/17/2015 02:01 PM, Marcelo Ricardo Leitner wrote: > Em 17-12-2015 16:29, Vlad Yasevich escreveu: >> On 12/17/2015 09:30 AM, Xin Long wrote: >>> In sctp_close, sctp_make_abort_user may return NULL because of memory >>> allocation failure. If this happens, it w

Re: [PATCH net] sctp: sctp should release assoc when sctp_make_abort_user return NULL in sctp_close

2015-12-17 Thread Vlad Yasevich
On 12/17/2015 09:30 AM, Xin Long wrote: > In sctp_close, sctp_make_abort_user may return NULL because of memory > allocation failure. If this happens, it will bypass any state change > and never free the assoc. The assoc has no chance to be freed and it > will be kept in memory with the state it ha

Re: use-after-free in sctp_do_sm

2015-12-14 Thread Vlad Yasevich
On 12/14/2015 04:50 AM, David Laight wrote: > From: Vlad Yasevich >> Sent: 11 December 2015 18:38 > ... >>> Found a similar place in abort primitive handling like in this last >>> patch update, it's probably the issue you're still triggering. >>> &

Re: [V2 PATCH 1/1] net: sctp: dynamically enable or disable pf state

2015-12-14 Thread Vlad Yasevich
imes the user expects to disable pf state while the 2 > variables are changed to enable pf state. So it is necessary to > introduce a new variable to disable pf state. > > According to the suggestions from Vlad Yasevich, extra1 and extra2 > are removed. The initialization of pf_enable i

Re: use-after-free in sctp_do_sm

2015-12-11 Thread Vlad Yasevich
On 12/11/2015 09:03 AM, Marcelo Ricardo Leitner wrote: > On Fri, Dec 11, 2015 at 11:51:21AM -0200, Marcelo Ricardo Leitner wrote: >> Em 11-12-2015 11:35, Dmitry Vyukov escreveu: >>> On Wed, Dec 9, 2015 at 5:41 PM, Marcelo Ricardo Leitner >>> wrote: On Wed, Dec 09, 2015 at 01:03:56PM -0200, Ma

Re: [PATCH 1/1] net: sctp: dynamically enable or disable pf state

2015-12-11 Thread Vlad Yasevich
On 12/11/2015 04:05 AM, zyjzyj2...@gmail.com wrote: > From: Zhu Yanjun > > As we all know, the vale of pf_retrans >= max_retrans_path can > disable pf state. The variables of pf_retrans and max_retrans_path > can be changed by the user space application. > > Sometimes the user expects to disable

Re: [PATCH net] ipv6: sctp: clone options to avoid use after free

2015-12-09 Thread Vlad Yasevich
to avoid > future mistakes. > > Reported-by: Dmitry Vyukov > Signed-off-by: Eric Dumazet Acked-by: Vlad Yasevich This is sufficient for accept() processing, but looks like peeloff is missing a bunch of ipv6 support. I'll see if I can cook something up to fix that part. -vlad > -

Re: use-after-free in sctp_do_sm

2015-12-07 Thread Vlad Yasevich
On 12/07/2015 02:50 PM, Marcelo Ricardo Leitner wrote: > On Mon, Dec 07, 2015 at 02:33:52PM -0500, Vlad Yasevich wrote: >> On 12/07/2015 01:52 PM, Marcelo Ricardo Leitner wrote: >>> On Mon, Dec 07, 2015 at 02:20:47PM +0100, Dmitry Vyukov wrote: >>>> On Mon, Dec 7, 20

Re: use-after-free in sctp_do_sm

2015-12-07 Thread Vlad Yasevich
On 12/07/2015 01:52 PM, Marcelo Ricardo Leitner wrote: > On Mon, Dec 07, 2015 at 02:20:47PM +0100, Dmitry Vyukov wrote: >> On Mon, Dec 7, 2015 at 2:15 PM, Marcelo Ricardo Leitner >> wrote: >>> On Mon, Dec 07, 2015 at 12:26:09PM +0100, Dmitry Vyukov wrote: >>>>

Re: use-after-free in sctp_do_sm

2015-12-05 Thread Vlad Yasevich
On 12/04/2015 04:34 PM, Marcelo Ricardo Leitner wrote: > On Fri, Dec 04, 2015 at 09:25:35PM +0100, Dmitry Vyukov wrote: >> On Fri, Dec 4, 2015 at 6:48 PM, Marcelo Ricardo Leitner >> wrote: >>> Hi Dmitry, >>> >>> Can you please test this patch? >>> I'll re-post with proper subject if it works. >> >

Re: [PATCH net 3/3] sctp: also copy sk_tsflags when copying the socket

2015-12-04 Thread Vlad Yasevich
Marcelo Ricardo Leitner Acked-by: Vlad Yasevich -vlad > --- > net/sctp/socket.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/sctp/socket.c b/net/sctp/socket.c > index > 4c9282bdd06790a0cca7f7c33986e7eb6c541398..1a32ecdb8bae98de2e76591f0f5ffee1441ff04d

Re: [PATCH net 2/3] sctp: update the netstamp_needed counter when copying sockets

2015-12-04 Thread Vlad Yasevich
ov > Signed-off-by: Marcelo Ricardo Leitner Acked-by: Vlad Yasevich -vlad > --- > include/net/sock.h | 2 ++ > net/core/sock.c| 2 -- > net/sctp/socket.c | 3 +++ > 3 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/include/net/sock.h b/include/ne

Re: [PATCH net 1/3] sctp: use the same clock as if sock source timestamps were on

2015-12-04 Thread Vlad Yasevich
was enabled or not. > > Fixes: 52db882f3fc2 ("net: sctp: migrate cookie life from timeval to ktime") > Signed-off-by: Marcelo Ricardo Leitner Acked-by: Vlad Yasevich -vlad > --- > net/sctp/sm_make_chunk.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletion

Re: use-after-free in sctp_do_sm

2015-12-04 Thread Vlad Yasevich
On 12/04/2015 07:55 AM, Marcelo Ricardo Leitner wrote: > On Fri, Dec 04, 2015 at 11:40:02AM +0100, Dmitry Vyukov wrote: >> On Thu, Dec 3, 2015 at 9:51 PM, Joe Perches wrote: >>> (adding lkml as this is likely better discussed there) >>> >>> On Thu, 2015-12-03 at 15:42 -0500, Jason Baron wrote: >>>

Re: use-after-free in sctp_do_sm

2015-12-03 Thread Vlad Yasevich
On 12/03/2015 01:06 PM, Marcelo wrote: > > > Em 3 de dezembro de 2015 15:59:10 BRST, Eric Dumazet > escreveu: >> On Thu, 2015-12-03 at 15:43 -0200, Marcelo Ricardo Leitner wrote: >> >>> Vlad, others, >>> >>> It's been a long time but this was introduced by commit 914e1c8b6980 >>> ("sctp: Inheri

Re: [PATCH] sctp: convert sack_needed and sack_generation to bits

2015-11-30 Thread Vlad Yasevich
On 11/30/2015 09:17 AM, Marcelo Ricardo Leitner wrote: > They don't need to be any bigger than that and with this we start a new > bitfield for tracking association runtime stuff, like zero window > situation. > > Signed-off-by: Marcelo Ricardo Leitner Acked-by: V

Re: use-after-free in sctp_do_sm

2015-11-25 Thread Vlad Yasevich
On 11/24/2015 03:45 PM, Neil Horman wrote: > On Tue, Nov 24, 2015 at 11:10:32AM +0100, Dmitry Vyukov wrote: >> On Tue, Nov 24, 2015 at 10:31 AM, Dmitry Vyukov wrote: >>> On Tue, Nov 24, 2015 at 10:15 AM, Dmitry Vyukov wrote: Hello, The following program triggers use-after-free in s

Re: [PATCH net] sctp: translate host order to network order when setting a hmacid

2015-11-12 Thread Vlad Yasevich
hmac_num_idents * sizeof(__u16)); > + for (i = 0; i < hmacs->shmac_num_idents; i++) > + ep->auth_hmacs_list->hmac_ids[i] = > htons(hmacs->shmac_idents[i]); > ep->auth_hmacs_list->param_hdr.length = htons(sizeof(sctp_paramhdr_t) + >

Re: [PATCH net] ipv6: don't use CHECKSUM_PARTIAL on MSG_MORE/UDP_CORK sockets

2015-10-20 Thread Vlad Yasevich
to add more data to the socket on the first packet. > > This broke checksum calculation for UDPv6 for NFS protocols. > > Fixes: 32dce968dd987 ("ipv6: Allow for partial checksums on non-ufo packets") > Cc: Vlad Yasevich > Tested-by: Sabrina Dubroca > Tested-by: B

Re: [PATCH net] ipv6: don't use CHECKSUM_PARTIAL on MSG_MORE/UDP_CORK sockets

2015-10-20 Thread Vlad Yasevich
to add more data to the socket on the first packet. > > This broke checksum calculation for UDPv6 for NFS protocols. > > Fixes: 32dce968dd987 ("ipv6: Allow for partial checksums on non-ufo packets") > Cc: Vlad Yasevich Acked-by: Vlad Yasevich -vlad > Tested-by

Re: [net-next PATCH] net: bridge: fix for bridging 802.1Q without REORDER_HDR

2015-09-15 Thread Vlad Yasevich
On 09/15/2015 02:17 PM, Phil Sutter wrote: > On Tue, Sep 15, 2015 at 11:11:53AM -0400, Vlad Yasevich wrote: >> On 09/14/2015 04:06 PM, Phil Sutter wrote: >>> On Mon, Sep 14, 2015 at 02:21:10PM -0400, Vlad Yasevich wrote: >>>> On 09/11/2015 04:20 PM, Phil Sutter wrote:

Re: [net-next PATCH] net: bridge: fix for bridging 802.1Q without REORDER_HDR

2015-09-15 Thread Vlad Yasevich
On 09/14/2015 04:06 PM, Phil Sutter wrote: > On Mon, Sep 14, 2015 at 02:21:10PM -0400, Vlad Yasevich wrote: >> On 09/11/2015 04:20 PM, Phil Sutter wrote: >>> On Fri, Sep 11, 2015 at 12:24:45PM -0700, Stephen Hemminger wrote: >>>> On Fri, 11 Sep 2015 21:22:03

Re: Any way to configure a vlan interface to grab ONLY untagged frames?

2015-09-14 Thread Vlad Yasevich
On 09/13/2015 12:49 PM, Nathan Neulinger wrote: > It seems like running 'vconfig add IFACE 0' and using IFACE.0 would do this, > but it > doesn't actually seem to work that way. > > If I capture on IFACE directly, I'd expect to get all traffic, including the > tagged frames > (with the tag intac

Re: [net-next PATCH] net: bridge: fix for bridging 802.1Q without REORDER_HDR

2015-09-14 Thread Vlad Yasevich
On 09/11/2015 04:20 PM, Phil Sutter wrote: > On Fri, Sep 11, 2015 at 12:24:45PM -0700, Stephen Hemminger wrote: >> On Fri, 11 Sep 2015 21:22:03 +0200 >> Phil Sutter wrote: >> >>> When forwarding packets from an 802.1Q interface with REORDER_HDR set to >>> zero, the VLAN header previously inserted

Re: [PATCH net] sctp: fix race on protocol/netns initialization

2015-09-10 Thread Vlad Yasevich
On 09/10/2015 02:35 PM, Marcelo Ricardo Leitner wrote: > On Thu, Sep 10, 2015 at 01:24:54PM -0300, Marcelo Ricardo Leitner wrote: >> On Thu, Sep 10, 2015 at 11:50:06AM -0400, Vlad Yasevich wrote: >>> On 09/10/2015 10:22 AM, Marcelo Ricardo Leitner wrote: >>>> Em 1

Re: [PATCH net] sctp: fix race on protocol/netns initialization

2015-09-10 Thread Vlad Yasevich
On 09/10/2015 10:22 AM, Marcelo Ricardo Leitner wrote: > Em 10-09-2015 10:24, Vlad Yasevich escreveu: >> On 09/09/2015 05:06 PM, Marcelo Ricardo Leitner wrote: >>> Em 09-09-2015 17:30, Vlad Yasevich escreveu: >>>> On 09/09/2015 04:03 PM, Marcelo Ricardo Leitner wrote:

Re: [PATCH net] sctp: fix race on protocol/netns initialization

2015-09-10 Thread Vlad Yasevich
On 09/09/2015 05:06 PM, Marcelo Ricardo Leitner wrote: > Em 09-09-2015 17:30, Vlad Yasevich escreveu: >> On 09/09/2015 04:03 PM, Marcelo Ricardo Leitner wrote: >>> Consider sctp module is unloaded and is being requested because an user >>> is creating a sctp socket. &g

Re: [PATCH net] sctp: fix race on protocol/netns initialization

2015-09-09 Thread Vlad Yasevich
On 09/09/2015 04:03 PM, Marcelo Ricardo Leitner wrote: > Consider sctp module is unloaded and is being requested because an user > is creating a sctp socket. > > During initialization, sctp will add the new protocol type and then > initialize pernet subsys: > > status = sctp_v4_protosw_in

Re: [PATCH net 0/2] couple of sctp fixes for 0ca50d12fe46

2015-09-03 Thread Vlad Yasevich
st leak > sctp: add routing output fallback > > net/sctp/protocol.c | 10 +- > 1 file changed, 9 insertions(+), 1 deletion(-) > For the series Acked-by: Vlad Yasevich -vlad -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of

Re: [PATCH net] sctp: support global vtag assochash and per endpoint s(d)port assochash table

2015-08-31 Thread Vlad Yasevich
On 08/31/2015 01:44 PM, Xin Long wrote: > for telecom center, the usual case is that a server is connected by thousands > of clients. but if the server with only one enpoint(udp style) use the same > sport and dport to communicate with every clients, and every assoc in server > will be hashed in th

Re: [PATCH net-next v2] bridge: vlan: allow to suppress local mac install for all vlans

2015-08-28 Thread Vlad Yasevich
On 08/28/2015 11:26 AM, Nikolay Aleksandrov wrote: > >> On Aug 28, 2015, at 5:31 AM, Vlad Yasevich wrote: >> >> On 08/27/2015 10:17 PM, Nikolay Aleksandrov wrote: >>> >>>> On Aug 27, 2015, at 4:47 PM, Vlad Yasevich wrote: >>>>

Re: [PATCH net v2] sctp: ASCONF-ACK with Unresolvable Address should be sent

2015-08-28 Thread Vlad Yasevich
t; (ESTABLISHED)(ESTABLISHED) > > ASCONF-> > (Delete IP Address) > <- ASCONF-ACK > (Unresolvable Address) > > Signed-off-by: X

Re: [PATCH net-next v2] bridge: vlan: allow to suppress local mac install for all vlans

2015-08-28 Thread Vlad Yasevich
On 08/27/2015 10:17 PM, Nikolay Aleksandrov wrote: > >> On Aug 27, 2015, at 4:47 PM, Vlad Yasevich wrote: >> >> On 08/27/2015 05:02 PM, Nikolay Aleksandrov wrote: >>> >>>> On Aug 26, 2015, at 9:57 PM, roopa wrote: >>>> >>>> On 8

Re: [PATCH net-next] macvtap/macvlan: use IFF_NO_QUEUE

2015-08-28 Thread Vlad Yasevich
On 08/27/2015 10:42 PM, Jason Wang wrote: > > > On 08/27/2015 06:43 PM, Michael S. Tsirkin wrote: >> On Wed, Aug 26, 2015 at 01:45:30PM +0800, Jason Wang wrote: >>> >>> On 08/26/2015 12:32 AM, Vlad Yasevich wrote: >>>> On 08/25/2015 07:30 AM, J

Re: [PATCH net v3] sctp: donot reset the overall_error_count in SHUTDOWN_RECEIVE state

2015-08-27 Thread Vlad Yasevich
* outstanding data and rely on the retransmission limit be reached >* to shutdown the association. >*/ > - if (t->asoc->state != SCTP_STATE_SHUTDOWN_PENDING) > + if (t->asoc->state < SCTP_STATE_SHUTDOWN_PENDING) > t->asoc->overall_err

Re: [PATCH net-next v2] bridge: vlan: allow to suppress local mac install for all vlans

2015-08-27 Thread Vlad Yasevich
On 08/27/2015 05:02 PM, Nikolay Aleksandrov wrote: > >> On Aug 26, 2015, at 9:57 PM, roopa wrote: >> >> On 8/26/15, 4:33 AM, Nikolay Aleksandrov wrote: On Aug 25, 2015, at 11:06 PM, David Miller wrote: From: Nikolay Aleksandrov Date: Tue, 25 Aug 2015 22:28:16 -0700

Re: [PATCH net v2] sctp: start t5 timer only when peer.rwnd is 0 and local.state is SHUTDOWN_PENDING

2015-08-27 Thread Vlad Yasevich
On 08/27/2015 10:49 AM, lucien xin wrote: >> >> So one potential way is to have peer.rwnd and peer.a_rwnd, where peer.a_rwnd >> is >> the window advertised by peer and peer.rwnd and our estimation based on >> peer.a_rwnd. >> This way we will always know where we stand. >> >> Although I am not sur

Re: [PATCH net v2] sctp: start t5 timer only when peer.rwnd is 0 and local.state is SHUTDOWN_PENDING

2015-08-27 Thread Vlad Yasevich
On 08/27/2015 09:19 AM, lucien xin wrote: >> >> No, these are 2 distinct instances. In one instance, the peer is reachable >> and >> is able to communication 0 rwnd state to us. Thus we are being nice and >> granting >> the peer more time to exit the 0 window state. >> >> In the other state, th

Re: [PATCH net v4] sctp: asconf's process should verify address parameter is in the beginning

2015-08-27 Thread Vlad Yasevich
t; Signed-off-by: Marcelo Ricardo Leitner Looks good to me. Acked-by: Vlad Yasevich -vlad > --- > net/sctp/sm_make_chunk.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c > index 06320c8..a655d

Re: [PATCH net v3] sctp: asconf's process should verify address parameter is in the beginning

2015-08-26 Thread Vlad Yasevich
On 08/26/2015 05:09 PM, lucien xin wrote: > On Thu, Aug 27, 2015 at 4:59 AM, Marcelo Ricardo Leitner > wrote: >> On Wed, Aug 26, 2015 at 04:42:21PM -0400, Vlad Yasevich wrote: >>> On 08/26/2015 04:35 PM, Xin Long wrote: >>>> in sctp_process_asconf(), we get addres

Re: [PATCH net v4] sctp: asconf's process should verify address parameter is in the beginning

2015-08-26 Thread Vlad Yasevich
tp_process_asconf(), it will not be safe. > > so add detection in sctp_verify_asconf() to check the address parameter is in > the beginning, or return false to send abort. > > Signed-off-by: Xin Long > Signed-off-by: Vlad Yasevich Acked-by: Vlad Yasevich -vlad > --- >

Re: [PATCH net v3] sctp: asconf's process should verify address parameter is in the beginning

2015-08-26 Thread Vlad Yasevich
multiple address detection from first address detection. They are 2 different bugs and each one deserves a separate commit and changelog. Thanks -vlad > v1->v2: > * put the check behind the params' length verify. > > Signed-off-by: Xin Long > Signed-off-by: Vlad Yasevich &g

Re: [PATCH net v2] sctp: donot reset the overall_error_count in SHUTDOWN_RECEIVE state

2015-08-26 Thread Vlad Yasevich
On 08/23/2015 07:30 AM, Xin Long wrote: > commit f8d960524 fix the 0 peer.rwnd issue in SHUTDOWN_PENDING state through > not reseting the overall_error_count when receive a heartbeat, but the same > issue also exists in SHUTDOWN_RECEIVE state. > > so we change the condition to state < SCTP_STATE_S

Re: [PATCH net-next v2] bridge: vlan: allow to suppress local mac install for all vlans

2015-08-26 Thread Vlad Yasevich
On 08/26/2015 02:10 AM, B Viswanath wrote: >>> >>> I'd rather we fix the essence of the scalability problem than add >>> more spaghetti code to the various bridge paths. >>> >>> Can we make the fdb entries smaller? >>> >>> Can we enhance how we store such local entries such that they live in >>> a

Re: [PATCH net-next] bridge: vlan: allow to suppress local mac install for all vlans

2015-08-26 Thread Vlad Yasevich
On 08/24/2015 08:55 PM, Nikolay Aleksandrov wrote: > From: Nikolay Aleksandrov > > This patch adds a new knob that, when enabled, allows to suppress the > installation of local fdb entries in newly created vlans. This could > pose a big scalability issue if we have a large number of ports and a >

Re: [PATCH net-next] macvtap/macvlan: use IFF_NO_QUEUE

2015-08-25 Thread Vlad Yasevich
On 08/25/2015 07:30 AM, Jason Wang wrote: > > > On 08/25/2015 06:17 PM, Michael S. Tsirkin wrote: >> On Mon, Aug 24, 2015 at 04:33:12PM +0800, Jason Wang wrote: For macvlan, switch to use IFF_NO_QUEUE instead of tx_queue_len = 0. For macvtap, after commit 6acf54f1cf0a6747bac9fea26f

Re: [PATCH net] sctp: asconf process should treat multiple address parameter as unrecognized parameter

2015-08-25 Thread Vlad Yasevich
On 08/25/2015 10:18 AM, Marcelo Ricardo Leitner wrote: > On Tue, Aug 25, 2015 at 08:43:10PM +0800, lucien xin wrote: >> On Tue, Aug 25, 2015 at 8:39 PM, lucien xin wrote: I think it would be much better to catch this in the validation stage. If an implementation inserts multiple add

Re: [PATCH net v2] sctp: asconf's process should verify address parameter is in the beginning

2015-08-25 Thread Vlad Yasevich
On 08/25/2015 10:01 AM, Marcelo Ricardo Leitner wrote: > On Tue, Aug 25, 2015 at 08:29:24PM +0800, Xin Long wrote: >> in sctp_process_asconf(), we get address parameter from the beginning of >> the addip params. but we never check if it's really there. if the addr >> param is not there, it still ca

Re: [PATCH net v2] sctp: start t5 timer only when peer.rwnd is 0 and local.state is SHUTDOWN_PENDING

2015-08-24 Thread Vlad Yasevich
On 08/24/2015 02:31 PM, Marcelo Ricardo Leitner wrote: > On Mon, Aug 24, 2015 at 02:13:38PM -0400, Vlad Yasevich wrote: >> On 08/23/2015 07:30 AM, Xin Long wrote: >>> when A sends a data to B, then A close() and enter into SHUTDOWN_PENDING >>> state, >>> if B

Re: Low throughput in VMs using VxLAN

2015-08-24 Thread Vlad Yasevich
On 08/24/2015 12:19 PM, Santosh R wrote: > Hi, > >Earlier I was seeing lower throughput in VMs using VxLan as GRO was > not happening in VM. > Tom Herbert suggested to use "vxlan: GRO support at tunnel layer" patch > series. > With today's net-next (4.2.0-rc7) in host and VM, I could see GRO

  1   2   3   4   >