On 05/30/2017 01:12 PM, Stephen Hemminger wrote:
> On Sat, 27 May 2017 10:14:36 -0400
> Vladislav Yasevich <vyasev...@gmail.com> wrote:
>
>>
>> +static const char *netdev_events[] = {"NONE",
>> + "REBOOT",
>> + "FEATURE CHANGE",
>> + "BONDING FAILOVER",
>> + "NOTIFY PEERS",
>> + "RESEND IGMP",
>> + "BONDING OPTION"};
>
> Overall this looks fine, I will pickup the if_link.h from net-next.
>
> One stylistic change.
>
> Please add simple line break, and initialize by value:
>
> static const char *netdev_events[] = {
> [IFLA_EVENT_NONE] = "NONE",
> ...
>
> Do you want some prefix or bounding around the event output?
Don't really care about output from my side. If you think some prefix
would be good, I can surely add it.
> Also a little concerned that the output format change may break some program
> could the new output be at the end of the line?
>
I can try moving it to the end.
Thanks
-vlad
