Re: [PATCH net-next v2 0/3] mlxsw: spectrum_buffers: Add the ability to query the CPU port's shared buffer

2019-09-16 Thread Shalom Toledo
_init/fini() > > Patch #2: > * Move "changing CPU port's threshold and binding" check to a separate > patch > > Shalom Toledo (3): > mlxsw: spectrum_buffers: Prevent changing CPU port's configuration > mlxsw: spectrum: Register CPU port with devlink &g

Re: [PATCH net-next 1/2] mlxsw: spectrum: Register CPU port with devlink

2019-09-13 Thread Shalom Toledo
On Fri, Sep 13, 2019 at 10:02:23AM +0200, Jiri Pirko wrote: > Thu, Sep 12, 2019 at 03:07:39PM CEST, ido...@idosch.org wrote: > >From: Shalom Toledo > > > >Register CPU port with devlink. > > > >Signed-off-by: Shalom Toledo > >Signed-off-by: Ido Schimmel &

[PATCH net-next] mlxsw: spectrum_ptp: Fix compilation on 32-bit ARM

2019-06-18 Thread Shalom Toledo
hc_settime': spectrum_ptp.c:(.text+0x39c): undefined reference to `__aeabi_uldivmod' Fix by using div_u64(). Fixes: 992aa864dca0 ("mlxsw: spectrum_ptp: Add implementation for physical hardware clock operations") Signed-off-by: Shalom Toledo Reviewed-by: Ido Schimmel Reported-by: Natha

Re: [PATCH net-next 9/9] selftests: ptp: Add Physical Hardware Clock test

2019-06-11 Thread Shalom Toledo
On 07/06/2019 14:15, Vladimir Oltean wrote: > On Mon, 3 Jun 2019 at 15:25, Ido Schimmel wrote: >> >> From: Shalom Toledo >> >> Test the PTP Physical Hardware Clock functionality using the "phc_ctl" (a >> part of "linuxptp"). >>

Re: [PATCH net-next 4/9] mlxsw: reg: Add Management UTC Register

2019-06-06 Thread Shalom Toledo
On 06/06/2019 5:37, Richard Cochran wrote: > On Wed, Jun 05, 2019 at 06:55:18PM +0000, Shalom Toledo wrote: >> On 05/06/2019 20:23, Richard Cochran wrote: >>> On Wed, Jun 05, 2019 at 11:30:06AM +0000, Shalom Toledo wrote: >>>> On 04/06/2019 17:17, Richard Cochran wro

Re: [PATCH net-next 7/9] mlxsw: spectrum_ptp: Add implementation for physical hardware clock operations

2019-06-06 Thread Shalom Toledo
On 06/06/2019 11:50, Shalom Toledo wrote: > On 06/06/2019 5:43, Richard Cochran wrote: >> On Wed, Jun 05, 2019 at 07:28:38PM +0000, Shalom Toledo wrote: >>> So, there is an HW machine which responsible for adding UTC timestamp on >>> R-SPAN mirror packets and there is n

Re: [PATCH net-next 7/9] mlxsw: spectrum_ptp: Add implementation for physical hardware clock operations

2019-06-06 Thread Shalom Toledo
On 06/06/2019 5:43, Richard Cochran wrote: > On Wed, Jun 05, 2019 at 07:28:38PM +0000, Shalom Toledo wrote: >> So, there is an HW machine which responsible for adding UTC timestamp on >> R-SPAN mirror packets and there is no connection to the HW free running >> counter

Re: [PATCH net-next 7/9] mlxsw: spectrum_ptp: Add implementation for physical hardware clock operations

2019-06-05 Thread Shalom Toledo
On 05/06/2019 20:40, Richard Cochran wrote: > On Wed, Jun 05, 2019 at 11:44:21AM +0000, Shalom Toledo wrote: >> On 04/06/2019 17:28, Richard Cochran wrote: >>> Now I see why you did this. Nice try. >> >> I didn't try anything. >> >> The reason

Re: [PATCH net-next 4/9] mlxsw: reg: Add Management UTC Register

2019-06-05 Thread Shalom Toledo
On 05/06/2019 20:23, Richard Cochran wrote: > On Wed, Jun 05, 2019 at 11:30:06AM +0000, Shalom Toledo wrote: >> On 04/06/2019 17:17, Richard Cochran wrote: >>> On Mon, Jun 03, 2019 at 03:12:39PM +0300, Ido Schimmel wrote: >>>> From: Shalom Toledo >>>> >

Re: [PATCH net-next 6/9] ptp: ptp_clock: Publish scaled_ppm_to_ppb

2019-06-05 Thread Shalom Toledo
On 04/06/2019 17:21, Richard Cochran wrote: > On Mon, Jun 03, 2019 at 03:12:41PM +0300, Ido Schimmel wrote: >> From: Shalom Toledo >> >> Publish scaled_ppm_to_ppb to allow drivers to use it. > > But why? See my comment in patch #7 > >> @@ -63,7 +63,7 @@ st

Re: [PATCH net-next 7/9] mlxsw: spectrum_ptp: Add implementation for physical hardware clock operations

2019-06-05 Thread Shalom Toledo
On 04/06/2019 17:28, Richard Cochran wrote: > On Mon, Jun 03, 2019 at 03:12:42PM +0300, Ido Schimmel wrote: > >> +static int >> +mlxsw_sp1_ptp_update_phc_settime(struct mlxsw_sp_ptp_clock *clock, u64 nsec) > > Six words ^^^ > > What is wrong with "mlxsw_phc_settime" ? I can drop the "update". B

Re: [PATCH net-next 4/9] mlxsw: reg: Add Management UTC Register

2019-06-05 Thread Shalom Toledo
On 04/06/2019 17:17, Richard Cochran wrote: > On Mon, Jun 03, 2019 at 03:12:39PM +0300, Ido Schimmel wrote: >> From: Shalom Toledo >> >> The MTUTC register configures the HW UTC counter. > > Why is this called the "UTC" counter? > > The PTP time

[PATCH net-next] mlxfw: Replace license text with SPDX identifiers and adjust copyrights

2019-01-23 Thread Shalom Toledo
Signed-off-by: Shalom Toledo Acked-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxfw/mlxfw.h | 35 ++ .../net/ethernet/mellanox/mlxfw/mlxfw_fsm.c | 35 ++ .../net/ethernet/mellanox/mlxfw/mlxfw_mfa2.c | 35 ++ .../net/ethernet/mellanox

[PATCH iproute2-next 1/2] devlink: Add string to uint{8,16,32} conversion for generic parameters

2018-12-04 Thread Shalom Toledo
Allow setting u{8,16,32} generic parameters as a well defined strings in devlink user space tool. Signed-off-by: Shalom Toledo Reviewed-by: Jiri Pirko --- devlink/devlink.c | 145 ++ 1 file changed, 135 insertions(+), 10 deletions(-) diff --git a

[PATCH iproute2-next 2/2] devlink: Add support for 'fw_load_policy' generic parameter

2018-12-04 Thread Shalom Toledo
Add string to uint conversion for 'fw_load_policy' generic parameter. Signed-off-by: Shalom Toledo Reviewed-by: Jiri Pirko --- devlink/devlink.c| 13 - include/uapi/linux/devlink.h | 5 + 2 files changed, 17 insertions(+), 1 deletion(-) diff --git

[PATCH iproute2-next 0/2] devlink: Add support for 'fw_load_policy' generic parameter

2018-12-04 Thread Shalom Toledo
Patch #1 add string to uint conversion support for generic parameters. Patch #2 add string to uint support for 'fw_load_policy' generic parameter Shalom Toledo (2): devlink: Add string to uint{8,16,32} conversion for generic parameters devlink: Add support for 'fw_load_

[PATCH linux-firmware 0/2] Mellanox: Add new mlxsw_spectrum firmware 13.1530.152

2017-11-08 Thread Shalom Toledo
This set adds a new firmware version 13.1530.152 as well as information about the previous firmware version of the mlxsw_spectrum driver Shalom Toledo (2): WHENCE: Add missing entry for mlxsw_spectrum firmware Mellanox: Add new mlxsw_spectrum firmware 13.1530.152 WHENCE

[PATCH linux-firmware 1/2] WHENCE: Add missing entry for mlxsw_spectrum firmware

2017-11-08 Thread Shalom Toledo
Fixes: a4c72696f5f4 ("Mellanox: Add firmware for mlxsw_spectrum") Signed-off-by: Shalom Toledo --- WHENCE | 37 + 1 file changed, 37 insertions(+) diff --git a/WHENCE b/WHENCE index b2dc6a1..2a6dde8 100644 --- a/WHENCE +++ b/WHENCE @@ -3684,