On 04/06/2019 17:21, Richard Cochran wrote: > On Mon, Jun 03, 2019 at 03:12:41PM +0300, Ido Schimmel wrote: >> From: Shalom Toledo <shal...@mellanox.com> >> >> Publish scaled_ppm_to_ppb to allow drivers to use it. > > But why?
See my comment in patch #7 > >> @@ -63,7 +63,7 @@ static void enqueue_external_timestamp(struct >> timestamp_event_queue *queue, >> spin_unlock_irqrestore(&queue->lock, flags); >> } >> >> -static s32 scaled_ppm_to_ppb(long ppm) >> +s32 ptp_clock_scaled_ppm_to_ppb(long ppm) > > Six words is a little bit much for the name of a function. I can make it scaled_ppm_to_ppb() as before. Is that ok? or maybe you have something else in your mind? > > Thanks, > Richard >
