Re: linux-next: build failure after merge of the tip tree

2021-03-27 Thread Sedat Dilek
On Fri, Mar 26, 2021 at 2:11 PM Borislav Petkov wrote: > > On Fri, Mar 26, 2021 at 09:57:43AM +0100, Sedat Dilek wrote: > > The commit b90829704780 "bpf: Use NOP_ATOMIC5 instead of > > emit_nops(&prog, 5) for BPF_TRAMP_F_CALL_ORIG" is now in Linus Git > > (

Re: linux-next: build failure after merge of the tip tree

2021-03-26 Thread Sedat Dilek
On Mon, Mar 22, 2021 at 10:02 AM Borislav Petkov wrote: > > On Mon, Mar 22, 2021 at 02:37:14PM +1100, Stephen Rothwell wrote: > > Hi all, > > > > After merging the tip tree, today's linux-next build (x86_64 allmodconfig) > > failed like this: > > > > arch/x86/net/bpf_jit_comp.c: In function 'arch_

Re: linux-next: build failure after merge of the tip tree

2021-03-23 Thread Sedat Dilek
On Mon, Mar 22, 2021 at 4:39 AM Stephen Rothwell wrote: > > Hi all, > > After merging the tip tree, today's linux-next build (x86_64 allmodconfig) > failed like this: > > arch/x86/net/bpf_jit_comp.c: In function 'arch_prepare_bpf_trampoline': > arch/x86/net/bpf_jit_comp.c:2015:16: error: 'ideal_no

Re: [PATCHv2] btf_encoder: Match ftrace addresses within elf functions

2021-02-17 Thread Sedat Dilek
On Wed, Feb 17, 2021 at 2:56 PM Arnaldo Carvalho de Melo wrote: > > > > On February 17, 2021 10:40:43 AM GMT-03:00, Sedat Dilek > wrote: > >On Wed, Feb 17, 2021 at 1:44 PM Arnaldo Carvalho de Melo > > wrote: > >> > >> Em Sat, Feb 13,

Re: [PATCHv2] btf_encoder: Match ftrace addresses within elf functions

2021-02-17 Thread Sedat Dilek
On Wed, Feb 17, 2021 at 1:44 PM Arnaldo Carvalho de Melo wrote: > > Em Sat, Feb 13, 2021 at 05:46:48PM +0100, Jiri Olsa escreveu: > > Currently when processing DWARF function, we check its entrypoint > > against ftrace addresses, assuming that the ftrace address matches > > with function's entrypo

Re: [PATCHv2] btf_encoder: Match ftrace addresses within elf functions

2021-02-13 Thread Sedat Dilek
-x86/ > Acked-by: Andrii Nakryiko > Signed-off-by: Jiri Olsa Tested this v2 together with "btf_encoder: sanitize non-regular int base type" v2 on top of pahole v1.20 Tested-by: Sedat Dilek # Linux v5.11-rc7+ and LLVM/Clang v12.0.0-rc1 on x86 (64bit) - Sedat - &

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-11 Thread Sedat Dilek
On Thu, Feb 11, 2021 at 5:07 PM Jiri Olsa wrote: > > On Thu, Feb 11, 2021 at 04:43:48PM +0100, Sedat Dilek wrote: > > SNIP > > > > > filled with elf functions start/end values, right? > > > > > > > > > /* > > &

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-11 Thread Sedat Dilek
On Thu, Feb 11, 2021 at 4:08 PM Jiri Olsa wrote: > > On Wed, Feb 10, 2021 at 09:13:47PM +0100, Jiri Olsa wrote: > > On Wed, Feb 10, 2021 at 10:20:20AM -0800, Andrii Nakryiko wrote: > > > > SNIP > > > > > > but below is change for checking that ftrace addrs are within elf > > > > functions > > > >

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-10 Thread Sedat Dilek
On Wed, Feb 10, 2021 at 7:20 PM Andrii Nakryiko wrote: > > On Wed, Feb 10, 2021 at 5:26 AM Jiri Olsa wrote: > > > > On Tue, Feb 09, 2021 at 02:00:29PM -0800, Andrii Nakryiko wrote: > > > > SNIP > > > > > > > > I'm still trying to build the kernel.. however ;-) > > > > > > > > > > > > patch below

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-09 Thread Sedat Dilek
On Tue, Feb 9, 2021 at 6:12 PM Nick Desaulniers wrote: > > On Tue, Feb 9, 2021 at 9:07 AM Sedat Dilek wrote: > > > > We should ask linux-kbuild/Masahiro to have an option to OVERRIDE: > > When scripts/link-vmlinux.sh fails all generated files like vmlinux get >

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-09 Thread Sedat Dilek
On Tue, Feb 9, 2021 at 5:35 PM Nathan Chancellor wrote: > > On Tue, Feb 09, 2021 at 05:13:38PM +0100, Jiri Olsa wrote: > > On Tue, Feb 09, 2021 at 04:09:36PM +0100, Jiri Olsa wrote: > > > > SNIP > > > > > > > > > DW_AT_prototyped(true) > > > > > > > DW_AT_ty

Re: [PATCH] bpf: Hoise pahole version checks into Kconfig

2021-02-04 Thread Sedat Dilek
d require pahole to be installed with an > appropriate version to select and use CONFIG_DEBUG_INFO_BTF, which is > standard for options that require a specific tools version. > > Suggested-by: Sedat Dilek > Signed-off-by: Nathan Chancellor > --- > MAINTAINERS | 1

Re: [PATCH] bpf: Hoise pahole version checks into Kconfig

2021-02-03 Thread Sedat Dilek
On Thu, Jan 14, 2021 at 12:07 AM Nathan Chancellor wrote: > > On Wed, Jan 13, 2021 at 02:38:27PM -0800, Andrii Nakryiko wrote: > > Hm.. Just saw Linus proposing using $(error-if) in Kconfig for an > > unrelated issue ([0]). If we can make this work, then it would catch > > such issue early on, yet

Re: [PATCH RFC v2] tools: Factor Clang, LLC and LLVM utils definitions

2021-01-27 Thread Sedat Dilek
On Thu, Jan 28, 2021 at 2:41 AM Andrii Nakryiko wrote: > > On Wed, Jan 27, 2021 at 5:30 PM Sedat Dilek wrote: > > > > On Thu, Jan 28, 2021 at 2:27 AM Andrii Nakryiko > > wrote: > > > > > > On Thu, Jan 21, 2021 at 4:32 PM Sedat Dilek wrote: > >

[PATCH bpf-next] tools: Factor Clang, LLC and LLVM utils definitions

2021-01-27 Thread Sedat Dilek
bpf-next. CC: b...@vger.kernel.org Acked-by: Andrii Nakryiko Acked-by: Jiri Olsa # tools/build and tools/perf Signed-off-by: Sedat Dilek --- tools/bpf/bpftool/Makefile | 2 -- tools/bpf/runqslower/Makefile | 3 --- tools/build/feature/Makefile

Re: [PATCH RFC v2] tools: Factor Clang, LLC and LLVM utils definitions

2021-01-27 Thread Sedat Dilek
On Thu, Jan 28, 2021 at 2:27 AM Andrii Nakryiko wrote: > > On Thu, Jan 21, 2021 at 4:32 PM Sedat Dilek wrote: > > > > When dealing with BPF/BTF/pahole and DWARF v5 I wanted to build bpftool. > > > > While looking into the source code I found duplicate assignments

[PATCH RFC v2] tools: Factor Clang, LLC and LLVM utils definitions

2021-01-21 Thread Sedat Dilek
Linux v5.11-rc4. I hope to get some feedback from especially Linux-bpf folks. Acked-by: Jiri Olsa # tools/build and tools/perf Signed-off-by: Sedat Dilek --- Changelog RFC v1->v2: - Add Jiri's ACK - Adapt to fit Linux v5.11-rc4 tools/bpf/bpftool/Makefile | 2 -- tools

Re: [PATCH RFC] tools: Factor Clang, LLC and LLVM utils definitions

2021-01-21 Thread Sedat Dilek
On Fri, Jan 22, 2021 at 1:21 AM Sedat Dilek wrote: > > On Fri, Jan 22, 2021 at 1:12 AM Sedat Dilek wrote: > > > > On Fri, Jan 22, 2021 at 1:04 AM Andrii Nakryiko > > wrote: > > > > > > On Wed, Jan 20, 2021 at 2:36 PM Jiri Olsa wrote: > > >

Re: [PATCH RFC] tools: Factor Clang, LLC and LLVM utils definitions

2021-01-21 Thread Sedat Dilek
On Fri, Jan 22, 2021 at 1:12 AM Sedat Dilek wrote: > > On Fri, Jan 22, 2021 at 1:04 AM Andrii Nakryiko > wrote: > > > > On Wed, Jan 20, 2021 at 2:36 PM Jiri Olsa wrote: > > > > > > On Sat, Jan 16, 2021 at 10:54:04AM +0100, Sedat Dilek wrote: > > >

Re: [PATCH RFC] tools: Factor Clang, LLC and LLVM utils definitions

2021-01-21 Thread Sedat Dilek
On Fri, Jan 22, 2021 at 1:04 AM Andrii Nakryiko wrote: > > On Wed, Jan 20, 2021 at 2:36 PM Jiri Olsa wrote: > > > > On Sat, Jan 16, 2021 at 10:54:04AM +0100, Sedat Dilek wrote: > > > When dealing with BPF/BTF/pahole and DWARF v5 I wanted to build bpftool. > &g

Re: [PATCH bpf-next v3] samples/bpf: Update build procedure for manually compiling LLVM and Clang

2021-01-21 Thread Sedat Dilek
On Thu, Jan 21, 2021 at 9:55 AM Sedat Dilek wrote: > > On Thu, Jan 21, 2021 at 9:08 AM Andrii Nakryiko > wrote: > > > > On Wed, Jan 20, 2021 at 9:36 PM Nathan Chancellor > > wrote: > > > > > > On Thu, Jan 21, 2021 at 01:27:35PM +0800, Tiezhu Yang wr

Re: [PATCH bpf-next v3] samples/bpf: Update build procedure for manually compiling LLVM and Clang

2021-01-21 Thread Sedat Dilek
On Thu, Jan 21, 2021 at 9:08 AM Andrii Nakryiko wrote: > > On Wed, Jan 20, 2021 at 9:36 PM Nathan Chancellor > wrote: > > > > On Thu, Jan 21, 2021 at 01:27:35PM +0800, Tiezhu Yang wrote: > > > The current LLVM and Clang build procedure in samples/bpf/README.rst is > > > out of date. See below tha

Re: [PATCH RFC] tools: Factor Clang, LLC and LLVM utils definitions

2021-01-20 Thread Sedat Dilek
On Wed, Jan 20, 2021 at 11:36 PM Jiri Olsa wrote: > > On Sat, Jan 16, 2021 at 10:54:04AM +0100, Sedat Dilek wrote: > > When dealing with BPF/BTF/pahole and DWARF v5 I wanted to build bpftool. > > > > While looking into the source code I found duplicate assignments > &

[PATCH RFC] tools: Factor Clang, LLC and LLVM utils definitions

2021-01-16 Thread Sedat Dilek
Linux v5.11-rc3. I hope to get some feedback from especially Linux-bpf folks. Signed-off-by: Sedat Dilek --- tools/bpf/bpftool/Makefile | 2 -- tools/bpf/runqslower/Makefile | 3 --- tools/build/feature/Makefile| 4 ++-- tools/perf/Makefile

Re: [PATCH] bpf: Hoise pahole version checks into Kconfig

2021-01-12 Thread Sedat Dilek
d require pahole to be installed with an > appropriate version to select and use CONFIG_DEBUG_INFO_BTF, which is > standard for options that require a specific tools version. > > Suggested-by: Sedat Dilek > Signed-off-by: Nathan Chancellor Thanks for the patch, Nathan, Might be good to g

Re: Flaw in "random32: update the net random state on interrupt and activity"

2021-01-08 Thread Sedat Dilek
On Fri, Jan 8, 2021 at 4:41 PM Eric Dumazet wrote: > > On Fri, Jan 8, 2021 at 2:51 PM Sedat Dilek wrote: > > > > On Fri, Jan 8, 2021 at 2:08 PM Sedat Dilek wrote: > > > > > > On Wed, Aug 12, 2020 at 6:25 PM Eric Dumazet wrote: > > > > >

Re: Flaw in "random32: update the net random state on interrupt and activity"

2021-01-08 Thread Sedat Dilek
On Fri, Jan 8, 2021 at 2:08 PM Sedat Dilek wrote: > > On Wed, Aug 12, 2020 at 6:25 PM Eric Dumazet wrote: > > > > Also, I tried the diff for tcp_conn_request... > > > With removing the call to prandom_u32() not useful for > > > prandom_u32/tracing via perf. &

Re: Flaw in "random32: update the net random state on interrupt and activity"

2021-01-08 Thread Sedat Dilek
On Wed, Aug 12, 2020 at 6:25 PM Eric Dumazet wrote: > > Also, I tried the diff for tcp_conn_request... > > With removing the call to prandom_u32() not useful for > > prandom_u32/tracing via perf. > > I am planning to send the TCP patch once net-next is open. (probably next > week) Ping. What i

[PATCH] kbuild: explicitly specify the build id style

2020-09-24 Thread Sedat Dilek
[ Please CC me I am not subscribed to all MLs ] [ CC Sami ] Hi Bill, I have tested your patch on top of Sami's latest clang-cfi Git branch. Feel free to add... Tested-by: Sedat Dilek # LLVM toolchain version 11.0.0-rc3 on x86-64 Thanks for the patch. Regards, - Sedat -

Re: [PATCH 1/2] random32: make prandom_u32() output unpredictable

2020-09-14 Thread Sedat Dilek
On Mon, Sep 14, 2020 at 6:29 PM Willy Tarreau wrote: > > On Mon, Sep 14, 2020 at 06:16:40PM +0200, Sedat Dilek wrote: > > On Mon, Sep 14, 2020 at 4:53 PM Amit Klein wrote: > > > > > > Hi > > > > > > Is this patch being pushed to any branch? I d

Re: [PATCH 1/2] random32: make prandom_u32() output unpredictable

2020-09-14 Thread Sedat Dilek
On Mon, Sep 14, 2020 at 4:53 PM Amit Klein wrote: > > Hi > > Is this patch being pushed to any branch? I don't see it deployed anywhere > (unless I'm missing something...). > It's here: [1] https://git.kernel.org/pub/scm/linux/kernel/git/wtarreau/prandom.git/log/?h=20200901-siphash-noise > Be

Re: [PATCH 0/2] prandom_u32: make output less predictable

2020-09-01 Thread Sedat Dilek
orge Spelvin > Cc: Amit Klein > Cc: Eric Dumazet > Cc: "Jason A. Donenfeld" > Cc: Andy Lutomirski > Cc: Kees Cook > Cc: Thomas Gleixner > Cc: Peter Zijlstra > Cc: Linus Torvalds > Cc: ty...@mit.edu > Cc: Florian Westphal > Cc: Marc Plumb &

Re: [PATCH 1/2] random32: make prandom_u32() output unpredictable

2020-09-01 Thread Sedat Dilek
On Tue, Sep 1, 2020 at 10:57 AM Willy Tarreau wrote: > > On Tue, Sep 01, 2020 at 10:46:16AM +0200, Sedat Dilek wrote: > > Will you push the updated patchset to your prandom Git - for easy fetching? > > Yeah if you want, feel free to use this one : > > https://git.

Re: [PATCH 1/2] random32: make prandom_u32() output unpredictable

2020-09-01 Thread Sedat Dilek
On Tue, Sep 1, 2020 at 10:39 AM Willy Tarreau wrote: > > On Tue, Sep 01, 2020 at 10:33:40AM +0200, Yann Ylavic wrote: > > On Tue, Sep 1, 2020 at 8:45 AM Willy Tarreau wrote: > > > > > > +/* > > > + * Generate some initially weak seeding values to allow > > > + * the prandom_u32() engine t

Re: [DRAFT PATCH] random32: make prandom_u32() output unpredictable

2020-08-27 Thread Sedat Dilek
d Clang-LTO (LinkTime Optimization) #6: LLVM toolchain v11.0.0-rc2 and Clang-CFI (Control Flow Integrity) For what are you waiting for :-)? Feel free to add my... Tested-by: Sedat Dilek If you are interested in Clang-IAS/Clang-LTO/Clang-CFI... I want to promote the LLVM MC (micro-conference)

Re: [DRAFT PATCH] random32: make prandom_u32() output unpredictable

2020-08-20 Thread Sedat Dilek
On Thu, Aug 20, 2020 at 10:05 AM Willy Tarreau wrote: > > On Thu, Aug 20, 2020 at 08:58:38AM +0200, Willy Tarreau wrote: > > I've just pushed a new branch "20200820-siphash-noise" that I also > > rebased onto latest master. It's currently running make allmodconfig > > here, so that will take a whi

Re: [DRAFT PATCH] random32: make prandom_u32() output unpredictable

2020-08-19 Thread Sedat Dilek
On Thu, Aug 20, 2020 at 6:33 AM Willy Tarreau wrote: > > On Thu, Aug 20, 2020 at 05:05:49AM +0200, Sedat Dilek wrote: > > We have the same defines for K0 and K1 in include/linux/prandom.h and > > lib/random32.c? > > More room for simplifications? > > Definitely,

Re: [DRAFT PATCH] random32: make prandom_u32() output unpredictable

2020-08-19 Thread Sedat Dilek
On Sun, Aug 16, 2020 at 6:48 PM Sedat Dilek wrote: > > On Sun, Aug 16, 2020 at 5:01 PM Willy Tarreau wrote: > > > > Hi, > > > > so as I mentioned, I could run several test on our lab with variations > > around the various proposals and come to quite pos

Re: Flaw in "random32: update the net random state on interrupt and activity"

2020-08-19 Thread Sedat Dilek
On Wed, Aug 12, 2020 at 6:38 PM Sedat Dilek wrote: > > On Wed, Aug 12, 2020 at 6:25 PM Eric Dumazet wrote: > > > > On Wed, Aug 12, 2020 at 9:20 AM Sedat Dilek wrote: > > > > > > On Wed, Aug 12, 2020 at 5:16 PM Eric Dumazet > > > wrote: > &

Re: [DRAFT PATCH] random32: make prandom_u32() output unpredictable

2020-08-16 Thread Sedat Dilek
On Sun, Aug 16, 2020 at 5:01 PM Willy Tarreau wrote: > > Hi, > > so as I mentioned, I could run several test on our lab with variations > around the various proposals and come to quite positive conclusions. > > Synthetic observations: the connection rate and the SYN cookie rate do not > seem to be

Re: [DRAFT PATCH] random32: make prandom_u32() output unpredictable

2020-08-14 Thread Sedat Dilek
On Fri, Aug 14, 2020 at 6:05 PM Willy Tarreau wrote: > > On Fri, Aug 14, 2020 at 05:32:32PM +0200, Sedat Dilek wrote: > > commit 94c7eb54c4b8e81618ec79f414fe1ca5767f9720 > > "random32: add a tracepoint for prandom_u32()" > > > > ...I gave Willy's patch

Re: [DRAFT PATCH] random32: make prandom_u32() output unpredictable

2020-08-14 Thread Sedat Dilek
On Thu, Aug 13, 2020 at 10:06 AM Willy Tarreau wrote: > > On Thu, Aug 13, 2020 at 09:53:11AM +0200, Sedat Dilek wrote: > > On Wed, Aug 12, 2020 at 5:21 AM Willy Tarreau wrote: > > > > > > On Tue, Aug 11, 2020 at 12:51:43PM +0200, Sedat Dilek wrote: > > > &g

Re: [PATCH net] random32: add a tracepoint for prandom_u32()

2020-08-13 Thread Sedat Dilek
tcp_rcv_state_process > ... > perf script > > Signed-off-by: Eric Dumazet > Cc: Willy Tarreau > Cc: Sedat Dilek Thanks for the patch and embedding a list of instructions with linux-perf. Tested-by: Sedat Dilek - Sedat - >

Re: [DRAFT PATCH] random32: make prandom_u32() output unpredictable

2020-08-13 Thread Sedat Dilek
On Thu, Aug 13, 2020 at 4:00 PM Eric Dumazet wrote: > > On Thu, Aug 13, 2020 at 1:27 AM Sedat Dilek wrote: > > > > I run a perf session looks like this in my KDE/Plasma desktop-environment: > > > > [ PERF SESSION ] > > > > 1016 2020-08-13 09:57:24

Re: [DRAFT PATCH] random32: make prandom_u32() output unpredictable

2020-08-13 Thread Sedat Dilek
I run a perf session looks like this in my KDE/Plasma desktop-environment: [ PERF SESSION ] 1016 2020-08-13 09:57:24 echo 1 > /proc/sys/kernel/sched_schedstats 1017 2020-08-13 09:57:24 echo prandom_u32 >> /sys/kernel/debug/tracing/set_event 1018 2020-08-13 09:57:24 echo traceon > /sys/kerne

Re: [DRAFT PATCH] random32: make prandom_u32() output unpredictable

2020-08-13 Thread Sedat Dilek
On Thu, Aug 13, 2020 at 10:06 AM Willy Tarreau wrote: > > On Thu, Aug 13, 2020 at 09:53:11AM +0200, Sedat Dilek wrote: > > On Wed, Aug 12, 2020 at 5:21 AM Willy Tarreau wrote: > > > > > > On Tue, Aug 11, 2020 at 12:51:43PM +0200, Sedat Dilek wrote: > > > &g

Re: [DRAFT PATCH] random32: make prandom_u32() output unpredictable

2020-08-13 Thread Sedat Dilek
On Wed, Aug 12, 2020 at 5:21 AM Willy Tarreau wrote: > > On Tue, Aug 11, 2020 at 12:51:43PM +0200, Sedat Dilek wrote: > > Can you share this "rebased to mainline" version of George's patch? > > You can pick it from there if that helps, but keep in mind that >

Re: Flaw in "random32: update the net random state on interrupt and activity"

2020-08-12 Thread Sedat Dilek
On Wed, Aug 12, 2020 at 6:25 PM Eric Dumazet wrote: > > On Wed, Aug 12, 2020 at 9:20 AM Sedat Dilek wrote: > > > > On Wed, Aug 12, 2020 at 5:16 PM Eric Dumazet wrote: > > > > > > > > > > > > On 8/11/20 11:03 PM, Sedat Dilek wrote: > >

Re: Flaw in "random32: update the net random state on interrupt and activity"

2020-08-12 Thread Sedat Dilek
On Wed, Aug 12, 2020 at 5:16 PM Eric Dumazet wrote: > > > > On 8/11/20 11:03 PM, Sedat Dilek wrote: > > [ CC netdev ] > > [ Please CC me I am not subscribed to this mailing-list ] > > > > Hi Eric, > > > > I have added your diffs from [0] and have s

Re: Flaw in "random32: update the net random state on interrupt and activity"

2020-08-12 Thread Sedat Dilek
On Wed, Aug 12, 2020 at 8:35 AM Sedat Dilek wrote: > > [ INSTRUCTIONS ] > > echo 1 > /proc/sys/kernel/sched_schedstats > echo prandom_u32 >> /sys/kernel/debug/tracing/set_event > echo traceon > /sys/kernel/debug/tracing/events/random/prandom_u32/trigger > echo 1 &

Re: Flaw in "random32: update the net random state on interrupt and activity"

2020-08-11 Thread Sedat Dilek
[ INSTRUCTIONS ] echo 1 > /proc/sys/kernel/sched_schedstats echo prandom_u32 >> /sys/kernel/debug/tracing/set_event echo traceon > /sys/kernel/debug/tracing/events/random/prandom_u32/trigger echo 1 > /sys/kernel/debug/tracing/events/enable /home/dileks/bin/perf record -e random:prandom_u32 -a -g

Re: [DRAFT PATCH] random32: make prandom_u32() output unpredictable

2020-08-11 Thread Sedat Dilek
In the previous discussion... "Flaw in "random32: update the net random state on interrupt and activity" ...someone referred to . Someone tested this? Feedback? - Sedat - [0] https://marc.info/?t=15965890352&r=1&w=2 [1] https://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git/log/?h

Re: [DRAFT PATCH] random32: make prandom_u32() output unpredictable

2020-08-11 Thread Sedat Dilek
[ CC netdev ML ] Hi Willy, in [1] you say: > I've applied it on top of George's patch rebased to mainline for simplicity. > I've used a separate per_cpu noise variable to keep the net_rand_state static > with its __latent_entropy. Can you share this "rebased to mainline" version of George's pat

Re: [DRAFT PATCH] random32: make prandom_u32() output unpredictable

2020-08-09 Thread Sedat Dilek
+ CC:netdev ( Just FYI: Build and boot on bare metal. ) - Sedat - On Sun, Aug 9, 2020 at 11:01 PM Sedat Dilek wrote: > > Hi George, > > I have tried your patch on top of Linux v5.8 with... > > commit f227e3ec3b5c ("random32: update the net random state on &

Re: [PATCH v2 00/16] Remove uninitialized_var() macro

2020-06-22 Thread Sedat Dilek
On Sat, Jun 20, 2020 at 5:57 PM Kees Cook wrote: > > On Sat, Jun 20, 2020 at 09:03:34AM +0200, Sedat Dilek wrote: > > On Sat, Jun 20, 2020 at 5:30 AM Kees Cook wrote: > > > > > > v2: > > > - more special-cased fixes > > > - add revie

Re: [PATCH v2 00/16] Remove uninitialized_var() macro

2020-06-20 Thread Sedat Dilek
On Sat, Jun 20, 2020 at 5:30 AM Kees Cook wrote: > > v2: > - more special-cased fixes > - add reviews > v1: > https://lore.kernel.org/lkml/20200603233203.1695403-1-keesc...@chromium.org > > Using uninitialized_var() is dangerous as it papers over real bugs[1] > (or can in the future), and suppres

Re: Hang on wireless removal..

2020-06-08 Thread Sedat Dilek
On Sat, Jun 6, 2020 at 9:56 AM Johannes Berg wrote: > > Hi, sorry for the top post, on my phone. > > Yes, your analysis is spot on I think. I've got a fix for this in my > jberg/mac80211 tree, there's a deadlock with a work struct and the rtnl. > > Sorry about that. My testing should've caught it

Re: [PATCH 05/10] ide: Remove uninitialized_var() usage

2020-06-04 Thread Sedat Dilek
On Thu, Jun 4, 2020 at 10:20 PM Kees Cook wrote: > > On Thu, Jun 04, 2020 at 12:29:17PM -0700, Nick Desaulniers wrote: > > On Wed, Jun 3, 2020 at 4:32 PM Kees Cook wrote: > > > > > > Using uninitialized_var() is dangerous as it papers over real bugs[1] > > > (or can in the future), and suppresses

Re: [PATCH 00/10] Remove uninitialized_var() macro

2020-06-04 Thread Sedat Dilek
//github.com/nathanchance/llvm-kernel-testing > > For the series, consider it: > > Tested-by: Nathan Chancellor [build] > Hi Kees, I tried with updated version (checkpatch) of your tree and see no (new) warnings in my build-log. Feel free to add my... Tested-by: Sedat Dilek Thanks. Regards, - Sedat -

Re: [PATCH 08/10] checkpatch: Remove awareness of uninitialized_var() macro

2020-06-03 Thread Sedat Dilek
Hi Kees, can you push that change also to kees/linux.git#kspp/uninit/v5.7/macro ? Thanks in advance. Regards, - Sedat - [1] https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/log/?h=kspp/uninit/v5.7/macro On Thu, Jun 4, 2020 at 4:44 AM Kees Cook wrote: > > On Wed, Jun 03, 2020 at

Re: [PATCH 00/10] Remove uninitialized_var() macro

2020-06-03 Thread Sedat Dilek
On Thu, Jun 4, 2020 at 3:44 AM Kees Cook wrote: > > On Thu, Jun 04, 2020 at 03:23:28AM +0200, Sedat Dilek wrote: > > what is the base for your patchset? > > Hi! This was actually on Linus's latest tree (which is basically -next), > mostly because I figured this might be

Re: [PATCH 00/10] Remove uninitialized_var() macro

2020-06-03 Thread Sedat Dilek
On Thu, Jun 4, 2020 at 1:32 AM Kees Cook wrote: > > Using uninitialized_var() is dangerous as it papers over real bugs[1] > (or can in the future), and suppresses unrelated compiler warnings > (e.g. "unused variable"). If the compiler thinks it is uninitialized, > either simply initialize the vari

Re: [PATCH v4 00/14] NFC: nxp-nci: clean up and new device support

2019-08-20 Thread Sedat Dilek
nxp-nci: Get rid of code duplication in ->probe() > NFC: nxp-nci: Get rid of useless label > NFC: nxp-nci: Constify acpi_device_id > NFC: nxp-nci: Drop of_match_ptr() use > NFC: nxp-nci: Drop comma in terminator lines > NFC: nxp-nci: Remove unused macro pr_fmt() > NFC: n

Re: [PATCH 00/16] treewide: prefer __section from compiler_attributes.h

2019-08-19 Thread Sedat Dilek
On Mon, Aug 12, 2019 at 11:53 PM Nick Desaulniers wrote: > > GCC unescapes escaped string section names while Clang does not. Because > __section uses the `#` stringification operator for the section name, it > doesn't need to be escaped. > > This fixes an Oops observed in distro's that use system

Re: next-20190723: bpf/seccomp - systemd/journald issue?

2019-08-01 Thread Sedat Dilek
On Thu, Aug 1, 2019 at 9:39 AM Sedat Dilek wrote: > > Hi, > > just want to let you know that I did a git bisect with Linux v5.3-rc2 > (where the problem also exists) and the result (details see [1]): > > e55a73251da335873a6e87d68fb17e5aabb8978e is the firs

Re: next-20190723: bpf/seccomp - systemd/journald issue?

2019-08-01 Thread Sedat Dilek
Hi, just want to let you know that I did a git bisect with Linux v5.3-rc2 (where the problem also exists) and the result (details see [1]): e55a73251da335873a6e87d68fb17e5aabb8978e is the first bad commit commit e55a73251da335873a6e87d68fb17e5aabb8978e Author: Josh Poimboeuf Date: Thu Jun 27 2

Re: [PATCH v3 11/14] NFC: nxp-nci: Remove unused macro pr_fmt()

2019-07-29 Thread Sedat Dilek
On Mon, Jul 29, 2019 at 4:58 PM Sedat Dilek wrote: > > On Mon, Jul 29, 2019 at 12:38 PM Andy Shevchenko > wrote: > > > > On Fri, Jul 26, 2019 at 02:23:46PM -0700, David Miller wrote: > > > From: Andy Shevchenko > > > Date: Thu, 25 Jul 2019 22:35:08 +0300

Re: [PATCH v3 11/14] NFC: nxp-nci: Remove unused macro pr_fmt()

2019-07-29 Thread Sedat Dilek
gt; Signed-off-by: Andy Shevchenko > > > Tested-by: Sedat Dilek > > ... > > > @@ -12,8 +12,6 @@ > > > * Copyright (C) 2012 Intel Corporation. All rights reserved. > > > */ > > > > > > -#define pr_fmt(fmt) KBUILD_MODNAME ": " fm

Re: next-20190723: bpf/seccomp - systemd/journald issue?

2019-07-28 Thread Sedat Dilek
On Sat, Jul 27, 2019 at 7:11 PM Yonghong Song wrote: > > > > On 7/27/19 1:16 AM, Sedat Dilek wrote: > > On Sat, Jul 27, 2019 at 9:36 AM Sedat Dilek wrote: > >> > >> On Sat, Jul 27, 2019 at 4:24 AM Alexei Starovoitov > >> wrote: > >>>

Re: next-20190723: bpf/seccomp - systemd/journald issue?

2019-07-28 Thread Sedat Dilek
On Sat, Jul 27, 2019 at 7:08 PM Yonghong Song wrote: > > > > On 7/27/19 12:36 AM, Sedat Dilek wrote: > > On Sat, Jul 27, 2019 at 4:24 AM Alexei Starovoitov > > wrote: > >> > >> On Fri, Jul 26, 2019 at 2:19 PM Sedat Dilek wrote: > >>> >

Re: next-20190723: bpf/seccomp - systemd/journald issue?

2019-07-27 Thread Sedat Dilek
On Sat, Jul 27, 2019 at 9:36 AM Sedat Dilek wrote: > > On Sat, Jul 27, 2019 at 4:24 AM Alexei Starovoitov > wrote: > > > > On Fri, Jul 26, 2019 at 2:19 PM Sedat Dilek wrote: > > > > > > On Fri, Jul 26, 2019 at 11:10 PM Yonghong Song wrote: > > &

Re: next-20190723: bpf/seccomp - systemd/journald issue?

2019-07-27 Thread Sedat Dilek
On Sat, Jul 27, 2019 at 4:24 AM Alexei Starovoitov wrote: > > On Fri, Jul 26, 2019 at 2:19 PM Sedat Dilek wrote: > > > > On Fri, Jul 26, 2019 at 11:10 PM Yonghong Song wrote: > > > > > > > > > > > > On 7/26/19 2:02 PM, Sedat Dilek wrote

Re: next-20190723: bpf/seccomp - systemd/journald issue?

2019-07-26 Thread Sedat Dilek
On Fri, Jul 26, 2019 at 11:10 PM Yonghong Song wrote: > > > > On 7/26/19 2:02 PM, Sedat Dilek wrote: > > On Fri, Jul 26, 2019 at 10:38 PM Sedat Dilek wrote: > >> > >> Hi Yonghong Song, > >> > >> On Fri, Jul 26, 2019 at 5:45 PM Yonghong S

Re: next-20190723: bpf/seccomp - systemd/journald issue?

2019-07-26 Thread Sedat Dilek
On Fri, Jul 26, 2019 at 10:38 PM Sedat Dilek wrote: > > Hi Yonghong Song, > > On Fri, Jul 26, 2019 at 5:45 PM Yonghong Song wrote: > > > > > > > > On 7/26/19 1:26 AM, Sedat Dilek wrote: > > > Hi, > > > > > > I have opened a new i

Re: next-20190723: bpf/seccomp - systemd/journald issue?

2019-07-26 Thread Sedat Dilek
Hi Yonghong Song, On Fri, Jul 26, 2019 at 5:45 PM Yonghong Song wrote: > > > > On 7/26/19 1:26 AM, Sedat Dilek wrote: > > Hi, > > > > I have opened a new issue in the ClangBuiltLinux issue tracker. > > Glad to know clang 9 has asm goto support and now It

Re: [PATCH v3 01/14] NFC: fix attrs checks in netlink interface

2019-07-26 Thread Sedat Dilek
> u32 idx; > > - if (!info->attrs[NFC_ATTR_DEVICE_INDEX]) > + if (!info->attrs[NFC_ATTR_DEVICE_INDEX] || > + !info->attrs[NFC_ATTR_FIRMWARE_NAME]) > return -EINVAL; > > idx = nla_get_u32(info->attrs[NFC_ATTR_DEVICE_INDEX]); > -

[linux-stable-3.16.y] tun: allow positive return values on dev_get_valid_name() call

2018-05-14 Thread Sedat Dilek
Hi Ben, some Debian/jessie systems were caught by the bug-report in [1]. This issue was recently fixed in an updated Debian kernel for v3.16.y. Will you include the patch "tun: allow positive return values on dev_get_valid_name() call" [2] in linux-stable-3.16.y upstream? This was a fix for "tun

Re: tcp_bbr: Forcing set of BBR congestion control as default

2017-01-02 Thread Sedat Dilek
On Mon, Jan 2, 2017 at 8:12 PM, Neal Cardwell wrote: > On Mon, Jan 2, 2017 at 1:49 PM, Sedat Dilek wrote: >> On Mon, Jan 2, 2017 at 7:17 PM, Neal Cardwell wrote: >>> On Mon, Jan 2, 2017 at 12:05 AM, Sedat Dilek wrote: >>>> >>>> Hi, >>>&g

Re: tcp_bbr: Forcing set of BBR congestion control as default

2017-01-02 Thread Sedat Dilek
On Mon, Jan 2, 2017 at 7:17 PM, Neal Cardwell wrote: > On Mon, Jan 2, 2017 at 12:05 AM, Sedat Dilek wrote: >> >> Hi, >> >> I am trying to force the set of BBR congestion control as default. >> My old linux-config uses CUBIC as default. >> I want both BBR an

tcp_bbr: Forcing set of BBR congestion control as default

2017-01-01 Thread Sedat Dilek
Hi, I am trying to force the set of BBR congestion control as default. My old linux-config uses CUBIC as default. I want both BBR and CUBIC to be built but BBR shall be my default. I tried the below snippet. I refresh my new linux-config like this... $ MAKE="make V=1" ; COMPILER="mycompiler" ;

Re: [v4.6-rc7-183-g1410b74e4061]

2016-05-22 Thread Sedat Dilek
On 5/16/16, Sedat Dilek wrote: > On 5/16/16, Peter Zijlstra wrote: >> On Mon, May 16, 2016 at 07:42:35PM +0200, Sedat Dilek wrote: >> >>> Unfortunately, I could not reproduce this again with none of my >>> 183-kernels. >>> When I first hit a &

Re: [GIT] Networking

2016-05-19 Thread Sedat Dilek
On 5/19/16, Reinoud Koornstra wrote: > On Thu, May 19, 2016 at 2:20 AM, Reinoud Koornstra > wrote: >> On Wed, May 18, 2016 at 12:51 PM, Linus Torvalds >> wrote: >>> On Wed, May 18, 2016 at 11:45 AM, Linus Torvalds >>> wrote: From what I can tell, there's a merge bug in commit 909b27f7

Re: [v4.6-rc7-183-g1410b74e4061]

2016-05-16 Thread Sedat Dilek
On 5/16/16, Peter Zijlstra wrote: > On Mon, May 16, 2016 at 07:42:35PM +0200, Sedat Dilek wrote: > >> Unfortunately, I could not reproduce this again with none of my >> 183-kernels. >> When I first hit a "chain_key collision" issue, it was hard to redproduce, &g

Re: [v4.6-rc7-183-g1410b74e4061]

2016-05-16 Thread Sedat Dilek
On 5/16/16, Ingo Molnar wrote: > > * Sedat Dilek wrote: > >> Hi, >> >> as Linux v4.6 is very near, I decided to write this bug report (only >> drunk one coffee). >> >> First, I am not absolutely sure if this is a real issue as... >> #1: Th

Re: codel: split into multiple files

2016-04-25 Thread Sedat Dilek
On 4/26/16, Michal Kazior wrote: > On 26 April 2016 at 08:09, Sedat Dilek wrote: >> Hi, >> >> I had a very quick view on net-next.git#master (up to commit >> fab7b629a82da1b59620470d13152aff975239f6). >> >> Commit in [1] aka "codel: split into multi

Re: codel: split into multiple files

2016-04-25 Thread Sedat Dilek
Hi, I had a very quick view on net-next.git#master (up to commit fab7b629a82da1b59620470d13152aff975239f6). Commit in [1] aka "codel: split into multiple files" removed codel.h but [2] and [3] have relicts to it. Forgot to remove? (Not sure if there exist more relicts.) Regards, - Sedat - [1]

[Linux-v4.4-LTS] ppp: Backport of rtnetlink device handling

2016-01-03 Thread Sedat Dilek
Hi Guillaume, which patches do I need to backport "ppp: rtnetlink device handling" to Linux v4.4 which will be a LongTerm-Supported (LTS) Linux-kernel [0]? I tried [1] and [2] on top of recent net-next Git tree which will be in Linux v4.5. Currently, your patches are not included in net-next.git#

Re: [net-next] l2tp: rely on ppp layer for skb scrubbing

2016-01-03 Thread Sedat Dilek
rtnetlink device handling Feel free to add my... Tested-by: Sedat Dilek - Sedat - [1] https://patchwork.ozlabs.org/patch/561540/ -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.

Re: [2/2] ppp: implement rtnetlink device handling

2016-01-03 Thread Sedat Dilek
Built up and ran successfully on my Ubuntu/precise AMD64 box on top of net-next.git#master up to ("c07f30ad6805: Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net"). Feel free to add my... Tested-by: Sedat Dilek - Sedat - [1] https://patchwork.ozlabs.org/patch/560

Re: [1/2] ppp: define reusable device creation functions

2016-01-03 Thread Sedat Dilek
Built up and ran successfully on my Ubuntu/precise AMD64 box on top of net-next.git#master up to ("c07f30ad6805: Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net"). Feel free to add my... Tested-by: Sedat Dilek - Sedat - [1] https://patchwork.ozlabs.org/patch/560

Re: [net-next] ppp: rtnetlink device handling

2015-12-31 Thread Sedat Dilek
On Thu, Dec 31, 2015 at 6:10 PM, David Miller wrote: > From: Sedat Dilek > Date: Thu, 31 Dec 2015 15:06:18 +0100 > >> Just off-topic... > > Please do not hijack a thread discussing a patch series like this to > talk about something completely unrelated. Yes, you ar

Re: [net-next] ppp: rtnetlink device handling

2015-12-31 Thread Sedat Dilek
On Thu, Dec 31, 2015 at 12:01 PM, Sedat Dilek wrote: > On Thu, Dec 31, 2015 at 11:41 AM, Guillaume Nault > wrote: >> On Thu, Dec 31, 2015 at 08:46:59AM +0100, Sedat Dilek wrote: >>> Hi Guillaume, >>> >>> can you explain why you moved ppp to rtnet

Re: [net-next] ppp: rtnetlink device handling

2015-12-31 Thread Sedat Dilek
On Thu, Dec 31, 2015 at 11:41 AM, Guillaume Nault wrote: > On Thu, Dec 31, 2015 at 08:46:59AM +0100, Sedat Dilek wrote: >> Hi Guillaume, >> >> can you explain why you moved ppp to rtnetlink device handling? >> Benefits, etc.? >> > The objective is to bring all

[net-next] ppp: rtnetlink device handling

2015-12-30 Thread Sedat Dilek
Hi Guillaume, can you explain why you moved ppp to rtnetlink device handling? Benefits, etc.? Does anything change when using NetworkManager/ModemManager/pppd for my network setup/handling (here: Ubuntu/precise AMD64)? Thanks in advance. Regards, - Sedat - P.S.: Coming soon... Not (only) in th

Re: [Linux 4.2-rc8+...v4.3-rc2] REGRESSION: ppp: circular locking dependency detected: [pppd] ppp_dev_uninit() | rtnl_lock()

2015-09-25 Thread Sedat Dilek
On Fri, Sep 25, 2015 at 7:58 AM, Sedat Dilek wrote: > On Thu, Sep 24, 2015 at 8:00 PM, David Miller wrote: >> From: Sedat Dilek >> Date: Thu, 24 Sep 2015 18:19:16 +0200 >> >>> OK, I guess DaveM will take your patch into net.git#master first... >>> and tag

Re: [Linux 4.2-rc8+...v4.3-rc2] REGRESSION: ppp: circular locking dependency detected: [pppd] ppp_dev_uninit() | rtnl_lock()

2015-09-24 Thread Sedat Dilek
On Thu, Sep 24, 2015 at 8:00 PM, David Miller wrote: > From: Sedat Dilek > Date: Thu, 24 Sep 2015 18:19:16 +0200 > >> OK, I guess DaveM will take your patch into net.git#master first... >> and tag it there with CC-stable? > > I do not tag anything with stable. > &g

Re: [Linux 4.2-rc8+...v4.3-rc2] REGRESSION: ppp: circular locking dependency detected: [pppd] ppp_dev_uninit() | rtnl_lock()

2015-09-24 Thread Sedat Dilek
On Thu, Sep 24, 2015 at 1:03 PM, Guillaume Nault wrote: > On Wed, Sep 23, 2015 at 11:21:50PM +0200, Sedat Dilek wrote: >> On Wed, Sep 23, 2015 at 10:46 PM, Sedat Dilek wrote: >> > On Wed, Sep 23, 2015 at 12:38 PM, Guillaume Nault >> > wrote: >> > Do you mind

Re: [Linux 4.2-rc8+...v4.3-rc2] REGRESSION: ppp: circular locking dependency detected: [pppd] ppp_dev_uninit() | rtnl_lock()

2015-09-23 Thread Sedat Dilek
On Wed, Sep 23, 2015 at 10:46 PM, Sedat Dilek wrote: > On Wed, Sep 23, 2015 at 12:38 PM, Guillaume Nault > wrote: >> On Wed, Sep 23, 2015 at 08:06:16AM +0200, Sedat Dilek wrote: >>> Without reverting the below culprit ppp patch... >>> >>> commit/?id=8

Re: [Linux 4.2-rc8+...v4.3-rc2] REGRESSION: ppp: circular locking dependency detected: [pppd] ppp_dev_uninit() | rtnl_lock()

2015-09-23 Thread Sedat Dilek
On Wed, Sep 23, 2015 at 12:38 PM, Guillaume Nault wrote: > On Wed, Sep 23, 2015 at 08:06:16AM +0200, Sedat Dilek wrote: >> Without reverting the below culprit ppp patch... >> >> commit/?id=8cb775bc0a34dc596837e7da03fd22c747be618b >> ("ppp: fix device un

Re: [Linux 4.2-rc8+] circular locking dependency detected: [pppd] ppp_dev_uninit() | rtnl_lock()

2015-09-04 Thread Sedat Dilek
> Could this be caused by this commit...? > > commit 8cb775bc0a34dc596837e7da03fd22c747be618b > "ppp: fix device unregistration upon netns deletion" > With the Revert "ppp: fix device unregistration upon netns deletion" I do not see any lockdep issues. - Sedat - -- To unsubscribe from this list:

  1   2   >