On 4/26/16, Michal Kazior <michal.kaz...@tieto.com> wrote: > On 26 April 2016 at 08:09, Sedat Dilek <sedat.di...@gmail.com> wrote: >> Hi, >> >> I had a very quick view on net-next.git#master (up to commit >> fab7b629a82da1b59620470d13152aff975239f6). >> >> Commit in [1] aka "codel: split into multiple files" removed codel.h >> but [2] and [3] have relicts to it. >> Forgot to remove? > > codel.h was not removed. diffstat for codel.h is all red which I > presume is why you thought of it as removed, see: > > http://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/tree/include/net/codel.h?id=d068ca2ae2e614b9a418fb3b5f1fd4cf996ff032 >
[ CC Jens ] OK. So what are the plans in the future? Keep a "generic" codel.h (compatibility reasons?) for net or is it your split? AFAICS I have seen a codel-implementation in block.git#wb-buf-throttle. Does it make sense to have a more "super-generic" codel.h for re-use (not only for net and block)? Just a thought. - Sedat - [1] http://git.kernel.org/cgit/linux/kernel/git/axboe/linux-block.git/log/?h=wb-buf-throttle [2] http://git.kernel.org/cgit/linux/kernel/git/axboe/linux-block.git/commit/?h=wb-buf-throttle&id=b8bc0478ddd6f32a09a2b1ff30f7c75605448638 [3] http://git.kernel.org/cgit/linux/kernel/git/axboe/linux-block.git/commit/?h=wb-buf-throttle&id=e26e88f9c125a9cd6d3df0087386992183c1f47e
