Re: [PATCH v2 1/1] kernel.h: Split out panic and oops helpers

2021-04-09 Thread Sebastian Reichel
ers > - elaborated commit message (Luis) > - collected given tags (incl. Andrew's SoB, see below) > > I added Andrew's SoB since part of the fixes I took from him. Andrew, > feel free to amend or tell me how you want me to do. > > [...] > drivers/power/re

Re: [patch 1/1] genirq: Disable interrupts for force threaded handlers

2021-03-18 Thread Sebastian Andrzej Siewior
> > > It will not because both threads will wake_up(thread). > > Note that the above says "interrupt(irq_B)" suggesting it's a > non-threaded interrupt unlike irq_A. I missed that bit, thanks. Sebastian

Re: [patch 1/1] genirq: Disable interrupts for force threaded handlers

2021-03-17 Thread Sebastian Andrzej Siewior
; For not RT this is not changing much, except that during the execution of > the threaded handler interrupts are delayed until the handler > returns. Vs. scheduling and softirq processing there is no difference. > > For RT kernels there is no issue. Acked-by: Sebastian Andrzej Siewio

Re: [patch 07/14] tasklets: Prevent tasklet_unlock_spin_wait() deadlock on RT

2021-03-09 Thread Sebastian Andrzej Siewior
voided. > - */ > -static inline void tasklet_unlock_spin_wait(struct tasklet_struct *t) > -{ > - while (test_bit(TASKLET_STATE_RUN, &t->state)) > - cpu_relax(); > -} Look at that. The forward declaration for tasklet_unlock_spin_wait() should have remained. Sorry for that. Sebastian

Re: [patch 07/14] tasklets: Prevent tasklet_unlock_spin_wait() deadlock on RT

2021-03-09 Thread Sebastian Andrzej Siewior
On 2021-03-09 09:42:10 [+0100], Thomas Gleixner wrote: > tasklet_unlock_spin_wait() spin waits for the TASKLET_STATE_SCHED bit in > the tasklet state to be cleared. This works on !RT nicely because the … Could you please fold this: diff --git a/include/linux/interrupt.h b/include/linux/interrupt.

[PATCH] kcov: Remove kcov include from sched.h and move it to its users.

2021-02-18 Thread Sebastian Andrzej Siewior
the kconv header file. Move the include of the kconv.h header from sched.h it its users. Additionally include sched.h from kconv.h to ensure that everything task_struct related is available. Signed-off-by: Sebastian Andrzej Siewior --- include/linux/kcov.h | 1 + include/linux/sched.h | 1

[PATCH net-next] net: caif: Use netif_rx_any_context().

2021-02-13 Thread Sebastian Andrzej Siewior
this driver and because the call chains are hard to follow. As a stop gap use netif_rx_any_context() which invokes the correct code path depending on context and confines the in_interrupt() usage to core code. Signed-off-by: Sebastian Andrzej Siewior --- net/caif/chnl_net.c | 5 + 1 file

Re: [PATCH 0/2] chelsio: cxgb: Use threaded interrupts for deferred work

2021-02-03 Thread Sebastian Andrzej Siewior
On 2021-02-02 17:31:23 [-0800], Jesse Brandeburg wrote: > Sebastian Andrzej Siewior wrote: > > > Patch #2 fixes an issue in which del_timer_sync() and tasklet_kill() is > > invoked from the interrupt handler. This is probably a rare error case > > since it disables inter

[PATCH 0/2] chelsio: cxgb: Use threaded interrupts for deferred work

2021-02-02 Thread Sebastian Andrzej Siewior
adding another worker for this task (and flush_work() to synchronise vs rmmod). This has been only compile tested. Sebastian

[PATCH 1/2] chelsio: cxgb: Replace the workqueue with threaded interrupt

2021-02-02 Thread Sebastian Andrzej Siewior
F_PL_INTR_EXT as interrupt source like it is used before the worker is scheduled. Enable the interrupt again once t1_elmer0_ext_intr_handler() is done. Signed-off-by: Sebastian Andrzej Siewior --- drivers/net/ethernet/chelsio/cxgb/common.h | 5 +-- drivers/net/ethernet/chelsio/cxgb/cxgb2.c | 44

[PATCH 2/2] chelsio: cxgb: Disable the card on error in threaded interrupt

2021-02-02 Thread Sebastian Andrzej Siewior
. In case of a fatal error, use t1_interrupts_disable() to disable all interrupt sources and then wake the interrupt thread with F_PL_INTR_SGE_ERR as pending flag. The threaded-interrupt will stop the card via t1_sge_stop() and not re-enable the interrupts again. Signed-off-by: Sebastian Andrzej

[PATCH] net: arcnet: Fix RESET flag handling

2021-01-28 Thread Sebastian Andrzej Siewior
en() and arcnet_close() accordingly. Check drivers/net/arcnet/com20020.c. Run the device RESET sequence from a scheduled workqueue instead. Signed-off-by: Ahmed S. Darwish Signed-off-by: Sebastian Andrzej Siewior --- Repost as non-RFC. No hardware around, just review. drivers/net/arcnet/arc-r

Re: [PATCH] rtlwifi: Assign boolean values to a bool variable

2021-01-20 Thread Sebastian Andrzej Siewior
"Power Status", > (dc_mode ? "DC mode" : "AC mode"), Sebastian

Re: [RFC PATCH 2/3] chelsio: cxgb: Move slow interrupt handling to threaded irqs

2021-01-11 Thread Sebastian A. Siewior
upt source or use IRQF_ONESHOT to mask the interrupt line until the threaded handler is done. If you look at t1_elmer0_ext_intr() it disables F_PL_INTR_EXT before the worker scheduled so the interrupt does not trigger again. The worker then does what ever is needed (t1_elmer0_ext_intr_handler) and then ACKs F_PL_INTR_EXT and enables F_PL_INTR_EXT again so it may trigger an interrupt again. Sebastian

Re: [RFC PATCH 0/1] net: arcnet: Fix RESET sequence

2021-01-11 Thread Sebastian A. Siewior
interrupt handler. Sebastian

Re: [PATCH] dt-bindings: Add missing array size constraints

2021-01-05 Thread Sebastian Reichel
./bindings/power/supply/bq25980.yaml| 1 + > [...] Acked-by: Sebastian Reichel -- Sebastian signature.asc Description: PGP signature

Re: [PATCH] dt-bindings: Fix JSON pointers

2020-12-18 Thread Sebastian Reichel
ellWise. The only way to obtain >it is to mail two batteries to a test facility of CellWise and receive >back a test report with the binary blob. > -$ref: /schemas/types.yaml#definitions/uint8-array > + $ref: /schemas/types.yaml#/definitions/uint8-array > minItems: 64 > maxItems: 64 > [...] Acked-by: Sebastian Reichel -- Sebastian signature.asc Description: PGP signature

[PATCH 2/3] atm: nicstar: Replace in_interrupt() usage

2020-11-16 Thread Sebastian Andrzej Siewior
illiams <3ch...@gmail.com> CC: Jakub Kicinski Signed-off-by: Sebastian Andrzej Siewior --- drivers/atm/nicstar.c | 24 ++-- include/linux/atmdev.h | 1 + net/atm/raw.c | 12 ++-- 3 files changed, 29 insertions(+), 8 deletions(-) diff --git a/drivers/atm/n

[PATCH 3/3] atm: lanai: Remove in_interrupt() usage

2020-11-16 Thread Sebastian Andrzej Siewior
which will trigger a warning if used in bad context. Remove in_interrupt(). Cc: Chas Williams <3ch...@gmail.com> Cc: netdev@vger.kernel.org Signed-off-by: Sebastian Andrzej Siewior --- drivers/atm/lanai.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/atm/lan

[PATCH 0/3] atm: Replace in_interrupt usage

2020-11-16 Thread Sebastian Andrzej Siewior
Folks, this mini series contains the removal of in_interrupt() in drivers/atm and a tiny bugfix while staring into code. Sebastian

[PATCH 1/3] atm: nicstar: Unmap DMA on send error

2020-11-16 Thread Sebastian Andrzej Siewior
ve virt_to_bus() and support 64-bit platforms") Cc: Chas Williams <3ch...@gmail.com> Signed-off-by: Sebastian Andrzej Siewior --- drivers/atm/nicstar.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/atm/nicstar.c b/drivers/atm/nicstar.c index 7af74fb450a0d..09ad733

[PATCH v2 net-next 1/3] soc/fsl/qbman: Add an argument to signal if NAPI processing is required.

2020-11-01 Thread Sebastian Andrzej Siewior
he value to the caller including `qman_cb_dqrr' typedef which is used by the dpaa and the crypto driver. Signed-off-by: Sebastian Andrzej Siewior Cc: "Horia Geantă" Cc: Aymen Sghaier Cc: Herbert XS Cc: "David S. Miller" Cc: Madalin Bucur Cc: Jakub Kicinski

[PATCH v2 net-next 2/3] net: dpaa: Replace in_irq() usage.

2020-11-01 Thread Sebastian Andrzej Siewior
conveyed in an argument passed by the caller, which usually knows the context. Use the `sched_napi' argument passed by the callback. It is set true if called from the interrupt handler and NAPI should be scheduled. Signed-off-by: Sebastian Andrzej Siewior Cc: "Horia Geantă" Cc: Ay

[PATCH v2 net-next 0/3] fsl/qbman: in_interrupt() cleanup.

2020-11-01 Thread Sebastian Andrzej Siewior
This is the in_interrupt() clean for FSL DPAA framework and the two users. The `napi' parameter has been renamed to `sched_napi', the other parts are same as in the previous post [0]. [0] https://lkml.kernel.org/r/20201027225454.3492351-1-bige...@linutronix.de Sebastian

[PATCH v2 net-next 3/3] crypto: caam: Replace in_irq() usage.

2020-11-01 Thread Sebastian Andrzej Siewior
conveyed in an argument passed by the caller, which usually knows the context. Use the `sched_napi' argument passed by the callback. It is set true if called from the interrupt handler and NAPI should be scheduled. Signed-off-by: Sebastian Andrzej Siewior Cc: "Horia Geantă" Cc: Ay

Re: [PATCH net-next 14/15] net: dpaa: Replace in_irq() usage.

2020-11-01 Thread Sebastian Andrzej Siewior
enamed it to `sched_napi'. Sebastian

[PATCH net-next 04/15] net: mlx5: Replace in_irq() usage.

2020-10-27 Thread Sebastian Andrzej Siewior
be seperated or the context be conveyed in an argument passed by the caller, which usually knows the context. mlx5_eq_async_int() knows the context via the action argument already so using it for the lock variant decision is a straight forward replacement for in_irq(). Signed-off-by: Sebastian

[PATCH net-next 14/15] net: dpaa: Replace in_irq() usage.

2020-10-27 Thread Sebastian Andrzej Siewior
conveyed in an argument passed by the caller, which usually knows the context. Use the `napi' argument passed by the callback. It is set true if called from the interrupt handler and NAPI should be scheduled. Signed-off-by: Sebastian Andrzej Siewior Cc: "Horia Geantă" Cc: Aymen Sghaier

[PATCH net-next 10/15] net: zd1211rw: Remove in_atomic() usage.

2020-10-27 Thread Sebastian Andrzej Siewior
The usage of in_atomic() in driver code is deprecated as it can not always detect all states where it is not allowed to sleep. All callers are in premptible thread context and all functions invoke core functions which have checks for invalid calling contexts already. Signed-off-by: Sebastian

[PATCH net-next 12/15] net: rtlwifi: Remove in_interrupt() usage in halbtc_send_bt_mp_operation()

2020-10-27 Thread Sebastian Andrzej Siewior
t_coex_supported_feature() None of these have a caller. Welcome to the wonderful world of HALs and onion layers. Remove in_interrupt() check. Signed-off-by: Sebastian Andrzej Siewior Cc: Ping-Ke Shih Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wirel...@vger.ker

[PATCH net-next 11/15] net: rtlwifi: Remove in_interrupt() usage in is_any_client_connect_to_ap().

2020-10-27 Thread Sebastian Andrzej Siewior
code further use list_empty() instead of walking the list and counting the entries just to check the count for > 0 at the end. Signed-off-by: Sebastian Andrzej Siewior Cc: Ping-Ke Shih Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wirel...@vger.kernel.o

[PATCH net-next 15/15] crypto: caam: Replace in_irq() usage.

2020-10-27 Thread Sebastian Andrzej Siewior
conveyed in an argument passed by the caller, which usually knows the context. Use the `napi' argument passed by the callback. It is set true if called from the interrupt handler and NAPI should be scheduled. Signed-off-by: Sebastian Andrzej Siewior Cc: "Horia Geantă" Cc: Aymen Sghaier

[PATCH net-next 13/15] soc/fsl/qbman: Add an argument to signal if NAPI processing is required.

2020-10-27 Thread Sebastian Andrzej Siewior
he value to the caller including `qman_cb_dqrr' typedef which is used by the dpaa and the crypto driver. Signed-off-by: Sebastian Andrzej Siewior Cc: "Horia Geantă" Cc: Aymen Sghaier Cc: Herbert Xu Cc: "David S. Miller" Cc: Madalin Bucur Cc: Jakub Kicinski

[PATCH net-next 06/15] net: airo: Invoke airo_read_wireless_stats() directly

2020-10-27 Thread Sebastian Andrzej Siewior
y. Invoke airo_read_wireless_stats() directly from the callback and remove the now unused JOB_WSTATS handling. Signed-off-by: Sebastian Andrzej Siewior Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wirel...@vger.kernel.org Cc: netdev@vger.kernel.org --- driver

[PATCH net-next 09/15] net: hostap: Remove in_atomic() check.

2020-10-27 Thread Sebastian Andrzej Siewior
hostap_get_wireless_stats() is the iw_handler_if::get_wireless_stats() callback of this driver. This callback was not allowed to sleep until commit a160ee69c6a46 ("wext: let get_wireless_stats() sleep") in v2.6.32. Remove the therefore pointless in_atomic() check. Signed-off-by:

[PATCH net-next 08/15] net: airo: Replace in_atomic() usage.

2020-10-27 Thread Sebastian Andrzej Siewior
x27;s pointless to invoke schedule() if there is no request to reschedule. Pass the may_sleep condition through the various call chains leading to issuecommand(). Signed-off-by: Sebastian Andrzej Siewior Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wirel...@vge

[PATCH net-next 07/15] net: airo: Always use JOB_STATS and JOB_EVENT

2020-10-27 Thread Sebastian Andrzej Siewior
context through a quite large amount of functions. As this is ancient hardware, avoid the churn and enforce the invocation of those functions through the JOB machinery. Signed-off-by: Sebastian Andrzej Siewior Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: l

[PATCH net-next 00/15] in_interrupt() cleanup, part 2

2020-10-27 Thread Sebastian Andrzej Siewior
code paths which might sleep. In the long run, usage of 'preemptible, in_*irq etc.' should be banned from driver code completely. This is part two addressing remaining drivers except for orinoco-usb. Sebastian

[PATCH net-next 01/15] net: orinoco: Remove BUG_ON(in_interrupt/irq())

2020-10-27 Thread Sebastian Andrzej Siewior
n the invoked functions (always enabled or debug option dependent) cover these conditions already, so the BUG_ON()'s do not really provide additional value. Just remove them. Signed-off-by: Sebastian Andrzej Siewior Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicin

[PATCH net-next 05/15] net: tlan: Replace in_irq() usage

2020-10-27 Thread Sebastian Andrzej Siewior
(), tlan_mii_write_reg() and tlan_phy_print() are invoked from interrupt and other contexts. Split out the actual function body into helper variants which are called from interrupt context and make the original functions wrappers which acquire tlan_priv::lock unconditionally. Signed-off-by: Sebastian Andrzej Siewior

[PATCH net-next 03/15] net: forcedeth: Replace context and lock check with a lockdep_assert()

2020-10-27 Thread Sebastian Andrzej Siewior
replace the warning and the lock assert with lockdep_assert_held(). Signed-off-by: Sebastian Andrzej Siewior Cc: Rain River Cc: Zhu Yanjun Cc: "David S. Miller" Cc: Jakub Kicinski Cc: netdev@vger.kernel.org --- drivers/net/ethernet/nvidia/forcedeth.c | 6 +- 1 file changed, 1

[PATCH net-next 02/15] net: neterion: s2io: Replace in_interrupt() for context detection

2020-10-27 Thread Sebastian Andrzej Siewior
et_rx_mode() s2io_set_multicast() s2io_txpic_intr_handle() s2io_link() init_tti() Add a may_sleep argument to wait_for_cmd_complete(), s2io_set_multicast() and init_tti() and hand the context information in from the call sites. Signed-off-by: Sebastian Andrzej Siewior Cc: Jon

Re: [PATCH net v2] net: openvswitch: fix to make sure flow_lookup() is not preempted

2020-10-15 Thread Sebastian Andrzej Siewior
p(tbl, ti, ma, key, &n_mask_hit, &n_cache_hit, &index); > + local_bh_enable(); > + return flow; > } > > struct sw_flow *ovs_flow_tbl_lookup_exact(struct flow_table *tbl, Otherwise it looks good. Sebastian

Re: [PATCH net-next] net: openvswitch: fix to make sure flow_lookup() is not preempted

2020-10-15 Thread Sebastian Andrzej Siewior
On 2020-10-15 10:11:31 [+0200], Eelco Chaudron wrote: > Thanks for your reply! Yes I had it replaced with local_bh_disable() in my > v2, as I noticed the hard IRQ to softirq part earlier. Okay. Resend the complete thing once you ready and I take a look. > Thanks, > > Eelco Sebastian

Re: [PATCH net-next] net: openvswitch: fix to make sure flow_lookup() is not preempted

2020-10-15 Thread Sebastian Andrzej Siewior
You need something stronger :) Side note: Adding a fixes tag and net-next looks like "stable material starting next merge window". > Thanks, > > Eelco Sebastian

Re: [PATCH net-next] net: openvswitch: fix to make sure flow_lookup() is not preempted

2020-10-13 Thread Sebastian Andrzej Siewior
disabled due to CPU specific variables. > + */ Once again. u64_stats_update_begin(). What protects you against concurrent access. > + preempt_disable(); > + flow = flow_lookup(tbl, ti, ma, key, &n_mask_hit, &n_cache_hit, &index); > + preempt_enable(); > + return flow; > } > > struct sw_flow *ovs_flow_tbl_lookup_exact(struct flow_table *tbl, > Sebastian

Re: [PATCH] dt-bindings: Another round of adding missing 'additionalProperties'

2020-10-05 Thread Sebastian Reichel
ll take this thru the DT tree. > > [...] > .../bindings/power/supply/cw2015_battery.yaml | 2 ++ > .../bindings/power/supply/rohm,bd99954.yaml | 8 > [...] Acked-by: Sebastian Reichel -- Sebastian signature.asc Description: PGP signature

Re: [RFC] Status of orinoco_usb

2020-10-02 Thread Sebastian Andrzej Siewior
ling to test any changes. Not sure moving is easy since it depends on other files in that folder. USB is one interface next to PCI for instance. Unless you meant to move the whole driver including all interfaces. I was suggesting to remove the USB bits. > thanks, > > greg k-h Sebastian

[RFC] Status of orinoco_usb

2020-10-02 Thread Sebastian Andrzej Siewior
er is an orphan since commit 3a59babbee409 ("orinoco: update status in MAINTAINERS") which is ten years ago. If I replace in_softirq() with a `may_sleep' argument then it is still broken. Should it be removed? Sebastian

Re: [PATCH v3 1/2] net: add support for threaded NAPI polling

2020-08-30 Thread Sebastian Gottschall
/git.kernel.org/pub/scm/linux/kernel/git/kuba/linux.git/log/?h=tapi looks interesting. keep going Sebastian

[PATCH NET] net: atlantic: Use readx_poll_timeout() for large timeout

2020-08-18 Thread Sebastian Andrzej Siewior
ode, the context appears to be preemptible so using usleep() should work and avoid busy spinning. Use readx_poll_timeout() in the poll loop. Cc: Mark Starovoytov Cc: Igor Russkikh Signed-off-by: Sebastian Andrzej Siewior --- Could someone with hardware please verify it? It compiles, yes. driv

Re: [PATCH net-next 2/2] enetc: use napi_schedule to be compatible with PREEMPT_RT

2020-08-12 Thread Sebastian Andrzej Siewior
ntained stable kernel. This would also ensure that it is part stable-RT trees. > Also, not really sure who is using the threadirqs option except for > testing purposes. Oh. > Thanks, > -Vladimir Sebastian

Re: [PATCH net-next 2/2] enetc: use napi_schedule to be compatible with PREEMPT_RT

2020-08-12 Thread Sebastian Andrzej Siewior
t; Signed-off-by: Vladimir Oltean > > Applied. Could these two patches be forwarded -stable, please? The changelog describes this as a problem on PREEMPT_RT but this also happens on !RT with the `threadirqs' commandline switch. Sebastian

Re: [PATCH] net: add support for threaded NAPI polling

2020-08-02 Thread Sebastian Gottschall
Am 31.07.2020 um 18:36 schrieb Eric Dumazet: On 7/30/20 10:21 AM, Sebastian Gottschall wrote: Am 30.07.2020 um 18:08 schrieb Eric Dumazet: On 7/30/20 7:30 AM, Sebastian Gottschall wrote: Am 29.07.2020 um 19:44 schrieb Eric Dumazet: On 7/29/20 9:50 AM, Felix Fietkau wrote: For some

Re: [PATCH] net: add support for threaded NAPI polling

2020-07-30 Thread Sebastian Gottschall
Am 30.07.2020 um 18:08 schrieb Eric Dumazet: On 7/30/20 7:30 AM, Sebastian Gottschall wrote: Am 29.07.2020 um 19:44 schrieb Eric Dumazet: On 7/29/20 9:50 AM, Felix Fietkau wrote: For some drivers (especially 802.11 drivers), doing a lot of work in the NAPI poll function does not perform

Re: [PATCH] net: add support for threaded NAPI polling

2020-07-30 Thread Sebastian Gottschall
Am 30.07.2020 um 17:42 schrieb David Laight: From: Sebastian Gottschall Sent: 30 July 2020 15:30 ... Quite frankly, I do believe this STATE_THREADED status should be a generic NAPI attribute that can be changed dynamically, at admin request, instead of having to change/recompile a driver

Re: [PATCH] net: add support for threaded NAPI polling

2020-07-30 Thread Sebastian Gottschall
Am 29.07.2020 um 19:44 schrieb Eric Dumazet: On 7/29/20 9:50 AM, Felix Fietkau wrote: For some drivers (especially 802.11 drivers), doing a lot of work in the NAPI poll function does not perform well. Since NAPI poll is bound to the CPU it was scheduled from, we can easily end up with a few v

Re: [RFC 0/7] Add support to process rx packets in thread

2020-07-25 Thread Sebastian Gottschall
i agree. i just can say that i tested this patch recently due this discussion here. and it can be changed by sysfs. but it doesnt work for wifi drivers which are mainly using dummy netdev devices. for this i made a small patch to get them working using napi_set_threaded manually hardcoded in th

Re: [RFC 0/7] Add support to process rx packets in thread

2020-07-25 Thread Sebastian Gottschall
Am 25.07.2020 um 14:25 schrieb Hillf Danton: On Sat, 25 Jul 2020 12:38:00 +0200 Sebastian Gottschall wrote: you may consider this https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1142611.html <https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1142611.html>

Re: [RFC 0/7] Add support to process rx packets in thread

2020-07-25 Thread Sebastian Gottschall
e last 2 days and it worked so far (with some little modifications) so such a solution existed already and may be considered here Sebastian someone Am 25.07.2020 um 10:16 schrieb Hillf Danton: On Wed, 22 Jul 2020 09:12:42 + David Laight wrote: On 21 July 2020 18:25 Andrew Lunn wrote:

Re: [RFC 7/7] ath10k: Handle rx thread suspend and resume

2020-07-23 Thread Sebastian Gottschall
your patch seem to only affect the WCN3990 chipset. all other ath10k supported chipset are not supported here. so you see a chance to implement this more generic? Sebastian Am 21.07.2020 um 19:14 schrieb Rakesh Pillai: During the system suspend or resume, the rx thread also needs to be

[PATCH net] net/mlx5e: Do not include rwlock.h directly

2020-07-03 Thread Sebastian Andrzej Siewior
rwlock.h should not be included directly. Instead linux/splinlock.h should be included. Including it directly will break the RT build. Fixes: 549c243e4e010 ("net/mlx5e: Extract neigh-specific code from en_rep.c to rep/neigh.c") Signed-off-by: Sebastian Andrzej Siewior --- It would

[PATCH v3 5/7] connector/cn_proc: Protect send_msg() with a local lock

2020-05-27 Thread Sebastian Andrzej Siewior
f-by: Mike Galbraith Signed-off-by: Sebastian Andrzej Siewior --- drivers/connector/cn_proc.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/drivers/connector/cn_proc.c b/drivers/connector/cn_proc.c index d58ce664da843..646ad385e4904 100644 --- a/drivers

Re: [PATCH v2 5/7] connector/cn_proc: Protect send_msg() with a local lock

2020-05-25 Thread Sebastian Andrzej Siewior
_inc_return(local_evt.counts) - 1; > > Naming nit: renaming this from 'proc_event_counts' to > 'local_evt.counts' is a step back IMO - what's an 'evt', > did we run out of e's? ;-) > > Should be something like local_event.count? (Singular.) okay. > Thanks, > > Ingo Sebastian

[PATCH v2 5/7] connector/cn_proc: Protect send_msg() with a local lock

2020-05-24 Thread Sebastian Andrzej Siewior
f-by: Mike Galbraith Signed-off-by: Sebastian Andrzej Siewior --- drivers/connector/cn_proc.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/drivers/connector/cn_proc.c b/drivers/connector/cn_proc.c index d58ce664da843..d424d1f469136 100644 --- a/drivers

[PATCH 6/8] connector/cn_proc: Protect send_msg() with a local lock

2020-05-19 Thread Sebastian Andrzej Siewior
f-by: Mike Galbraith Signed-off-by: Sebastian Andrzej Siewior --- drivers/connector/cn_proc.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/connector/cn_proc.c b/drivers/connector/cn_proc.c index d58ce664da843..055b0c86a0693 100644 --- a/drivers/connector/cn_pr

Re: [PATCH][next] rtw88: fix spelling mistake "fimrware" -> "firmware"

2020-04-30 Thread Sebastian Andrzej Siewior
On 2020-04-24 09:47:33 [+0100], Colin King wrote: > From: Colin Ian King > > There are spelling mistakes in two rtw_err error messages. Fix them. > > Signed-off-by: Colin Ian King Acked-by: Sebastian Andrzej Siewior Sebastian

Re: [PATCH net-next v2] net: sched: Avoid using yield() in a busy waiting loop

2019-10-16 Thread Sebastian Andrzej Siewior
pensive checks in the fast paths of > > packet > > +* processing which isn't worth it. > > +*/ > > + schedule_timeout_uninterruptible(1); > > I am curious why this is uninterruptible? You don't want a signal to wake it too early. It has to chill for a jiffy. > Thanks. Sebastian

[PATCH net-next v2] net: sched: Avoid using yield() in a busy waiting loop

2019-10-16 Thread Sebastian Andrzej Siewior
: Rewrite commit message, add comment, use schedule_timeout_uninterruptible()] Signed-off-by: Sebastian Andrzej Siewior --- v1…v2: Typo fixes, noticed by Sergei Shtylyov. net/sched/sch_generic.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/net/sched

[PATCH net-next] net: sched: Avoid using yield() in a busy waiting loop

2019-10-11 Thread Sebastian Andrzej Siewior
[bigeasy: Rewrite commit message, add comment, use schedule_timeout_uninterruptible()] Signed-off-by: Sebastian Andrzej Siewior --- The old thread also pointed anoth yield() loop which was resolved by commit 845704a535e9b ("tcp: avoid looping in tcp_send_fin()")

[PATCH net-next] net/mvpp2: Replace tasklet with softirq hrtimer

2019-08-13 Thread Sebastian Andrzej Siewior
From: Thomas Gleixner The tx_done_tasklet tasklet is used in invoke the hrtimer (mvpp2_hr_timer_cb) in softirq context. This can be also achieved without the tasklet but with HRTIMER_MODE_SOFT as hrtimer mode. Signed-off-by: Thomas Gleixner Signed-off-by: Sebastian Andrzej Siewior

[PATCH v2 net-next 6/7] tg3: Use napi_alloc_frag()

2019-06-07 Thread Sebastian Andrzej Siewior
ned-off-by: Sebastian Andrzej Siewior --- drivers/net/ethernet/broadcom/tg3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c index 6d1f9c822548e..4c404d2213f98 100644 --- a/drivers/net/ethernet/broadcom/tg

[PATCH v2 net-next 4/7] dpaa2-eth: Use napi_alloc_frag()

2019-06-07 Thread Sebastian Andrzej Siewior
The driver is using netdev_alloc_frag() for allocation in the ->ndo_start_xmit() path. That one is always invoked in a BH disabled region so we could also use napi_alloc_frag(). Use napi_alloc_frag() for skb allocation. Cc: Ioana Radulescu Acked-by: Ioana Radulescu Signed-off-by: Sebast

[PATCH v2 net-next 3/7] dpaa2-eth: Remove preempt_disable() from seed_pool()

2019-06-07 Thread Sebastian Andrzej Siewior
d the no longer required preempt_disable(). Cc: Ioana Radulescu Acked-by: Ioana Radulescu Signed-off-by: Sebastian Andrzej Siewior --- drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c

[PATCH v2 net-next 2/7] net: Don't disable interrupts in __netdev_alloc_skb()

2019-06-07 Thread Sebastian Andrzej Siewior
alloc_cache.page'. The IRQ check is cheaper compared to disabling & enabling interrupts and memory allocation with disabled interrupts does not work on -RT. Signed-off-by: Sebastian Andrzej Siewior --- net/core/skbuff.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(

[PATCH v2 net-next 7/7] net: hwbm: Make the hwbm_pool lock a mutex

2019-06-07 Thread Sebastian Andrzej Siewior
longer invokes hwbm_pool_refill() in an atomic context so we can pass GFP_KERNEL to hwbm_pool_refill() and remove the `gfp' argument from hwbm_pool_add(). Cc: Thomas Petazzoni Signed-off-by: Sebastian Andrzej Siewior --- drivers/net/ethernet/marvell/mvneta.c| 2 +- drivers/net/ethernet/

[PATCH v2 net-next 1/7] net: Don't disable interrupts in napi_alloc_frag()

2019-06-07 Thread Sebastian Andrzej Siewior
c_frag() for the allocation. The IRQ check is cheaper compared to disabling & enabling interrupts and memory allocation with disabled interrupts does not work on -RT. Signed-off-by: Sebastian Andrzej Siewior --- net/core/skbuff.c | 53 ++- 1 file ch

[PATCH v2 net-next 5/7] bnx2x: Use napi_alloc_frag()

2019-06-07 Thread Sebastian Andrzej Siewior
...@marvell.com Signed-off-by: Sebastian Andrzej Siewior --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c index 008ad0ca89ba0

[PATCH v2 net-next 0/7] Avoid local_irq_save() and use napi_alloc_frag() where possible

2019-06-07 Thread Sebastian Andrzej Siewior
| irqs_disabled())" instead just "irqs_disabled()" to align with __dev_kfree_skb_any(). Pointed out by Eric Dumazet. - 6/7 has a typo less. Pointed out by Sergei Shtylyov. - 3/7 + 4/7 added acks from Ioana Radulescu. Sebastian

Re: [PATCH net-next 1/7] net: Don't disable interrupts in napi_alloc_frag()

2019-05-31 Thread Sebastian Andrzej Siewior
ause it just checks the preempt counter. Sebastian

[PATCH net-next 5/7] bnx2x: Use napi_alloc_frag()

2019-05-29 Thread Sebastian Andrzej Siewior
...@marvell.com Signed-off-by: Sebastian Andrzej Siewior --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c index 008ad0ca89ba0

[PATCH net-next 0/7] Avoid local_irq_save() and use napi_alloc_frag() where possible

2019-05-29 Thread Sebastian Andrzej Siewior
emove `netdev_alloc_cache' but then noticed that we still have non-NAPI drivers using netdev_alloc_skb() and I dropped that idea. Using napi_alloc_frag() over netdev_alloc_frag() would skip the not required local_bh_disable() around the allocation. Sebastian

[PATCH net-next 3/7] dpaa2-eth: Remove preempt_disable() from seed_pool()

2019-05-29 Thread Sebastian Andrzej Siewior
d the no longer required preempt_disable(). Cc: Ioana Radulescu Signed-off-by: Sebastian Andrzej Siewior --- drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c b/drivers/net/ethernet/freesc

[PATCH net-next 1/7] net: Don't disable interrupts in napi_alloc_frag()

2019-05-29 Thread Sebastian Andrzej Siewior
c_frag() for the allocation. The IRQ check is cheaper compared to disabling & enabling interrupts and memory allocation with disabled interrupts does not work on -RT. Signed-off-by: Sebastian Andrzej Siewior --- net/core/skbuff.c | 53 ++- 1 file ch

[PATCH net-next 6/7] tg3: Use napi_alloc_frag()

2019-05-29 Thread Sebastian Andrzej Siewior
han Signed-off-by: Sebastian Andrzej Siewior --- drivers/net/ethernet/broadcom/tg3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c index 6d1f9c822548e..4c404d2213f98 100644 --- a/drivers/net/ether

[PATCH net-next 4/7] dpaa2-eth: Use napi_alloc_frag()

2019-05-29 Thread Sebastian Andrzej Siewior
The driver is using netdev_alloc_frag() for allocation in the ->ndo_start_xmit() path. That one is always invoked in a BH disabled region so we could also use napi_alloc_frag(). Use napi_alloc_frag() for skb allocation. Cc: Ioana Radulescu Signed-off-by: Sebastian Andrzej Siewior --- driv

[PATCH net-next 7/7] net: hwbm: Make the hwbm_pool lock a mutex

2019-05-29 Thread Sebastian Andrzej Siewior
longer invokes hwbm_pool_refill() in an atomic context so we can pass GFP_KERNEL to hwbm_pool_refill() and remove the `gfp' argument from hwbm_pool_add(). Cc: Thomas Petazzoni Signed-off-by: Sebastian Andrzej Siewior --- drivers/net/ethernet/marvell/mvneta.c| 2 +- drivers/net/ethernet/

[PATCH net-next 2/7] net: Don't disable interrupts in __netdev_alloc_skb()

2019-05-29 Thread Sebastian Andrzej Siewior
alloc_cache.page'. The IRQ check is cheaper compared to disabling & enabling interrupts and memory allocation with disabled interrupts does not work on -RT. Signed-off-by: Sebastian Andrzej Siewior --- net/core/skbuff.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(

Re: Remove tasklet_hrtimer

2019-03-20 Thread Sebastian Andrzej Siewior
On 2019-03-20 10:45:41 [-0700], David Miller wrote: > > tglx can take them, feel free to add my: > > Acked-by: David S. Miller Thank you. Sebastian

Re: Remove tasklet_hrtimer

2019-03-20 Thread Sebastian Andrzej Siewior
they are again. Last two user. davem, what do we here? There is a Reviewed-by tag by Johannes for #1. There is nothing for #2. Should I ping Steffen/Herbert for an ack on #2? Do you prefer to take all three or should tglx/tip apply them (with or without an explicit ack for #2)? Sebastian

[PATCH 1/3] mac80211_hwsim: Replace hrtimer tasklet with softirq hrtimer

2019-03-01 Thread Sebastian Andrzej Siewior
Berg Cc: Kalle Valo Signed-off-by: Sebastian Andrzej Siewior --- drivers/net/wireless/mac80211_hwsim.c | 46 --- 1 file changed, 21 insertions(+), 25 deletions(-) diff --git a/drivers/net/wireless/mac80211_hwsim.c b/drivers/net/wireless/mac80211_hwsim.c index

[PATCH 2/3] xfrm: Replace hrtimer tasklet with softirq hrtimer

2019-03-01 Thread Sebastian Andrzej Siewior
vid S. Miller" Signed-off-by: Sebastian Andrzej Siewior --- include/net/xfrm.h| 2 +- net/xfrm/xfrm_state.c | 30 ++ 2 files changed, 19 insertions(+), 13 deletions(-) diff --git a/include/net/xfrm.h b/include/net/xfrm.h index 85386becbaea2..bbcf0b650b81e 10

Remove tasklet_hrtimer

2019-03-01 Thread Sebastian Andrzej Siewior
I just noticed that we still have the tasklet_hrtimer infastructure in tree. A while ago we tried to remove it. I digged the old patches up and it seems they did not apply and nobody followed up. So here they are again. Last two user. Sebastian

[PATCH 3/3] softirq: Remove tasklet_hrtimer

2019-03-01 Thread Sebastian Andrzej Siewior
From: Thomas Gleixner There are no more tasklet_hrtimer users of this interface. Remove it. Signed-off-by: Thomas Gleixner Signed-off-by: Anna-Maria Gleixner Signed-off-by: Sebastian Andrzej Siewior --- include/linux/interrupt.h | 25 --- kernel/softirq.c | 51

Re: stmmac / meson8b-dwmac

2019-02-24 Thread Sebastian Gottschall
** **its clearly visible when i activated the other stream for getting duplex load ... The highest rate also stays alot under the possible 930MBits that i have seen earlier with 4.14. ** ** ** **the parallel stream reached around 450Mbits , which almost sums up to 660Mbits. This is what i me

[PATCH net v3] net: dp83640: expire old TX-skb

2019-02-04 Thread Sebastian Andrzej Siewior
iconductor PHYTER.") Signed-off-by: Sebastian Andrzej Siewior Reviewed-by: Kurt Kanzenbach Acked-by: Richard Cochran --- v2…v3: - added a Fixes: tag, Richard's Acked-by and `net' after PATCH. RFC … v2: - reverse xmas tree - stable tag drivers/net/phy/dp836

[PATCH v2] net: dp83640: expire old TX-skb

2019-02-01 Thread Sebastian Andrzej Siewior
inuxptp/ptp4l usually closes the socket and opens a new one (in such a timeout case) so those "stale" replies never get there. However it does not resume normal operation anymore. Purge old skbs in decode_txts(). Cc: sta...@vger.kernel.org Signed-off-by: Sebastian Andrzej Siewior Revie

Re: [RFC] net: dp83640: expire old TX-skb

2019-02-01 Thread Sebastian Andrzej Siewior
atching fields. Using the timeout is probably the best that we can > do. yeah. I've been looking around and it seems there is nothing. And since that packet from the PHY is sent very seen usually shortly after the transmit I went for something similar that is already done the RX path. Sebastian

[RFC] net: dp83640: expire old TX-skb

2019-01-28 Thread Sebastian Andrzej Siewior
inuxptp/ptp4l usually closes the socket and opens a new one (in such a timeout case) so those "stale" replies never get there. However it does not resume normal operation anymore. Purge old skbs in decode_txts(). Reviewed-by: Kurt Kanzenbach Signed-off-by: Sebastian Andrzej Siewio

Re: [PATCH 6/8] power: reset: at91-reset: add support for sam9x60 SoC

2019-01-24 Thread Sebastian Reichel
Hi, On Thu, Jan 24, 2019 at 10:34:50AM +, nicolas.fe...@microchip.com wrote: > Hi Sebastian, > > On 23/01/2019 at 19:34, Sebastian Reichel wrote: > > Hi, > > > > On Wed, Jan 16, 2019 at 10:57:42AM +0100, Nicolas Ferre wrote: > >> Add support for ad

  1   2   3   4   >