On 2019-10-16 10:28:04 [-0700], Cong Wang wrote: > > Link: > > https://lkml.kernel.org/r/1393976987-23555-1-git-send-email-...@pengutronix.de > > BTW, this link doesn't work, 404 is returned.
here it returns 200: |$ wget https://lkml.kernel.org/r/1393976987-23555-1-git-send-email-...@pengutronix.de |--2019-10-16 20:37:05-- https://lkml.kernel.org/r/1393976987-23555-1-git-send-email-...@pengutronix.de |Resolving lkml.kernel.org (lkml.kernel.org)... 54.69.74.255, 54.71.250.162 |Connecting to lkml.kernel.org (lkml.kernel.org)|54.69.74.255|:443... connected. |HTTP request sent, awaiting response... 302 Found |Location: https://lore.kernel.org/linux-rt-users/1393976987-23555-1-git-send-email-...@pengutronix.de/ [following] |--2019-10-16 20:37:06-- https://lore.kernel.org/linux-rt-users/1393976987-23555-1-git-send-email-...@pengutronix.de/ |Resolving lore.kernel.org (lore.kernel.org)... 54.71.250.162, 54.69.74.255 |Connecting to lore.kernel.org (lore.kernel.org)|54.71.250.162|:443... connected. |HTTP request sent, awaiting response... 200 OK |Length: 10044 (9,8K) [text/html] |Saving to: ‘1393976987-23555-1-git-send-email-...@pengutronix.de’ > > --- a/net/sched/sch_generic.c > > +++ b/net/sched/sch_generic.c > > @@ -1217,8 +1217,13 @@ void dev_deactivate_many(struct list_head *head) > > > > /* Wait for outstanding qdisc_run calls. */ > > list_for_each_entry(dev, head, close_list) { > > - while (some_qdisc_is_busy(dev)) > > - yield(); > > + while (some_qdisc_is_busy(dev)) { > > + /* wait_event() would avoid this sleep-loop but > > would > > + * require expensive checks in the fast paths of > > packet > > + * processing which isn't worth it. > > + */ > > + schedule_timeout_uninterruptible(1); > > I am curious why this is uninterruptible? You don't want a signal to wake it too early. It has to chill for a jiffy. > Thanks. Sebastian
