Re: [PATCH] xen-netback: Check for hotplug-status existence before watching

2021-04-13 Thread Paul Durrant
eating the behaviour that was previously assumed to exist. Signed-off-by: Michael Brown Reviewed-by: Paul Durrant --- drivers/net/xen-netback/xenbus.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/x

Re: xen-netback hotplug-status regression bug

2021-04-13 Thread Paul Durrant
On 13/04/2021 11:48, Michael Brown wrote: On 13/04/2021 08:12, Paul Durrant wrote: If the frontend subsequently disconnects and reconnects (e.g. transitions through Closed->Initialising->Connected) then: - Nothing recreates "hotplug-status" - When the frontend re-enters

Re: xen-netback hotplug-status regression bug

2021-04-13 Thread Paul Durrant
On 10/04/2021 19:25, Michael Brown wrote: Commit https://github.com/torvalds/linux/commit/1f25657 ("xen-netback: remove 'hotplug-status' once it has served its purpose") seems to have introduced a regression that prevents a vif frontend from transitioning more than once into Connected state.

Re: [net-next 2/2] xen-netback: add module parameter to disable dynamic multicast control

2021-03-11 Thread Paul Durrant
t value is enable. Signed-off-by: ChiaHao Hsu Reviewed-by: Paul Durrant

Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring

2021-03-11 Thread Paul Durrant
e. Signed-off-by: ChiaHao Hsu Reviewed-by: Paul Durrant

Re: [PATCH] xen-netback: correct success/error reporting for the SKB-with-fraglist case

2021-02-25 Thread Paul Durrant
On 25/02/2021 14:00, Jan Beulich wrote: On 25.02.2021 13:11, Paul Durrant wrote: On 25/02/2021 07:33, Jan Beulich wrote: On 24.02.2021 17:39, Paul Durrant wrote: On 23/02/2021 16:29, Jan Beulich wrote: When re-entering the main loop of xenvif_tx_check_gop() a 2nd time, the special

Re: [PATCH] xen-netback: correct success/error reporting for the SKB-with-fraglist case

2021-02-25 Thread Paul Durrant
On 25/02/2021 07:33, Jan Beulich wrote: On 24.02.2021 17:39, Paul Durrant wrote: On 23/02/2021 16:29, Jan Beulich wrote: When re-entering the main loop of xenvif_tx_check_gop() a 2nd time, the special considerations for the head of the SKB no longer apply. Don't mistakenly report ERROR t

Re: [PATCH] xen-netback: correct success/error reporting for the SKB-with-fraglist case

2021-02-24 Thread Paul Durrant
On 23/02/2021 16:29, Jan Beulich wrote: When re-entering the main loop of xenvif_tx_check_gop() a 2nd time, the special considerations for the head of the SKB no longer apply. Don't mistakenly report ERROR to the frontend for the first entry in the list, even if - from all I can tell - this shoul

RE: [PATCH v2 5/8] xen/events: link interdomain events to associated xenbus device

2021-02-11 Thread Paul Durrant
k Wilk > ; Roger Pau Monné > ; Jens Axboe ; Wei Liu > ; Paul Durrant > ; David S. Miller ; Jakub Kicinski > ; Boris > Ostrovsky ; Stefano Stabellini > > Subject: [PATCH v2 5/8] xen/events: link interdomain events to associated > xenbus device > > In order

RE: [PATCH v2 4/8] xen/netback: fix spurious event detection for common event case

2021-02-11 Thread Paul Durrant
> -Original Message- > From: Juergen Gross > Sent: 11 February 2021 10:16 > To: xen-de...@lists.xenproject.org; netdev@vger.kernel.org; > linux-ker...@vger.kernel.org > Cc: Juergen Gross ; Wei Liu ; Paul > Durrant ; David > S. Miller ; Jakub Kicinski >

RE: [PATCH 2/7] net: xen-netback: xenbus: Demote nonconformant kernel-doc headers

2021-01-18 Thread Paul Durrant
> -Original Message- > From: Lee Jones > Sent: 15 January 2021 20:09 > To: lee.jo...@linaro.org > Cc: linux-ker...@vger.kernel.org; Wei Liu ; Paul Durrant > ; David S. > Miller ; Jakub Kicinski ; Alexei > Starovoitov ; > Daniel Borkmann ; Jesper Dangaard

RE: [PATCH net-next v13 3/3] xen networking: add XDP offset adjustment to xen-netback

2020-06-26 Thread Paul Durrant
XDP offset adjustment > to xen-netback > > the patch basically adds the offset adjustment and netfront > state reading to make XDP work on netfront side. > > Signed-off-by: Denis Kirjanov Reviewed-by: Paul Durrant > --- > drivers/net/xen-netback/common.h| 4 +++

RE: [PATCH net-next v12 3/3] xen networking: add XDP offset adjustment to xen-netback

2020-06-26 Thread Paul Durrant
> -Original Message- > From: Denis Kirjanov > Sent: 26 June 2020 12:27 > To: netdev@vger.kernel.org > Cc: bro...@redhat.com; jgr...@suse.com; wei@kernel.org; p...@xen.org; > ilias.apalodi...@linaro.org > Subject: [PATCH net-next v12 3/3] xen networking: add XDP offset adjustment > to

RE: [PATCH net-next v11 3/3] xen networking: add XDP offset adjustment to xen-netback

2020-06-26 Thread Paul Durrant
> + /* headroom requested by xen-netfront */ > + u16 netfront_xdp_headroom; I'd still prefer the shorter name of 'xdp_headroom'. With that fixed... Reviewed-by: Paul Durrant > + > /* Is this interface disabled? True when backend discovers &g

RE: [PATCH net-next v10 3/3] xen networking: add XDP offset adjustment to xen-netback

2020-06-22 Thread Paul Durrant
tworking: add XDP offset > adjustment to xen-netback > > On 6/22/20, Paul Durrant wrote: > >> -Original Message- > >> From: Denis Kirjanov > >> Sent: 22 June 2020 10:21 > >> To: netdev@vger.kernel.org > >> Cc: bro...@redhat.com; jgr..

RE: [PATCH net-next v10 3/3] xen networking: add XDP offset adjustment to xen-netback

2020-06-22 Thread Paul Durrant
> -Original Message- > From: Denis Kirjanov > Sent: 22 June 2020 10:21 > To: netdev@vger.kernel.org > Cc: bro...@redhat.com; jgr...@suse.com; wei@kernel.org; p...@xen.org; > ilias.apalodi...@linaro.org > Subject: [PATCH net-next v10 3/3] xen networking: add XDP offset adjustment > to

RE: [PATCH net-next v9 2/2] xen networking: add XDP offset adjustment to xen-netback

2020-05-12 Thread Paul Durrant
tworking: add XDP offset > adjustment to xen-netback > > On 5/11/20, Paul Durrant wrote: > >> -Original Message- > >> From: Denis Kirjanov > >> Sent: 11 May 2020 13:12 > >> To: p...@xen.org > >> Cc: netdev@vger.kernel.org; bro...@redhat.c

RE: [PATCH net-next v9 2/2] xen networking: add XDP offset adjustment to xen-netback

2020-05-11 Thread Paul Durrant
tworking: add XDP offset > adjustment to xen-netback > > On 5/11/20, Paul Durrant wrote: > >> -Original Message- > >> From: Denis Kirjanov > >> Sent: 11 May 2020 11:22 > >> To: netdev@vger.kernel.org > >> Cc: bro...@redhat.com; jgr...@suse.com; w

RE: [PATCH net-next v9 2/2] xen networking: add XDP offset adjustment to xen-netback

2020-05-11 Thread Paul Durrant
> -Original Message- > From: Denis Kirjanov > Sent: 11 May 2020 11:22 > To: netdev@vger.kernel.org > Cc: bro...@redhat.com; jgr...@suse.com; wei@kernel.org; p...@xen.org; > ilias.apalodi...@linaro.org > Subject: [PATCH net-next v9 2/2] xen networking: add XDP offset adjustment to > x

RE: [PATCH net-next v7 2/2] xen networking: add XDP offset adjustment to xen-netback

2020-05-07 Thread Paul Durrant
djustment to xen-netback > > On 5/5/20, Paul Durrant wrote: > >> -Original Message- > >> >> @@ -417,6 +431,11 @@ static void frontend_changed(struct xenbus_device > >> >> *dev, > >> >> set_backend_state(be

RE: [PATCH net-next v7 2/2] xen networking: add XDP offset adjustment to xen-netback

2020-05-05 Thread Paul Durrant
> -Original Message- > >> @@ -417,6 +431,11 @@ static void frontend_changed(struct xenbus_device > >> *dev, > >>set_backend_state(be, XenbusStateConnected); > >>break; > >> > >> + case XenbusStateReconfiguring: > >> + read_xenbus_frontend_xdp(be, dev); > >

RE: [PATCH net-next v7 2/2] xen networking: add XDP offset adjustment to xen-netback

2020-05-05 Thread Paul Durrant
> -Original Message- > From: Denis Kirjanov > Sent: 04 May 2020 09:38 > To: netdev@vger.kernel.org > Cc: jgr...@suse.com; wei@kernel.org; p...@xen.org; > ilias.apalodi...@linaro.org > Subject: [PATCH net-next v7 2/2] xen networking: add XDP offset adjustment to > xen-netback > > the

[PATCH net-next] MAINTAINERS: xen-netback: update my email address

2019-09-13 Thread Paul Durrant
My Citrix email address will expire shortly. Signed-off-by: Paul Durrant -- Cc: Wei Liu --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index e7a47b5210fd..b36d51f0fe5c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -17646,7 +17646,7

RE: [PATCH net-next] Update my email address

2019-05-31 Thread Paul Durrant
> -Original Message- > From: Wei Liu [mailto:wei.l...@citrix.com] > Sent: 31 May 2019 08:31 > To: netdev@vger.kernel.org > Cc: Xen-devel ; Paul Durrant > ; David Miller > ; Wei Liu > Subject: [PATCH net-next] Update my email address > > Signed-off-by: We

RE: [PATCH] xen-netback: don't populate the hash cache on XenBus disconnect

2019-02-28 Thread Paul Durrant
> -Original Message- > From: Igor Druzhinin [mailto:igor.druzhi...@citrix.com] > Sent: 28 February 2019 14:11 > To: xen-de...@lists.xenproject.org; netdev@vger.kernel.org; > linux-ker...@vger.kernel.org > Cc: Wei Liu ; Paul Durrant ; > da...@davemloft.net; Igor &

RE: [PATCH] xen-netback: fix occasional leak of grant ref mappings under memory pressure

2019-02-28 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf Of > Paul Durrant > Sent: 28 February 2019 11:22 > To: Wei Liu > Cc: Igor Druzhinin ; Wei Liu > ; netdev@vger.kernel.org; > linux-ker...@vger.kernel.org; xen-de

RE: [PATCH] xen-netback: fix occasional leak of grant ref mappings under memory pressure

2019-02-28 Thread Paul Durrant
> -Original Message- > From: Igor Druzhinin [mailto:igor.druzhi...@citrix.com] > Sent: 28 February 2019 11:44 > To: Paul Durrant ; Wei Liu > Cc: xen-de...@lists.xenproject.org; netdev@vger.kernel.org; > linux-ker...@vger.kernel.org; > da...@davemloft.net >

RE: [PATCH] xen-netback: fix occasional leak of grant ref mappings under memory pressure

2019-02-28 Thread Paul Durrant
> -Original Message- > From: Wei Liu [mailto:wei.l...@citrix.com] > Sent: 28 February 2019 11:02 > To: Paul Durrant > Cc: Igor Druzhinin ; > xen-de...@lists.xenproject.org; > netdev@vger.kernel.org; linux-ker...@vger.kernel.org; Wei Liu > ; > da...@davemlof

RE: [PATCH] xen-netback: fix occasional leak of grant ref mappings under memory pressure

2019-02-28 Thread Paul Durrant
> -Original Message- > From: Igor Druzhinin [mailto:igor.druzhi...@citrix.com] > Sent: 28 February 2019 02:03 > To: xen-de...@lists.xenproject.org; netdev@vger.kernel.org; > linux-ker...@vger.kernel.org > Cc: Wei Liu ; Paul Durrant ; > da...@davemloft.net; Igor &

RE: [PATCH 1/1] xen-netback: process malformed sk_buff correctly to avoid BUG_ON()

2018-03-28 Thread Paul Durrant
> -Original Message- > From: Dongli Zhang [mailto:dongli.zh...@oracle.com] > Sent: 28 March 2018 00:42 > To: xen-de...@lists.xenproject.org; linux-ker...@vger.kernel.org > Cc: netdev@vger.kernel.org; Wei Liu ; Paul Durrant > > Subject: [PATCH 1/1] xen-netback: proc

RE: [PATCH net-next v2] xen-netback: make copy batch size configurable

2017-12-21 Thread Paul Durrant
> -Original Message- > From: Joao Martins [mailto:joao.m.mart...@oracle.com] > Sent: 21 December 2017 17:24 > To: netdev@vger.kernel.org > Cc: Joao Martins ; Wei Liu > ; Paul Durrant ; xen- > de...@lists.xenproject.org > Subject: [PATCH net-next v2] xen-netba

RE: [PATCH] xen-netback: Fix logging message with spurious period after newline

2017-12-06 Thread Paul Durrant
> -Original Message- > From: Joe Perches [mailto:j...@perches.com] > Sent: 06 December 2017 06:40 > To: Wei Liu ; Paul Durrant > Cc: xen-de...@lists.xenproject.org; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org > Subject: [PATCH] xen-netback: Fix logging

RE: [PATCH] xen-netfront: remove warning when unloading module

2017-11-20 Thread Paul Durrant
> -Original Message- > From: Eduardo Otubo [mailto:ot...@redhat.com] > Sent: 20 November 2017 10:41 > To: xen-de...@lists.xenproject.org > Cc: netdev@vger.kernel.org; Paul Durrant ; Wei > Liu ; linux-ker...@vger.kernel.org; > vkuzn...@redhat.com; cav...@redhat.com; che

RE: [PATCH net-next v1] xen-netback: make copy batch size configurable

2017-11-13 Thread Paul Durrant
> -Original Message- > From: Joao Martins [mailto:joao.m.mart...@oracle.com] > Sent: 13 November 2017 16:34 > To: Paul Durrant > Cc: netdev@vger.kernel.org; Wei Liu ; xen- > de...@lists.xenproject.org > Subject: Re: [PATCH net-next v1] xen-netback: make copy batc

RE: [PATCH net-next v1] xen-netback: make copy batch size configurable

2017-11-13 Thread Paul Durrant
> -Original Message- > From: Joao Martins [mailto:joao.m.mart...@oracle.com] > Sent: 13 November 2017 11:54 > To: Paul Durrant > Cc: netdev@vger.kernel.org; Wei Liu ; xen- > de...@lists.xenproject.org > Subject: Re: [PATCH net-next v1] xen-netback: make copy batc

RE: [Xen-devel] [PATCH net-next v1] xen-netback: make copy batch size configurable

2017-11-13 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 13 November 2017 10:50 > To: Paul Durrant > Cc: Wei Liu ; xen-de...@lists.xenproject.org; 'Joao > Martins' ; netdev@vger.kernel.org > Subject: Re: [Xen-devel] [PATCH net-next v

RE: [PATCH net-next v1] xen-netback: make copy batch size configurable

2017-11-13 Thread Paul Durrant
> -Original Message- > From: Joao Martins [mailto:joao.m.mart...@oracle.com] > Sent: 10 November 2017 19:35 > To: netdev@vger.kernel.org > Cc: Joao Martins ; Wei Liu > ; Paul Durrant ; xen- > de...@lists.xenproject.org > Subject: [PATCH net-next v1] xen-netba

RE: [PATCH net] xen-netback: correctly schedule rate-limited queues

2017-06-21 Thread Paul Durrant
> -Original Message- > From: Wei Liu [mailto:wei.l...@citrix.com] > Sent: 21 June 2017 10:21 > To: netdev@vger.kernel.org > Cc: Xen-devel ; Paul Durrant > ; David Miller ; jean- > lo...@dupond.be; Wei Liu > Subject: [PATCH net] xen-netback: correctly schedule rate

RE: [PATCH net v3] xen-netback: fix race condition on XenBus disconnect

2017-03-09 Thread Paul Durrant
> -Original Message- > From: Igor Druzhinin [mailto:igor.druzhi...@citrix.com] > Sent: 09 March 2017 19:42 > To: netdev@vger.kernel.org; xen-de...@lists.xenproject.org > Cc: Paul Durrant ; jgr...@suse.com; Wei Liu > ; Igor Druzhinin > Subject: [PATCH net v3]

RE: [PATCH net v2] xen-netback: fix race condition on XenBus disconnect

2017-03-06 Thread Paul Durrant
> -Original Message- > From: Igor Druzhinin [mailto:igor.druzhi...@citrix.com] > Sent: 03 March 2017 20:23 > To: netdev@vger.kernel.org; xen-de...@lists.xenproject.org > Cc: Paul Durrant ; jgr...@suse.com; Wei Liu > ; Igor Druzhinin > Subject: [PATCH net v2]

RE: [PATCH] xen-netback: fix race condition on XenBus disconnect

2017-03-03 Thread Paul Durrant
> -Original Message- > From: Igor Druzhinin > Sent: 03 March 2017 13:54 > To: Paul Durrant ; netdev@vger.kernel.org; xen- > de...@lists.xenproject.org > Cc: jgr...@suse.com; Wei Liu > Subject: Re: [PATCH] xen-netback: fix race condition on XenBus disconnect > &

RE: [PATCH] xen-netback: fix race condition on XenBus disconnect

2017-03-03 Thread Paul Durrant
> -Original Message- > From: Igor Druzhinin > Sent: 03 March 2017 13:56 > To: Paul Durrant ; netdev@vger.kernel.org; xen- > de...@lists.xenproject.org > Cc: jgr...@suse.com; Wei Liu > Subject: Re: [PATCH] xen-netback: fix race condition on XenBus disconnect > &

RE: [PATCH] xen-netback: fix race condition on XenBus disconnect

2017-03-03 Thread Paul Durrant
> -Original Message- > From: Igor Druzhinin [mailto:igor.druzhi...@citrix.com] > Sent: 02 March 2017 22:57 > To: netdev@vger.kernel.org; xen-de...@lists.xenproject.org > Cc: Paul Durrant ; jgr...@suse.com; Wei Liu > ; Igor Druzhinin > Subject: [PATCH] xen-netback:

[PATCH net 1/2] xen-netback: keep a local pointer for vif in backend_disconnect()

2017-03-02 Thread Paul Durrant
This patch replaces use of 'be->vif' with 'vif' and hence generally makes the function look tidier. No semantic change. Signed-off-by: Paul Durrant --- Cc: Wei Liu --- drivers/net/xen-netback/xenbus.c | 32 ++-- 1 file changed, 18 inse

[PATCH net 2/2] xen-netback: don't vfree() queues under spinlock

2017-03-02 Thread Paul Durrant
] ? xenbus_printf+0x50/0x50 [ 174.541278] ? __kthread_init_worker+0x40/0x40 [ 174.541898] ret_from_fork+0x21/0x2c [ 174.548635] switch: port 2(vif3.0) entered disabled state This patch defers the vfree() until after the spinlock is released. Reported-by: Juergen Gross Signed-off-by: Paul Durrant --- Cc

[PATCH net 0/2] xen-netback: update memory leak fix to avoid BUG

2017-03-02 Thread Paul Durrant
d this call to vfree() in a spin lock, leading to a BUG due to incorrect context. Patch #1 makes the existing code more readable Patch #2 fixes the problem Paul Durrant (2): xen-netback: keep a local pointer for vif in backend_disconnect() xen-netback: don't vfree() queues under spinlock

RE: BUG due to "xen-netback: protect resource cleaning on XenBus disconnect"

2017-03-02 Thread Paul Durrant
> -Original Message- > From: Juergen Gross [mailto:jgr...@suse.com] > Sent: 02 March 2017 12:13 > To: Wei Liu > Cc: Igor Druzhinin ; xen-devel de...@lists.xenproject.org>; Linux Kernel Mailing List ker...@vger.kernel.org>; netdev@vger.kernel.org; Boris Ostrovsky &g

RE: [PATCH net] xen-netback: Use GFP_ATOMIC to allocate hash

2017-03-02 Thread Paul Durrant
> -Original Message- > From: Anoob Soman [mailto:anoob.so...@citrix.com] > Sent: 02 March 2017 10:50 > To: netdev@vger.kernel.org; xen-de...@lists.xenproject.org > Cc: Paul Durrant ; Wei Liu ; > Anoob Soman > Subject: [PATCH net] xen-netback: Use GFP_AT

RE: [Xen-devel] [PATCH] xen-netback: vif counters from int/long to u64

2017-02-10 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of > Mart van Santen > Sent: 10 February 2017 12:02 > To: Wei Liu ; Paul Durrant ; > xen-de...@lists.xenproject.org; netdev@vger.kernel.org > Cc: Mart van Santen > Subject:

[PATCH net-next] xen-netfront: reject short packets and handle non-linear packets

2017-01-25 Thread Paul Durrant
lls sufficient bytes into the linear area. Signed-off-by: Paul Durrant Reported-by: Sowmini Varadhan Tested-by: Sowmini Varadhan --- Cc: Boris Ostrovsky Cc: Juergen Gross --- drivers/net/xen-netfront.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/xen-netfront.c b/drivers/

RE: [Xen-devel] xennet_start_xmit assumptions

2017-01-25 Thread Paul Durrant
> -Original Message- > From: Sowmini Varadhan [mailto:sowmini.varad...@oracle.com] > Sent: 19 January 2017 11:14 > To: Paul Durrant > Cc: Konrad Rzeszutek Wilk ; Wei Liu > ; netdev@vger.kernel.org; xen- > de...@lists.xenproject.org > Subject: Re: [Xen-devel] xenne

RE: [Xen-devel] xennet_start_xmit assumptions

2017-01-19 Thread Paul Durrant
> -Original Message- > From: Sowmini Varadhan [mailto:sowmini.varad...@oracle.com] > Sent: 19 January 2017 11:14 > To: Paul Durrant > Cc: Konrad Rzeszutek Wilk ; Wei Liu > ; netdev@vger.kernel.org; xen- > de...@lists.xenproject.org > Subject: Re: [Xen-devel] xenne

RE: [Xen-devel] xennet_start_xmit assumptions

2017-01-19 Thread Paul Durrant
> -Original Message- > From: Konrad Rzeszutek Wilk [mailto:konrad.w...@oracle.com] > Sent: 18 January 2017 19:25 > To: Sowmini Varadhan ; Wei Liu > ; Paul Durrant > Cc: netdev@vger.kernel.org; xen-de...@lists.xenproject.org > Subject: Re: [Xen-devel] xennet_start_xmi

RE: [PATCH v2 2/2] xen-netback: protect resource cleaning on XenBus disconnect

2017-01-18 Thread Paul Durrant
> -Original Message- > From: Igor Druzhinin [mailto:igor.druzhi...@citrix.com] > Sent: 17 January 2017 20:50 > To: Wei Liu > Cc: Paul Durrant ; xen-de...@lists.xenproject.org; > netdev@vger.kernel.org; linux-ker...@vger.kernel.org; Igor Druzhinin > > Subject: [P

RE: [PATCH v2 1/2] xen-netback: fix memory leaks on XenBus disconnect

2017-01-18 Thread Paul Durrant
> -Original Message- > From: Igor Druzhinin [mailto:igor.druzhi...@citrix.com] > Sent: 17 January 2017 20:50 > To: Wei Liu > Cc: Paul Durrant ; xen-de...@lists.xenproject.org; > netdev@vger.kernel.org; linux-ker...@vger.kernel.org; Igor Druzhinin > > Subject: [P

RE: [PATCH] xen-netback: fix memory leaks on XenBus disconnect

2017-01-13 Thread Paul Durrant
> -Original Message- > From: Wei Liu [mailto:wei.l...@citrix.com] > Sent: 13 January 2017 10:38 > To: Igor Druzhinin > Cc: Wei Liu ; xen-de...@lists.xenproject.org; Paul > Durrant ; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH]

RE: [PATCH] xen-netback: fix memory leaks on XenBus disconnect

2017-01-13 Thread Paul Durrant
> -Original Message- > From: Igor Druzhinin [mailto:igor.druzhi...@citrix.com] > Sent: 12 January 2017 17:52 > To: Wei Liu ; xen-de...@lists.xenproject.org; Paul > Durrant > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; Igor Druzhinin > > Subject:

RE: [PATCH 2/3] xen: modify xenstore watch event interface

2017-01-06 Thread Paul Durrant
> -Original Message- > From: Juergen Gross [mailto:jgr...@suse.com] > Sent: 06 January 2017 15:06 > To: linux-ker...@vger.kernel.org; xen-de...@lists.xenproject.org > Cc: boris.ostrov...@oracle.com; Juergen Gross ; > konrad.w...@oracle.com; Roger Pau Monne ; Wei Li

RE: [Xen PATCH] xen-netback: fix error handling output

2016-11-08 Thread Paul Durrant
> -Original Message- > From: Arnd Bergmann [mailto:a...@arndb.de] > Sent: 08 November 2016 13:35 > To: David Vrabel > Cc: Arnd Bergmann ; Wei Liu ; Paul > Durrant ; David S. Miller > ; Juergen Gross ; Filipe Manco > ; xen-de...@lists.xenproject.org; > netdev

RE: [PATCH v3] xen-netback: prefer xenbus_scanf() over xenbus_gather()

2016-11-08 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 08 November 2016 07:46 > To: Paul Durrant ; Wei Liu > Cc: xen-devel ; netdev@vger.kernel.org > Subject: [PATCH v3] xen-netback: prefer xenbus_scanf() over > xenbus_gather() > > For s

RE: [PATCH 06/12] xen: make use of xenbus_read_unsigned() in xen-netback

2016-11-01 Thread Paul Durrant
> -Original Message- > From: Juergen Gross [mailto:jgr...@suse.com] > Sent: 31 October 2016 16:48 > To: linux-ker...@vger.kernel.org; xen-de...@lists.xen.org > Cc: David Vrabel ; boris.ostrov...@oracle.com; > Juergen Gross ; Wei Liu ; Paul > Durrant ; netdev@vger

RE: [PATCH v2 RESEND] xen-netback: prefer xenbus_scanf() over xenbus_gather()

2016-10-25 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 25 October 2016 09:23 > To: Paul Durrant > Cc: David Vrabel ; Wei Liu ; > xen-de...@lists.xenproject.org; boris.ostrov...@oracle.com; Juergen Gross > ; netdev@vger.kernel.org > Subject: R

RE: [PATCH v2 RESEND] xen-netback: prefer xenbus_scanf() over xenbus_gather()

2016-10-25 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 24 October 2016 16:08 > To: Paul Durrant ; Wei Liu > Cc: David Vrabel ; xen-de...@lists.xenproject.org; > boris.ostrov...@oracle.com; Juergen Gross ; > netdev@vger.kernel.org > Subjec

RE: [PATCH] xen-netback: fix type mismatch warning

2016-10-12 Thread Paul Durrant
> -Original Message- > From: Arnd Bergmann [mailto:a...@arndb.de] > Sent: 12 October 2016 10:54 > To: Wei Liu ; Paul Durrant > Cc: Arnd Bergmann ; David S. Miller > ; David Vrabel ; xen- > de...@lists.xenproject.org; netdev@vger.kernel.org; linux- > ker...@v

RE: [PATCHv1 net] xen-netback: fix guest Rx stall detection (after guest Rx refactor)

2016-10-11 Thread Paul Durrant
> -Original Message- > From: David Vrabel [mailto:david.vra...@citrix.com] > Sent: 11 October 2016 16:48 > To: netdev@vger.kernel.org > Cc: David Vrabel ; xen-de...@lists.xenproject.org; > Paul Durrant ; Wei Liu > Subject: [PATCHv1 net] xen-netback: fix guest Rx s

[PATCH net] xen-netback: (re-)create a debugfs node for hash information

2016-10-10 Thread Paul Durrant
From: Paul Durrant It is useful to be able to see the hash configuration when running tests. This patch adds a debugfs node for that purpose. The original version of this patch (commit c0c64c152389) was reverted due to build failures caused by a conflict with commit 0364a8824c02 ("xen-ne

[PATCH net-next] MAINTAINERS: add myself as a maintainer of xen-netback

2016-10-07 Thread Paul Durrant
Signed-off-by: Paul Durrant Cc: Wei Liu --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 464437d..4491841 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -13061,6 +13061,7 @@ F: arch/arm64/include/asm/xen/ XEN NETWORK BACKEND DRIVER M

Reversion of "xen-netback: create a debugfs node for hash information"

2016-10-07 Thread Paul Durrant
Dave, I notice that you have made the above reversion of commit c0c64c15 (debugfs node) due to a build failure, despite the failure being caused by commit 0364a882 (switch to threaded irq) which was made subsequently. I assume you want me to re-spin a new patch for the debugfs node to fix the

[PATCH v2 net] xen-netback: make sure that hashes are not send to unaware frontends

2016-10-07 Thread Paul Durrant
() instead, which is clearly guaranteed to be called irrespective of the number of queues. Signed-off-by: Paul Durrant Cc: Wei Liu --- v2: - Simplified and re-based onto re-factored net branch --- drivers/net/xen-netback/interface.c | 20 +--- 1 file changed, 9 insertions(+), 11

RE: [PATCH net] xen-netback: make sure that hashes are not send to unaware frontends

2016-10-07 Thread Paul Durrant
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: 07 October 2016 06:38 > To: Paul Durrant > Cc: netdev@vger.kernel.org; xen-de...@lists.xenproject.org; Wei Liu > > Subject: Re: [PATCH net] xen-netback: make sure that hashes are

[PATCH net] xen-netback: make sure that hashes are not send to unaware frontends

2016-10-06 Thread Paul Durrant
not only on the presence of a s/w hash, but also on whether the hash algorithm has been configured. Signed-off-by: Paul Durrant Cc: Wei Liu --- drivers/net/xen-netback/interface.c | 13 ++--- drivers/net/xen-netback/netback.c | 23 ++- 2 files changed, 16

RE: [Xen-devel] [PATCH v2 net-next 4/7] xen-netback: immediately wake tx queue when guest rx queue has space

2016-10-04 Thread Paul Durrant
> -Original Message- > From: Konrad Rzeszutek Wilk [mailto:konrad.w...@oracle.com] > Sent: 04 October 2016 13:49 > To: Paul Durrant > Cc: netdev@vger.kernel.org; xen-de...@lists.xenproject.org; Wei Liu > ; David Vrabel > Subject: Re: [Xen-devel] [PATCH v2 net-

RE: [Xen-devel] [PATCH v2 net-next 5/7] xen-netback: process guest rx packets in batches

2016-10-04 Thread Paul Durrant
> -Original Message- > From: Konrad Rzeszutek Wilk [mailto:konrad.w...@oracle.com] > Sent: 04 October 2016 13:48 > To: Paul Durrant > Cc: netdev@vger.kernel.org; xen-de...@lists.xenproject.org; Wei Liu > ; David Vrabel > Subject: Re: [Xen-devel] [PATCH v2 net-

RE: [Xen-devel] [PATCH v2 net-next 2/7] xen-netback: retire guest rx side prefix GSO feature

2016-10-04 Thread Paul Durrant
> -Original Message- > From: Konrad Rzeszutek Wilk [mailto:konrad.w...@oracle.com] > Sent: 04 October 2016 13:52 > To: Paul Durrant ; annie...@oracle.com; > joao.m.mart...@oracle.com > Cc: netdev@vger.kernel.org; xen-de...@lists.xenproject.org; Wei Liu > > Subject

[PATCH v2 net-next 5/7] xen-netback: process guest rx packets in batches

2016-10-04 Thread Paul Durrant
From: David Vrabel Instead of only placing one skb on the guest rx ring at a time, process a batch of up-to 64. This improves performance by ~10% in some tests. Signed-off-by: David Vrabel [re-based] Signed-off-by: Paul Durrant --- Cc: Wei Liu --- drivers/net/xen-netback/rx.c | 15

[PATCH v2 net-next 0/7] xen-netback: guest rx side refactor

2016-10-04 Thread Paul Durrant
. v2: - Rebased onto refreshed net-next David Vrabel (4): xen-netback: refactor guest rx xen-netback: immediately wake tx queue when guest rx queue has space xen-netback: process guest rx packets in batches xen-netback: batch copies for multiple to-guest rx packets Paul Durrant (2): xen

[PATCH v2 net-next 7/7] xen/netback: add fraglist support for to-guest rx

2016-10-04 Thread Paul Durrant
From: Ross Lagerwall This allows full 64K skbuffs (with 1500 mtu ethernet, composed of 45 fragments) to be handled by netback for to-guest rx. Signed-off-by: Ross Lagerwall [re-based] Signed-off-by: Paul Durrant --- Cc: Wei Liu --- drivers/net/xen-netback/interface.c | 2 +- drivers/net

[PATCH v2 net-next 6/7] xen-netback: batch copies for multiple to-guest rx packets

2016-10-04 Thread Paul Durrant
: David Vrabel [re-based] Signed-off-by: Paul Durrant --- Cc: Wei Liu --- drivers/net/xen-netback/common.h | 1 + drivers/net/xen-netback/rx.c | 27 +-- 2 files changed, 18 insertions(+), 10 deletions(-) diff --git a/drivers/net/xen-netback/common.h b/drivers/net/xen

[PATCH v2 net-next 3/7] xen-netback: refactor guest rx

2016-10-04 Thread Paul Durrant
only 44 kB instead of 220 kB. 3. Make the code more maintainable. Signed-off-by: David Vrabel [re-based] Signed-off-by: Paul Durrant --- Cc: Wei Liu --- drivers/net/xen-netback/common.h | 23 +- drivers/net/xen-netback/rx.c | 654 +++ 2 files changed, 254

[PATCH v2 net-next 4/7] xen-netback: immediately wake tx queue when guest rx queue has space

2016-10-04 Thread Paul Durrant
From: David Vrabel When an skb is removed from the guest rx queue, immediately wake the tx queue, instead of after processing them. Signed-off-by: David Vrabel [re-based] Signed-off-by: Paul Durrant --- Cc: Wei Liu --- drivers/net/xen-netback/rx.c | 24 1 file

[PATCH v2 net-next 1/7] xen-netback: separate guest side rx code into separate module

2016-10-04 Thread Paul Durrant
patch style-check issues. Signed-off-by: Paul Durrant --- Cc: Wei Liu --- drivers/net/xen-netback/Makefile | 2 +- drivers/net/xen-netback/netback.c | 754 drivers/net/xen-netback/rx.c | 789 ++ 3 files changed, 790

[PATCH v2 net-next 2/7] xen-netback: retire guest rx side prefix GSO feature

2016-10-04 Thread Paul Durrant
SO packets, which is also used by all Linux frontends. NOTE: Removal of this feature will not cause breakage in old Windows frontends. They simply will no longer receive GSO packets - the packets instead being fragmented in the backend. Signed-off-by: Paul Durrant --- Cc: Wei Liu --- d

RE: [PATCH net-next 0/7] xen-netback: guest rx side refactor

2016-10-04 Thread Paul Durrant
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: 04 October 2016 05:52 > To: Paul Durrant > Cc: netdev@vger.kernel.org; xen-de...@lists.xenproject.org > Subject: Re: [PATCH net-next 0/7] xen-netback: guest rx side refactor > > From: P

[PATCH net-next 7/7] xen/netback: add fraglist support for to-guest rx

2016-10-03 Thread Paul Durrant
From: Ross Lagerwall This allows full 64K skbuffs (with 1500 mtu ethernet, composed of 45 fragments) to be handled by netback for to-guest rx. Signed-off-by: Ross Lagerwall [re-based] Signed-off-by: Paul Durrant --- Cc: Wei Liu --- drivers/net/xen-netback/interface.c | 2 +- drivers/net

[PATCH net-next 0/7] xen-netback: guest rx side refactor

2016-10-03 Thread Paul Durrant
. David Vrabel (4): xen-netback: refactor guest rx xen-netback: immediately wake tx queue when guest rx queue has space xen-netback: process guest rx packets in batches xen-netback: batch copies for multiple to-guest rx packets Paul Durrant (2): xen-netback: separate guest side rx code

[PATCH net-next 1/7] xen-netback: separate guest side rx code into separate module

2016-10-03 Thread Paul Durrant
patch style-check issues. Signed-off-by: Paul Durrant --- Cc: Wei Liu --- drivers/net/xen-netback/Makefile | 2 +- drivers/net/xen-netback/netback.c | 754 drivers/net/xen-netback/rx.c | 789 ++ 3 files changed, 790

[PATCH net-next 3/7] xen-netback: refactor guest rx

2016-10-03 Thread Paul Durrant
only 44 kB instead of 220 kB. 3. Make the code more maintainable. Signed-off-by: David Vrabel [re-based] Signed-off-by: Paul Durrant --- Cc: Wei Liu --- drivers/net/xen-netback/common.h | 23 +- drivers/net/xen-netback/rx.c | 654 +++ 2 files changed, 254

[PATCH net-next 6/7] xen-netback: batch copies for multiple to-guest rx packets

2016-10-03 Thread Paul Durrant
: David Vrabel [re-based] Signed-off-by: Paul Durrant --- Cc: Wei Liu --- drivers/net/xen-netback/common.h | 1 + drivers/net/xen-netback/rx.c | 27 +-- 2 files changed, 18 insertions(+), 10 deletions(-) diff --git a/drivers/net/xen-netback/common.h b/drivers/net/xen

[PATCH net-next 5/7] xen-netback: process guest rx packets in batches

2016-10-03 Thread Paul Durrant
From: David Vrabel Instead of only placing one skb on the guest rx ring at a time, process a batch of up-to 64. This improves performance by ~10% in some tests. Signed-off-by: David Vrabel [re-based] Signed-off-by: Paul Durrant --- Cc: Wei Liu --- drivers/net/xen-netback/rx.c | 15

[PATCH net-next 4/7] xen-netback: immediately wake tx queue when guest rx queue has space

2016-10-03 Thread Paul Durrant
From: David Vrabel When an skb is removed from the guest rx queue, immediately wake the tx queue, instead of after processing them. Signed-off-by: David Vrabel [re-based] Signed-off-by: Paul Durrant --- Cc: Wei Liu --- drivers/net/xen-netback/rx.c | 24 1 file

[PATCH net-next 2/7] xen-netback: retire guest rx side prefix GSO feature

2016-10-03 Thread Paul Durrant
SO packets, which is also used by all Linux frontends. NOTE: Removal of this feature will not cause breakage in old Windows frontends. They simply will no longer receive GSO packets - the packets instead being fragmented in the backend. Signed-off-by: Paul Durrant --- Cc: Wei Liu --- d

RE: [Xen-devel] [PATCH resend] xen-netback: switch to threaded irq for control ring

2016-09-22 Thread Paul Durrant
> -Original Message- > From: Juergen Gross [mailto:jgr...@suse.com] > Sent: 22 September 2016 11:39 > To: Paul Durrant ; xen-de...@lists.xenproject.org; > netdev@vger.kernel.org; linux-ker...@vger.kernel.org > Cc: Wei Liu > Subject: Re: [Xen-devel] [PATCH resend] x

RE: [Xen-devel] [PATCH resend] xen-netback: switch to threaded irq for control ring

2016-09-22 Thread Paul Durrant
> -Original Message- > From: Juergen Gross [mailto:jgr...@suse.com] > Sent: 22 September 2016 11:17 > To: Paul Durrant ; xen-de...@lists.xenproject.org; > net...@vger.kernel.orga ; linux- > ker...@vger.kernel.org > Cc: Wei Liu > Subject: Re: [Xen-devel] [PATCH res

[PATCH net-next] xen-netback: create a debugfs node for hash information

2016-08-17 Thread Paul Durrant
It is useful to be able to see the hash configuration when running tests. This patch adds a debugfs node for that purpose. Signed-off-by: Paul Durrant Cc: Wei Liu --- drivers/net/xen-netback/common.h | 4 +++ drivers/net/xen-netback/hash.c | 68

RE: [Xen-devel] [PATCH] xen-netback: correct return value checks on xenbus_scanf()

2016-07-07 Thread Paul Durrant
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of David Vrabel > Sent: 07 July 2016 11:45 > To: Wei Liu; David Vrabel > Cc: xen-de...@lists.xenproject.org; Jan Beulich; netdev@vger.kernel.org > Subject: Re: [Xen-devel] [PATCH] xe

RE: [Xen-devel] [PATCH] xen-netback: correct return value checks on xenbus_scanf()

2016-07-07 Thread Paul Durrant
> -Original Message- > From: Paul Durrant > Sent: 07 July 2016 11:41 > To: Wei Liu; David Vrabel > Cc: Jan Beulich; Wei Liu; xen-de...@lists.xenproject.org; > netdev@vger.kernel.org > Subject: RE: [Xen-devel] [PATCH] xen-netback: correct return value che

RE: [Xen-devel] [PATCH] xen-netback: correct return value checks on xenbus_scanf()

2016-07-07 Thread Paul Durrant
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Wei Liu > Sent: 07 July 2016 11:35 > To: David Vrabel > Cc: Jan Beulich; Wei Liu; xen-de...@lists.xenproject.org; > netdev@vger.kernel.org > Subject: Re: [Xen-devel] [PATCH] xen-n

RE: [Xen-devel] [PATCH] xen-netback: prefer xenbus_write() over xenbus_printf() where possible

2016-07-07 Thread Paul Durrant
r xenbus_write() over > xenbus_printf() where possible > > ... as being the simpler variant. > > Signed-off-by: Jan Beulich Reviewed-by: Paul Durrant > --- > drivers/net/xen-netback/xenbus.c | 24 +--- > 1 file changed, 9 insertions(+), 15 deletions(-) >

RE: [Xen-devel] [PATCH] xen-netback: correct return value checks on xenbus_scanf()

2016-07-07 Thread Paul Durrant
eturn value checks on > xenbus_scanf() > > Only a positive return value indicates success. > > Signed-off-by: Jan Beulich Reviewed-by: Paul Durrant > --- > drivers/net/xen-netback/xenbus.c | 26 +- > 1 file changed, 13 insertions(+), 13 deletions(

[PATCH net-next] xen-netback: only deinitialized hash if it was initialized

2016-05-18 Thread Paul Durrant
called. This patch brings the call to xenvif_deinit_hash() in xenvif_disconnect_ctrl() inside the if clause that checks whether the control ring event channel was connected. This is sufficient to ensure it is only called if xenvif_init_hash() was called previously. Signed-off-by: Paul Durrant

  1   2   >