> -----Original Message----- > From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Wei Liu > Sent: 07 July 2016 11:35 > To: David Vrabel > Cc: Jan Beulich; Wei Liu; xen-de...@lists.xenproject.org; > netdev@vger.kernel.org > Subject: Re: [Xen-devel] [PATCH] xen-netback: correct return value checks > on xenbus_scanf() > > On Thu, Jul 07, 2016 at 10:58:16AM +0100, David Vrabel wrote: > > On 07/07/16 08:57, Jan Beulich wrote: > > > Only a positive return value indicates success. > > > > This is not correct. > >
If Xen's vsscanf follows the semantics of scanf(3) then 0 is a failure so I think the comment is correct. Paul > > Do you mean the commit message is not correct or the code is not > correct? If it is the formal, do you have any suggestion to fix it? > > (I was going to just ack this because Paul already reviewed it) > > Wei. > > > David
