> -----Original Message----- > From: David Miller [mailto:da...@davemloft.net] > Sent: 07 October 2016 06:38 > To: Paul Durrant <paul.durr...@citrix.com> > Cc: netdev@vger.kernel.org; xen-de...@lists.xenproject.org; Wei Liu > <wei.l...@citrix.com> > Subject: Re: [PATCH net] xen-netback: make sure that hashes are not send > to unaware frontends > > From: Paul Durrant <paul.durr...@citrix.com> > Date: Thu, 6 Oct 2016 15:47:10 +0100 > > > In the case when a frontend only negotiates a single queue with xen- > > netback it is possible for a skbuff with a s/w hash to result in a > > hash extra_info segment being sent to the frontend even when no hash > > algorithm has been configured. (The ndo_select_queue() entry point > > makes sure the hash is not set if no algorithm is configured, but this > > entry point is not called when there is only a single queue). This can > > result in a frontend that isunable to handle extra_info segments being > > given such a segment, causing it to crash. > > > > This patch fixes the problem by gating whether the extra_info is sent > > not only on the presence of a s/w hash, but also on whether the hash > > algorithm has been configured. > > > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> > > Cc: Wei Liu <wei.l...@citrix.com> > > This doesn't apply cleanly to the current 'net' tree, please respin. >
Sure. V2 coming. Paul > Thanks.
