Re: [PATCH net-next 13/13] ARM: net: bpf: use double-word load/stores where available

2018-07-10 Thread Olof Johansson
Hi Russell, On Tue, Jul 10, 2018 at 5:37 AM, Russell King wrote: > Use double-word load and stores where support for this instruction is > supported by the CPU architecture. > > Signed-off-by: Russell King > --- > arch/arm/net/bpf_jit_32.c | 55 > ---

[PATCH] MAINTAINERS: Remove myself from PA Semi entries

2016-09-13 Thread Olof Johansson
The platform is old, very few users and I lack bandwidth to keep after it these days. Mark the base platform as well as the drivers as orphans, patches have been flowing through the fallback maintainers for a while already. Signed-off-by: Olof Johansson --- Jean, Dave, I was hoping to have

Re: [PATCH v5 09/11] dtb: xgene: Add MDIO node

2016-08-01 Thread Olof Johansson
Hi, I came across this now when looking at merge conflicts when preparing this. I wish I had seen it sooner. On Thu, Jul 7, 2016 at 4:02 PM, Iyappan Subramanian wrote: > Added mdio node for mdio driver. Also added phy-handle > reference to the ethernet nodes. > > Removed unused mdio subnode wit

Re: [PATCH net 2/2] DT: phy.txt: Clarify expected compatible values

2016-01-27 Thread Olof Johansson
On Wed, Jan 27, 2016 at 9:11 AM, Andrew Lunn wrote: > On Wed, Jan 27, 2016 at 08:41:56AM -0800, Olof Johansson wrote: >> On Tue, Jan 26, 2016 at 4:11 PM, Andrew Lunn wrote: >> > PHY devices may only list clause 22, 45, and their PHY identifier >> > values as

Re: [PATCH net 2/2] DT: phy.txt: Clarify expected compatible values

2016-01-27 Thread Olof Johansson
On Tue, Jan 26, 2016 at 4:11 PM, Andrew Lunn wrote: > PHY devices may only list clause 22, 45, and their PHY identifier > values as compatible values. No other compatible strings are allowed. > Make this clear in the documentation, and remove examples where > make/model compatible strings are list

Re: [BISECTED] v4.5-rc1 phylib regression

2016-01-26 Thread Olof Johansson
On Tue, Jan 26, 2016 at 1:36 PM, Andrew Lunn wrote: > On Tue, Jan 26, 2016 at 12:46:31PM -0800, Florian Fainelli wrote: >> On 26/01/16 10:14, Olof Johansson wrote: >> > +devicet...@vger.kernel.org instead. >> > >> > On Tue, Jan 26, 2016 at 10:08 AM, Olof Jo

Re: [BISECTED] v4.5-rc1 phylib regression

2016-01-26 Thread Olof Johansson
+devicet...@vger.kernel.org instead. On Tue, Jan 26, 2016 at 10:08 AM, Olof Johansson wrote: > On Tue, Jan 26, 2016 at 9:53 AM, Andrew Lunn wrote: >>> I hate to bikeshed, but I'm not sure if "generic-mdio" is too... >>> generic? Will someone writing a DT be t

Re: [BISECTED] v4.5-rc1 phylib regression

2016-01-26 Thread Olof Johansson
On Tue, Jan 26, 2016 at 9:53 AM, Andrew Lunn wrote: >> I hate to bikeshed, but I'm not sure if "generic-mdio" is too... >> generic? Will someone writing a DT be thinking "well, this is a >> generic mdio PHY, I should set it"? "mdio-device"? >> "generic-nonphy-mdio"? Neither of those seem much bet

Re: [BISECTED] v4.5-rc1 phylib regression

2016-01-26 Thread Olof Johansson
On Tue, Jan 26, 2016 at 5:34 AM, Andrew Lunn wrote: > On Tue, Jan 26, 2016 at 02:14:35PM +0200, Aaro Koskinen wrote: >> Hi, >> >> On Tue, Jan 26, 2016 at 05:46:24AM +0100, Andrew Lunn wrote: >> > On Mon, Jan 25, 2016 at 05:45:21PM +0200, Aaro Koskinen wrote: >> > > I get the below crash on OCTEON

Re: [patch 0/6] pasemi_mac updates for 2.6.26

2008-02-26 Thread Olof Johansson
On Tue, Feb 26, 2008 at 01:21:00PM -0500, Jeff Garzik wrote: > Olof Johansson wrote: > > On Tue, Feb 26, 2008 at 08:49:58PM +1100, Paul Mackerras wrote: > >> What route do you think these should take upstream? I'm happy to take > >> them if Jeff is OK with that.

Re: [patch 0/6] pasemi_mac updates for 2.6.26

2008-02-26 Thread Olof Johansson
On Tue, Feb 26, 2008 at 08:49:58PM +1100, Paul Mackerras wrote: > Olof Johansson writes: > > > Here's a set of updates for pasemi_mac for 2.6.26. Some of them touch > > the dma_lib in the platform code as well, but it's easier if it's all > > merg

Re: [patch 1/6] pasemi_mac: Move RX/TX section enablement to dma_lib

2008-02-26 Thread Olof Johansson
Hi, On Tue, Feb 26, 2008 at 10:46:06PM +1100, Michael Ellerman wrote: > On Wed, 2008-02-20 at 20:57 -0600, Olof Johansson wrote: > > + i = 1000; > > + pasemi_write_dma_reg(PAS_DMA_COM_RXCMD, 0); > > + while ((i > 0) && (pasemi_read_dma_reg(PAS_DMA_CO

[patch 5/6] pasemi_mac: Enable GSO by default

2008-02-20 Thread Olof Johansson
Ethtool support will handle the runtime toggling, but we do quite a bit better with it on by default so just leave it on for now. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: k.org/drivers/net/pasemi

[patch 4/6] pasemi_mac: jumbo frame support

2008-02-20 Thread Olof Johansson
el is not quite enough to feed one of the 10Gig links, so allocate two channels for XAUI interfaces. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: 2.6.25/drivers/net/pasemi_mac.c === --- 2.6.25.orig/drivers/net/p

[patch 6/6] pasemi_mac: basic ethtool support

2008-02-20 Thread Olof Johansson
First cut at ethtool support, to be completed over time. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: 2.6.25/drivers/net/Makefile === --- 2.6.25.orig/drivers/net/Makefile +++ 2.6.25/drivers/net/Makefile @@ -218,7

[patch 0/6] pasemi_mac updates for 2.6.26

2008-02-20 Thread Olof Johansson
Here's a set of updates for pasemi_mac for 2.6.26. Some of them touch the dma_lib in the platform code as well, but it's easier if it's all merged through netdev to avoid dependencies. Major highlights are jumbo frame support and ethtool basics, the rest is mostly minor plumbing around it. -- -

[patch 2/6] [POWERPC] pasemi: Add flag management functions to dma_lib

2008-02-20 Thread Olof Johansson
Add functions to manage the channel syncronization flags to dma_lib Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: k.org/arch/powerpc/platforms/pasemi/dma_lib.c === --- k.org.orig/arch/powerpc/platforms/

[patch 1/6] pasemi_mac: Move RX/TX section enablement to dma_lib

2008-02-20 Thread Olof Johansson
Also stop both rx and tx sections before changing the configuration of the dma device during init. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: k.org/arch/powerpc/platforms/pasemi/dma_lib.c === --- k.org.ori

[patch 3/6] [POWERPC] pasemi: Add function engine management functions to dma_lib

2008-02-20 Thread Olof Johansson
Used to allocate functions for crypto/checksum offload. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: k.org/arch/powerpc/platforms/pasemi/dma_lib.c === --- k.org.orig/arch/powerpc/platforms/pasemi/dma_lib.c +++

Dealing with limited resources and DMA Engine copies

2008-02-13 Thread Olof Johansson
Hi, My DMA Engine has a limited resource: It's got a descriptor ring, so it's not always possible to add a new descriptor to it (i.e. it might be full). While allocating a huge ring will help, eventually I'm sure I will hit a case where it'll overflow. I thought this was going to be taken care of

Re: [PATCH] net: NEWEMAC: Remove "rgmii-interface" from rgmii matching table

2008-02-06 Thread Olof Johansson
On Wed, Feb 06, 2008 at 10:23:40AM -0600, Josh Boyer wrote: > On Wed, 6 Feb 2008 10:01:57 -0600 > Olof Johansson <[EMAIL PROTECTED]> wrote: > > > On Wed, Feb 06, 2008 at 01:21:59PM +0100, Stefan Roese wrote: > > > With the removal the the "rgmii-interface"

Re: [PATCH] net: NEWEMAC: Remove "rgmii-interface" from rgmii matching table

2008-02-06 Thread Olof Johansson
On Wed, Feb 06, 2008 at 01:21:59PM +0100, Stefan Roese wrote: > With the removal the the "rgmii-interface" device_type property from the > dts files, the newemac driver needs an update to only rely on compatible > property. What about systems using an older dts, such as one kexec:ing from an older

[PATCH 1/3] pasemi_mac: Add support for changing mac address

2008-01-23 Thread Olof Johansson
Straightforward. It used to be hardcoded and impossible to override with ifconfig. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> diff --git a/drivers/net/pasemi_mac.c b/drivers/net/pasemi_mac.c index bb88a41..59dea3f 100644 --- a/drivers/net/pasemi_mac.c +++ b/drivers/net/pasemi

[PATCH 2/3] pasemi_mac: add support for setting MTU

2008-01-23 Thread Olof Johansson
Currently keeping it at 1500 bytes or below since jumbo frames need special checksum offload on TX. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> diff --git a/drivers/net/pasemi_mac.c b/drivers/net/pasemi_mac.c index 59dea3f..059c6b0 100644 --- a/drivers/net/pasemi_mac.c +++ b/drive

[PATCH 0/3] A few more pasemi_mac patches for 2.6.25

2008-01-23 Thread Olof Johansson
Hi, This should be the last of my updates for 2.6.25: 1/3: pasemi_mac: Add support for changing mac address 2/3: pasemi_mac: add support for setting MTU 3/3: pasemi_mac: Disable interface on close Thanks, Olof -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of

[PATCH 3/3] pasemi_mac: Disable interface on close

2008-01-23 Thread Olof Johansson
Turns out we never disable the interface. It doesn't really cause any problems since the channel is off, but it's still better to do it this way. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> diff --git a/drivers/net/pasemi_mac.c b/drivers/net/pasemi_mac.c index 059c6b0

[PATCH 2.6.24] pasemi_mac: Fix reuse of free'd skb

2007-12-03 Thread Olof Johansson
ty crashes of various kind, as reported by Brent Baude and David Woodhouse. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> --- Jeff, I'd like to see this in 2.6.24, it's causing some real problems out there. It's not needed in the 2.6.25 queue since the other changes ther

Re: [PASEMI_MAC] Don't claim to do IPv6 checksum offload

2007-12-02 Thread Olof Johansson
On Mon, Dec 03, 2007 at 04:34:32AM +, David Woodhouse wrote: > Signed-off-by: David Woodhouse <[EMAIL PROTECTED]> Acked-by: Olof Johansson <[EMAIL PROTECTED]> Jeff, I'd like to see this in 2.6.24, please. Thanks, -Olof -- To unsubscribe from this list: send the line

Re: [PATCH 2/11] ibm_newemac: Add ET1011c PHY support

2007-11-30 Thread Olof Johansson
On Sat, Dec 01, 2007 at 07:59:16AM +1100, Benjamin Herrenschmidt wrote: > > On Fri, 2007-11-30 at 08:29 -0600, Olof Johansson wrote: > > Hi, > > > > On Fri, Nov 30, 2007 at 04:40:24PM +1100, Benjamin Herrenschmidt wrote: > > > > > This adds support for the

Re: [PATCH 2/11] ibm_newemac: Add ET1011c PHY support

2007-11-30 Thread Olof Johansson
Hi, On Fri, Nov 30, 2007 at 04:40:24PM +1100, Benjamin Herrenschmidt wrote: > This adds support for the Agere ET1011c PHY as found on the AMCC Taishan > board. The whole patch has whitespace messed up (tabs vs spaces). -Olof - To unsubscribe from this list: send the line "unsubscribe netdev" i

Re: [PATCH 1/11] ibm_newemac: Add BCM5248 and Marvell 88E1111 PHY support

2007-11-30 Thread Olof Johansson
Hi, On Fri, Nov 30, 2007 at 04:40:23PM +1100, Benjamin Herrenschmidt wrote: > +static int m88e_init(struct mii_phy *phy) > +{ > + printk("%s: Marvell 88E Ethernet\n", __FUNCTION__); KERN_ level? -Olof - To unsubscribe from this list: send the line "unsubscribe netdev" in the body

Re: [PATCH] [0/12] pasemi_mac updates for 2.6.25 + DMA channel management library

2007-11-28 Thread Olof Johansson
On Wed, Nov 28, 2007 at 08:54:10PM -0600, Olof Johansson wrote: > The patches are: [...] I got the order wrong above, the actual one is: 1/12 pasemi_mac: RX/TX ring management cleanup 2/12 pasemi_mac: Move register definitions to include/asm-powerpc 3/12 pasemi: DMA engine management librar

[PATCH] [12/12] pasemi_mac: Don't enable RX/TX without a link (if possible)

2007-11-28 Thread Olof Johansson
as they come in. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> --- drivers/net/pasemi_mac.c | 41 + 1 file changed, 33 insertions(+), 8 deletions(-) Index: k.org/drivers/net/pasemi_mac.c ==

[PATCH] [11/12] pasemi_mac: Print warning when not attaching to a PHY

2007-11-28 Thread Olof Johansson
-by: Olof Johansson <[EMAIL PROTECTED]> --- drivers/net/pasemi_mac.c |9 + 1 file changed, 5 insertions(+), 4 deletions(-) Index: k.org/drivers/net/pasemi_mac.c === --- k.org.orig/drivers/net/pasemi_mac.c +++

[PATCH] [10/12] pasemi_mac: Remove SKB copy/recycle logic

2007-11-28 Thread Olof Johansson
pasemi_mac: Remove SKB copy/recycle logic It doesn't really buy us much, since copying is about as expensive as the allocation in the first place. Just remove it for now. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> --- drivers/net/pasemi_mac.c | 25 +++---

[PATCH] [9/12] pasemi_mac: SKB unmap optimization

2007-11-28 Thread Olof Johansson
pasemi_mac: SKB unmap optimization Avoid touching skb_shinfo() in the unmap path, since it turns out to normally cause cache misses and delays. instead, save number of fragments in the TX_RING_INFO structures since that's all that's needed anyway. Signed-off-by: Olof Johansson <[EM

[PATCH] [7/12] pasemi_mac: Improve RX interrupt mitigation

2007-11-28 Thread Olof Johansson
al nice to have ethtool support for users to tune this at runtime. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> --- drivers/net/pasemi_mac.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) Index: k.org/dri

[PATCH] [8/12] pasemi_mac: Software-based LRO support

2007-11-28 Thread Olof Johansson
pasemi_mac: Software-based LRO support Implement LRO for pasemi_mac. Pretty straightforward. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> --- drivers/net/Kconfig |1 drivers/net/pasemi_mac.c | 53 +++ drivers/net/pasemi_mac.h

[PATCH] [6/12] pasemi_mac: Fix TX cleaning

2007-11-28 Thread Olof Johansson
r the last 1..31 ones in case we don't trigger a TX interrupt (and there's no RX activity that would otherwise trigger the poll). The longer-term fix is to separate TX from RX NAPI and do two separate poll loops. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> --- drivers/ne

[PATCH] [5/12] pasemi_mac: performance tweaks

2007-11-28 Thread Olof Johansson
NETIF_F_HIGHDMA * Misc other minor tweaks Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> --- drivers/net/pasemi_mac.c | 114 --- 1 file changed, 68 insertions(+), 46 deletions(-) Index: k.org/drivers/net/pasemi

[PATCH] [4/12] pasemi_mac: Convert to new dma library

2007-11-28 Thread Olof Johansson
pasemi_mac: Convert to new dma library Convert the pasemi_mac driver to the new platform global DMA manaagement library. This also does a couple of other minor cleanups w.r.t. channel management. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> --- drivers/net/pasemi_mac.c

[PATCH] [3/12] pasemi: DMA engine management library

2007-11-28 Thread Olof Johansson
pasemi: DMA engine management library Introduce a DMA management library to manage the various DMA resources on the PA Semi SoCs. Since several drivers need to allocate these shared resources, provide some abstractions as well as allocation/free functions for channels, etc. Signed-off-by: Olof

[PATCH] [2/12] pasemi_mac: Move register definitions to include/asm-powerpc

2007-11-28 Thread Olof Johansson
it makes sense to share the constants. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> --- drivers/net/pasemi_mac.c |1 drivers/net/pasemi_mac.h | 336 - include/asm-powerpc/pasemi_dma.h | 391

[PATCH] [1/12] pasemi_mac: RX/TX ring management cleanup

2007-11-28 Thread Olof Johansson
pasemi_mac: RX/TX ring management cleanup Prepare a bit for supporting multiple TX queues by cleaning up some of the ring management and shuffle things around a bit. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> --- drivers/net/pasemi_mac.c

[PATCH] [0/12] pasemi_mac updates for 2.6.25 + DMA channel management library

2007-11-28 Thread Olof Johansson
Hi, The following series contains driver updates for 2.6.25, together with a couple of patches that introduces a library for abstracting DMA channel allocation and access. While the DMA stuff (patches 5 and 6) isn't really netdev material, the driver updates depend on them, and it'd just be easie

Re: [PATCH] Fix warning for token-ring from sysctl checker

2007-11-14 Thread Olof Johansson
On Wed, Nov 14, 2007 at 08:45:28AM -0800, Randy Dunlap wrote: > On Wed, 14 Nov 2007 08:56:20 -0700 Eric W. Biederman wrote: > > > David Miller <[EMAIL PROTECTED]> writes: > > > > > From: Olof Johansson <[EMAIL PROTECTED]> > > > Date: Tue, 13 N

[PATCH] Fix warning for token-ring from sysctl checker

2007-11-12 Thread Olof Johansson
As seen when booting ppc64_defconfig: sysctl table check failed: /net/token-ring .3.14 procname does not match binary path procname Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> diff --git a/kernel/sysctl_check.c b/kernel/sysctl_check.c index 5a2f2b2..4abc6d2 100644 --- a/

[PATCH 1/2] pasemi_mac: Don't set replace-source-address descriptor bits

2007-11-06 Thread Olof Johansson
Don't use the "replace source address with local MAC address" bits, since it causes problems on some variations of the hardware due to an erratum. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: k.org/dri

[PATCH 2/2] pasemi_mac: Fix CRC checks

2007-11-06 Thread Olof Johansson
Make sure we don't feed packets with bad CRC up the network stack, and discount the packet length as reported from the MAC for the CRC field. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: k.org/drivers/net/p

[PATCH 0/2] pasemi_mac: two bugfixes for 2.6.24

2007-11-06 Thread Olof Johansson
Hi Jeff, Two bugfixes for pasemi_mac for 2.6.24: [PATCH 1/2] pasemi_mac: Don't set replace-source-address descriptor bits [PATCH 2/2] pasemi_mac: Fix CRC checks Thanks, -Olof - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More

[PATCH] phylib: Silence driver registration

2007-11-04 Thread Olof Johansson
It gets quite verbose to see every single PHY driver being registered by default. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index c046121..f6e4848 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/n

[PATCH] phylib: Add ID for Marvell 88E1240

2007-11-04 Thread Olof Johansson
Add PHY IDs for Marvell 88E1240. It seems to have close enough programming models to /1112 for basic support at least. Also clean up whitespace in the ID list a bit. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c

Re: [PATCH] net: Add 405EX support to new EMAC driver

2007-11-04 Thread Olof Johansson
On Sun, Nov 04, 2007 at 02:37:59PM +1100, Benjamin Herrenschmidt wrote: > > On Fri, 2007-11-02 at 11:03 -0500, Olof Johansson wrote: > > On Fri, Nov 02, 2007 at 08:14:43AM +0100, Stefan Roese wrote: > > > This patch adds support for the 405EX to the new EMAC driver. Some

Re: [PATCH] net: Add 405EX support to new EMAC driver

2007-11-02 Thread Olof Johansson
On Fri, Nov 02, 2007 at 08:14:43AM +0100, Stefan Roese wrote: > This patch adds support for the 405EX to the new EMAC driver. Some as on > AXON, the 405EX handles the MDIO via the RGMII bridge. Hi, This isn't feedback on your patch as much as on "new-emac" in general: Isn't this the case where t

[PATCH v2] niu: Cleanup PAGE_SIZE checks a bit

2007-10-20 Thread Olof Johansson
that could ever be untrue? Or are there really archs with non-power-of-two PAGE_SIZE? Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> -- Ack! It should obviously use min(), not max()! -Olof diff --git a/drivers/net/niu.c b/drivers/net/niu.c index ed1f9bb..795cc68 100644 --- a/driv

[PATCH] pasemi_mac: fix typo

2007-10-20 Thread Olof Johansson
Add missing &: drivers/net/pasemi_mac.c: In function 'pasemi_mac_clean_rx': drivers/net/pasemi_mac.c:553: warning: passing argument 1 of 'prefetch' makes pointer from integer without a cast Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> diff --git a/drivers/

[PATCH] niu: Cleanup PAGE_SIZE checks a bit

2007-10-20 Thread Olof Johansson
that could ever be untrue? Or are there really archs with non-power-of-two PAGE_SIZE? Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> diff --git a/drivers/net/niu.c b/drivers/net/niu.c index ed1f9bb..795cc68 100644 --- a/drivers/net/niu.c +++ b/drivers/net/niu.c @@ -3103,31 +3103,12 @@ st

[PATCH] Fix build break in tsi108.c

2007-10-19 Thread Olof Johansson
Fix build break: drivers/net/tsi108_eth.c: In function 'tsi108_init_one': drivers/net/tsi108_eth.c:1633: error: expected ')' before 'dev' drivers/net/tsi108_eth.c:1633: warning: too few arguments for format make[2]: *** [drivers/net/tsi108_eth.o] Error 1 Signed-

Re: [PATCH 0/4] Fix race between sk_filter reassign and sk_clone()

2007-10-18 Thread Olof Johansson
valid case? sk_detach_filter() seems to handle a NULL sk_filter, at least. So, this needs review by someone who knows the filter, but it fixes the problem for me: Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> diff --git a/net/core/filter.c b/net/core/filter.c index 1f0068e..e0a0694

[PATCH RESEND] [11/11] pasemi_mac: enable iommu support

2007-10-03 Thread Olof Johansson
pasemi_mac: enable iommu support Enable IOMMU support for pasemi_mac, but avoid using it on non-partitioned systems for performance reasons. The user can override this by selecting the PPC_PASEMI_IOMMU_DMA_FORCE configuration option. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> -

Re: [PATCH] [9/11] pasemi_mac: clear out old errors on interface open

2007-10-03 Thread Olof Johansson
On Wed, Oct 03, 2007 at 01:46:16PM -0400, Jeff Garzik wrote: > Olof Johansson wrote: >> pasemi_mac: clear out old errors on interface open >> Clear out any pending errors when an interface is brought up. Since the >> bits >> are sticky, they might be from interface s

[PATCH] [10/11] pasemi_mac: use buffer index pointer in clean_rx()

2007-10-02 Thread Olof Johansson
longer supported, and needs a pile of other workarounds that are not being submitted for mainline inclusion. So the fact that this breaks old hardware is not a problem at this time. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: k.org/drivers/net/pasemi

[PATCH] [11/11] pasemi_mac: enable iommu support

2007-10-02 Thread Olof Johansson
longer supported, and needs a pile of other workarounds that are not being submitted for mainline inclusion. So the fact that this breaks old hardware is not a problem at this time. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: k.org/drivers/net/pasemi

[PATCH] [8/11] pasemi_mac: update todo list

2007-10-02 Thread Olof Johansson
pasemi_mac: update todo list Remove some stale todo items that have been taken care of. Add a couple of upcoming ones. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: 2.6.23/drivers/net/pasemi_mac.c === --- 2.6.2

[PATCH] [9/11] pasemi_mac: clear out old errors on interface open

2007-10-02 Thread Olof Johansson
pasemi_mac: clear out old errors on interface open Clear out any pending errors when an interface is brought up. Since the bits are sticky, they might be from interface shutdown time after firmware has used it, etc. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: k.org/drive

[PATCH] [6/11] pasemi_mac: add local skb alignment

2007-10-02 Thread Olof Johansson
aligned instead. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: k.org/drivers/net/pasemi_mac.c === --- k.org.orig/drivers/net/pasemi_mac.c +++ k.org/drivers/net/pasemi_mac.c @@ -37,6 +37,12 @@ #include "pasemi_mac.

[PATCH] [7/11] pasemi_mac: further performance tweaks

2007-10-02 Thread Olof Johansson
ix up some of the tx ring wrap logic. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: k.org/drivers/net/pasemi_mac.c === --- k.org.orig/drivers/net/pasemi_mac.c +++ k.org/drivers/net/pasemi_mac.c @@ -56,8 +56,8 @@ /

[PATCH] [4/11] pasemi_mac: implement sg support

2007-10-02 Thread Olof Johansson
pasemi_mac: implement sg support Implement SG support for pasemi_mac Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: k.org/drivers/net/pasemi_mac.c === --- k.org.orig/drivers/net/pasemi_mac.c +++ k.org/drive

[PATCH] [5/11] pasemi_mac: workaround for erratum 5971

2007-10-02 Thread Olof Johansson
out of credits. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: k.org/drivers/net/pasemi_mac.c === --- k.org.orig/drivers/net/pasemi_mac.c +++ k.org/drivers/net/pasemi_mac.c @@ -239,7 +239,9 @@ static int pasemi_m

[PATCH] [3/11] pasemi_mac: rework ring management

2007-10-02 Thread Olof Johansson
pasemi_mac: rework ring management Rework ring management, switching to an opaque ring format instead of the struct-based descriptor+pointer setup, since it will be needed for SG support. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: k.org/drivers/net/pasemi

[PATCH] [2/11] pasemi_mac: fix bug in receive buffer dma mapping

2007-10-02 Thread Olof Johansson
still needs fixing for the future) Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: k.org/drivers/net/pasemi_mac.c === --- k.org.orig/drivers/net/pasemi_mac.c +++ k.org/drivers/net/pasemi_mac.c @@ -396

[PATCH] [1/11] pasemi_mac: basic error checking

2007-10-02 Thread Olof Johansson
pasemi_mac: basic error checking Add some rudimentary error checking to pasemi_mac. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: k.org/drivers/net/pasemi_mac.c === --- k.org.orig/drivers/net/pasemi_mac.c +++

[PATCH] [0/11] pasemi_mac: Patches for 2.6.24

2007-10-02 Thread Olof Johansson
Hi, This series of patches go on top of the previous fixes that were sent out and picked up. It's a series of mostly feature-related changes, but also a couple of bugfixes: [1/11] pasemi_mac: basic error checking [2/11] pasemi_mac: fix bug in receive buffer dma mapping [3/11] pasemi_mac: rework

[PATCH] [6/6] pasemi_mac: pass in count of buffers to replenish rx ring with

2007-09-26 Thread Olof Johansson
#x27;re filling for the first time or not. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: k.org/drivers/net/pasemi_mac.c === --- k.org.orig/drivers/net/pasemi_mac.c +++ k.org/drivers/net/pasemi_mac.c @@ -375,23 +

[PATCH] [5/6] pasemi_mac: don't enable rx before there are buffers on the ring

2007-09-26 Thread Olof Johansson
ce is enabled, to avoid temporary out-of-buffer errors for the very first packets (on busy networks). Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: 2.6.23/drivers/net/pasemi_mac.c === --- 2.6.23.orig/drivers/net/p

[PATCH] [5/6] pasemi_mac: flags as passed to spin_*_irqsave() should be unsigned long

2007-09-26 Thread Olof Johansson
pasemi_mac: flags as passed to spin_*_irqsave() should be unsigned long. Signed-off-by: Tony Breeds <[EMAIL PROTECTED]> Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> --- Found trying to build a -rt kernel, which has a BUILD_BUG_ON(), in this caswe. drivers/net/pasemi_mac.c |

[PATCH] [3/6] pasemi_mac: set interface speed correctly on XAUI ports

2007-09-26 Thread Olof Johansson
pasemi_mac: set interface speed correctly on XAUI ports Set interface speed for XAUI to 10G per default, not 1G. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: 2.6.23/drivers/net/pasemi_mac.c === --- 2.6.23.orig/d

[PATCH] [2/6] pasemi_mac: fix build break in pasemi_mac_clean_rx()

2007-09-26 Thread Olof Johansson
pasemi_mac: fix build break in pasemi_mac_clean_rx() Fix breakage caused by the unification of stats structs. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: k.org/drivers/net/pasemi_mac.c === --- k.org.orig/drive

[PATCH] [0/6] Bugfixes for pasemi_mac

2007-09-26 Thread Olof Johansson
Hi, Following patches are for various bug fixes against current netdev-2.6.24 upstream branch. Please apply. [PATCH] [1/6] pasemi_mac: fix build break in pasemi_mac_probe() [PATCH] [2/6] pasemi_mac: fix build break in pasemi_mac_clean_rx() [PATCH] [3/6] pasemi_mac: set interface speed correctly

[PATCH] [1/6] pasemi_mac: fix build break in pasemi_mac_probe()

2007-09-26 Thread Olof Johansson
pasemi_mac: fix build break in pasemi_mac_probe() Fix breakage caused by recent unification of print_mac() stuff. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: k.org/drivers/net/pasemi_mac.c === --- k.org.orig/d

Re: [PATCH v2] [02/10] pasemi_mac: Stop using the pci config space accessors for register read/writes

2007-08-24 Thread Olof Johansson
On Fri, Aug 24, 2007 at 02:05:31PM +1000, Stephen Rothwell wrote: > On Thu, 23 Aug 2007 13:13:10 -0500 Olof Johansson <[EMAIL PROTECTED]> wrote: > > > > out: > > - pci_dev_put(mac->iob_pdev); > > -out_put_dma_pdev: > > - pci_dev_put(mac->dma

[PATCH v2] [02/10] pasemi_mac: Stop using the pci config space accessors for register read/writes

2007-08-23 Thread Olof Johansson
get it and ioremap it there (in case it ever moves in future products). For now, provide a hardcoded fallback for older firmwares. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> --- Updated: Removed explicit inlines, cleaned up read functions, fixed grammar. Index: mainline/drive

Re: [PATCH] [02/10] pasemi_mac: Stop using the pci config space accessors for register read/writes

2007-08-23 Thread Olof Johansson
On Thu, Aug 23, 2007 at 10:31:03AM +1000, Stephen Rothwell wrote: > On Wed, 22 Aug 2007 09:12:48 -0500 Olof Johansson <[EMAIL PROTECTED]> wrote: > > > > -static unsigned int read_iob_reg(struct pasemi_mac *mac, unsigned int reg) > > +static inline unsigned int read_iob

[PATCH] [07/10] pasemi_mac: Enable LLTX

2007-08-22 Thread Olof Johansson
Enable LLTX on pasemi_mac: we're already doing sufficient locking in the driver to enable it. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: mainline/drivers/net/pasemi_mac.c === --- mainline.orig/drivers/net/p

[PATCH] [04/10] pasemi_mac: Fix memcpy amount for short receives

2007-08-22 Thread Olof Johansson
Fix up memcpy for short receives. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: mainline/drivers/net/pasemi_mac.c === --- mainline.orig/drivers/net/pasemi_mac.c +++ mainline/drivers/net/pasemi_mac.c @@ -516,9

[PATCH] [02/10] pasemi_mac: Stop using the pci config space accessors for register read/writes

2007-08-22 Thread Olof Johansson
get it and ioremap it there (in case it ever moves in future products). For now, provide a hardcoded fallback for older firmwares. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: mainline/drivers/net/pasemi

[PATCH] [06/10] pasemi_mac: Batch up TX buffer frees

2007-08-22 Thread Olof Johansson
Postpone pci unmap and skb free of the transmitted buffers to outside of the tx ring lock, batching them up 32 at a time. Also increase the count threshold to 128. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: mainline/drivers/net/pasemi

[PATCH] [08/10] pasemi_mac: Fix TX ring wrap checking

2007-08-22 Thread Olof Johansson
The old logic didn't detect full (tx) ring cases properly, causing overruns and general badness. Clean it up a bit and abstract out the ring size checks, always making sure to leave 1 slot open. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: mainline/drivers/net/p

[PATCH] [05/10] pasemi_mac: RX performance tweaks

2007-08-22 Thread Olof Johansson
Various RX performance tweaks, do some explicit prefetching of packet data, etc. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: mainline/drivers/net/pasemi_mac.c === --- mainline.orig/drivers/net/pasemi_mac.c +++ ma

[PATCH] [10/10] pasemi_mac: Clean TX ring in poll

2007-08-22 Thread Olof Johansson
ere hasn't been an interrupt. Instead of setting up a dedicated timer for this, just clean it in the NAPI poll routine instead. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> --- I know I got this rejected last time it was submitted, but no answers with suggestions on how to handle it

[PATCH] [09/10] pasemi_mac: Fix RX checksum flags

2007-08-22 Thread Olof Johansson
RX side flag to use is CHECKSUM_UNNECESSARY, not CHECKSUM_COMPLETE. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: mainline/drivers/net/pasemi_mac.c === --- mainline.orig/drivers/net/pasemi_mac.c +++ mainline/drive

[PATCH] [01/10] pasemi_mac: Abstract out register access

2007-08-22 Thread Olof Johansson
Abstract out the PCI config read/write accesses into reg read/write ones, still calling the pci accessors on the back end. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: mainline/drivers/net/pasemi

[PATCH] [03/10] pasemi_mac: Enable L2 caching of packet headers

2007-08-22 Thread Olof Johansson
Enable settings to target l2 for the first few cachelines of the packet, since we'll access them to get to the various headers. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: mainline/drivers/net/p

[PATCH] [00/10] pasemi_mac patches for 2.6.24

2007-08-22 Thread Olof Johansson
Hi, pasemi_mac patches for 2.6.24: 01/10: pasemi_mac: Abstract out register access 02/10: pasemi_mac: Stop using the pci config space accessors for register read/writes 03/10: pasemi_mac: Enable L2 caching of packet headers 04/10: pasemi_mac: Fix memcpy amount for short receives 05/10: pasemi_ma

[PATCH] [2/2] phylib: Add Marvell 88E1112 phy id

2007-07-03 Thread Olof Johansson
Add 88E1112 PHY ID to the marvell driver. Seems to do fine with the 88E inits. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: mainline/drivers/net/phy/marvell.c === --- mainline.orig/drivers/net/phy/mar

[PATCH] [1/2] phylib: cleanup marvell.c a bit

2007-07-03 Thread Olof Johansson
Simplify the marvell driver init a bit: Make the supported devices an array instead of explicitly registering each structure. This makes it considerably easier to add new devices down the road. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: mainline/drivers/net/phy/mar

Re: [PATCH 2/9] pasemi_mac: Clean TX ring in poll

2007-07-03 Thread Olof Johansson
On Mon, Jul 02, 2007 at 08:34:22AM -0400, Jeff Garzik wrote: > >Index: netdev-2.6/drivers/net/pasemi_mac.c > >=== > >--- netdev-2.6.orig/drivers/net/pasemi_mac.c > >+++ netdev-2.6/drivers/net/pasemi_mac.c > >@@ -1052,6 +1052,7 @@ stati

[PATCH 1/9] pasemi_mac: Fix TX interrupt threshold

2007-06-22 Thread Olof Johansson
It was mistakenly set to interrupt on the second packet instead of first, causing some interesting latency behaviour. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: netdev-2.6/drivers/net/pasemi_mac.c === --- netd

[PATCH 2/9] pasemi_mac: Clean TX ring in poll

2007-06-22 Thread Olof Johansson
Clean the TX ring in the poll call, to avoid sitting on mapped buffers for a long time. NFS doesn't seem to like it much, for example. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: netdev-2.6/drivers/net/p

[PATCH 0/9] pasemi_mac patches for 2.6.23

2007-06-22 Thread Olof Johansson
Hi, pasemi_mac patches: minor tweaks, bugfixes and perf enhancements. Please consider for the 2.6.23 merge window. Thanks, -Olof - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majo

  1   2   >