On Sun, Nov 04, 2007 at 02:37:59PM +1100, Benjamin Herrenschmidt wrote: > > On Fri, 2007-11-02 at 11:03 -0500, Olof Johansson wrote: > > On Fri, Nov 02, 2007 at 08:14:43AM +0100, Stefan Roese wrote: > > > This patch adds support for the 405EX to the new EMAC driver. Some as on > > > AXON, the 405EX handles the MDIO via the RGMII bridge. > > > > Hi, > > > > This isn't feedback on your patch as much as on "new-emac" in general: > > > > Isn't this the case where there should really be device tree properties > > instead? If you had an "ibm,emac-has-axon-stacr" property in the device > > node, then you don't have to modify the driver for every new board out > > there. Same for the other device properties, of course. > > > > I thought this was what having the device tree was all about. :( > > Somewhat yeah. There are subtle variations here or there we haven't > totally indenfified... It might be a better option in our case here to > add "has-mdio" to the rgmii nodes indeed. > > Part of the problem with those cells is that the chip folks keep > changing things subtly from one rev to another though, it's not even > totally clear to me yet whether the RGMII registers are totally > compatible betwee axon and 405ex, which is why I've pretty much stuck to > "compatible" properties to identify the variants. > > The device-tree can do both. It's still better than no device-tree since > at least you know what cell variant is in there.
Well, it's better than compile-time ifdefs. Providing what version of the device you have CAN be done without a device tree too. :-) > As for the STACR, Axon isn't the first one to have that bit flipped, I > think we should name the property differently, something like > "stacr-oc-inverted". Sure, it was the habit of having to modify the driver for platforms that don't add any new features I was against. I don't really care what the properties are called :-) > We can still use properties that way for new things in fact. As for EMAC > on cell, well, I can always put some fixup somewhere. Sounds good (with s/can still/should/). -Olof - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
