Hi Krzysztof,
On Thu, Mar 11, 2021 at 04:27:35PM +0100, Krzysztof Kozlowski wrote:
> ARCH_SOCFPGA is being renamed to ARCH_INTEL_SOCFPGA so adjust the
> 32-bit ARM drivers to rely on new symbol.
>
> Signed-off-by: Krzysztof Kozlowski
Acked-by: Moritz Fischer
> ---
> driver
] Request device [5e:00.0]fault addr f000
DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr f000
DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr f000
DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr f000
Signed-off-by: Moritz Fischer
---
Changes from v3:
- Added
Hi Jakub,
On Tue, Oct 27, 2020 at 04:16:06PM -0700, Jakub Kicinski wrote:
> On Fri, 23 Oct 2020 13:28:34 -0700 Moritz Fischer wrote:
> > diff --git a/drivers/net/ethernet/dec/tulip/de2104x.c
> > b/drivers/net/ethernet/dec/tulip/de2104x.c
> > index d9f6c19940ef..ea7442cc
] Request device [5e:00.0]fault addr f000
DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr f000
DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr f000
DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr f000
Signed-off-by: Moritz Fischer
---
I'd consider it a bu
] Request device [5e:00.0]fault addr f000
DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr f000
DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr f000
DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr f000
Signed-off-by: Moritz Fischer
---
Changes from v1:
- Replace
On Thu, Oct 22, 2020 at 04:04:16PM -0700, James Bottomley wrote:
> On Thu, 2020-10-22 at 15:06 -0700, Moritz Fischer wrote:
> > The driver does not implement a shutdown handler which leads to
> > issues
> > when using kexec in certain scenarios. The NIC keeps on fetching
>
] Request device [5e:00.0]fault addr f000
DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr f000
DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr f000
DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr f000
Signed-off-by: Moritz Fischer
---
Hi all,
I'm not su
Replace an instance of kmemdup() with the devres counted version
instead.
Signed-off-by: Moritz Fischer
---
drivers/net/ethernet/dec/tulip/de2104x.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/dec/tulip/de2104x.c
b/drivers/net/ethernet/dec
Replace pci_enable_device() with its devres counterpart
pcim_enable_device().
Signed-off-by: Moritz Fischer
---
Note: Please check my logic on this, it would seem to me
calling pci_disable_device() on devices enabled with
pcim_enable_device() *should* be fine.
Changes from v1:
- Fixed missing
from v1:
- Fix issue with the pci_enable_device patch.
Moritz Fischer (3):
net: dec: tulip: de2104x: Replace alloc_etherdev by
devm_alloc_etherdev
net: dec: tulip: de2104x: Replace pci_enable_device with devres
version
net: dec: tulip: de2104x: Replace kmemdup() with devm_kmempdup
Replace devm_alloc_etherdev() with its devres version.
Signed-off-by: Moritz Fischer
---
drivers/net/ethernet/dec/tulip/de2104x.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/dec/tulip/de2104x.c
b/drivers/net/ethernet/dec/tulip/de2104x.c
index
On Sun, Sep 13, 2020 at 05:10:01PM -0700, Moritz Fischer wrote:
> Replace pci_enable_device() with its devres counterpart
> pcim_enable_device().
>
> Signed-off-by: Moritz Fischer
> ---
> drivers/net/ethernet/dec/tulip/de2104x.c | 7 ++-
> 1 file changed, 2 inser
Replace devm_alloc_etherdev() with its devres version.
Signed-off-by: Moritz Fischer
---
drivers/net/ethernet/dec/tulip/de2104x.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/dec/tulip/de2104x.c
b/drivers/net/ethernet/dec/tulip/de2104x.c
index
Replace an instance of kmemdup() with the devres counted version
instead.
Signed-off-by: Moritz Fischer
---
drivers/net/ethernet/dec/tulip/de2104x.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/dec/tulip/de2104x.c
b/drivers/net/ethernet/dec
Replace pci_enable_device() with its devres counterpart
pcim_enable_device().
Signed-off-by: Moritz Fischer
---
drivers/net/ethernet/dec/tulip/de2104x.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/dec/tulip/de2104x.c
b/drivers/net/ethernet
This series is the first bunch of minor cleanups for the de2104x driver
to make it look and behave more like a modern driver.
These changes replace some of the non-devres versions with devres
versions of functions to simplify the error paths.
Next up after this will be the ioremap part.
Moritz
-pci_dma_sync_sg_for_cpu(e1, e2, e3, e4)
> +dma_sync_sg_for_cpu(&e1->dev, e2, e3, e4)
>
> @@
> expression e1, e2, e3, e4;
> @@
> -pci_dma_sync_sg_for_device(e1, e2, e3, e4)
> + dma_sync_sg_for_device(&e1->dev, e2, e3, e4)
>
> @@
> expression e1, e2
0 eth0: rx work limit reached
> [ 102.251387] de2104x :17:00.0 eth0: rx work limit reached
> [ 102.267444] de2104x :17:00.0 eth0: rx work limit reached
>
> Signed-off-by: Lucy Yan
Reviewed-by: Moritz Fischer
> ---
> drivers/net/ethernet/dec/tulip/de2104x.c | 2 +-
>
Hi Arthur,
On Mon, Feb 11, 2019 at 9:19 AM wrote:
>
> From: Arthur Kiyanovski
>
> Update driver version due to bug fix.
Wouldn't you want to do this atomically with the actual fix in one commit?
Thanks,
Moritz
Hi David,
On Thu, Feb 7, 2019 at 6:15 PM David Miller wrote:
>
> From: Moritz Fischer
> Date: Thu, 7 Feb 2019 12:14:55 -0800
>
> > Add fixed_phy_register_with_gpiod() API. It lets users create a
> > fixed_phy instance that uses a GPIO descriptor which was obtained
>
Add fixed_phy_register_with_gpiod() API. It lets users create a
fixed_phy instance that uses a GPIO descriptor which was obtained
externally e.g. through platform data.
This enables platform devices (non-DT based) to use GPIOs for link
status.
Reviewed-by: Florian Fainelli
Signed-off-by: Moritz
Add fixed_phy_register_with_gpiod() API. It lets users create a
fixed_phy instance that uses a GPIO descriptor which was obtained
externally e.g. through platform data.
This enables platform devices (non-DT based) to use GPIOs for link
status.
Signed-off-by: Moritz Fischer
---
Changes from RFC
Fix fixed_phy not checking GPIO if no link_update callback
is registered.
In the original version all users registered a link_update
callback so the issue was masked.
Fixes: a5597008dbc2 ("phy: fixed_phy: Add gpio to determine link up/down.")
Reviewed-by: Andrew Lunn
Signed-off-
Hi Andrew,
thanks for your feedback.
On Wed, Feb 06, 2019 at 10:53:22PM +0100, Andrew Lunn wrote:
> On Wed, Feb 06, 2019 at 12:51:06PM -0800, Moritz Fischer wrote:
> > Move the DT based link GPIO parsing to of_mdio and let the places
> > that register a fixed_phy pass in a GPI
Hi Andrew,
On Wed, Feb 06, 2019 at 10:59:05PM +0100, Andrew Lunn wrote:
> On Wed, Feb 06, 2019 at 10:10:40AM -0800, Moritz Fischer wrote:
> > Fix fixed_phy not checking GPIO if no link_update callback
> > is registered.
> >
> > Signed-off-by: Moritz Fisch
Move the DT based link GPIO parsing to of_mdio and let the places
that register a fixed_phy pass in a GPIO descriptor or NULL.
This allows fixed_phy on non-DT platforms to have link GPIOs, too.
Signed-off-by: Moritz Fischer
---
drivers/net/dsa/dsa_loop.c | 2 +-
drivers/net
Fix fixed_phy not checking GPIO if no link_update callback
is registered.
Signed-off-by: Moritz Fischer
---
Hi all,
I've been trying to figure out where exactly this broke,
it must've been somewhere when the file was refactored
in connection with phylink?
Unfortunately I couldn'
From: Moritz Fischer
Make MDIO child optional and only instantiate the
MDIO bus if the child is actually present.
There are currently no (in-tree) users of this
binding; all (out-of-tree) users use overlays that
get shipped together with the FPGA images that contain
the IP.
This will
From: Moritz Fischer
This series adds fixed-link support to nixge.
The first patch corrects the binding to correctly reflect
hardware that does not come with MDIO cores instantiated.
The second patch adds fixed link support to the driver.
The third patch updates the binding document with the
From: Moritz Fischer
Add support for fixed-link configurations to nixge driver.
Signed-off-by: Moritz Fischer
---
drivers/net/ethernet/ni/nixge.c | 27 ---
1 file changed, 20 insertions(+), 7 deletions(-)
diff --git a/drivers/net/ethernet/ni/nixge.c b/drivers/net
From: Moritz Fischer
Update device-tree binding with fixed-link support.
With fixed-link support the formerly required property 'phy-handle'
is now optional if 'fixed-link' child is present.
Signed-off-by: Moritz Fischer
---
.../devicetree/bindings/net/ni
On Mon, Feb 04, 2019 at 03:58:54PM +0100, Andrew Lunn wrote:
> On Fri, Feb 01, 2019 at 06:50:48PM -0800, Moritz Fischer wrote:
> > Make MDIO child optional and only instantiate the
> > MDIO bus if the child is actually present.
> >
> > There are currently no (in-tree
maintainabilty
of future revisions of this IP.
Signed-off-by: Moritz Fischer
Cc: Andrew Lunn
Cc: Rob Herring
---
Hi Rob, Andrew,
I know generally changing bindings is a no-no. Ultimately
I'm working on adding fixed-link support to this driver,
during the review of that Andrew suggested to dro
forms")
Signed-off-by: Moritz Fischer
Cc: Arnd Bergmann
---
drivers/net/ethernet/ni/nixge.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/net/ethernet/ni/nixge.c b/drivers/net/ethernet/ni/nixge.c
index 74cf52e3fb09..0611f2335b4a 100644
--- a/d
Add support for 64-bit platforms to driver.
The hardware only supports 32-bit register accesses
so the accesses need to be split up into two writes
when setting the current and tail descriptor values.
Cc: Florian Fainelli
Signed-off-by: Moritz Fischer
---
Changes from RFC:
- Work around
Add support for 64-bit (ZynqMP) platform to driver.
The hardware only supports 32-bit register accesses
so the accesses need to be split up into two writes
when setting the current and tail descriptor values.
Signed-off-by: Moritz Fischer
Cc: Florian Fainelli
---
Hi all,
I'm worki
.
Fixes commit 492caffa8a1a ("net: ethernet: nixge: Add support for
National Instruments XGE netdev")
Reported-by: Alex Williams
Signed-off-by: Moritz Fischer
---
drivers/net/ethernet/ni/nixge.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/net/e
r, mac_addr);
^~~~
expected ‘const u8 * {aka const unsigned char *}’ but argument
is of type ‘const char *’
static inline void ether_addr_copy(u8 *dst, const u8 *src)
Signed-off-by: Moritz Fischer
---
drivers/net/ethernet/ni/nixge.c | 2 +-
1 file changed, 1 insertion(+), 1 deleti
On Thu, Apr 26, 2018 at 02:57:42PM -0700, Moritz Fischer wrote:
> Make nixge driver work with 'mac-address' property instead of
> 'address' property. There are currently no in-tree users and
> the only users of this driver are devices that use overlays
> we c
Make nixge driver work with 'mac-address' property instead of
'address' property. There are currently no in-tree users and
the only users of this driver are devices that use overlays
we control to instantiate the device together with the corresponding
FPGA images.
Signed-of
This adds bindings for the NI XGE 1G/10G network device.
Reviewed-by: Rob Herring
Signed-off-by: Moritz Fischer
---
Changes from v5:
- None
Changes from v4:
- None
Changes from v3:
- Added Rob's Reviewed-by
Changes from v2:
- Addressed Rob's comments w.r.t to IRQ names and typo
Ch
Add support for the National Instruments XGE 1/10G network device.
It uses the EEPROM on the board via NVMEM.
Signed-off-by: Moritz Fischer
---
Changes from v5:
- Fixed up indents according to David's feedback
- Fixed KConfig ---help--- -> help
Changes from v4:
- Worked on consist
Hi David,
On Mon, Mar 26, 2018 at 11:38:30AM -0400, David Miller wrote:
> From: Moritz Fischer
> Date: Fri, 23 Mar 2018 13:41:28 -0700
>
> > +static void nixge_hw_dma_bd_release(struct net_device *ndev)
> > +{
> > + int i;
> > + struct nixge_priv *priv = net
This adds bindings for the NI XGE 1G/10G network device.
Reviewed-by: Rob Herring
Signed-off-by: Moritz Fischer
---
Changes from v4:
- None
Changes from v3:
- Added Rob's Reviewed-by
Changes from v2:
- Addressed Rob's comments w.r.t to IRQ names and typo
Changes from v1:
- Corr
Add support for the National Instruments XGE 1/10G network device.
It uses the EEPROM on the board via NVMEM.
Signed-off-by: Moritz Fischer
---
Changes from v4:
- Worked on consistency for constants
- Removed unused constants
- Removed unused includes
Changes from v3:
- Added NIXGE prefix to
Add support for the National Instruments XGE 1/10G network device.
It uses the EEPROM on the board via NVMEM.
Signed-off-by: Moritz Fischer
---
Changes from v3:
- Added NIXGE prefix to MDIO constants
- Removed NIXGE_MAX_PHY_ADDR (unused)
- Consistency for NIXGE_MDIO_CXX_READ constants
- Use
This adds bindings for the NI XGE 1G/10G network device.
Reviewed-by: Rob Herring
Signed-off-by: Moritz Fischer
---
Changes from v3:
- Added Rob's Reviewed-by
Changes from v2:
- Addressed Rob's comments w.r.t to IRQ names and typo
Changes from v1:
- Corrected from nixge -&
Florian,
On Wed, Feb 28, 2018 at 11:44 AM, Russell King wrote:
> On Wed, Feb 28, 2018 at 11:36:12AM -0800, Florian Fainelli wrote:
>> We do the same thing as the generic function: nothing, so utilize it.
>>
>> Signed-off-by: Florian Fainelli
>> ---
>> drivers/net/phy/marvell10g.c | 7 +--
>>
This adds bindings for the NI XGE 1G/10G network device.
Signed-off-by: Moritz Fischer
---
Changes from v2:
- Addressed Rob's comments w.r.t to IRQ names and typo
Changes from v1:
- Corrected from nixge -> nixge.txt
---
Documentation/devicetree/bindings/net/nixge.
Add support for the National Instruments XGE 1/10G network device.
It uses the EEPROM on the board via NVMEM.
Signed-off-by: Moritz Fischer
---
Changes from v2:
- Implement recv side NAPI
- Improved error handling
- Implemented C45 writes
- Added ethtool callbacks & blink functiona
On Sat, Jul 15, 2017 at 09:48:32PM +0200, Andrew Lunn wrote:
> > > > + ethernet_phy1: ethernet-phy@4 {
> > > > + compatible = "ethernet-phy-ieee802.3-c45";
> > > > + reg = <4>;
> > > > + devices = <0xa>;
> > > > +
Hi Andrew,
On Sat, Jul 15, 2017 at 08:37:45PM +0200, Andrew Lunn wrote:
> On Fri, Jul 14, 2017 at 01:48:45PM -0700, Moritz Fischer wrote:
> > This adds bindings for the NI XGE 1G/10G network device.
> >
> > Signed-off-by: Moritz Fischer
> > ---
> > Docu
This adds bindings for the NI XGE 1G/10G network device.
Signed-off-by: Moritz Fischer
---
Documentation/devicetree/bindings/net/nixge.txt | 32 +
1 file changed, 32 insertions(+)
create mode 100644 Documentation/devicetree/bindings/net/nixge.txt
diff --git a
Add support for the National Instruments XGE 1/10G network device.
It uses the EEPROM on the board via NVMEM.
Signed-off-by: Moritz Fischer
---
Changes from v1:
- Added dependency on ARCH_ZYNQ (Kbuild)
- Removed unused variables
- Use of_phy_connect as suggested
- Removed masking of (un
Hi Andrew,
On Thu, Jul 13, 2017 at 6:34 PM, Andrew Lunn wrote:
>> > > + /* not sure if this is the correct way of dealing with this ... */
>> > > + ndev->phydev->supported &= ~(SUPPORTED_Autoneg);
>> > > + ndev->phydev->advertising = ndev->phydev->supported;
>> > > + ndev->phydev->autoneg = AUTON
Hi Yuan,
On Thu, Jul 13, 2017 at 5:33 PM, YUAN Linyu
wrote:
>
>
>> -Original Message-
>> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org]
>> On Behalf Of Moritz Fischer
>> Sent: Friday, July 14, 2017 5:22 AM
>> To: n
Hi Andrew,
thanks for the quick response.
On Fri, Jul 14, 2017 at 12:36:36AM +0200, Andrew Lunn wrote:
> > +++ b/drivers/net/ethernet/ni/nixge.c
> > @@ -0,0 +1,1246 @@
> > +/*
> > + * Copyright (c) 2016-2017, National Instruments Corp.
> > + *
> > + * Network Driver for Ettus Research XGE MAC
> >
This adds bindings for the NI XGE 1G/10G network device.
Signed-off-by: Moritz Fischer
---
Documentation/devicetree/bindings/net/nixge.c | 32 +++
1 file changed, 32 insertions(+)
create mode 100644 Documentation/devicetree/bindings/net/nixge.c
diff --git a
Add support for the National Instruments XGE 1/10G network device.
It uses the EEPROM on the board via NVMEM.
Signed-off-by: Moritz Fischer
---
drivers/net/ethernet/Kconfig |1 +
drivers/net/ethernet/Makefile|1 +
drivers/net/ethernet/ni/Kconfig | 26 +
drivers/net/ethernet
Andrew,
On Wed, Feb 15, 2017 at 2:12 PM, Andrew Lunn wrote:
>> @@ -3342,8 +3371,18 @@ static int macb_probe(struct platform_device *pdev)
>> macb_get_hwaddr(bp);
>>
>> /* Power up the PHY if there is a GPIO reset */
>> - phy_node = of_get_next_available_child(np, NULL);
>
Hi Florian,
thanks for the quick reply.
On Wed, Feb 15, 2017 at 12:57 PM, Florian Fainelli wrote:
> On 02/15/2017 12:44 PM, m...@kernel.org wrote:
>> From: Moritz Fischer
>>
>> This allows 'fixed-link' direct MAC connections to be declared
>> in devicetree
erface down, since unregister_netdev
> will end up calling macb_close.
>
> Signed-off-by: Xander Huff
> Signed-off-by: Nathan Sullivan
> Signed-off-by: Brad Mouring
Reviewed-by: Moritz Fischer
Hi Andrew,
On Mon, Jun 27, 2016 at 5:56 PM, Andrew Lunn wrote:
> Does it have any ID registers at all?
There is a vendor specific (to my knowledge) register at device 1
register 65535 ([1]) that could be read back. I haven't seen anyone
else do that.
Thanks,
Moritz
[1]
http://www.xilinx.com
Hi all,
I have a 10GigE PHY that I'm working with that has most of it's
functionality availabile via MDIO
in a clause 45 compliant fashion, however the usual probe method fails
since the id registers
are not implemented.
I hacked up drivers/of/of_mdio.c to include something similar to of_get_phy_
checkpatch.pl gave the following error:
ERROR: space required before the open parenthesis '('
+ for(; p < end; p++, offset += 4)
Acked-by: Nicolas Ferre
Acked-by: Michal Simek
Signed-off-by: Moritz Fischer
---
drivers/net/ethernet/cadence/macb.c | 2 +-
1 file changed
Acked-by: Michal Simek
Acked-by: Nicolas Ferre
Signed-off-by: Moritz Fischer
---
drivers/net/ethernet/cadence/macb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/cadence/macb.c
b/drivers/net/ethernet/cadence/macb.c
index 01a8ffb..eec3200 100644
This commit deals with a bunch of checkpatch suggestions
that without changing behavior make checkpatch happier.
Acked-by: Michal Simek
Acked-by: Nicolas Ferre
Signed-off-by: Moritz Fischer
---
drivers/net/ethernet/cadence/macb.c | 46 +++--
1 file changed, 24
ypo in comments as suggested by Joe
Cheers,
Moritz
Moritz Fischer (5):
net: macb: Fix coding style error message
net: macb: Fix coding style warnings
net: macb: Fix coding style suggestions
net: macb: Use ether_addr_copy over memcpy
net: macb: Fix simple typo
drivers/net/ethernet
This commit takes care of the coding style warnings
that are mostly due to a different comment style and
lines over 80 chars, as well as a dangling else.
Acked-by: Nicolas Ferre
Signed-off-by: Moritz Fischer
---
drivers/net/ethernet/cadence/macb.c | 100 +++-
1
Checkpatch suggests using ether_addr_copy over memcpy
to copy the mac address.
Acked-by: Michal Simek
Acked-by: Nicolas Ferre
Signed-off-by: Moritz Fischer
---
drivers/net/ethernet/cadence/macb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/cadence
Nicolas,
On Wed, Mar 16, 2016 at 6:39 AM, Nicolas Ferre wrote:
> Le 13/03/2016 20:10, Moritz Fischer a écrit :
>> Hi all,
>>
>> I backed out the variable scope changes and made a separate
>> patch for the ether_addr_copy change.
>>
>> Changes from v1:
&
This commit takes care of the coding style warnings
that are mostly due to a different comment style and
lines over 80 chars, as well as a dangling else.
Signed-off-by: Moritz Fischer
---
drivers/net/ethernet/cadence/macb.c | 101 +++-
1 file changed, 43
Hi all,
I backed out the variable scope changes and made a separate
patch for the ether_addr_copy change.
Changes from v1:
* Backed out variable scope changes
* Separated out ether_addr_copy into it's own commit
* Fixed typo in comments as suggested by Joe
Cheers,
Moritz
Moritz Fisch
Signed-off-by: Moritz Fischer
---
drivers/net/ethernet/cadence/macb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/cadence/macb.c
b/drivers/net/ethernet/cadence/macb.c
index a0c01e5..681e5bf 100644
--- a/drivers/net/ethernet/cadence/macb.c
+++ b
This commit deals with a bunch of checkpatch suggestions
that without changing behavior make checkpatch happier.
Signed-off-by: Moritz Fischer
---
drivers/net/ethernet/cadence/macb.c | 46 +++--
1 file changed, 24 insertions(+), 22 deletions(-)
diff --git a
Checkpatch suggests using ether_addr_copy over memcpy
to copy the mac address.
Signed-off-by: Moritz Fischer
---
drivers/net/ethernet/cadence/macb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/cadence/macb.c
b/drivers/net/ethernet/cadence/macb.c
checkpatch.pl gave the following error:
ERROR: space required before the open parenthesis '('
+ for(; p < end; p++, offset += 4)
Signed-off-by: Moritz Fischer
---
drivers/net/ethernet/cadence/macb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
Hi all,
thanks for the feedback.
On Wed, Mar 9, 2016 at 8:29 AM, Michal Simek wrote:
> On 7.3.2016 18:13, Nicolas Ferre wrote:
>> I'm not usually fond of this type of patches, but I must admit that this
>> series corrects some style issues.
While I was playing around with my fixed-link for mac
Hi Joe, David,
On Mon, Mar 7, 2016 at 10:49 AM, David Miller wrote:
> From: Moritz Fischer
> Date: Mon, 7 Mar 2016 08:17:38 -0800
>
>> @@ -945,6 +943,7 @@ static int macb_rx_frame(struct macb *bp, unsigned int
>> first_frag,
>> static int macb_rx(
This commit deals with a bunch of checkpatch suggestions
that without changing behavior make checkpatch happier.
Signed-off-by: Moritz Fischer
---
drivers/net/ethernet/cadence/macb.c | 46 +++--
1 file changed, 24 insertions(+), 22 deletions(-)
diff --git a
checkpatch.pl gave the following error:
ERROR: space required before the open parenthesis '('
+ for(; p < end; p++, offset += 4)
Signed-off-by: Moritz Fischer
---
drivers/net/ethernet/cadence/macb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
Derp, it's monday morning. Ignore the second [3/3] patch... Sorry for the noise.
Moritz
This commit takes care of the coding style warnings
that are mostly due to a different comment style and
lines over 80 chars.
Notable exceptions are ether_addr_copy vs memcpy,
as well as a dangling else after a return.
Signed-off-by: Moritz Fischer
---
drivers/net/ethernet/cadence/macb.c | 109
quash
them into one commit.
Cheers,
Moritz
Moritz Fischer (3):
net: macb: Fix coding style error message
net: macb: Fix more coding style issues
net: macb: Address checkpatch 'check' suggestions
drivers/net/ethernet/cadence/macb.c | 157
This commit deals with a bunch of check suggestions
that without changing behavior make checkpatch hapy.
Signed-off-by: Moritz Fischer
---
drivers/net/ethernet/cadence/macb.c | 46 +++--
1 file changed, 24 insertions(+), 22 deletions(-)
diff --git a/drivers/net
Signed-off-by: Moritz Fischer
---
drivers/net/ethernet/cadence/macb.c | 63 -
drivers/net/ethernet/cadence/macb.h | 1 +
2 files changed, 43 insertions(+), 21 deletions(-)
diff --git a/drivers/net/ethernet/cadence/macb.c
b/drivers/net/ethernet/cadence
, so I'm more looking for pointers on obvious mistakes
than
for a thorough code review.
Thanks in advance,
Moritz
Moritz Fischer (1):
net: macb: Attempt to make fixed link working on macb
drivers/net/ethernet/cadence/macb.c | 63 -
drivers/net/eth
Hi Gregory,
so far dealt with this in u-boot. The power down the PHY part makes
sense, though. Minor nit down inline.
Will need to test on hardware (Zynq).
On Wed, Dec 9, 2015 at 9:49 AM, Gregory CLEMENT
wrote:
> With device tree it is no more possible to reset the PHY at board
> level. Furtherm
88 matches
Mail list logo
