t;
> Cc: Nicolas Saenz Julienne
> Cc: Maxime Ripard
> Cc: Linus Walleij
> Cc: Bartosz Golaszewski
> Cc: Bjorn Andersson
> Cc: Krzysztof Kozlowski
> Cc: Marc Kleine-Budde
> Cc: "David S. Miller"
> Cc: Jakub Kicinski
> Cc: Srinivas Kandagatla
>
add a parameter
> to our syscon phandle. The driver will use this value as an index into
> the regmap, so that we can address more than the first register, if
> needed.
>
> Signed-off-by: Andre Przywara
Acked-by: Maxime Ripard
Maxime
signature.asc
Description: PGP signature
On Tue, Dec 15, 2020 at 07:18:48PM +0100, Christophe JAILLET wrote:
> Le 15/12/2020 à 12:37, Maxime Ripard a écrit :
> > On Tue, Dec 15, 2020 at 12:11:53PM +0300, Dan Carpenter wrote:
> > > On Tue, Dec 15, 2020 at 09:56:55AM +0100, Maxime Ripard wrote:
> > > > Hi,
&
On Tue, Dec 15, 2020 at 12:11:53PM +0300, Dan Carpenter wrote:
> On Tue, Dec 15, 2020 at 09:56:55AM +0100, Maxime Ripard wrote:
> > Hi,
> >
> > On Mon, Dec 14, 2020 at 09:21:17PM +0100, Christophe JAILLET wrote:
> > > 'irq_of_parse_and_map()
Hi,
On Mon, Dec 14, 2020 at 09:21:17PM +0100, Christophe JAILLET wrote:
> 'irq_of_parse_and_map()' should be balanced by a corresponding
> 'irq_dispose_mapping()' call. Otherwise, there is some resources leaks.
Do you have a source to back that? It's not clear at all from the
documentation for th
On Tue, Sep 22, 2020 at 01:56:15PM +1200, Barry Song wrote:
> The comment "holders of db->lock must always block IRQs" and related
> code to do irqsave and irqrestore don't make sense since we are in a
> IRQ-disabled hardIRQ context.
>
> Cc: Maxime Ripard
&g
Hi Andrew,
On Tue, Jul 07, 2020 at 04:19:18PM +0200, Andrew Lunn wrote:
> On Mon, Jul 06, 2020 at 08:13:31PM +0200, Maxime Ripard wrote:
> > I came across an issue today on an Allwinner board, but I believe it's a
> > core issue.
> >
> > That board is using the
Hi,
I came across an issue today on an Allwinner board, but I believe it's a
core issue.
That board is using the stmac driver together with a phy that happens to
have a reset GPIO, except that that GPIO will never be claimed, and the
PHY will thus never work.
You can find an example of such a bo
Hi,
On Sun, Jul 05, 2020 at 12:51:10PM -0700, Vasily Khoruzhick wrote:
> Pinebook has an RTL8723CS WiFi + BT chip, BT is connected to UART1
> and uses PL5 as device wake GPIO, PL6 as host wake GPIO the I2C
> controlling signals are connected to R_I2C bus.
>
> Enable it in the device tree.
>
> Si
Hi Marcel,
On Tue, Apr 28, 2020 at 11:51:24AM +0200, Marcel Holtmann wrote:
> Hi Alistair,
>
> > The sopine board has an optional RTL8723BS WiFi + BT module that can be
> > connected to UART1. Add this to the device tree so that it will work
> > for users if connected.
> >
> > Signed-off-by: Ali
The older Allwinner SoCs have a CAN controller that is supported in Linux,
with a matching Device Tree binding.
Now that we have the DT validation in place, let's convert the device tree
bindings for that controller over to a YAML schemas.
Signed-off-by: Maxime Ripard
---
.../net/can/allw
On Thu, Jun 27, 2019 at 10:06:57AM -0600, Rob Herring wrote:
> On Thu, Jun 27, 2019 at 9:57 AM Maxime Ripard
> wrote:
> > > > +
> > > > +reset-gpios = <&gpio2 5 1>;
> > > > +reset-delay-us = <2>;
> > > > +
&g
Hi Rob,
On Thu, Jun 27, 2019 at 09:48:06AM -0600, Rob Herring wrote:
> On Thu, Jun 27, 2019 at 9:32 AM Maxime Ripard
> wrote:
> >
> > The MDIO buses have a number of available device tree properties that can
> > be used in their device tree node. Add a YAML schemas for
Even though the DWMAC driver uses some driver specific properties, the PHY
core has a bunch of generic properties and can deal with them nicely.
Let's deprecate our specific properties.
Reviewed-by: Martin Blumenstingl
Reviewed-by: Rob Herring
Signed-off-by: Maxime Ripard
---
Document
The DWMAC specific properties to manage the PHY have been superseeded by
the generic PHY properties. Let's move to it.
Reviewed-by: Andrew Lunn
Tested-by: Chen-Yu Tsai
Signed-off-by: Maxime Ripard
---
arch/arm/boot/dts/sun6i-a31-hummingbird.dts | 6 +++---
arch/arm/boot/dts/sun6i
The networking PHYs have a number of available device tree properties that
can be used in their device tree node. Add a YAML schemas for those.
Reviewed-by: Andrew Lunn
Reviewed-by: Rob Herring
Signed-off-by: Maxime Ripard
---
Documentation/devicetree/bindings/net/ethernet-phy.yaml | 179
Switch our Allwinner H3 EMAC controller binding to a YAML schema to enable
the DT validation. Since that controller is based on a Synopsys IP, let's
add the validation to that schemas with a bunch of conditionals.
Reviewed-by: Rob Herring
Signed-off-by: Maxime Ripard
---
Document
Switch our Allwinner A10 EMAC controller binding to a YAML schema to enable
the DT validation.
Reviewed-by: Rob Herring
Signed-off-by: Maxime Ripard
---
Documentation/devicetree/bindings/net/allwinner,sun4i-a10-emac.yaml | 55
The MDIO buses have a number of available device tree properties that can
be used in their device tree node. Add a YAML schemas for those.
Suggested-by: Andrew Lunn
Signed-off-by: Maxime Ripard
---
Documentation/devicetree/bindings/net/mdio.txt | 38 +-
Documentation/devicetree
The phy device tree property has been deprecated in favor of phy-handle,
let's replace it.
Signed-off-by: Maxime Ripard
---
arch/arm/boot/dts/sun4i-a10-a1000.dts| 2 +-
arch/arm/boot/dts/sun4i-a10-ba10-tvbox.dts | 2 +-
arch/arm/boot/dts/sun4i-a10-cubieboar
Switch the STMMAC / Synopsys DesignWare MAC controller binding to a YAML
schema to enable the DT validation.
Reviewed-by: Rob Herring
Signed-off-by: Maxime Ripard
---
Documentation/devicetree/bindings/net/snps,dwmac.yaml | 389 +++-
Documentation/devicetree/bindings/net/stmmac.txt
Unlike what was initially claimed in the PHY binding, the interrupt
property of a PHY can be omitted, and the OS will turn to polling instead.
Document that.
Reviewed-by: Andrew Lunn
Reviewed-by: Rob Herring
Signed-off-by: Maxime Ripard
---
Documentation/devicetree/bindings/net/ethernet
While the Ethernet PHY framework was marked as maintained, the device tree
bindings associated to that framework was not listed under the maintained
files. Fix that.
Reviewed-by: Andrew Lunn
Signed-off-by: Maxime Ripard
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a
speeds
- Add a custom select clause to make the PHY binding validate all phy
nodes, and not just the ones with a compatible
- Validate the fixed-link array elements
- Removed deprecated properties (phy-mode, phy, phy-device)
- Restrict the number of items under link-gpios to 1
Maxime
The Ethernet controllers have a good number of generic options that can be
needed in a device tree. Add a YAML schemas for those.
Reviewed-by: Rob Herring
Signed-off-by: Maxime Ripard
---
Documentation/devicetree/bindings/net/ethernet-controller.yaml | 204 +++-
Documentation/devicetree
Switch our Allwinner A20 GMAC controller binding to a YAML schema to enable
the DT validation. Since that controller is based on a Synopsys IP, let's
add the validation to that schemas with a bunch of conditionals.
Reviewed-by: Rob Herring
Signed-off-by: Maxime Ripard
---
Document
Switch our Allwinner A10 MDIO controller binding to a YAML schema to enable
the DT validation.
Reviewed-by: Rob Herring
Signed-off-by: Maxime Ripard
---
Documentation/devicetree/bindings/net/allwinner,sun4i-a10-mdio.yaml | 70
Hi,
On Wed, Jun 19, 2019 at 08:17:52AM -0600, Rob Herring wrote:
> On Wed, Jun 19, 2019 at 3:47 AM Maxime Ripard
> wrote:
> >
> > The MDIO buses have a number of available device tree properties that can
> > be used in their device tree node. Add a YAML schemas for tho
> > +- $ref: /schemas/types.yaml#definitions/uint32
> > +- enum: [10, 100, 1000]
>
> This recently changed, depending on context. If PHYLINK is being used,
> any speed is allowed. If phylib is used, then only these speeds are
> allowed. And we are starting to see some speeds other than listed
> here.
phylink seems to be described in a separate binding document, maybe we
can adjust that later?
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
signature.asc
Description: PGP signature
The DWMAC specific properties to manage the PHY have been superseeded by
the generic PHY properties. Let's move to it.
Reviewed-by: Andrew Lunn
Tested-by: Chen-Yu Tsai
Signed-off-by: Maxime Ripard
---
This patch should go through arm-soc.
Changes from v1:
- New patch
---
arch/arm
Switch our Allwinner A10 MDIO controller binding to a YAML schema to enable
the DT validation.
Signed-off-by: Maxime Ripard
---
Changes from v2:
- Add the generic MDIO YAML schema
Changes from v1:
- Add a select statement with the deprecated compatible, and remove it
from the valid
The phy-mode device tree property has been deprecated in favor of
phy-connection-type, let's replace it.
Signed-off-by: Maxime Ripard
---
Changes from v2:
- new patch
---
arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts| 2 +-
arch/arm64/boot/dts/allwinner/sun50i-a64-n
Switch our Allwinner A20 GMAC controller binding to a YAML schema to enable
the DT validation. Since that controller is based on a Synopsys IP, let's
add the validation to that schemas with a bunch of conditionals.
Reviewed-by: Rob Herring
Signed-off-by: Maxime Ripard
---
Changes fr
The phy device tree property has been deprecated in favor of phy-handle,
let's replace it.
Signed-off-by: Maxime Ripard
---
Changes from v2:
- new patch
---
arch/arm/boot/dts/sun4i-a10-a1000.dts| 2 +-
arch/arm/boot/dts/sun4i-a10-ba10-tvbox.dts | 2 +-
arc
The phy-mode device tree property has been deprecated in favor of
phy-connection-type, let's replace it.
Signed-off-by: Maxime Ripard
---
Changes from v2:
- new patch
---
arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts| 2 +-
arch/arm/boot/dts/sun8i-h3-beelink-x
The phy-mode device tree property has been deprecated in favor of
phy-connection-type, let's replace it.
Signed-off-by: Maxime Ripard
---
Changes from v2:
- new patch
---
arch/arm/boot/dts/sun6i-a31-colombus.dts | 2 +-
arch/arm/boot/dts/sun6i-a31-hummingbird.dts | 2 +-
Switch the STMMAC / Synopsys DesignWare MAC controller binding to a YAML
schema to enable the DT validation.
Signed-off-by: Maxime Ripard
---
Changes from v2:
- Switch to phy-connection-type instead of phy-mode
- Fix the snps,*pbl properties type
Changes from v1:
- Restrict snps,tso to
Switch our Allwinner H3 EMAC controller binding to a YAML schema to enable
the DT validation. Since that controller is based on a Synopsys IP, let's
add the validation to that schemas with a bunch of conditionals.
Signed-off-by: Maxime Ripard
---
Changes from v2:
- Switch to phy-conne
Switch our Allwinner A10 EMAC controller binding to a YAML schema to enable
the DT validation.
Signed-off-by: Maxime Ripard
---
Changes from v2:
- Switch from the deprecated phy property to phy-handle
---
Documentation/devicetree/bindings/net/allwinner,sun4i-a10-emac.yaml | 55
Unlike what was initially claimed in the PHY binding, the interrupt
property of a PHY can be omitted, and the OS will turn to polling instead.
Document that.
Reviewed-by: Andrew Lunn
Reviewed-by: Rob Herring
Signed-off-by: Maxime Ripard
---
Documentation/devicetree/bindings/net/ethernet
The MDIO buses have a number of available device tree properties that can
be used in their device tree node. Add a YAML schemas for those.
Suggested-by: Andrew Lunn
Signed-off-by: Maxime Ripard
---
Changes from v2:
- New patch
---
Documentation/devicetree/bindings/net/mdio.txt | 38
Even though the DWMAC driver uses some driver specific properties, the PHY
core has a bunch of generic properties and can deal with them nicely.
Let's deprecate our specific properties.
Reviewed-by: Martin Blumenstingl
Signed-off-by: Maxime Ripard
---
Changes from v2:
- Use the depre
The Ethernet controllers have a good number of generic options that can be
needed in a device tree. Add a YAML schemas for those.
Reviewed-by: Rob Herring
Signed-off-by: Maxime Ripard
---
Changes from v2:
- Add back the deprecated properties using the deprecated keyword
Changes from v1
While the Ethernet PHY framework was marked as maintained, the device tree
bindings associated to that framework was not listed under the maintained
files. Fix that.
Reviewed-by: Andrew Lunn
Signed-off-by: Maxime Ripard
---
Changes from v1:
- New patch
---
MAINTAINERS | 1 +
1 file changed
The networking PHYs have a number of available device tree properties that
can be used in their device tree node. Add a YAML schemas for those.
Reviewed-by: Andrew Lunn
Reviewed-by: Rob Herring
Signed-off-by: Maxime Ripard
---
Changes from v1:
- Add missing compatible options
- add
f: "#/properties/phy-handle"
> > deprecated: true
> >
> > Does that sound good?
>
> Yes.
Great, I'll post that.
> > Now, how do we handle the case above, in the device specific binding?
> > We just require the non-deprecated one, or the t
Hi Rob,
On Thu, Jun 13, 2019 at 11:32:30AM -0600, Rob Herring wrote:
> On Thu, Jun 13, 2019 at 7:25 AM Maxime Ripard
> wrote:
> > On Mon, Jun 10, 2019 at 12:59:29PM -0600, Rob Herring wrote:
> > > On Mon, Jun 10, 2019 at 8:31 AM Andrew Lunn wrote:
> &
ror in the schemas, which in turn means that you'll have a lot
of friction to support schemas, since you would have to convert your
driver to support the new way of doing things, before being able to
have a schema for your binding.
And then, we need to agree on how to express the deprecation. I
On Mon, Jun 10, 2019 at 01:13:25PM -0600, Rob Herring wrote:
> On Mon, Jun 10, 2019 at 3:26 AM Maxime Ripard
> wrote:
> > +then:
> > + properties:
> > +snps,pbl:
> > + allOf:
> > +- $ref: /schemas/types.yaml#definitions/
Hi,
On Mon, Jun 10, 2019 at 01:22:00PM -0600, Rob Herring wrote:
> On Mon, Jun 10, 2019 at 3:26 AM Maxime Ripard
> wrote:
> > +then:
> > + properties:
> > +allwinner,tx-delay-ps:
> > + allOf:
> > +- $ref: /schemas/types.
Hi Andrew,
On Mon, Jun 10, 2019 at 04:37:30PM +0200, Andrew Lunn wrote:
> On Mon, Jun 10, 2019 at 11:25:45AM +0200, Maxime Ripard wrote:
> > Switch our Allwinner A10 MDIO controller binding to a YAML schema to enable
> > the DT validation.
> >
> > Signed-off-by: Maxime
ed though, which is kind of a
shame, but still much better than what we currently have.
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
signature.asc
Description: PGP signature
The networking PHYs have a number of available device tree properties that
can be used in their device tree node. Add a YAML schemas for those.
Signed-off-by: Maxime Ripard
---
Changes from v1:
- Add missing compatible options
- add missing phy speeds
- Fix the maintainers entry
- Add
Even though the DWMAC driver uses some driver specific properties, the PHY
core has a bunch of generic properties and can deal with them nicely.
Let's deprecate our specific properties.
Signed-off-by: Maxime Ripard
---
Changes from v1:
- New patch
---
Documentation/devicetree/binding
Switch our Allwinner A10 EMAC controller binding to a YAML schema to enable
the DT validation.
Signed-off-by: Maxime Ripard
---
Documentation/devicetree/bindings/net/allwinner,sun4i-a10-emac.yaml | 55
+++
Documentation/devicetree/bindings
Unlike what was initially claimed in the PHY binding, the interrupt
property of a PHY can be omitted, and the OS will turn to polling instead.
Document that.
Signed-off-by: Maxime Ripard
---
Documentation/devicetree/bindings/net/ethernet-phy.yaml | 1 -
1 file changed, 1 deletion(-)
diff
Switch our Allwinner A20 GMAC controller binding to a YAML schema to enable
the DT validation. Since that controller is based on a Synopsys IP, let's
add the validation to that schemas with a bunch of conditionals.
Signed-off-by: Maxime Ripard
---
Changes from v1:
- Add a file of it
Switch our Allwinner H3 EMAC controller binding to a YAML schema to enable
the DT validation. Since that controller is based on a Synopsys IP, let's
add the validation to that schemas with a bunch of conditionals.
Signed-off-by: Maxime Ripard
---
Changes from v1:
- Add specific bi
The DWMAC specific properties to manage the PHY have been superseeded by
the generic PHY properties. Let's move to it.
Signed-off-by: Maxime Ripard
---
This patch should go through arm-soc.
Changes from v1:
- New patch
---
arch/arm/boot/dts/sun6i-a31-hummingbird.dts | 6 +++---
Switch the STMMAC / Synopsys DesignWare MAC controller binding to a YAML
schema to enable the DT validation.
Signed-off-by: Maxime Ripard
---
Changes from v1:
- Restrict snps,tso to only a couple of compatibles
- Use an enum for the compatibles
- Add a custom select statement with the
Switch our Allwinner A10 MDIO controller binding to a YAML schema to enable
the DT validation.
Signed-off-by: Maxime Ripard
---
Changes from v1:
- Add a select statement with the deprecated compatible, and remove it
from the valid compatibles
---
Documentation/devicetree/bindings/net
While the Ethernet PHY framework was marked as maintained, the device tree
bindings associated to that framework was not listed under the maintained
files. Fix that.
Signed-off-by: Maxime Ripard
---
Changes from v1:
- New patch
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff
The Ethernet controllers have a good number of generic options that can be
needed in a device tree. Add a YAML schemas for those.
Signed-off-by: Maxime Ripard
---
Changes from v1:
- Use an enum for phy-connection-types
- Validate the items for the fixed-link array
- Set the number of
27;minimum': 0,
'maximum': 31}, 'description': 'The ID number for the PHY.'} is not valid under
any of the given schemas
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Hi Rob,
On Thu, May 23, 2019 at 10:33:05AM -0500, Rob Herring wrote:
> On Thu, May 23, 2019 at 4:57 AM Maxime Ripard
> wrote:
> >
> > Switch the STMMAC / Synopsys DesignWare MAC controller binding to a YAML
> > schema to enable the DT validation.
>
> You picked
Hi Florian,
On Thu, May 23, 2019 at 11:16:55AM -0700, Florian Fainelli wrote:
> On 5/23/19 2:56 AM, Maxime Ripard wrote:
> > The networking PHYs have a number of available device tree properties that
> > can be used in their device tree node. Add a YAML schemas for those.
> &
Hi Alexandre,
On Thu, May 23, 2019 at 05:05:51PM +0200, Alexandre Torgue wrote:
> Hi Maxime
>
> On 5/23/19 11:56 AM, Maxime Ripard wrote:
> > Switch the STMMAC / Synopsys DesignWare MAC controller binding to a YAML
> > schema to enable the DT validation.
> >
>
Hi Andrew,
(Sorry for not CC'ing you on this)
On Thu, May 23, 2019 at 04:37:44PM +0200, Andrew Lunn wrote:
> On Thu, May 23, 2019 at 11:56:45AM +0200, Maxime Ripard wrote:
> > The networking PHYs have a number of available device tree properties that
> > can be used in th
n.
> > +
> > +
> > + - if:
>
> Couldn't this be an 'else' and avoid the allOf?
I don't really know, we could go both ways. Which one would be the
more verbose in the case where someone would just have a boolean
instead of the node or the array?
Thanks!
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
On Thu, May 23, 2019 at 11:25:09AM +, Jose Abreu wrote:
> From: Maxime Ripard
> Date: Thu, May 23, 2019 at 12:07:15
>
> > You can then run make dtbs_check, and those YAML files will be used to
> > validate that any devicetree using those properties are doing it
>
Hi!
On Thu, May 23, 2019 at 10:11:39AM +, Jose Abreu wrote:
> From: Maxime Ripard
> Date: Thu, May 23, 2019 at 10:56:49
>
> > Switch the STMMAC / Synopsys DesignWare MAC controller binding to a YAML
> > schema to enable the DT validation.
> >
> > Signed-off-b
Switch our Allwinner A10 EMAC controller binding to a YAML schema to enable
the DT validation.
Signed-off-by: Maxime Ripard
---
Documentation/devicetree/bindings/net/allwinner,sun4i-a10-emac.yaml | 55
+++
Documentation/devicetree/bindings
Switch our Allwinner A10 MDIO controller binding to a YAML schema to enable
the DT validation.
Signed-off-by: Maxime Ripard
---
Documentation/devicetree/bindings/net/allwinner,sun4i-a10-mdio.yaml | 55
+++
Documentation/devicetree/bindings
Switch the STMMAC / Synopsys DesignWare MAC controller binding to a YAML
schema to enable the DT validation.
Signed-off-by: Maxime Ripard
---
Documentation/devicetree/bindings/net/snps,dwmac.yaml | 344 +++-
Documentation/devicetree/bindings/net/stmmac.txt | 179 +--
2 files
Switch our Allwinner H3 EMAC controller binding to a YAML schema to enable
the DT validation. Since that controller is based on a Synopsys IP, let's
add the validation to that schemas with a bunch of conditionals.
Signed-off-by: Maxime Ripard
---
Documentation/devicetree/bindings/net/
Switch our Allwinner A20 GMAC controller binding to a YAML schema to enable
the DT validation. Since that controller is based on a Synopsys IP, let's
add the validation to that schemas with a bunch of conditionals.
Signed-off-by: Maxime Ripard
---
Documentation/devicetree/bindings/net/allw
Unlike what was initially claimed in the PHY binding, the interrupt
property of a PHY can be omitted, and the OS will turn to polling instead.
Document that.
Signed-off-by: Maxime Ripard
---
Documentation/devicetree/bindings/net/ethernet-phy.yaml | 1 -
1 file changed, 1 deletion(-)
diff
The Ethernet controllers have a good number of generic options that can be
needed in a device tree. Add a YAML schemas for those.
Signed-off-by: Maxime Ripard
---
Documentation/devicetree/bindings/net/ethernet-controller.yaml | 197 +++-
Documentation/devicetree/bindings/net/ethernet.txt
The networking PHYs have a number of available device tree properties that
can be used in their device tree node. Add a YAML schemas for those.
Signed-off-by: Maxime Ripard
---
Documentation/devicetree/bindings/net/ethernet-phy.yaml | 148 +-
Documentation/devicetree/bindings/net
15 2>;
> + byte-transform = "ascii";
> + byte-increment = <1>;
> + byte-increment-at = <5>;
> + byte-result-swap;
> + };
> +
> + ð1 {
> + nvmem-cells = <ð1_addr>;
> + nvmem-cell-names = "mac-address";
> + };
> +
Something along those lines yes. I'm not sure why in your example the
cell doesn't start at the mac address itself, instead of starting at
the key + having to specify an offset though. The reg property is the
offset already.
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
inary-swapped", "ascii",
> "ascii-delimited".
>"binary" is the default.
> - nvmem-mac-address-increment: number, value by which should be
>incremented MAC address octet, could be negative value as well.
> - nvmem-mac-address-increment-octet: number, valid values 0-5, default is 5.
>Specifies MAC address octet used for `nvmem-mac-address-increment`.
>
> What do you think?
It looks to me that it should be abstracted away by the nvmem
interface and done at the provider level, not the customer.
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
signature.asc
Description: PGP signature
On Wed, Apr 17, 2019 at 06:06:00PM +0200, Petr Štetiar wrote:
> Maxime Ripard [2019-04-17 10:06:14]:
>
> > NVMEM is supported by of_net already
>
> Well, not anymore:
>
> commit afa64a72b862a7a9d04f8d07fba632eaf06b23f8
> Author: Bartosz Golaszewski
> Date:
On Wed, Apr 17, 2019 at 11:49:21AM +0200, Petr Štetiar wrote:
> Maxime Ripard [2019-04-17 10:06:14]:
>
> Hi Maxime,
>
> > On Tue, Apr 16, 2019 at 10:05:00PM +0200, Petr Štetiar wrote:
> > > From: John Crispin
> > >
> > > Many embedded devices
nup of the patch for upstream submission]
> Signed-off-by: Petr Štetiar
NVMEM is supported by of_net already and there's an MTD-to-nvmem
bridge already, so it doesn't look really necessary to create
additional properties that cover the same use case.
(or at least, you should expla
fe.
>
> Signed-off-by: Yizhuo
Acked-by: Maxime Ripard
Thanks!
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
signature.asc
Description: PGP signature
reviewer that since you check 'ret' the
> >> initialization of
> >> 'val' is no longer needed.
>
> Thanks, but why initialization matters here? Is performance the main
> concern?
Not really, but if we turn this the other way around, why should we do
something that doesn't bring anything?
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
signature.asc
Description: PGP signature
= priv->plat->bsp_priv;
> struct device_node *node = priv->device->of_node;
> int ret;
> - u32 reg, val;
> + u32 reg, val = 0;
I guess we don't need to initialize it anymore with the check you add?
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
signature.asc
Description: PGP signature
MODULE_LICENSE, use it as the definitive source of the
> licence, and fixup with others when there are contradictions.
>
> Cc: Russell King
> Cc: Maxime Ripard
> Cc: Jonas Jensen
> Cc: Laurent Pinchart
> Cc: Paulius Zaleckas
> Cc: Scott Wood
> Cc: Andrew F. Davis
efinition to the generic phy headers. This
would allow to have a documented, obvious link between a mode and its
subnodes, for all the actors involved (consumer, provider, and
framework) without prior knowledge.
C) Document what the submodes expectations are
What do you think?
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
signature.asc
Description: PGP signature
Hi,
On Tue, May 15, 2018 at 11:47:16PM -0700, Chen-Yu Tsai wrote:
> On Mon, May 14, 2018 at 1:03 AM, Maxime Ripard
> wrote:
> > 1;5201;0c
> > On Sun, May 13, 2018 at 12:37:49PM -0700, Chen-Yu Tsai wrote:
> >> On Wed, May 2, 2018 at 4:54 AM, Maxime Ripard
> >>
1;5201;0c
On Sun, May 13, 2018 at 12:37:49PM -0700, Chen-Yu Tsai wrote:
> On Wed, May 2, 2018 at 4:54 AM, Maxime Ripard
> wrote:
> > On Wed, May 02, 2018 at 06:19:51PM +0800, Icenowy Zheng wrote:
> >>
> >>
> >> 于 2018年5月2日 GMT+08:00 下午5:53:21, Chen-Yu Tsai
ported by the control register. Not implementing, i.e.
> supporting the whole range from the property, which might get truncated,
> doesn't make much sense to me.
With that driver we don't, but the previous design had the same
feature and it was used on more boards. It was simply initialized
statically in U-Boot, and not in Linux through the DT like it is done
here.
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
signature.asc
Description: PGP signature
On Thu, May 03, 2018 at 02:40:42PM -0400, David Miller wrote:
> From: Maxime Ripard
> Date: Thu, 3 May 2018 15:12:57 +0200
>
> > Hi Dave,
> >
> > On Wed, May 02, 2018 at 11:06:17AM -0400, David Miller wrote:
> >> From: Chen-Yu Tsai
> >> Date:
elevant to enable a
particular feature, even if it means getting multiple maintainers
involved.
Just to make sure we understood you fully, do you want Chen-Yu to
resend his serie following your comments, or was that just a general
remark for next time?
Thanks!
Maxime
--
Maxime Ripard, Bootlin (form
On Wed, May 02, 2018 at 06:19:51PM +0800, Icenowy Zheng wrote:
>
>
> 于 2018年5月2日 GMT+08:00 下午5:53:21, Chen-Yu Tsai 写到:
> >On Wed, May 2, 2018 at 5:51 PM, Maxime Ripard
> > wrote:
> >> Hi,
> >>
> >> On Wed, May 02, 2018 at 12:12:27AM +080
ompatible. It's what was in the DT before, and
it's how it's called in the datasheet.
Otherwise, the whole serie looks good to me:
Acked-by: Maxime Ripard
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
signature.asc
Description: PGP signature
On Mon, Apr 16, 2018 at 10:51:55PM +0800, Chen-Yu Tsai wrote:
> On Mon, Apr 16, 2018 at 10:31 PM, Maxime Ripard
> wrote:
> > On Thu, Apr 12, 2018 at 11:23:30PM +0800, Chen-Yu Tsai wrote:
> >> On Thu, Apr 12, 2018 at 11:11 PM, Icenowy Zheng wrote:
> >> > 于 2018年4
On Thu, Apr 12, 2018 at 11:23:30PM +0800, Chen-Yu Tsai wrote:
> On Thu, Apr 12, 2018 at 11:11 PM, Icenowy Zheng wrote:
> > 于 2018年4月12日 GMT+08:00 下午10:56:28, Maxime Ripard
> > 写到:
> >>On Wed, Apr 11, 2018 at 10:16:39PM +0800, Icenowy Zheng wrote:
> >>> Fr
m-c";
> + reg = <0x 0x28000>;
> + };
> + };
That doesn't look related at all to what's being discussed here, so
you'd rather add it as part of your DE2-enablement serie (or amend
your commit log to say why this is important to do it in this patch).
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
signature.asc
Description: PGP signature
break
bisectability.
Chen-Yu's (or was it yours?) initial solution with a custom writeable
hook only allowing a single register seemed like a better one.
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
signature.asc
Description: PGP signature
1 - 100 of 195 matches
Mail list logo
