Hi Rob, Thanks for the review,
On Thu, May 23, 2019 at 08:10:22AM -0500, Rob Herring wrote: > > + fixed-link: > > + allOf: > > + - if: > > + type: array > > + then: > > + minItems: 1 > > + maxItems: 1 > > + items: > > + type: array > > + minItems: 5 > > + maxItems: 5 > > + description: > > + An array of 5 cells, with the following accepted values > > + - At index 0, the emulated PHY ID, choose any but but > > + unique to the all specified fixed-links, from 0 to 31 > > + - at index 1, duplex configuration with 0 for half duplex > > + or 1 for full duplex > > + - at index 2, link speed in Mbits/sec, accepted values are > > + 10, 100 and 1000 > > + - at index 3, pause configuration with 0 for no pause, 1 > > + for pause > > + - at index 4, asymmetric pause configuration with 0 for no > > + asymmetric pause, 1 for asymmetric pause > > Looks like constraints to me: > > items: > - minimum: 0 > maximum: 31 > - enum: [ 0, 1 ] > - enum: [ 10, 100, 1000 ] > ... Yeah, we should definitely do something like that. I tried and failed, but that looks like the right solution. > > + > > + > > + - if: > > Couldn't this be an 'else' and avoid the allOf? I don't really know, we could go both ways. Which one would be the more verbose in the case where someone would just have a boolean instead of the node or the array? Thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
