Hi, On Mon, Jun 10, 2019 at 01:22:00PM -0600, Rob Herring wrote: > On Mon, Jun 10, 2019 at 3:26 AM Maxime Ripard <maxime.rip...@bootlin.com> > wrote: > > + then: > > + properties: > > + allwinner,tx-delay-ps: > > + allOf: > > + - $ref: /schemas/types.yaml#definitions/uint32 > > Can drop this as anything with unit prefix has its type defined > already.
Not for picoseconds though. I'll send a PR to dt-schema if you prefer to define it there. > > > + - enum: [0, 100, 200, 300, 400, 500, 600, 700] > > + default: 0 > > + description: > > + External RGMII PHY TX clock delay chain value in ps. > > + > > + allwinner,rx-delay-ps: > > + allOf: > > + - $ref: /schemas/types.yaml#definitions/uint32 > > + - enum: > > + - 0 > > + - 100 > > + - 200 > > + - 300 > > + - 400 > > + - 500 > > + - 600 > > + - 700 > > + - 800 > > + - 900 > > + - 1000 > > + - 1100 > > + - 1200 > > + - 1300 > > + - 1400 > > + - 1500 > > + - 1600 > > + - 1700 > > + - 1800 > > + - 1900 > > + - 2000 > > + - 2100 > > + - 2200 > > + - 2300 > > + - 2400 > > + - 2500 > > + - 2600 > > + - 2700 > > + - 2800 > > + - 2900 > > + - 3000 > > + - 3100 > > I think you can do > > enum: [1, 2, 3, > 4, 5, 6] > > Or you can do: > > minimum: 0 > maximum: 3100 > multipleOf: 100 > > IIRC that multipleOf is a json-schema key. I really like that second syntax, thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
signature.asc
Description: PGP signature
