[PATCH 1/1] af_packet: Raw socket destruction warning fix

Signed-off-by: Vaneet Narang Signed-off-by: Amit Nagal Signed-off-by: Maninder Singh --- net/packet/af_packet.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c index 992396a..e6047e6 100644 --- a/net/packet/

Re: [PATCH] af_packet: Raw socket destruction warning fix

Hi Daniel, >The other sock_put() in packet_release() to drop the final ref and call into >sk_free(), which drops the 1 ref on the sk_wmem_alloc from init time. Since you >got into __sk_free() via sock_wfree() destructor, your socket must have invoked >packet_release() prior to this (perhaps kernel

Re: [PATCH 1/1] ath10k: fixing wrong initialization of struct channel

>> chandef is initialized with NULL and on the very next line, >> we are using it to get channel, which is not correct. >> >> channel should be initialized after obtaining chandef. >> >> Signed-off-by: Maninder Singh >How did you find this bug? Static an

[PATCH 1/1] ath10k: fixing wrong initialization of struct channel

chandef is initialized with NULL and on the very next line, we are using it to get channel, which is not correct. channel should be initialized after obtaining chandef. Signed-off-by: Maninder Singh --- drivers/net/wireless/ath/ath10k/mac.c |2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH 1/1] igb: Use ARRAY_SIZE instead fo sizeof(a)/sizeof(a[0])

Hi Joe, >> Use ARRAY_SIZE instead fo sizeof(a)/sizeof(a[0]) > >I think all of these #defines should be removed instead >as they are all used only once. If we replcase only ARRAY_SIZE then cood will look alike to drivers/net/ethernet/intel/e1000e/phy.c And if we have to remove these #defines , th

[PATCH 1/1] igb: Use ARRAY_SIZE instead fo sizeof(a)/sizeof(a[0])

Use ARRAY_SIZE instead fo sizeof(a)/sizeof(a[0]) Signed-off-by: Maninder Singh Reviewed-by: Yogesh Narayan Gaur --- drivers/net/ethernet/intel/igb/e1000_phy.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/intel/igb/e1000_phy.c b/drivers/net

[RFC][PATCH v2] ppp: remove NULL check before kfree

Removes NULL check before kfree and using tabs in place of space. and removing checkpatch warning: labels should not be indented. Signed-off-by: Maninder Singh Reviewed-by: Vaneet narang --- drivers/net/ppp/ppp_mppe.c | 24 +++- 1 file changed, 11 insertions(+), 13

Re: [PATCH 1/1] ppp: remove NULL check before kfree

>No need of explicit NULL check before kfree, >removing the same and little coding style changes. > >Signed-off-by: Maninder Singh >Reviewed-by: Vaneet narang >--- > drivers/net/ppp/ppp_mppe.c | 10 -- > 1 file changed, 4 insertions(+), 6 deletions(-) > &g

[PATCH 1/1] ppp: remove NULL check before kfree

No need of explicit NULL check before kfree, removing the same and little coding style changes. Signed-off-by: Maninder Singh Reviewed-by: Vaneet narang --- drivers/net/ppp/ppp_mppe.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/net/ppp/ppp_mppe.c b

[RFC PATCH v2] packet: remove handling of tx_ring

. Signed-off-by: Maninder Singh Suggested-by: Frans Klaver --- v1: replace if()/BUG with BUG_ON() for tx_ring v2: remove BUG() by removing tx_ring handling net/packet/af_packet.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/net/packet/af_packet.c b/net/packet

Re: [RFC PATCH v2] packet: remove handling of tx_ring

age of tx_ring. > >s,funciton,function, Thanks for feedback , please check below changelog if it looks ok, Then i will share updated patch:- v1 = replace if()/BUG with BUG_ON() for tx_ring. Signed-off-by: Maninder Singh Signed-off-by: Frans Klaver --- Changes in v2: Remove handling o

[RFC PATCH v2] packet: remove handling of tx_ring

tx_ring. Thus removing tx_ring from init_prb_bdqc. Signed-off-by: Maninder Singh Suggested-by: Frans Klaver --- net/packet/af_packet.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c index fd51641..aeafcf0

Re: [PATCH 1/1] ssb: remove unncessary out label

Hi Michael, >> pdev = bus->host_pci; >> mutex_init(&bus->sprom_mutex); >> -err = device_create_file(&pdev->dev, &dev_attr_ssb_sprom); >> -if (err) >> -goto out; >> - >> -out: >> -return err; >> +return device_create_file(&pdev->dev, &dev_attr_ssb_sprom); >> }

[PATCH 1/1] ssb: remove unncessary out label

This patch removes unnecessary label "out" and some restructring for using device_create_file directly. Signed-off-by: Maninder Singh Reviewed-by: Rohit Thapliyal --- drivers/ssb/pci.c |8 +--- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git a/drivers/ssb/pci.c

[PATCH 1/1] ixgbe: use kzalloc for allocating one thing

-by: Maninder Singh Reviewed-by: Vaneet Narang --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c index 3bf2f3c..3f58757 100644

Re: Re: [PATCH 1/1] net: replace if()/BUG with BUG_ON()

Hi David, >> Use BUG_ON(condition) instead of if(condition)/BUG() >> >> Signed-off-by: Maninder Singh >> Reviewed-by: Akhilesh Kumar >Your email client corrupted this patch, making it unusable I resent the patch with git send-mail , it results ok, hopefully it does not corrupt it. Thanks

[RESUBMIT Patch 1/1] net: replace if()/BUG with BUG_ON

Use BUG_ON(condition) instead of if(condition)/BUG() . Signed-off-by: Maninder Singh Reviewed-by: Akhilesh Kumar --- net/packet/af_packet.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c index b5989c6..c91d405 100644

[PATCH 1/1] net: replace if()/BUG with BUG_ON()

Use BUG_ON(condition) instead of if(condition)/BUG() Signed-off-by: Maninder Singh Reviewed-by: Akhilesh Kumar --- net/packet/af_packet.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c index b5989c6..c91d405 100644