[PATCH iproute2] iproute: fix printing resolved localhost

://bugs.debian.org/983591 Reported-by: Axel Scheepers Signed-off-by: Luca Boccassi --- ip/iproute.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/ip/iproute.c b/ip/iproute.c index 291f1a58..5853f026 100644 --- a/ip/iproute.c +++ b/ip/iproute.c @@ -796,9 +796,10 @@ int print_route

Re: [PATCH 2/2] iwlwifi: dbg: Mark ucode tlv data as const

ns already a couple > of times. > > This patch adds the const prefix to those cast pointers, so that such > attempt can be caught more easily in future. > > Signed-off-by: Takashi Iwai > Acked-by: Luca Coelho Patch applied to iwlwifi-next.git, thanks. 71b6254a6c98 iwlwifi: dbg: Mark ucode tlv data as const

Re: [PATCH iproute2] iproute get: force rtm_dst_len to 32/128

On Sun, 24 Jan 2021 at 17:26, David Ahern wrote: > > On 1/24/21 8:53 AM, Luca Boccassi wrote: > > Since NETLINK_GET_STRICT_CHK was enabled, the kernel rejects commands > > that pass a prefix length, eg: > > > > ip route get `1.0.0.0/1 > > Error: ipv4: In

[PATCH iproute2 v2] iproute: force rtm_dst_len to 32/128

;s no point in setting a rtm_dst_len that we know is going to be rejected, just force it to the right value if it's passed on the command line. Print a warning to stderr to notify users. Bug-Debian: https://bugs.debian.org/944730 Reported-By: Clément 'wxcafé' Hertling Signed-off-by: L

[PATCH iproute2] iproute get: force rtm_dst_len to 32/128

;s no point in setting a rtm_dst_len that we know is going to be rejected, just force it to the right value if it's passed on the command line. Bug-Debian: https://bugs.debian.org/944730 Reported-By: Clément 'wxcafé' Hertling Signed-off-by: Luca Boccassi --- As mentioned

[PATCH iproute2 2/2] vrf: fix ip vrf exec with libbpf

last insn is not an exit or jmp processed 0 insns (limit 100) max_states_per_insn 0 total_states 0 peak_states 0 mark_read 0 Kernel compiled with CGROUP_BPF enabled? https://bugs.debian.org/980046 Reported-by: Emmanuel DECAEN Signed-off-by: Luca Boccassi --- lib/bpf_glue.c | 3 ++- 1 file

[PATCH iproute2 1/2] vrf: print BPF log buffer if bpf_program_load fails

Necessary to understand what is going on when bpf_program_load fails Signed-off-by: Luca Boccassi --- ip/ipvrf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ip/ipvrf.c b/ip/ipvrf.c index 42779e5c..91578031 100644 --- a/ip/ipvrf.c +++ b/ip/ipvrf.c @@ -278,8 +278,8

Re: [PATCH iproute2 v2] tc/mqprio: json-ify output

On Wed, 2020-12-02 at 09:42 -0700, David Ahern wrote: > On 11/28/20 11:30 AM, Luca Boccassi wrote: > > @@ -287,9 +293,9 @@ static int mqprio_print_opt(struct qdisc_util *qu, FILE > > *f, struct rtattr *opt) > > return -1; > >

[PATCH v3] tc/mqprio: json-ify output

From: Luca Boccassi As reported by a Debian user, mqprio output in json mode is invalid: { "kind": "mqprio", "handle": "8021:", "dev": "enp1s0f0", "root": true, "options": { tc 2 map 0 0

Re: [RFC iproute2] tc/mqprio: json-ify output

On Sat, 2020-11-28 at 09:34 -0800, Stephen Hemminger wrote: > On Sat, 28 Nov 2020 12:17:00 + > Luca Boccassi wrote: > > > On Fri, 2020-11-27 at 21:21 -0800, Stephen Hemminger wrote: > > > On Fri, 27 Nov 2020 15:26:25 + > > > Luca Boccassi wrote: > &g

Re: [PATCH iproute2 v2] tc/mqprio: json-ify output

On Sat, 2020-11-28 at 12:21 +, Luca Boccassi wrote: > As reported by a Debian user, mqprio output in json mode is > invalid: > > { > "kind": "mqprio", > "handle": "8021:", > "dev": "enp1s0f0",

[PATCH iproute2 v2] tc/mqprio: json-ify output

ot;options": { "tc": 2, "map": [ 0, 0, 0, 1, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 ], "queues": [ [ 0, 3 ], [ 4, 7 ] ], "mode": "channel", "shaper": "dcb" } } https://bugs.debian.org/

Re: [RFC iproute2] tc/mqprio: json-ify output

On Fri, 2020-11-27 at 21:21 -0800, Stephen Hemminger wrote: > On Fri, 27 Nov 2020 15:26:25 + > Luca Boccassi wrote: > > > As reported by a Debian user, mqprio output in json mode is > > invalid: > > > > { > > "kind": "mqprio&q

[PATCH iproute2 v2] tc/mqprio: json-ify output

0 0 0 0 queues:(0:3) (4:7) mode:channel shaper:dcb} } json-ify it, while trying to maintain the same formatting for standard output. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=972784 Reported-by: Roméo GINON Signed-off-by: Luca Boccassi --- v1: I do not ha

[PATCH iproute2] ip/netns: use flock when setting up /run/netns

eproduces, to add an artificial synchronization point after the first mount(). Reported-by: Etienne Dechamps Signed-off-by: Luca Boccassi --- ip/ipnetns.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/ip/ipnetns.c b/ip/ipnetns.c index 14e8e087..3e96d267 100

[PATCH iproute2] Add dcb/.gitignore

Signed-off-by: Luca Boccassi --- dcb/.gitignore | 1 + 1 file changed, 1 insertion(+) create mode 100644 dcb/.gitignore diff --git a/dcb/.gitignore b/dcb/.gitignore new file mode 100644 index ..3f26856c --- /dev/null +++ b/dcb/.gitignore @@ -0,0 +1 @@ +dcb -- 2.29.2

[RFC iproute2] tc/mqprio: json-ify output

0 0 0 0 queues:(0:3) (4:7) mode:channel shaper:dcb} } json-ify it, while trying to maintain the same formatting for standard output. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=972784 Signed-off-by: Luca Boccassi --- I do not have hardware where I can configure mq

Re: [PATCH v2 00/29] [Set 1,2,3] Rid W=1 warnings in Wireless

gt; wil6210: wil_platform: Demote kernel-doc header to standard comment > > > > > block > > > > > wil6210: wmi: Correct misnamed function parameter 'ptr_' > > > > > ath6kl: wmi: Remove unused variable 'rate' > > > > > ath9

Re: [PATCH] dt-bindings: Whitespace clean-ups in schema files

Hi, On 14/08/20 16:51, Rob Herring wrote: > On Thu, Aug 13, 2020 at 4:31 AM Luca Ceresoli wrote: >> >> Hi Rob, >> >> On 12/08/20 22:36, Rob Herring wrote: >>> Clean-up incorrect indentation, extra spaces, long lines, and missing >>> EOF newline in sch

Re: [PATCH] dt-bindings: Whitespace clean-ups in schema files

ous écris une longue lettre parce que >je n'ai pas le temps d'en écrire une courte. > > the following code snippet would FAIL: > > Blaise Pascal: Je vous écris une longue lettre parce que > je n'ai pas le temps d'en écrire une courte. > (https://yamllint.readthedocs.io/en/stable/rules.html#module-yamllint.rules.indentation) -- Luca

Re: [PATCH] iwlwifi: mvm: Remove unused inline function iwl_mvm_tid_to_ac_queue

YueHaibing wrote: > commit cfbc6c4c5b91 ("iwlwifi: mvm: support mac80211 TXQs model") > left behind this, remove it. > > Signed-off-by: YueHaibing Patch applied to iwlwifi-next.git, thanks. f12694634153 iwlwifi: mvm: Remove unused inline function iwl_mvm_tid_to_ac_queue

Re: [PATCH 6/9] net: wireless: intel: fix wiki website url

Flavio Suligoi wrote: > In some Intel files, the wiki url is still the old > "wireless.kernel.org" instead of the new > "wireless.wiki.kernel.org" > > Signed-off-by: Flavio Suligoi Patch applied to iwlwifi-next.git, thanks. e00c6d8d491b net: wireless: intel: fix wiki website url

Re: [PATCH] iwlwifi: remove redundant assignment to variable bufsz

erity: ("Unused value") > Signed-off-by: Colin Ian King > --- Thanks! I applied this to our internal tree and it will reach the mainline following our usual upstreaming process. -- Cheers, Luca.

Re: [PATCH 3/8] dt-bindings: net: bluetooth: Add rtl8723bs-bluetooth

mmers has already written [1], the existing code [2] takes this "postfix" as parameter and basically fills it into a filename template ("${CFG_NAME}-${POSTFIX}.bin"). So either we stay with the "firmware-postfix" property or the existing code would have to be

Re: [PATCH] net: macb: fix error format in dev_err()

Hi Andrew, On 14/05/19 14:35, Andrew Lunn wrote: > On Tue, May 14, 2019 at 09:14:50AM +0200, Luca Ceresoli wrote: >> Errors are negative numbers. Using %u shows them as very large positive >> numbers such as 4294967277 that don't make sense. Use the %d format >> instead

[PATCH net RESEND] net: macb: fix error format in dev_err()

Errors are negative numbers. Using %u shows them as very large positive numbers such as 4294967277 that don't make sense. Use the %d format instead, and get a much nicer -19. Signed-off-by: Luca Ceresoli Fixes: b48e0bab142f ("net: macb: Migrate to devm clock interface") Fixes: 93b

[PATCH] net: macb: fix error format in dev_err()

Errors are negative numbers. Using %u shows them as very large positive numbers such as 4294967277 that don't make sense. Use the %d format instead, and get a much nicer -19. Signed-off-by: Luca Ceresoli --- drivers/net/ethernet/cadence/macb_main.c | 16 1 file chang

Re: [PATCH] iwlwifi: trans: fix killer series loadded incorrect firmware

ans->cfg != &killer1650w_2ax_cfg) || > trans->hw_rev == CSR_HW_REV_TYPE_QNJ_B0)) { > u32 hw_status; > Thanks for your patch, Cyrus! We already have an identical patch in our internal tree and it will reach the mainline soon. -- Cheers, Luca.

Re: [PATCH] net: wireless: iwlwifi: Fix double-free problems in iwl_req_fw_callback()

; Thanks! Applied to our internal tree and will reach the mainline following our normal upstreaming process. -- Cheers, Luca.

Re: linux-next: manual merge of the bpf-next tree with the net tree

On Wed, 2019-03-27 at 18:53 -0700, Alexei Starovoitov wrote: > On Wed, Mar 27, 2019 at 8:15 AM Alexei Starovoitov > < > alexei.starovoi...@gmail.com > > wrote: > > then get propagated into net-next and then bpf-next will get them > > as well. > > Now it'

[PATCH bpf-next v8] tools/bpf: generate pkg-config file for libbpf

From: Luca Boccassi Generate a libbpf.pc file at build time so that users can rely on pkg-config to find the library, its CFLAGS and LDFLAGS. Signed-off-by: Luca Boccassi Acked-by: Andrey Ignatov --- v2: use QUIET_GEN instead of QUIET_LINK to generate pc file, save kernel version in its

Re: [PATCH bpf-next v7] tools/bpf: generate pkg-config file for libbpf

On Tue, 2019-03-26 at 13:12 -0700, Alexei Starovoitov wrote: > On Thu, Mar 21, 2019 at 4:09 PM < > luca.bocca...@gmail.com > > wrote: > > From: Luca Boccassi < > > bl...@debian.org > > > > > > > Generate a libbpf.pc file at build time so that u

Re: [PATCH bpf-next v6] tools/bpf: generate pkg-config file for libbpf

On Thu, 2019-03-21 at 15:43 -0700, Alexei Starovoitov wrote: > On Thu, Mar 21, 2019 at 10:33:17PM +, luca.bocca...@gmail.com > wrote: > > From: Luca Boccassi > > > > Generate a libbpf.pc file at build time so that users can rely > > on pkg-config to find the l

[PATCH bpf-next v7] tools/bpf: generate pkg-config file for libbpf

From: Luca Boccassi Generate a libbpf.pc file at build time so that users can rely on pkg-config to find the library, its CFLAGS and LDFLAGS. Signed-off-by: Luca Boccassi Acked-by: Andrey Ignatov --- v2: use QUIET_GEN instead of QUIET_LINK to generate pc file, save kernel version in its

Re: [PATCH bpf-next v4] tools/bpf: generate pkg-config file for libbpf

On Thu, 2019-03-21 at 23:19 +0100, Daniel Borkmann wrote: > On 03/21/2019 11:01 PM, Alexei Starovoitov wrote: > > On Thu, Mar 21, 2019 at 04:00:46PM +, Andrey Ignatov wrote: > > > luca.bocca...@gmail.com [Thu, 2019-03- > > > 21 03:26 -0700]:

[PATCH bpf-next v6] tools/bpf: generate pkg-config file for libbpf

From: Luca Boccassi Generate a libbpf.pc file at build time so that users can rely on pkg-config to find the library, its CFLAGS and LDFLAGS. Signed-off-by: Luca Boccassi Acked-by: Andrey Ignatov --- v2: use QUIET_GEN instead of QUIET_LINK to generate pc file, save kernel version in its

[PATCH bpf-next v5] tools/bpf: generate pkg-config file for libbpf

From: Luca Boccassi Generate a libbpf.pc file at build time so that users can rely on pkg-config to find the library, its CFLAGS and LDFLAGS. Signed-off-by: Luca Boccassi Acked-by: Andrey Ignatov --- v2: use QUIET_GEN instead of QUIET_LINK to generate pc file, save kernel version in its

Re: [PATCH bpf-next v4] tools/bpf: generate pkg-config file for libbpf

On Thu, 2019-03-21 at 15:01 -0700, Alexei Starovoitov wrote: > On Thu, Mar 21, 2019 at 04:00:46PM +, Andrey Ignatov wrote: > > luca.bocca...@gmail.com [Thu, 2019-03-21 > > 03:26 -0700]: > > > From: Luca Boccassi > > > > > > Generate a libbpf.pc

netfilter: missing correlation checks on icmp[v6] errors before applying IP_CT_RELATED

ind_get(state->net, zone, &innertuple); > if (!h) { > pr_debug("icmp_error_message: no match\n"); > return -NF_ACCEPT; > } > > if (NF_CT_DIRECTION(h) == IP_CT_DIR_REPLY) > ctinfo += IP_CT_IS_REPLY; > > /* Update skb to refer to this connection */ > nf_ct_set(skb, nf_ct_tuplehash_to_ctrack(h), ctinfo); > return NF_ACCEPT; > } Best Regards. Luca Moro Synacktiv

Re: [PATCH bpf-next v3] tools/bpf: generate pkg-config file for libbpf

On Wed, 2019-03-20 at 23:58 +, Andrey Ignatov wrote: > luca.bocca...@gmail.com [Wed, 2019-03-20 > 06:28 -0700]: > > From: Luca Boccassi > > > > Generate a libbpf.pc file at build time so that users can rely > > on pkg-config to find the library, its CFLAGS an

[PATCH bpf-next v4] tools/bpf: generate pkg-config file for libbpf

From: Luca Boccassi Generate a libbpf.pc file at build time so that users can rely on pkg-config to find the library, its CFLAGS and LDFLAGS. Signed-off-by: Luca Boccassi --- v2: use QUIET_GEN instead of QUIET_LINK to generate pc file, save kernel version in its own variable instead of

Re: [PATCH bpf-next v2] tools/bpf: generate pkg-config file for libbpf

On Wed, 2019-03-20 at 10:21 -0700, Stanislav Fomichev wrote: > On 03/20, Luca Boccassi wrote: > > On Wed, 2019-03-20 at 13:22 +0000, Luca Boccassi wrote: > > > On Tue, 2019-03-19 at 16:17 -0700, Stanislav Fomichev wrote: > > > > On 03/19, Luca Boccassi wrote: > >

Re: [PATCH bpf-next v2] tools/bpf: generate pkg-config file for libbpf

On Wed, 2019-03-20 at 13:22 +, Luca Boccassi wrote: > On Tue, 2019-03-19 at 16:17 -0700, Stanislav Fomichev wrote: > > On 03/19, Luca Boccassi wrote: > > > Generate a libbpf.pc file at build time so that users can rely > > > on pkg-config to find the libr

[PATCH bpf-next v3] tools/bpf: generate pkg-config file for libbpf

From: Luca Boccassi Generate a libbpf.pc file at build time so that users can rely on pkg-config to find the library, its CFLAGS and LDFLAGS. Signed-off-by: Luca Boccassi --- v2: use QUIET_GEN instead of QUIET_LINK to generate pc file, save kernel version in its own variable instead of

Re: [PATCH bpf-next v2] tools/bpf: generate pkg-config file for libbpf

On Tue, 2019-03-19 at 16:17 -0700, Stanislav Fomichev wrote: > On 03/19, Luca Boccassi wrote: > > Generate a libbpf.pc file at build time so that users can rely > > on pkg-config to find the library, its CFLAGS and LDFLAGS. > > > > Signed-off-by: Luca Boccassi &g

Re: [PATCH bpf-next] tools/bpf: generate pkg-config file for libbpf

On Tue, 2019-03-19 at 14:23 -0700, Stanislav Fomichev wrote: > On 03/19, Luca Boccassi wrote: > > Generate a libbpf.pc file at build time so that users can rely > > on pkg-config to find the library, its CFLAGS and LDFLAGS. > > > > Signed-off-by: Luca Boccassi

[PATCH bpf-next v2] tools/bpf: generate pkg-config file for libbpf

Generate a libbpf.pc file at build time so that users can rely on pkg-config to find the library, its CFLAGS and LDFLAGS. Signed-off-by: Luca Boccassi --- v2: use QUIET_GEN instead of QUIET_LINK to generate pc file, save kernel version in its own variable instead of calling make inline

[PATCH bpf-next] tools/bpf: generate pkg-config file for libbpf

Generate a libbpf.pc file at build time so that users can rely on pkg-config to find the library, its CFLAGS and LDFLAGS. Signed-off-by: Luca Boccassi --- tools/lib/bpf/.gitignore | 1 + tools/lib/bpf/Makefile | 18 +++--- tools/lib/bpf/libbpf.pc.template | 11

Re: [PATCH] iwlwifi: fix 64-bit division

the simpler div_s64() that can handle > > negative inputs correctly. > > > > Fixes: 937b10c0de68 ("iwlwifi: mvm: add debug prints for FTM") > > Signed-off-by: Arnd Bergmann > > Luca, can I take this directly? Yeah, I guess to make things simpler, and since you're planning to send fixes to 5.1 already anyway, you can just take this one. I'll assign it to you in patchwork. Arnd, this way you'll get it earlier. ;) -- Cheers, Luca.

Re: [PATCH] iwlwifi: mvm: Use div64_s64 instead of do_div in iwl_mvm_debug_range_resp

arithmetic signed (even when working with non zero values), so rather > than make the literal () a unsigned long, I agree with your > change > to keep the division signed as well. Thanks for the fix. > Reviewed-by: Nick Desaulniers Thanks for the patch and for the review. I've applied this to our internal tree and it will be sent upstreaming following our normal upstreaming process. -- Cheers, Luca.

[RFC iproute2 v2] ip route: get: allow zero-length subnet mask

1.0.0.0/0 1.0.0.0 via 192.168.1.1 dev eth0 src 192.168.1.91 uid 1000 cache Reported-by: Clément Hertling Signed-off-by: Luca Boccassi --- v2: changed the check instead of removing it, so that "ip route get" fails since the address is a mandatory parameter according to the manpage

[RFC iproute2] ip route: get: allow zero-length subnet mask

ed-by: Clément Hertling Signed-off-by: Luca Boccassi --- Stephen et al, this was reported by a Debian user: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=921737 It makes sense to me at a cursory glance, but sending as RFC as I'm not 100% familiar with the route get function. ip/ipr

Re: [PATCH] net: wireless: prefix header search paths with $(srctree)/

kefile | 6 +++- > > -- > > drivers/net/wireless/broadcom/brcm80211/brcmutil/Makefile | 4 +--- > > drivers/net/wireless/intel/iwlwifi/dvm/Makefile | 2 +- > > drivers/net/wireless/intel/iwlwifi/mvm/Makefile | 2 +- > > drivers/net/wireless/realtek/r

Re: [PATCH] iwlwifi: fix false-positive maybe-uninitialized warning

off-by: Arnd Bergmann > --- Thanks! This has been applied in our internal tree and will reach the mainline following our normal upstreaming process. -- Cheers, Luca.

[PATCH iproute2 1/3] man: ss.8: more line breaks

groff stiff complains about unbreakable lines: 96: warning [p 2, 3.0i]: can't break line Indent it some more. Fixes: 7f5047524c99 ("man: ss.8: break and indent long line") Signed-off-by: Luca Boccassi --- man/man8/ss.8 | 10 -- 1 file changed, 8 insertions(+), 2 del

[PATCH iproute2 3/3] Makefile: check manpages for syntax errors

Pass the same parameters Lintian uses in Debian. $ make check <...> Checking manpages for syntax errors... :48: warning: macro `Q' not defined Error in tc-taprio.8 Makefile:27: recipe for target 'check' failed Signed-off-by: Luca Boccassi --- As far as I can see all th

[PATCH iproute2 2/3] man: tc-taprio.8: fix syntax error

.Q does not exist so groff complains and the "queues" word is actually not displayed. Fixes: 579acb4bc52f ("taprio: Add manpage for tc-taprio(8)") Signed-off-by: Luca Boccassi --- man/man8/tc-taprio.8 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ma

Re: linux-next: build warnings after merge of the wireless-drivers-next tree

t; Introduced by commit > > > > > > > > f14cda6f3b31 ("iwlwifi: trans: parse and store debug ini TLVs") > > > > > > > > These are noted because I use -Wimplict-fallthrough > > > > > > > > The warnings can be sup

Re: [PATCH iproute2 v2 4/4] testsuite: remove gre kmods if the test loads them

On Sun, 2018-12-16 at 21:21 +0100, Petr Vorel wrote: > Hi Luca, > > Reviewed-by: Petr Vorel > LGTM, but I'd suggest 2 small changes (see bellow). > > > +++ b/testsuite/tests/ip/tunnel/add_tunnel.t > >  TUNNEL_NAME="tunnel_test_ip" > > I'

[PATCH iproute2 v3 4/4] testsuite: remove gre kmods if the test loads them

purposes. Signed-off-by: Luca Boccassi Reviewed-by: Petr Vorel --- v2: applied suggestions from Petr to simplify the modules parsing/unloading v3: ditto, added reviewed-by tag testsuite/tests/ip/tunnel/add_tunnel.t | 13 + 1 file changed, 13 insertions(+) diff --git a/testsuite/tests/ip

[PATCH iproute2 v3 2/4] testsuite: declare dependency between $(TESTS) and generate_nlmsg

vf_rate.t] Error 127 CC generate_nlmsg Makefile:123: recipe for target 'check' failed make: *** [check] Error 2 Add an explicit dependency in testuite/Makefile's $(TESTS) rule so that the tool correctly gets compiled before any test runs. Fixes: 3537633dcf44 ("testsuite:

[PATCH iproute2 v3 3/4] testsuite: delete dummy interface after default route test

Signed-off-by: Luca Boccassi Reviewed-by: Petr Vorel --- v2: fixed copypasta in log message v3: added reviewed-by tag testsuite/tests/ip/route/add_default_route.t | 2 ++ 1 file changed, 2 insertions(+) diff --git a/testsuite/tests/ip/route/add_default_route.t b/testsuite/tests/ip/route

[PATCH iproute2 v3 1/4] Makefile: have check target depend on all

../../config.mk: No such file or directory make[2]: *** No rule to make target '../../config.mk'. Stop. Fixes: 8804a8c0d387 ("Makefile: Add check target") Signed-off-by: Luca Boccassi Reviewed-by: Petr Vorel Tested-by: Petr Vorel --- v2: added reviewed/tested-by tags, removed Cc

Re: [PATCH iproute2 3/4] tests: delete dummy interface after default route test

On Sat, 2018-12-15 at 17:32 +0100, Petr Vorel wrote: > Hi Luca, > > > Signed-off-by: Luca Boccassi > > Reviewed-by: Petr Vorel > > --- > >  testsuite/tests/ip/route/add_default_route.t | 2 ++ > >  1 file changed, 2 insertions(+) > > diff --git a/te

Re: [PATCH iproute2 4/4] testsuite: remove gre kmods if the test loads them

On Sat, 2018-12-15 at 18:37 +0100, Petr Vorel wrote: > Hi Luca, > > > The tunnel test leaves behind link devices created by the GRE > > kernel > > modules: > > $ ip -br link > > ... > > gre0@NONEDOWN 0.0.0.0 > > gretap0@NONE DOWN 00:00:00:0

[PATCH iproute2 v2 3/4] testsuite: delete dummy interface after default route test

Signed-off-by: Luca Boccassi --- v2: fixed copypasta in log message testsuite/tests/ip/route/add_default_route.t | 2 ++ 1 file changed, 2 insertions(+) diff --git a/testsuite/tests/ip/route/add_default_route.t b/testsuite/tests/ip/route/add_default_route.t index 569ba1f8..ded4edc3 100755

[PATCH iproute2 v2 1/4] Makefile: have check target depend on all

../../config.mk: No such file or directory make[2]: *** No rule to make target '../../config.mk'. Stop. Fixes: 8804a8c0d387 ("Makefile: Add check target") Signed-off-by: Luca Boccassi Reviewed-by: Petr Vorel Tested-by: Petr Vorel --- v2: added reviewed/tested-by tags, removed Cc

[PATCH iproute2 v2 4/4] testsuite: remove gre kmods if the test loads them

purposes. Signed-off-by: Luca Boccassi Reviewed-by: Petr Vorel --- v2: applied suggestions from Petr to simplify the modules parsing/unloading testsuite/tests/ip/tunnel/add_tunnel.t | 13 + 1 file changed, 13 insertions(+) diff --git a/testsuite/tests/ip/tunnel/add_tunnel.t b/testsuite

[PATCH iproute2 v2 2/4] testsuite: declare dependency between $(TESTS) and generate_nlmsg

vf_rate.t] Error 127 CC generate_nlmsg Makefile:123: recipe for target 'check' failed make: *** [check] Error 2 Add an explicit dependency in testuite/Makefile's $(TESTS) rule so that the tool correctly gets compiled before any test runs. Fixes: 3537633dcf44 ("testsuite:

[PATCH iproute2 4/4] testsuite: remove gre kmods if the test loads them

purposes. Signed-off-by: Luca Boccassi --- testsuite/tests/ip/tunnel/add_tunnel.t | 24 1 file changed, 24 insertions(+) diff --git a/testsuite/tests/ip/tunnel/add_tunnel.t b/testsuite/tests/ip/tunnel/add_tunnel.t index 3f5a9d3c..76f8b011 100755 --- a/testsuite/tests/ip

[PATCH iproute2 2/4] testsuite: declare dependency between $(TESTS) and generate_nlmsg

vf_rate.t] Error 127 CC generate_nlmsg Makefile:123: recipe for target 'check' failed make: *** [check] Error 2 Add an explicit dependency in testuite/Makefile's $(TESTS) rule so that the tool correctly gets compiled before any test runs. Fixes: 3537633dcf44 ("tes

[PATCH iproute2 3/4] tests: delete dummy interface after default route test

Signed-off-by: Luca Boccassi --- testsuite/tests/ip/route/add_default_route.t | 2 ++ 1 file changed, 2 insertions(+) diff --git a/testsuite/tests/ip/route/add_default_route.t b/testsuite/tests/ip/route/add_default_route.t index 569ba1f8..c536e35f 100755 --- a/testsuite/tests/ip/route

[PATCH iproute2 1/4] Makefile: have check target depend on all

../../config.mk: No such file or directory make[2]: *** No rule to make target '../../config.mk'. Stop. Fixes: 8804a8c0d387 ("Makefile: Add check target") Cc: petr.vo...@gmail.com Signed-off-by: Luca Boccassi --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH iproute2] testsuite: correctly use CC macros for generate_nlmsg

It's $(QUIET_CC)$(CC) not $(QUIET_CC), copy-paste error. CI does verbose build so it slipped through. Fixes: 6e7d347aabbb ("testsuite: build generate_nlmsg with QUIET_CC") Signed-off-by: Luca Boccassi --- testsuite/tools/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 de

[PATCH iproute2 v2] Fix warning in tc-skbprio.8 manpage

". If" gets interpreted as a macro, so move the period to the previous line: 33: warning: macro `If' not defined Fixes: 141b55f8544e ("Add SKB Priority qdisc support in tc(8)") Signed-off-by: Luca Boccassi --- v2: remove extra space to avoid making the full-stop bold

Re: [PATCH iproute2] Fix warning in tc-skbprio.8 manpage

On Fri, 2018-11-02 at 15:19 +, Edward Cree wrote: > On 02/11/18 10:57, Luca Boccassi wrote: > > ". If" gets interpreted as a macro, so move the period to the > > previous > > line: > > > >   33: warning: macro `If' not defined > > >

[PATCH iproute2] man: ss.8: break and indent long line

Fixes groff warning: ss.8 92: warning [p 2, 2.8i]: can't break line And makes the line also more readable. Signed-off-by: Luca Boccassi --- This line is the example of an output, so you might not want to break it. Let me know if you prefer a different solution. man/man8/ss.8 | 8 ++

[PATCH iproute2 1/2] testsuite: build generate_nlmsg with QUIET_CC

Follow the standard pattern, and respect user's verbosity setting. Signed-off-by: Luca Boccassi --- testsuite/tools/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testsuite/tools/Makefile b/testsuite/tools/Makefile index e1d9bfef..85df69ec 100644 --- a/test

[PATCH iproute2 2/2] Pass CPPFLAGS to the compiler

When building Debian packages pre-processor flags are passed via CPPFLAGS, as the convention indicates. Specifically, the hardening -D_FORTIFY_SOURCE=2 flag is used. Pass CPPFLAGS to all calls of QUIET_CC together with CFLAGS. Signed-off-by: Luca Boccassi --- configure | 2 +- misc/Makefile

[PATCH iproute2] Fix warning in tc-skbprio.8 manpage

". If" gets interpreted as a macro, so move the period to the previous line: 33: warning: macro `If' not defined Fixes: 141b55f8544e ("Add SKB Priority qdisc support in tc(8)") Signed-off-by: Luca Boccassi --- man/man8/tc-skbprio.8 | 4 ++-- 1 file changed, 2 i

[PATCH iproute2] Include bsd/string.h only in include/utils.h

lable") Signed-off-by: Luca Boccassi --- genl/ctrl.c | 3 --- include/utils.h | 4 ip/iplink.c | 3 --- ip/ipnetns.c | 3 --- ip/iproute_lwtunnel.c | 3 --- ip/ipvrf.c| 3 --- ip/ipxfrm.c | 3 --- ip/tunnel.c | 3 --- ip/xf

[PATCH iproute2 v2] Use libbsd for strlcpy if available

If libc does not provide strlcpy check for libbsd with pkg-config to avoid relying on inline version. Signed-off-by: Luca Boccassi --- Changed from -include /usr/include/bsd/string.h hack to HAVE_LIBBSD and proper includes in each file that uses strlcpy. The hack causes a compiler warning as ip

Re: [PATCH iproute2] Use libbsd for strlcpy if available

On Wed, 2018-10-31 at 08:09 -0700, Stephen Hemminger wrote: > On Mon, 29 Oct 2018 10:46:50 + > Luca Boccassi wrote: > > > If libc does not provide strlcpy check for libbsd with pkg-config > > to > > avoid relying on inline version. > > > > Signed-

Re: [PATCH iproute2] Use libbsd for strlcpy if available

On Mon, 2018-10-29 at 09:27 -0600, David Ahern wrote: > On 10/29/18 4:46 AM, Luca Boccassi wrote: > > If libc does not provide strlcpy check for libbsd with pkg-config > > to > > avoid relying on inline version. > > > > Signed-off-by: Luca Boccassi > > --

[PATCH iproute2] Use libbsd for strlcpy if available

If libc does not provide strlcpy check for libbsd with pkg-config to avoid relying on inline version. Signed-off-by: Luca Boccassi --- This allows distro maintainers to be able to choose to reduce duplication and let this code be maintained in one place, in the external library. configure | 12

Re: [PATCH iproute2 v2 0/3] testsuite: make alltests fixes

te generate_nlmsg when needed >   testsuite: Warn about empty $(IPVERS) > >  testsuite/Makefile | 21 ++--- >  1 file changed, 14 insertions(+), 7 deletions(-) Series-tested-by: Luca Boccassi -- Kind regards, Luca Boccassi signature.asc Description: This is a digitally signed message part

Re: [PATCH] iprule: Fix destination prefix output

ot;, NULL); >   print_color_string(PRINT_ANY, ifa_family_color(frh- > >family), > -    "dst", "%s ", dst); > +    "dst", "%s", dst); >   if (frh->dst_len != host_len) >  

Re: [PATCH iproute2 1/3] testsuite: remove all temp files and implement make clean

On Thu, 2018-08-23 at 09:07 +0200, Stefan Bader wrote: > On 22.08.2018 20:09, Luca Boccassi wrote: > > Some generated test files were not removed, including one > > executable in > > the testsuite/tools directory. > > Ensure make clean from the top level directory

[PATCH iproute2 3/3] testsuite: run dmesg with sudo

Some distributions like Debian nowadays restrict the dmesg command to root-only. Run it with sudo in the testsuite. Signed-off-by: Luca Boccassi --- testsuite/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testsuite/Makefile b/testsuite/Makefile index 5e269877

[PATCH iproute2 2/3] testsuite: let make compile build the netlink helper

The generate_nlmsg binary is required but make -C testsuite compile does not build it. Add the necessary includes and C*FLAGS to the tools Makefile and have the compile target build it. Signed-off-by: Luca Boccassi --- testsuite/Makefile | 1 + testsuite/tools/Makefile | 4 +++- 2 files

[PATCH iproute2 1/3] testsuite: remove all temp files and implement make clean

Some generated test files were not removed, including one executable in the testsuite/tools directory. Ensure make clean from the top level directory works for the testsuite subdirs too, and that all the files are removed. Signed-off-by: Luca Boccassi --- Makefile | 2

Re: [PATCH] testsuite: Handle large number of kernel options

file | 16 +++- >  1 file changed, 11 insertions(+), 5 deletions(-) > > diff --git a/testsuite/Makefile b/testsuite/Makefile > index 8fcbc55..f9f3b19 100644 Acked-by: Luca Boccassi Looks good to me, thanks. -- Kind regards, Luca Boccassi signature.asc Description: This is a digitally signed message part

Re: [PATCH 07/33] iwlwifi: mvm: use match_string() helper

return -EINVAL; > > ret = 0; Looks fine, I'll push this to our internal tree for review and take a closer look at what the match_string() function does exactly. Thanks for the patch. -- Cheers, Luca.

Re: [iproute2] Bug#898840: Latest update breaks ip6 default gateway cli api

On Wed, 2018-05-16 at 16:53 +0200, Michal Kubecek wrote: > On Wed, May 16, 2018 at 02:42:24PM +0100, Luca Boccassi wrote: > > Hans reported a regression in v4.16.0, ip route now requires -6 to > > be > > manually added when using v6 addresses while up to 4.15 it didn't, &

Re: [iproute2] Bug#898840: Latest update breaks ip6 default gateway cli api

y introduced the problem: 93fa12418dc6f5943692250244be303bb162175b utils: Always specify family and ->bytelen in get_prefix_1() Could you please have a look when you have a moment? It's very easy to reproduce, and it breaks existing scripts and so on. Thanks! -- Kind regards, Luca Boccassi signature.asc Description: This is a digitally signed message part

[PATCH iproute2] ip: do not drop capabilities if net_admin=i is set

ng ip exec vrf with libcap") Signed-off-by: Luca Boccassi --- Reported on Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=898015 The reporter tested this patch and verified it solves the issue. lib/utils.c | 15 --- man/man8/ip-vrf.8 | 4 2 files c

Re: [PATCH][next] iwlwifi: mvm: remove division by size of sizeof(struct ieee80211_wmm_rule)

s, Colin! I've pushed this to our internal tree for review and if everything goes fine it will land upstream following our normal upstreaming process. -- Cheers, Luca.

[PATCH iproute2 v1] Drop capabilities if not running ip exec vrf with libcap

capabilities on start if not invoked with "vrf exec". Update the manpage with the requirements. Signed-off-by: Luca Boccassi --- Changes since RFC: moved drop_cap to lib/util.c to call it from ipvrf.c after vrf_switch, which is the function that requires the additional permissions, ha

Re: [RFC PATCH iproute2] Drop capabilities if not running ip exec vrf with libcap

On Tue, 2018-03-27 at 10:15 -0700, Stephen Hemminger wrote: > On Tue, 27 Mar 2018 17:24:19 +0100 > Luca Boccassi wrote: > > > ip vrf exec requires root or CAP_NET_ADMIN, CAP_SYS_ADMIN and > > CAP_DAC_OVERRIDE. It is not possible to run unprivileged commands > > like

Re: [RFC PATCH iproute2] Drop capabilities if not running ip exec vrf with libcap

On Tue, 2018-03-27 at 10:40 -0600, David Ahern wrote: > On 3/27/18 10:24 AM, Luca Boccassi wrote: > > ip vrf exec requires root or CAP_NET_ADMIN, CAP_SYS_ADMIN and > > CAP_DAC_OVERRIDE. It is not possible to run unprivileged commands > > like > > ping as non-root or

  1   2   >