From: Randy Dunlap
Date: Oct/15/2020, 15:45:57 (UTC+00:00)
> On 10/15/20 12:28 AM, Stephen Rothwell wrote:
> > Hi all,
> >
> > Since the merge window is open, please do not add any v5.11 material to
> > your linux-next included branches until after v5.10-rc1 has been released.
> >
> > News: the
From: Russell King - ARM Linux admin
Date: Jun/05/2020, 18:10:34 (UTC+00:00)
> This is incorrect - you should not mask the link partner's advertisement
> with our advertisement like this; consider the table in 802.3 for
> resolving the pause modes, where simply doing a bitwise-and operation
> bet
From: Biao Huang
Date: Jun/09/2020, 10:41:33 (UTC+00:00)
> - rx_q->rx_count_frames += priv->rx_coal_frames;
> - if (rx_q->rx_count_frames > priv->rx_coal_frames)
> + if (rx_q->rx_count_frames >= priv->rx_coal_frames)
This is no right. If you want to RX IC bit
The VID is converted to le16 so the variable must be __le16 type.
Reported-by: kbuild test robot
Fixes: c7ab0b8088d7 ("net: stmmac: Fallback to VLAN Perfect filtering if HASH
is not available")
Signed-off-by: Jose Abreu
---
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
Cc: Jose
From: Thierry Reding
Date: Sep/25/2019, 23:46:20 (UTC+00:00)
> On Wed, Sep 25, 2019 at 10:31:13AM -0700, Florian Fainelli wrote:
> > The way I would approach it (as done in bcmgenet.c) is that if the
> > platform both has CONFIG_PHYS_ADDR_T_64BIT=y and supports > 32-bits
> > addresses, then you w
From: Jose Abreu
Date: Sep/25/2019, 12:41:04 (UTC+00:00)
> From: David Miller
> Date: Sep/25/2019, 12:33:53 (UTC+00:00)
>
> > From: Jose Abreu
> > Date: Wed, 25 Sep 2019 10:44:53 +
> >
> > > From: David Miller
> > > Date: Sep/24/2019, 20:
From: David Miller
Date: Sep/25/2019, 12:33:53 (UTC+00:00)
> From: Jose Abreu
> Date: Wed, 25 Sep 2019 10:44:53 +
>
> > From: David Miller
> > Date: Sep/24/2019, 20:45:08 (UTC+00:00)
> >
> >> From: Thierry Reding
> >> Date: Fri, 20 Sep 20
From: David Miller
Date: Sep/24/2019, 20:45:08 (UTC+00:00)
> From: Thierry Reding
> Date: Fri, 20 Sep 2019 19:00:34 +0200
>
> > From: Thierry Reding
> >
> > The DWMAC 4.10 supports the same enhanced addressing mode as later
> > generations. Parse this capability from the hardware feature regi
From: Jakub Kicinski
Date: Sep/22/2019, 23:31:32 (UTC+00:00)
> On Fri, 20 Sep 2019 19:01:27 +0200, Thierry Reding wrote:
> > From: Thierry Reding
> >
> > The size of individual pages in the page pool in given by an order. The
> > order is the binary logarithm of the number of pages that make up
From: David Laight
Date: Sep/17/2019, 11:36:21 (UTC+00:00)
> From: Jose Abreu
> > Sent: 17 September 2019 08:59
> > From: Nathan Chancellor
> > Date: Sep/17/2019, 08:32:32 (UTC+00:00)
> >
> > > Hi all,
> > >
> > > Clang recently added a new
From: Nathan Chancellor
Date: Sep/17/2019, 08:32:32 (UTC+00:00)
> Hi all,
>
> Clang recently added a new diagnostic in r371605, -Wsizeof-array-div,
> that tries to warn when sizeof(X) / sizeof(Y) does not compute the
> number of elements in an array X (i.e., sizeof(Y) is wrong). See that
> commi
From: Vladimir Oltean
Date: Sep/15/2019, 03:00:01 (UTC+00:00)
> Instead of looking directly at skb->priority during xmit, let's get the
> netdev queue and the queue-to-traffic-class mapping, and put the
> resulting traffic class into the dsa_8021q PCP field. The switch is
> configured with a 1-to
From: Florian Fainelli
Date: Sep/10/2019, 20:01:01 (UTC+00:00)
> On 9/10/19 1:35 AM, Jose Abreu wrote:
> > From: Thierry Reding
> > Date: Sep/09/2019, 20:13:29 (UTC+00:00)
> >
> >> On Mon, Sep 09, 2019 at 04:05:52PM +, Jose Abreu wrote:
> >>> Fro
From: Thierry Reding
Date: Sep/10/2019, 14:54:27 (UTC+00:00)
> On Tue, Sep 10, 2019 at 08:32:38AM +0000, Jose Abreu wrote:
> > From: Thierry Reding
> > Date: Sep/09/2019, 20:11:27 (UTC+00:00)
> >
> > > On Mon, Sep 09, 2019 at 04:07:04PM +, Jose Abreu wrote
From: Thierry Reding
Date: Sep/09/2019, 20:13:29 (UTC+00:00)
> On Mon, Sep 09, 2019 at 04:05:52PM +0000, Jose Abreu wrote:
> > From: Thierry Reding
> > Date: Sep/09/2019, 16:25:46 (UTC+00:00)
> >
> > > @@ -79,6 +79,10 @@ static void dwmac4_dma_init_rx_ch
From: Thierry Reding
Date: Sep/09/2019, 20:11:27 (UTC+00:00)
> On Mon, Sep 09, 2019 at 04:07:04PM +0000, Jose Abreu wrote:
> > From: Thierry Reding
> > Date: Sep/09/2019, 16:25:45 (UTC+00:00)
> >
> > > @@ -92,6 +92,7 @@ struct stmmac_dma_cfg {
> > > i
From: Thierry Reding
Date: Sep/09/2019, 16:25:45 (UTC+00:00)
> @@ -92,6 +92,7 @@ struct stmmac_dma_cfg {
> int fixed_burst;
> int mixed_burst;
> bool aal;
> + bool eame;
bools should not be used in struct's, please change to int.
---
Thanks,
Jose Miguel Abreu
From: Thierry Reding
Date: Sep/09/2019, 16:25:46 (UTC+00:00)
> @@ -79,6 +79,10 @@ static void dwmac4_dma_init_rx_chan(void __iomem *ioaddr,
> value = value | (rxpbl << DMA_BUS_MODE_RPBL_SHIFT);
> writel(value, ioaddr + DMA_CHAN_RX_CONTROL(chan));
>
> + if (dma_cfg->eame)
There
From: Russell King - ARM Linux admin
Date: Aug/08/2019, 13:09:03 (UTC+00:00)
> On Thu, Aug 08, 2019 at 11:45:29AM +0000, Jose Abreu wrote:
> > From: Russell King - ARM Linux admin
> > Date: Aug/08/2019, 10:23:13 (UTC+00:00)
> >
> > > On Thu, Aug 08, 2019 at 09:0
Add 2 new selftests for VLAN Insertion offloading. Tests are for inner
and outer VLAN offloading.
Signed-off-by: Jose Abreu
---
.../net/ethernet/stmicro/stmmac/stmmac_selftests.c | 96 +-
1 file changed, 94 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet
In order to add Split Header support, stmmac_rx() needs to take into
account that packet may be split accross multiple descriptors.
Refactor the logic of this function in order to support this scenario.
Signed-off-by: Jose Abreu
---
drivers/net/ethernet/stmicro/stmmac/stmmac.h | 6
Adds the logic to insert a given VLAN ID in a packet. This is offloaded
to HW and its descriptor based. For now, only XGMAC implements the
necessary callbacks.
Signed-off-by: Jose Abreu
---
drivers/net/ethernet/stmicro/stmmac/common.h | 8
drivers/net/ethernet/stmicro/stmmac
Add the support for Flexible PPS in XGMAC cores.
Signed-off-by: Jose Abreu
---
drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h | 19
.../net/ethernet/stmicro/stmmac/dwxgmac2_core.c| 56 ++
2 files changed, 75 insertions(+)
diff --git a/drivers/net/ethernet
Add support for EEE in XGMAC cores by implementing the necessary
callbacks.
Signed-off-by: Jose Abreu
---
drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h | 12
.../net/ethernet/stmicro/stmmac/dwxgmac2_core.c| 75 --
drivers/net/ethernet/stmicro/stmmac
Add the support for Split Header feature in the RX path and enable it in
XGMAC cores.
Signed-off-by: Jose Abreu
---
drivers/net/ethernet/stmicro/stmmac/common.h | 1 +
drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h | 6 ++
.../net/ethernet/stmicro/stmmac/dwxgmac2_descs.c | 18
Add 4 new tests:
- SA Insertion (register based)
- SA Insertion (descriptor based)
- SA Replacament (register based)
- SA Replacement (descriptor based)
Signed-off-by: Jose Abreu
---
.../net/ethernet/stmicro/stmmac/stmmac_selftests.c | 98
Add the ethtool interface to dump the register map in XGMAC cores.
Signed-off-by: Jose Abreu
---
drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h | 2 ++
.../net/ethernet/stmicro/stmmac/dwxgmac2_core.c| 11 +-
drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c | 10
Couple of improvements for -next tree. More info in commit logs.
---
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
Cc: Jose Abreu
Cc: "David S. Miller"
Cc: Maxime Coquelin
Cc: netdev@vger.kernel.org
Cc: linux-st...@st-md-mailman.stormreply.com
Cc: linux-arm-ker...@lists.infradead.org
Add the support for Source Address Insertion and Replacement in XGMAC
cores. Two methods are supported: Descriptor based and register based.
Signed-off-by: Jose Abreu
---
drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h | 2 ++
drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c | 11
Add a counter that increments each time a packet with split header is
received.
Signed-off-by: Jose Abreu
---
drivers/net/ethernet/stmicro/stmmac/common.h | 1 +
drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 1 +
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c| 2 ++
3
Return the correct value when RX descriptor is not the last one.
Signed-off-by: Jose Abreu
---
drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c
b/drivers/net
TX Timestamp in XGMAC comes from MAC instead of descriptors. Implement
this in a new callback.
Also, RX Timestamp in XGMAC must be cheked against corruption and we need
a barrier to make sure that descriptor fields are read correctly.
Signed-off-by: Jose Abreu
---
.../net/ethernet/stmicro
From: Russell King - ARM Linux admin
Date: Aug/08/2019, 10:23:13 (UTC+00:00)
> On Thu, Aug 08, 2019 at 09:02:57AM +0000, Jose Abreu wrote:
> > From: Russell King - ARM Linux admin
> > Date: Aug/08/2019, 09:26:26 (UTC+00:00)
> >
> > > Hi,
> > >
>
USXGMII. As link is
operating in 10G but I configure USXGMII for 2.5G maybe autoneg outcome
should always be 10G ?
> On Thu, Aug 08, 2019 at 08:17:29AM +, Jose Abreu wrote:
> > ++ PHY Experts
> >
> > From: Jose Abreu
> > Date: Aug/07/2019, 16:46:23 (UTC+00:00)
>
++ PHY Experts
From: Jose Abreu
Date: Aug/07/2019, 16:46:23 (UTC+00:00)
> Hello,
>
> I've some sample code for Clause 73 support using Synopsys based XPCS
> but I would like to clarify some things that I noticed.
>
> I'm using USXGMII as interface and a single
Hello,
I've some sample code for Clause 73 support using Synopsys based XPCS
but I would like to clarify some things that I noticed.
I'm using USXGMII as interface and a single SERDES that operates at 10G
rate but MAC side is working at 2.5G. Maximum available bandwidth is
therefore 2.5Gbps.
From: Shaokun Zhang
Date: Aug/07/2019, 09:17:29 (UTC+00:00)
> From: yuqi jin
>
> XGMAC_MTL_RXQ_DMA_MAP1 will be configured if the number of queues is
> greater than 3, but local variable chan will shift left more than 32-bits.
> Let's fix this issue.
This was already fixed in -net. Please see
We support more speeds now. Update the Kconfig entry.
Signed-off-by: Jose Abreu
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
---
drivers/net/ethernet/stmicro/stmmac/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net
For review and testing only.
This converts stmmac to use phylink. Besides the code redution this will
allow to gain more flexibility.
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
Jose Abreu (2):
net: stmmac: Prepare to convert to phylink
net: stmmac
From: Maxime Ripard
Date: Thu, May 23, 2019 at 12:07:15
> You can then run make dtbs_check, and those YAML files will be used to
> validate that any devicetree using those properties are doing it
> properly. That implies having the right node names, properties, types,
> ranges of values when rele
From: Maxime Ripard
Date: Thu, May 23, 2019 at 10:56:49
> Switch the STMMAC / Synopsys DesignWare MAC controller binding to a YAML
> schema to enable the DT validation.
>
> Signed-off-by: Maxime Ripard
How exactly can I see the final results of this ? Do you have any link ?
(I'm no expert in
From: Corentin Labbe
Date: Wed, May 15, 2019 at 18:29:22
> I will try to investigate the MMC failure. Does -1 (vs other -E) is the
> right error code to return from the driver ?
Thank you for testing!
Yes, I will fix to return a valid error code.
As per MMC failure this can be due to your
In order for the selftests to run the Flow Control selftest we need to
also pass pause frames to the stack.
Pass this type of frames while in promiscuous mode.
Signed-off-by: Jose Abreu
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
Cc: Corentin Labbe
In order for the selftests to run the Flow Control selftest we need to
also pass pause frames to the stack.
Pass this type of frames while in promiscuous mode.
Signed-off-by: Jose Abreu
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
Cc: Corentin Labbe
In order for hash filter to work we need to set the HPF bit.
Found out while running stmmac selftests.
Signed-off-by: Jose Abreu
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
Cc: Corentin Labbe
---
drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c | 1
: stmmac: dwmac-sun8i: Enable control of loopback
Jose Abreu (13):
net: stmmac: Add MAC loopback callback to HWIF
net: stmmac: dwmac100: Add MAC loopback support
net: stmmac: dwmac1000: Add MAC loopback support
net: stmmac: dwmac4/5: Add MAC loopback support
net: stmmac: dwxgmac2: Add MAC
XGMAC has a different MMC module. Lets use HWIF callbacks for MMC module
so that correct callbacks are automatically selected.
Signed-off-by: Jose Abreu
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
Cc: Corentin Labbe
---
drivers/net/ethernet/stmicro/stmmac
In preparation for the addition of stmmac selftests we implement the MAC
loopback callback in dwmac4/5 cores.
Signed-off-by: Jose Abreu
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
Cc: Corentin Labbe
---
drivers/net/ethernet/stmicro/stmmac/dwmac4.h
In order for the selftests to run the Flow Control selftest we need to
also pass pause frames to the stack.
Pass this type of frames while in promiscuous mode.
Signed-off-by: Jose Abreu
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
Cc: Corentin Labbe
)
- Only test in offline mode (Andrew)
- Do not call phy_loopback twice (Alexandre)
Signed-off-by: Jose Abreu
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
Cc: Corentin Labbe
Cc: Andrew Lunn
---
drivers/net/ethernet/stmicro/stmmac/Kconfig| 9
In order for hash filter to work we need to set the HPF bit.
Fout out while running stmmac selftests
Signed-off-by: Jose Abreu
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
Cc: Corentin Labbe
---
drivers/net/ethernet/stmicro/stmmac/dwmac4.h | 1
From: Corentin Labbe
This patch enable use of set_mac_loopback in dwmac-sun8i
Signed-off-by: Corentin Labbe
Signed-off-by: Jose Abreu
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
---
drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 13 +
1
In case we don't use a given address entry we need to clear it because
it could contain previous values that are no longer valid.
Found out while running stmmac selftests.
Signed-off-by: Jose Abreu
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
Cc: Cor
In preparation for the addition of stmmac selftests we implement the MAC
loopback callback in dwxgmac2 core.
Signed-off-by: Jose Abreu
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
Cc: Corentin Labbe
---
drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h
In preparation for the addition of stmmac selftests we implement the MAC
loopback callback in dwmac1000 core.
Signed-off-by: Jose Abreu
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
Cc: Corentin Labbe
---
drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c
In preparation for the addition of stmmac selftests we implement the MAC
loopback callback in dwmac100 core.
Signed-off-by: Jose Abreu
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
Cc: Corentin Labbe
---
drivers/net/ethernet/stmicro/stmmac/dwmac100_core.c
In preparation for the addition of selftests support for stmmac we add a
new callback to HWIF that can be used to set the controller in loopback
mode.
Signed-off-by: Jose Abreu
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
Cc: Corentin Labbe
---
drivers/net
From: Simon Huelck
Date: Sat, May 11, 2019 at 15:53:34
> ethtool -S gave me some counts for mmc_rx_fifo_overflow, which i didnt
> recognize before.
Flow Control can prevent this to happen. Please check if your DT FIFO
bindings are >= 4096.
> Do we have new ideas / new direction to dig for ?
G
From: Vinicius Costa Gomes
Date: Tue, Mar 26, 2019 at 21:02:43
> The series that I planning to send this week has some ideas about how to
> solve all these three points. But for hardware offloading and frame
> preemption, all I will propose is the interface for talking to the
> driver.
Was this
On 3/3/2019 4:12 PM, Heiner Kallweit wrote:
> Not sure whether anybody is relying on the gen10g driver currently.
I do for stmmac (code not upstreamed yet) and it works okay. For
debug purposes I ended up writing my own phy driver but this is a
plain copy of Generic 10G driver + reset and suspend/
Hi Andrew,
On 3/1/2019 1:53 PM, Andrew Lunn wrote:
> On Fri, Mar 01, 2019 at 11:54:24AM +0100, Jose Abreu wrote:
>> +static inline int phy_update_link(struct phy_device *phydev)
>> +{
>> +if (!phydev->drv)
>> +return -EIO;
>> +
Currently phy_read_status() considers that either the PHY driver has the
read_status() callback or uses the generic callback.
For C45 PHYs we need to use the gen10g_read_status() callback.
Signed-off-by: Jose Abreu
Cc: Andrew Lunn
Cc: Florian Fainelli
Cc: "David S. Miller"
Cc:
For -net. Please review!
Cc: Andrew Lunn
Cc: Florian Fainelli
Cc: "David S. Miller"
Cc: Joao Pinto
Jose Abreu (2):
net: phy: Use C45 Helpers in phy_read_status()
net: phy: Use C45 Helpers in PHY_FORCING state
drivers/net/phy/phy.c | 2 +-
include/linux/phy.h | 15
When using a C45 PHY that is in PHY_FORCING state we are currently not
taking into account that this kind of PHY has different update_link
functions.
Use the C45 Helpers instead or the driver built-in read_status() helper,
if possible.
Signed-off-by: Jose Abreu
Cc: Andrew Lunn
Cc: Florian
Hi Simon,
On 2/27/2019 7:02 PM, Simon Huelck wrote:
> Hi,
>
>
> the thing is , that im not a stmmac developer. Yes , maybe i can bissect
> it and yes you are lucky since im a C-developer since a long time for
> embedded systems.
>
> The problem is that i dont understand the structure of stmmac
Hi Simon,
On 2/24/2019 8:34 PM, Simon Huelck wrote:
> the topic is about ODROID C2 / Amlogic S905X since the start. we have a
> performance regression since 4.14.
As we are not advancing in this topic I suggest you try bisecting
the offending commit.
Thanks,
Jose Miguel Abreu
interrupts that are enabled so, no event will be
missed.
In my tests with GMAC5 this increased performance.
Signed-off-by: Jose Abreu
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
---
drivers/net/ethernet/stmicro/stmmac/dwmac4_
Tested in XGMAC2 and GMAC5.
Cc: Florian Fainelli
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
Jose Abreu (3):
net: stmmac: Fix NAPI poll in TX path when in multi-queue
net: stmmac: dwmac4: Also use TBU interrupt to clean TX path
net: stmmac: dwxgmac2
interrupts that are enabled so, no event will
be missed.
In my tests withe XGMAC2 this increased performance.
Signed-off-by: Jose Abreu
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
---
drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h | 4 +++-
d
instances per each TX and RX queue, as
suggested by Florian.
Changes from v2:
- Only force restart transmission if there are pending packets
Changes from v1:
- Pass entire ring size to TX clean path (Florian)
Signed-off-by: Jose Abreu
Cc: Florian Fainelli
Cc: Joao Pinto
Cc: David
Hi Simon,
On 2/18/2019 6:05 PM, Simon Huelck wrote:
> disabling EEE doesnt help ( did it via the entry in the .dtb / .dts ),
> the results are the same. I can confirm the LPI counters are zero or one
> only after the test.
It's interesting to see that you have a lot of RX packets but few
RX i
On 2/18/2019 4:51 PM, Simon Huelck wrote:
> Hi,
>
> no im testing vanilla mainline kernel and against 4.14. where
> performance was ok. but turning off EEE via ethtool should have same
> results than removal of that patch.
>
> But, since it was mainlined recently , not long ago, i think this was
On 2/18/2019 4:40 PM, Simon Huelck wrote:
> Hi,
>
> EEE is enabled for odroid - c2 and should be working in 5.0-rc7 afaik ?
Oops, I was seeing in the wrong version, sorry.
And did you test without that patch ?
Thanks,
Jose Miguel Abreu
On 2/18/2019 3:53 PM, Simon Huelck wrote:
> How can i do this (reset stats) ?
A simple ifdown / ifup should work.
> The .dtb .dts is meson-gxbb-odroid-c2 from mainline kernel 5.0.rc7
So, according to your DT bindings you have broken EEE yet it's
still enabled in stmmac as we see the LPI counters
On 2/18/2019 3:29 PM, Simon Huelck wrote:
> Can i reset the ethtool statistics for better overview ?
Yes please. And do send the remaining logs + DT bindings.
Thanks,
Jose Miguel Abreu
On 2/18/2019 8:49 AM, Jose Abreu wrote:
> #define XGMAC_DMA_INT_DEFAULT_EN (XGMAC_NIE | XGMAC_AIE | XGMAC_RBUE | \
> - XGMAC_RIE | XGMAC_TIE)
> + XGMAC_RIE | XGMAC_TBUE | XGMAC_TIE)
This is wrong and was a left-
We are saving the status of EEE even before we try to enable it. This
leads to a race with XMIT function that tries to arm EEE timer before we
set it up.
Fix this by only saving the EEE parameters after all operations are
performed with success.
Signed-off-by: Jose Abreu
Fixes: d765955d2ae0
On 2/18/2019 12:41 PM, Jose Abreu wrote:
> On 2/18/2019 12:33 PM, Simon Huelck wrote:
>> Hi,
>>
>>
>> i recognize the followin on my ethernet stats:
>>
>> threshold: 1
>> tx_pkt_n: 1457325
>> rx_pkt_n: 5022405
>>
On 2/18/2019 12:33 PM, Simon Huelck wrote:
> Hi,
>
>
> i recognize the followin on my ethernet stats:
>
> threshold: 1
> tx_pkt_n: 1457325
> rx_pkt_n: 5022405
> normal_irq_n: 671738
> rx_normal_irq_n: 606573
> napi_poll: 784439
> tx_normal_irq_n: 61061
> t
interrupts that are enabled so, no event will be
missed.
In my tests with GMAC5 this increased performance.
Signed-off-by: Jose Abreu
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
---
drivers/net/ethernet/stmicro/stmmac/dwmac4_
interrupts that are enabled so, no event will
be missed.
In my tests withe XGMAC2 this increased performance.
Signed-off-by: Jose Abreu
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
---
drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h | 4 +++-
d
Tested in XGMAC2 and GMAC5.
Cc: Florian Fainelli
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
Jose Abreu (3):
net: stmmac: Fix NAPI poll in TX path when in multi-queue
net: stmmac: dwmac4: Also use TBU interrupt to clean TX path
net: stmmac: dwxgmac2
instances per each TX and RX queue, as
suggested by Florian.
Changes from v1:
- Pass entire ring size to TX clean path (Florian)
Signed-off-by: Jose Abreu
Cc: Florian Fainelli
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
---
drivers/net/ethernet
On 2/18/2019 8:42 AM, Jose Abreu wrote:
> On 2/17/2019 2:48 PM, Martin Blumenstingl wrote:
>> Jose, is my command for disabling offloading correct?
>
> Yes, I think so. What about NIC statistics and logs ? ("ethtool
> -S eth0", "dmesg | grep -i stmmac")
On 2/17/2019 2:48 PM, Martin Blumenstingl wrote:
> Jose, is my command for disabling offloading correct?
Yes, I think so. What about NIC statistics and logs ? ("ethtool
-S eth0", "dmesg | grep -i stmmac")
Thanks,
Jose Miguel Abreu
instances per each TX and RX queue, as
suggested by Florian.
Signed-off-by: Jose Abreu
Cc: Florian Fainelli
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
---
drivers/net/ethernet/stmicro/stmmac/stmmac.h | 5 +-
drivers/net/ethernet/stmicro/stmmac
interrupts that are enabled so, no event will
be missed.
In my tests withe XGMAC2 this increased performance.
Signed-off-by: Jose Abreu
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
---
drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h | 4 +++-
d
interrupts that are enabled so, no event will be
missed.
In my tests with GMAC5 this increased performance.
Signed-off-by: Jose Abreu
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
---
drivers/net/ethernet/stmicro/stmmac/dwmac4_
Tested in XGMAC2 and GMAC5. I guess 1/3 can be backported but besides being a
kind of "not that small" refactoring it's also for a scenario that no-one
complained yet ... Advice ?
Cc: Florian Fainelli
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torg
On 2/14/2019 3:00 PM, Alexandre Torgue wrote:
> Hi Jose
>
> On 2/14/19 3:18 PM, Jose Abreu wrote:
>> Hi Alexandre,
>>
>> On 2/14/2019 2:12 PM, Alexandre Torgue wrote:
>>> In dwmac4_wrback_get_rx_timestamp_status we looking for a RX
>>> timestamp.
>
Hi Alexandre,
On 2/14/2019 2:12 PM, Alexandre Torgue wrote:
> In dwmac4_wrback_get_rx_timestamp_status we looking for a RX timestamp.
> For that receive descriptors are handled and so we should use defines
> related to receive descriptors. It'll no change the functional behavior
> as RDES3_RDES1_V
en TX is still not done it
will return 0 budget).
Fix this by looking at all TX channels in NAPI poll function.
Signed-off-by: Jose Abreu
Fixes: 8fce33317023 ("net: stmmac: Rework coalesce timer and fix multi-queue
races")
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Hello,
On 2/9/2019 1:09 AM, Martin Blumenstingl wrote:
> (it's interesting that the sending direction has 445 retries)
I saw this before and I think it was related with COE. Can you
please disable all offloading and try again?
Anyway, maybe Simon should bissect ? I think since 4.14 there are
not
This includes SYNC, Follow_Up, Delay_Req, Delay_Resp, Pdelay_Req,
> Pdelay_Resp and Pdelay_Resp_Follow_Up messages.
>
> Signed-off-by: Ilias Apalodimas
Acked-by: Jose Abreu
and, on XGMAC2: Tested-by: Jose Abreu
Thanks,
Jose Miguel Abreu
Hi Niklas,
On 2/5/2019 10:05 PM, Niklas Cassel wrote:
> On Wed, Jan 30, 2019 at 03:54:18PM +0100, Jose Abreu wrote:
>>
>> Some misc fixes for stmmac targeting -net.
>>
>> Cc: Joao Pinto
>> Cc: David S. Miller
>> Cc: Giuseppe Cavallaro
>> Cc: Ale
Queue 0.
Signed-off-by: Jose Abreu
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac
If we don't have DT then stmmac_clk will not be available. Let's add a
new Platform Data field so that we can specify the refclk by this mean.
This way we can still use the coalesce command in PCI based setups.
Signed-off-by: Jose Abreu
Cc: Joao Pinto
Cc: David S. Miller
Cc
Some misc fixes for stmmac targeting -net.
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
Jose Abreu (3):
net: stmmac: Fallback to Platform Data clock in Watchdog conversion
net: stmmac: Send TSO packets always from Queue 0
net: stmmac: Disable EEE mode
In stmmac xmit callback we use a different flow for TSO packets but TSO
xmit callback is not disabling the EEE mode.
Fix this by disabling earlier the EEE mode, i.e. before calling the TSO
xmit callback.
Signed-off-by: Jose Abreu
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc
Hello Artem,
Please specify in patch subject whether this is for -net or
-net-next. More comments inline.
On 1/17/2019 7:15 PM, Artem Panfilov wrote:
> From: Tema
>
> This patch adds support for the SIOCGHWTSTAMP ioctl which enables user
> processes to read the current hwtstamp_config settings
1 - 100 of 358 matches
Mail list logo
